Compare commits
5 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 508a16b68e | |||
| 32bd877e82 | |||
| b1c068c34d | |||
| 285eb00655 | |||
| 1bec3559ab |
@@ -1,9 +0,0 @@
|
|||||||
[run]
|
|
||||||
branch = True
|
|
||||||
source = .
|
|
||||||
|
|
||||||
[report]
|
|
||||||
omit =
|
|
||||||
bot_bottle/egress_addon.py
|
|
||||||
bot_bottle/cli/tui.py
|
|
||||||
tests/*
|
|
||||||
@@ -39,14 +39,8 @@ jobs:
|
|||||||
with:
|
with:
|
||||||
python-version: "3.12"
|
python-version: "3.12"
|
||||||
|
|
||||||
- name: Install dev requirements
|
|
||||||
run: python3 -m pip install -r requirements-dev.txt
|
|
||||||
|
|
||||||
- name: Run unit tests
|
- name: Run unit tests
|
||||||
run: python3 -m coverage run -m unittest discover -t . -s tests/unit -v
|
run: python3 -m unittest discover -t . -s tests/unit -v
|
||||||
|
|
||||||
- name: Report unit coverage
|
|
||||||
run: python3 -m coverage report -m
|
|
||||||
|
|
||||||
integration:
|
integration:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
|||||||
@@ -8,7 +8,6 @@ on:
|
|||||||
- '**.py'
|
- '**.py'
|
||||||
- '.pylintrc'
|
- '.pylintrc'
|
||||||
- 'pyrightconfig.json'
|
- 'pyrightconfig.json'
|
||||||
- '.coveragerc'
|
|
||||||
workflow_dispatch:
|
workflow_dispatch:
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
@@ -46,19 +45,10 @@ jobs:
|
|||||||
echo "errors=$ERRORS" >> $GITHUB_OUTPUT
|
echo "errors=$ERRORS" >> $GITHUB_OUTPUT
|
||||||
echo "Pyright errors: $ERRORS"
|
echo "Pyright errors: $ERRORS"
|
||||||
|
|
||||||
- name: Run coverage and extract percentage
|
|
||||||
id: coverage
|
|
||||||
run: |
|
|
||||||
python -m coverage run -m unittest discover -t . -s tests/unit > /dev/null 2>&1 || true
|
|
||||||
PERCENT=$(python -m coverage report 2>/dev/null | grep '^TOTAL' | grep -oP '\d+(?=%)' | tail -1)
|
|
||||||
echo "percent=$PERCENT" >> $GITHUB_OUTPUT
|
|
||||||
echo "Coverage: $PERCENT%"
|
|
||||||
|
|
||||||
- name: Update badges in README
|
- name: Update badges in README
|
||||||
run: |
|
run: |
|
||||||
PYLINT_SCORE="${{ steps.pylint.outputs.score }}"
|
PYLINT_SCORE="${{ steps.pylint.outputs.score }}"
|
||||||
PYRIGHT_ERRORS="${{ steps.pyright.outputs.errors }}"
|
PYRIGHT_ERRORS="${{ steps.pyright.outputs.errors }}"
|
||||||
COVERAGE_PERCENT="${{ steps.coverage.outputs.percent }}"
|
|
||||||
|
|
||||||
PYLINT_SCORE_ENCODED=$(echo "$PYLINT_SCORE" | sed 's|/|%2F|g')
|
PYLINT_SCORE_ENCODED=$(echo "$PYLINT_SCORE" | sed 's|/|%2F|g')
|
||||||
|
|
||||||
@@ -68,12 +58,9 @@ jobs:
|
|||||||
if [ -n "$PYRIGHT_ERRORS" ]; then
|
if [ -n "$PYRIGHT_ERRORS" ]; then
|
||||||
sed -i "s|/badge/pyright-[^)]*|/badge/pyright-${PYRIGHT_ERRORS}%20errors-brightgreen|" README.md
|
sed -i "s|/badge/pyright-[^)]*|/badge/pyright-${PYRIGHT_ERRORS}%20errors-brightgreen|" README.md
|
||||||
fi
|
fi
|
||||||
if [ -n "$COVERAGE_PERCENT" ]; then
|
|
||||||
sed -i "s|/badge/coverage-[^)]*|/badge/coverage-${COVERAGE_PERCENT}%25-brightgreen|" README.md
|
|
||||||
fi
|
|
||||||
|
|
||||||
echo "Updated badges:"
|
echo "Updated badges:"
|
||||||
grep -E "pylint|pyright|coverage" README.md | head -3
|
grep -E "pylint|pyright" README.md | head -2
|
||||||
|
|
||||||
- name: Commit and push badge updates
|
- name: Commit and push badge updates
|
||||||
run: |
|
run: |
|
||||||
@@ -86,7 +73,7 @@ jobs:
|
|||||||
else
|
else
|
||||||
echo "Badge changes detected, committing..."
|
echo "Badge changes detected, committing..."
|
||||||
git add README.md
|
git add README.md
|
||||||
MSG="chore: update quality badges"$'\n\n'"- Pylint: ${{ steps.pylint.outputs.score }}"$'\n'"- Pyright: ${{ steps.pyright.outputs.errors }} errors"$'\n'"- Coverage: ${{ steps.coverage.outputs.percent }}%"$'\n\n'"[skip ci]"
|
MSG="chore: update quality badges"$'\n\n'"- Pylint: ${{ steps.pylint.outputs.score }}"$'\n'"- Pyright: ${{ steps.pyright.outputs.errors }} errors"$'\n\n'"[skip ci]"
|
||||||
git commit -m "$MSG"
|
git commit -m "$MSG"
|
||||||
git push
|
git push
|
||||||
fi
|
fi
|
||||||
|
|||||||
@@ -22,4 +22,3 @@ venv/
|
|||||||
.pytest_cache/
|
.pytest_cache/
|
||||||
.mypy_cache/
|
.mypy_cache/
|
||||||
.ruff_cache/
|
.ruff_cache/
|
||||||
.coverage
|
|
||||||
|
|||||||
@@ -7,7 +7,6 @@
|
|||||||
[](https://gitea.dideric.is/didericis/bot-bottle/actions?workflow=test.yml)
|
[](https://gitea.dideric.is/didericis/bot-bottle/actions?workflow=test.yml)
|
||||||
[](https://github.com/PyCQA/pylint)
|
[](https://github.com/PyCQA/pylint)
|
||||||
[](https://github.com/microsoft/pyright)
|
[](https://github.com/microsoft/pyright)
|
||||||
[](https://coverage.readthedocs.io/)
|
|
||||||
|
|
||||||
**Problem:** Developer wants to run a coding agent without supervision, but they don't want a prompt injected or misbehaving agent wrecking their environment or exfiltrating sensitive data.
|
**Problem:** Developer wants to run a coding agent without supervision, but they don't want a prompt injected or misbehaving agent wrecking their environment or exfiltrating sensitive data.
|
||||||
|
|
||||||
|
|||||||
@@ -61,6 +61,7 @@ class AgentProviderRuntime:
|
|||||||
prompt_mode: PromptMode
|
prompt_mode: PromptMode
|
||||||
bypass_args: tuple[str, ...]
|
bypass_args: tuple[str, ...]
|
||||||
resume_args: tuple[str, ...]
|
resume_args: tuple[str, ...]
|
||||||
|
remote_control_args: tuple[str, ...]
|
||||||
|
|
||||||
|
|
||||||
@dataclass(frozen=True)
|
@dataclass(frozen=True)
|
||||||
@@ -390,7 +391,7 @@ def prompt_args(
|
|||||||
if prompt_mode == "append_file":
|
if prompt_mode == "append_file":
|
||||||
return ["--append-system-prompt-file", prompt_path]
|
return ["--append-system-prompt-file", prompt_path]
|
||||||
if prompt_mode == "read_prompt_file":
|
if prompt_mode == "read_prompt_file":
|
||||||
if argv and ("resume" in argv or "remote-control" in argv):
|
if argv and "resume" in argv:
|
||||||
return []
|
return []
|
||||||
return [f"Read and follow the instructions in {prompt_path}."]
|
return [f"Read and follow the instructions in {prompt_path}."]
|
||||||
if prompt_mode == "print_read_prompt_file":
|
if prompt_mode == "print_read_prompt_file":
|
||||||
|
|||||||
@@ -112,8 +112,9 @@ class BottlePlan(ABC):
|
|||||||
def workspace_plan(self) -> WorkspacePlan:
|
def workspace_plan(self) -> WorkspacePlan:
|
||||||
return workspace_plan(self.spec, guest_home=self.guest_home)
|
return workspace_plan(self.spec, guest_home=self.guest_home)
|
||||||
|
|
||||||
def print(self) -> None:
|
def print(self, *, remote_control: bool) -> None:
|
||||||
"""Render the y/N preflight summary to stderr."""
|
"""Render the y/N preflight summary to stderr."""
|
||||||
|
del remote_control
|
||||||
spec = self.spec
|
spec = self.spec
|
||||||
manifest = self.manifest
|
manifest = self.manifest
|
||||||
agent = manifest.agent
|
agent = manifest.agent
|
||||||
|
|||||||
@@ -0,0 +1,211 @@
|
|||||||
|
"""capability_apply — host-side orchestrator for capability-block
|
||||||
|
remediation (PRD 0016).
|
||||||
|
|
||||||
|
On approval of a capability-block proposal, the dashboard calls
|
||||||
|
apply_capability_change(slug, new_dockerfile) which:
|
||||||
|
|
||||||
|
1. Snapshots the agent's transcript dir to
|
||||||
|
~/.bot-bottle/state/<slug>/transcript/ (best-effort).
|
||||||
|
2. Pushes the agent's working tree via `git push` (best-effort —
|
||||||
|
no upstream / no commits / no git repo all skip with a log).
|
||||||
|
3. Writes the new Dockerfile to
|
||||||
|
~/.bot-bottle/state/<slug>/Dockerfile (PRD 0016 Phase 1
|
||||||
|
state). The next `cli.py start <agent>` picks it up.
|
||||||
|
4. Force-removes the agent container + all sidecars + the
|
||||||
|
per-bottle networks. Idempotent — missing resources are not
|
||||||
|
errors.
|
||||||
|
|
||||||
|
Returns (before, after) Dockerfile contents so the dashboard can
|
||||||
|
record / render the diff. (capability-block has no audit log per
|
||||||
|
PRD 0013 — the per-bottle Dockerfile state is its own record.)
|
||||||
|
|
||||||
|
This is "fire-and-forget" from the agent's perspective: by the time
|
||||||
|
the dashboard writes the response file the supervise sidecar is
|
||||||
|
gone, so the agent's tool call connection drops without ever
|
||||||
|
receiving the response. The replacement agent (next manual
|
||||||
|
`cli.py start`) sees the new Dockerfile and starts from there.
|
||||||
|
v1 does not auto-relaunch — see PRD 0016's capability-block return
|
||||||
|
semantics open question.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import shutil
|
||||||
|
import subprocess
|
||||||
|
|
||||||
|
from ...agent_provider import get_provider
|
||||||
|
from ...log import info, warn
|
||||||
|
from ...bottle_state import (
|
||||||
|
mark_preserved,
|
||||||
|
per_bottle_dockerfile,
|
||||||
|
transcript_snapshot_dir,
|
||||||
|
write_per_bottle_dockerfile,
|
||||||
|
)
|
||||||
|
from .sidecar_bundle import sidecar_bundle_container_name
|
||||||
|
|
||||||
|
|
||||||
|
# Agent home inside the container (per the repo Dockerfile's
|
||||||
|
# `USER node` + `WORKDIR /home/node`). Used to locate the transcript
|
||||||
|
# dir + the workspace dir for git push.
|
||||||
|
_AGENT_HOME_IN_CONTAINER = "/home/node"
|
||||||
|
_AGENT_TRANSCRIPT_IN_CONTAINER = f"{_AGENT_HOME_IN_CONTAINER}/.claude"
|
||||||
|
_AGENT_WORKSPACE_IN_CONTAINER = f"{_AGENT_HOME_IN_CONTAINER}/workspace"
|
||||||
|
|
||||||
|
# Per-bottle resource name patterns (mirroring prepare.py).
|
||||||
|
def _agent_container_name(slug: str) -> str:
|
||||||
|
return f"bot-bottle-{slug}"
|
||||||
|
|
||||||
|
|
||||||
|
def _per_bottle_container_names(slug: str) -> list[str]:
|
||||||
|
"""All container names that belong to this bottle. Missing
|
||||||
|
containers are silently skipped by the teardown helper, so it's
|
||||||
|
fine to include names that don't exist for a given bottle."""
|
||||||
|
return [
|
||||||
|
_agent_container_name(slug),
|
||||||
|
sidecar_bundle_container_name(slug),
|
||||||
|
]
|
||||||
|
|
||||||
|
|
||||||
|
def _per_bottle_network_names(slug: str) -> list[str]:
|
||||||
|
return [
|
||||||
|
f"bot-bottle-net-{slug}",
|
||||||
|
f"bot-bottle-egress-{slug}",
|
||||||
|
]
|
||||||
|
|
||||||
|
|
||||||
|
class CapabilityApplyError(RuntimeError):
|
||||||
|
"""Raised when the apply fails in a way that should keep the
|
||||||
|
proposal pending (so the operator can retry). Best-effort
|
||||||
|
failures (transcript snapshot, git push) do not raise — they
|
||||||
|
just log and proceed."""
|
||||||
|
|
||||||
|
|
||||||
|
# --- Public helpers --------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def fetch_current_dockerfile(slug: str) -> str:
|
||||||
|
"""Return the Dockerfile content the next `cli.py start <agent>`
|
||||||
|
would use for this bottle. If a per-bottle override exists, that
|
||||||
|
one; otherwise the repo's Dockerfile.
|
||||||
|
|
||||||
|
Used by the operator-edit verb to show the current source of
|
||||||
|
truth, and by apply_capability_change for the before-diff."""
|
||||||
|
override = per_bottle_dockerfile(slug)
|
||||||
|
if override is not None:
|
||||||
|
return override
|
||||||
|
repo_dockerfile = get_provider("claude").dockerfile
|
||||||
|
if repo_dockerfile.is_file():
|
||||||
|
return repo_dockerfile.read_text()
|
||||||
|
raise CapabilityApplyError(
|
||||||
|
f"no per-bottle Dockerfile for {slug} and no provider Dockerfile at "
|
||||||
|
f"{repo_dockerfile}"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def apply_capability_change(slug: str, new_dockerfile: str) -> tuple[str, str]:
|
||||||
|
"""End-to-end capability-block remediation. See module docstring
|
||||||
|
for the sequence. Returns (before, after) Dockerfile content."""
|
||||||
|
if not new_dockerfile.strip():
|
||||||
|
raise CapabilityApplyError("proposed Dockerfile is empty")
|
||||||
|
before = fetch_current_dockerfile(slug)
|
||||||
|
|
||||||
|
snapshot_transcript(slug)
|
||||||
|
_push_working_tree(slug)
|
||||||
|
write_per_bottle_dockerfile(slug, new_dockerfile)
|
||||||
|
# Set the preserve marker BEFORE teardown so cli.py's session-end
|
||||||
|
# cleanup sees it and keeps the state dir intact for the
|
||||||
|
# operator's `cli.py resume <identity>`. Without the marker the
|
||||||
|
# state dir would be deleted as part of normal session end.
|
||||||
|
mark_preserved(slug)
|
||||||
|
_teardown_bottle(slug)
|
||||||
|
|
||||||
|
return before, new_dockerfile
|
||||||
|
|
||||||
|
|
||||||
|
# --- Internals -------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
def snapshot_transcript(slug: str) -> None:
|
||||||
|
"""`docker cp` /home/node/.claude out of the agent container into
|
||||||
|
~/.bot-bottle/state/<slug>/transcript/. Best-effort: missing
|
||||||
|
container, missing dir, or cp error all log a warning and return.
|
||||||
|
The transcript is what `claude --resume` reads to pick up where
|
||||||
|
the agent left off.
|
||||||
|
|
||||||
|
Called from two places:
|
||||||
|
- capability-apply, before tearing the bottle down.
|
||||||
|
- cli.py's session-end path, before the launch context closes,
|
||||||
|
so a crash or normal exit also leaves a transcript on disk
|
||||||
|
(deleted along with the state dir on clean exit, kept on
|
||||||
|
crash or capability-block per the preserve marker)."""
|
||||||
|
container = _agent_container_name(slug)
|
||||||
|
dest = transcript_snapshot_dir(slug)
|
||||||
|
if dest.exists():
|
||||||
|
# Remove any prior snapshot so the new one is a clean copy.
|
||||||
|
shutil.rmtree(dest, ignore_errors=True)
|
||||||
|
dest.parent.mkdir(parents=True, exist_ok=True)
|
||||||
|
r = subprocess.run(
|
||||||
|
["docker", "cp", f"{container}:{_AGENT_TRANSCRIPT_IN_CONTAINER}", str(dest)],
|
||||||
|
capture_output=True, text=True, check=False,
|
||||||
|
)
|
||||||
|
if r.returncode != 0:
|
||||||
|
warn(
|
||||||
|
f"transcript snapshot skipped "
|
||||||
|
f"({(r.stderr or '').strip() or 'no transcript dir in container?'})"
|
||||||
|
)
|
||||||
|
return
|
||||||
|
info(f"transcript snapshotted to {dest}")
|
||||||
|
|
||||||
|
|
||||||
|
def _push_working_tree(slug: str) -> None:
|
||||||
|
"""`docker exec <agent> git push` from /home/node/workspace.
|
||||||
|
Best-effort: not-a-git-repo, no upstream, nothing-to-push, no
|
||||||
|
network all log a warning and return. The replacement bottle
|
||||||
|
will pick up whatever's actually upstream."""
|
||||||
|
container = _agent_container_name(slug)
|
||||||
|
r = subprocess.run(
|
||||||
|
[
|
||||||
|
"docker", "exec", container, "sh", "-c",
|
||||||
|
f"cd {_AGENT_WORKSPACE_IN_CONTAINER} && "
|
||||||
|
f"git rev-parse --is-inside-work-tree >/dev/null 2>&1 && "
|
||||||
|
f"git push origin HEAD 2>&1 || true",
|
||||||
|
],
|
||||||
|
capture_output=True, text=True, check=False,
|
||||||
|
)
|
||||||
|
if r.returncode != 0:
|
||||||
|
warn(
|
||||||
|
f"capability-apply: git push skipped "
|
||||||
|
f"({(r.stderr or '').strip() or 'docker exec failed'})"
|
||||||
|
)
|
||||||
|
return
|
||||||
|
output = (r.stdout or "").strip()
|
||||||
|
if output:
|
||||||
|
info(f"capability-apply: git push: {output}")
|
||||||
|
else:
|
||||||
|
info("capability-apply: git push ran (no output — likely not a git workspace)")
|
||||||
|
|
||||||
|
|
||||||
|
def _teardown_bottle(slug: str) -> None:
|
||||||
|
"""Force-remove all per-bottle docker resources. Idempotent —
|
||||||
|
`docker rm -f` / `docker network rm` silently ignore missing
|
||||||
|
names, so this can be called even mid-rebuild."""
|
||||||
|
info(f"capability-apply: tearing down bottle {slug}")
|
||||||
|
for name in _per_bottle_container_names(slug):
|
||||||
|
subprocess.run(
|
||||||
|
["docker", "rm", "-f", name],
|
||||||
|
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, check=False,
|
||||||
|
)
|
||||||
|
for net in _per_bottle_network_names(slug):
|
||||||
|
subprocess.run(
|
||||||
|
["docker", "network", "rm", net],
|
||||||
|
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, check=False,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
__all__ = [
|
||||||
|
"CapabilityApplyError",
|
||||||
|
"apply_capability_change",
|
||||||
|
"fetch_current_dockerfile",
|
||||||
|
"snapshot_transcript",
|
||||||
|
]
|
||||||
@@ -34,6 +34,7 @@ from ...egress import (
|
|||||||
from ...git_gate import GIT_GATE_HOSTNAME
|
from ...git_gate import GIT_GATE_HOSTNAME
|
||||||
from ...log import die, warn
|
from ...log import die, warn
|
||||||
from ...supervise import (
|
from ...supervise import (
|
||||||
|
CURRENT_CONFIG_DIR_IN_AGENT,
|
||||||
QUEUE_DIR_IN_CONTAINER,
|
QUEUE_DIR_IN_CONTAINER,
|
||||||
SUPERVISE_HOSTNAME,
|
SUPERVISE_HOSTNAME,
|
||||||
SUPERVISE_PORT,
|
SUPERVISE_PORT,
|
||||||
@@ -232,6 +233,15 @@ def _agent_service(plan: DockerBottlePlan) -> dict[str, Any]:
|
|||||||
if plan.use_runsc:
|
if plan.use_runsc:
|
||||||
service["runtime"] = "runsc"
|
service["runtime"] = "runsc"
|
||||||
|
|
||||||
|
volumes: list[dict[str, Any]] = []
|
||||||
|
if plan.supervise_plan is not None:
|
||||||
|
volumes.append(_bind(
|
||||||
|
plan.supervise_plan.current_config_dir,
|
||||||
|
CURRENT_CONFIG_DIR_IN_AGENT,
|
||||||
|
))
|
||||||
|
if volumes:
|
||||||
|
service["volumes"] = volumes
|
||||||
|
|
||||||
# The init supervisor inside the bundle owns intra-bundle
|
# The init supervisor inside the bundle owns intra-bundle
|
||||||
# daemon ordering, so the agent only waits for the bundle
|
# daemon ordering, so the agent only waits for the bundle
|
||||||
# container itself.
|
# container itself.
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ from pathlib import Path
|
|||||||
|
|
||||||
from ..bottle_state import egress_state_dir
|
from ..bottle_state import egress_state_dir
|
||||||
from ..egress import EGRESS_ROUTES_FILENAME
|
from ..egress import EGRESS_ROUTES_FILENAME
|
||||||
from ..egress_addon_core import LOG_OFF, load_config
|
from ..egress_addon_core import load_routes
|
||||||
|
|
||||||
|
|
||||||
class EgressApplyError(RuntimeError):
|
class EgressApplyError(RuntimeError):
|
||||||
@@ -33,15 +33,11 @@ class EgressApplicator(ABC):
|
|||||||
@staticmethod
|
@staticmethod
|
||||||
def validate_routes_content(content: str) -> None:
|
def validate_routes_content(content: str) -> None:
|
||||||
try:
|
try:
|
||||||
config = load_config(content)
|
load_routes(content)
|
||||||
except ValueError as e:
|
except ValueError as e:
|
||||||
raise EgressApplyError(
|
raise EgressApplyError(
|
||||||
f"proposed routes.yaml is not valid: {e}"
|
f"proposed routes.yaml is not valid: {e}"
|
||||||
) from e
|
) from e
|
||||||
if config.log != LOG_OFF:
|
|
||||||
raise EgressApplyError(
|
|
||||||
"proposed routes.yaml must not change egress logging"
|
|
||||||
)
|
|
||||||
|
|
||||||
@staticmethod
|
@staticmethod
|
||||||
def _routes_path(slug: str) -> Path:
|
def _routes_path(slug: str) -> Path:
|
||||||
|
|||||||
@@ -68,11 +68,6 @@ def build_image(ref: str, context: str, *, dockerfile: str = "") -> None:
|
|||||||
_ensure_builder_dns()
|
_ensure_builder_dns()
|
||||||
args = [_CONTAINER, "build", "-t", ref, "--dns", dns_server()]
|
args = [_CONTAINER, "build", "-t", ref, "--dns", dns_server()]
|
||||||
if dockerfile:
|
if dockerfile:
|
||||||
# `container build` resolves -f relative to the current working
|
|
||||||
# directory, not the build context. Anchor a relative Dockerfile to
|
|
||||||
# the context so builds work from any cwd.
|
|
||||||
if not os.path.isabs(dockerfile):
|
|
||||||
dockerfile = os.path.join(context, dockerfile)
|
|
||||||
args.extend(["-f", dockerfile])
|
args.extend(["-f", dockerfile])
|
||||||
args.append(context)
|
args.append(context)
|
||||||
subprocess.run(args, check=True)
|
subprocess.run(args, check=True)
|
||||||
|
|||||||
+16
-10
@@ -1,7 +1,8 @@
|
|||||||
"""Per-bottle persistent state.
|
"""Per-bottle persistent state (PRD 0016).
|
||||||
|
|
||||||
Holds optional per-bottle Dockerfile overrides, the transcript snapshot
|
Holds the per-bottle Dockerfile override that capability-block
|
||||||
the state-preservation helper saves before teardown, and the launch metadata that lets
|
remediation writes, the transcript snapshot the state-preservation
|
||||||
|
helper saves before teardown, and the launch metadata that lets
|
||||||
`cli.py resume <identity>` reconstruct a bottle's spec. State
|
`cli.py resume <identity>` reconstruct a bottle's spec. State
|
||||||
lives at:
|
lives at:
|
||||||
|
|
||||||
@@ -60,7 +61,7 @@ _METADATA_NAME = "metadata.json"
|
|||||||
_LIVE_CONFIG_SUBDIR = "live-config"
|
_LIVE_CONFIG_SUBDIR = "live-config"
|
||||||
LIVE_CONFIG_ROUTES_NAME = "routes.yaml"
|
LIVE_CONFIG_ROUTES_NAME = "routes.yaml"
|
||||||
LIVE_CONFIG_ALLOWLIST_NAME = "allowlist"
|
LIVE_CONFIG_ALLOWLIST_NAME = "allowlist"
|
||||||
# Empty marker file. Session preservation writes it before teardown so
|
# Empty marker file. capability_apply writes it before teardown so
|
||||||
# cli.py's session-end cleanup knows to preserve the state dir for
|
# cli.py's session-end cleanup knows to preserve the state dir for
|
||||||
# `cli.py resume <identity>`. Absent = clean up.
|
# `cli.py resume <identity>`. Absent = clean up.
|
||||||
_PRESERVE_MARKER = ".preserve"
|
_PRESERVE_MARKER = ".preserve"
|
||||||
@@ -172,7 +173,8 @@ def per_bottle_dockerfile_path(identity: str) -> Path:
|
|||||||
|
|
||||||
def per_bottle_dockerfile(identity: str) -> str | None:
|
def per_bottle_dockerfile(identity: str) -> str | None:
|
||||||
"""Return the per-bottle Dockerfile content if present, else
|
"""Return the per-bottle Dockerfile content if present, else
|
||||||
None. None means: use the provider or manifest Dockerfile."""
|
None. None means: use the repo's Dockerfile (the original
|
||||||
|
pre-capability-block behavior)."""
|
||||||
p = per_bottle_dockerfile_path(identity)
|
p = per_bottle_dockerfile_path(identity)
|
||||||
if p.is_file():
|
if p.is_file():
|
||||||
return p.read_text()
|
return p.read_text()
|
||||||
@@ -256,7 +258,9 @@ def write_live_config(
|
|||||||
|
|
||||||
|
|
||||||
def transcript_snapshot_dir(identity: str) -> Path:
|
def transcript_snapshot_dir(identity: str) -> Path:
|
||||||
"""Where agent session snapshots are kept for resume flows."""
|
"""Where capability_apply stashes the agent's transcript before
|
||||||
|
teardown, so the next `cli.py start <agent>` can offer to
|
||||||
|
resume from it."""
|
||||||
return bottle_state_dir(identity) / _TRANSCRIPT_SUBDIR
|
return bottle_state_dir(identity) / _TRANSCRIPT_SUBDIR
|
||||||
|
|
||||||
|
|
||||||
@@ -283,7 +287,8 @@ def git_gate_state_dir(identity: str) -> Path:
|
|||||||
|
|
||||||
|
|
||||||
def supervise_state_dir(identity: str) -> Path:
|
def supervise_state_dir(identity: str) -> Path:
|
||||||
"""State subdir reserved for supervise sidecar bind-mount sources.
|
"""State subdir for the supervise sidecar's current-config dir
|
||||||
|
(bind-mounted into the agent at /etc/bot-bottle/current-config).
|
||||||
The queue dir is intentionally NOT under here — it lives at
|
The queue dir is intentionally NOT under here — it lives at
|
||||||
~/.bot-bottle/queue/<slug>/ alongside the audit logs, so it
|
~/.bot-bottle/queue/<slug>/ alongside the audit logs, so it
|
||||||
survives state-dir cleanup."""
|
survives state-dir cleanup."""
|
||||||
@@ -305,8 +310,9 @@ def preserve_marker_path(identity: str) -> Path:
|
|||||||
|
|
||||||
def mark_preserved(identity: str) -> Path:
|
def mark_preserved(identity: str) -> Path:
|
||||||
"""Mark this bottle's state for preservation across session
|
"""Mark this bottle's state for preservation across session
|
||||||
teardown so cli.py's session-end cleanup leaves the state dir
|
teardown. Written by capability_apply.apply_capability_change so
|
||||||
intact for a subsequent `cli.py resume`."""
|
cli.py's session-end cleanup leaves the state dir intact for a
|
||||||
|
subsequent `cli.py resume`."""
|
||||||
path = preserve_marker_path(identity)
|
path = preserve_marker_path(identity)
|
||||||
path.parent.mkdir(parents=True, exist_ok=True)
|
path.parent.mkdir(parents=True, exist_ok=True)
|
||||||
path.touch()
|
path.touch()
|
||||||
@@ -319,7 +325,7 @@ def is_preserved(identity: str) -> bool:
|
|||||||
|
|
||||||
def clear_preserve_marker(identity: str) -> None:
|
def clear_preserve_marker(identity: str) -> None:
|
||||||
"""Idempotent removal. Called at fresh launch (start or resume)
|
"""Idempotent removal. Called at fresh launch (start or resume)
|
||||||
so a marker left from a prior preserved session doesn't keep
|
so a marker left from a prior capability-block doesn't keep
|
||||||
state alive past the next normal session-end."""
|
state alive past the next normal session-end."""
|
||||||
try:
|
try:
|
||||||
preserve_marker_path(identity).unlink()
|
preserve_marker_path(identity).unlink()
|
||||||
|
|||||||
@@ -13,8 +13,9 @@ dirs are shared layout, so docker is the single owner of that
|
|||||||
bucket.
|
bucket.
|
||||||
|
|
||||||
State dirs with `.preserve` are intentionally never touched — they
|
State dirs with `.preserve` are intentionally never touched — they
|
||||||
hold preserved sessions the operator may want to `resume`. Manual
|
hold capability-block rebuilds or crash snapshots the operator may
|
||||||
`rm -rf ~/.bot-bottle/state/<identity>` is the path for those.
|
want to `resume`. Manual `rm -rf ~/.bot-bottle/state/<identity>`
|
||||||
|
is the path for those.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|||||||
@@ -4,12 +4,13 @@ Reads ~/.bot-bottle/state/<identity>/metadata.json to recover the
|
|||||||
(agent_name, cwd, copy_cwd) the bottle was originally started with,
|
(agent_name, cwd, copy_cwd) the bottle was originally started with,
|
||||||
then runs the same launch core as `start` — but pinned to the
|
then runs the same launch core as `start` — but pinned to the
|
||||||
recorded identity so the new bottle picks up any per-bottle Dockerfile
|
recorded identity so the new bottle picks up any per-bottle Dockerfile
|
||||||
override and transcript snapshot under the same state dir.
|
(from capability-block apply) and transcript snapshot under the same
|
||||||
|
state dir.
|
||||||
|
|
||||||
Use case: an interrupted or preserved bottle needs to be relaunched;
|
Use case: an agent calls capability-block, the dashboard approves
|
||||||
the operator runs
|
and tears down the bottle, the operator runs
|
||||||
./cli.py resume <identity>
|
./cli.py resume <identity>
|
||||||
to bring up the replacement from the recorded state.
|
to bring up the replacement with the new capabilities baked in.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
@@ -27,6 +28,7 @@ from .start import _launch_bottle
|
|||||||
def cmd_resume(argv: list[str]) -> int:
|
def cmd_resume(argv: list[str]) -> int:
|
||||||
parser = argparse.ArgumentParser(prog=f"{PROG} resume", add_help=True)
|
parser = argparse.ArgumentParser(prog=f"{PROG} resume", add_help=True)
|
||||||
parser.add_argument("--dry-run", action="store_true")
|
parser.add_argument("--dry-run", action="store_true")
|
||||||
|
parser.add_argument("--remote-control", action="store_true")
|
||||||
parser.add_argument(
|
parser.add_argument(
|
||||||
"identity",
|
"identity",
|
||||||
help="bottle identity from a prior `start` (see its session-end output)",
|
help="bottle identity from a prior `start` (see its session-end output)",
|
||||||
@@ -55,5 +57,6 @@ def cmd_resume(argv: list[str]) -> int:
|
|||||||
return _launch_bottle(
|
return _launch_bottle(
|
||||||
spec,
|
spec,
|
||||||
dry_run=args.dry_run,
|
dry_run=args.dry_run,
|
||||||
|
remote_control=args.remote_control,
|
||||||
backend_name=backend_name,
|
backend_name=backend_name,
|
||||||
)
|
)
|
||||||
|
|||||||
+24
-118
@@ -31,8 +31,9 @@ from ..bottle_state import (
|
|||||||
is_preserved,
|
is_preserved,
|
||||||
mark_preserved,
|
mark_preserved,
|
||||||
)
|
)
|
||||||
|
# from ..backend.docker.capability_apply import snapshot_transcript
|
||||||
from ..log import info
|
from ..log import info
|
||||||
from ..manifest import Manifest, ManifestIndex
|
from ..manifest import ManifestIndex
|
||||||
from ._common import PROG, USER_CWD, read_tty_line
|
from ._common import PROG, USER_CWD, read_tty_line
|
||||||
from . import tui
|
from . import tui
|
||||||
|
|
||||||
@@ -41,6 +42,7 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
parser = argparse.ArgumentParser(prog=f"{PROG} start", add_help=True)
|
parser = argparse.ArgumentParser(prog=f"{PROG} start", add_help=True)
|
||||||
parser.add_argument("--dry-run", action="store_true")
|
parser.add_argument("--dry-run", action="store_true")
|
||||||
parser.add_argument("--cwd", action="store_true", help="copy host cwd into the running bottle")
|
parser.add_argument("--cwd", action="store_true", help="copy host cwd into the running bottle")
|
||||||
|
parser.add_argument("--remote-control", action="store_true")
|
||||||
parser.add_argument(
|
parser.add_argument(
|
||||||
"--backend",
|
"--backend",
|
||||||
choices=known_backend_names(),
|
choices=known_backend_names(),
|
||||||
@@ -76,19 +78,16 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
# Bottle multiselect: always show after agent selection so operators
|
# Bottle multiselect: always show after agent selection so operators
|
||||||
# can compose bottles at launch time without editing agent manifests.
|
# can compose bottles at launch time without editing agent manifests.
|
||||||
available_bottles = manifest.all_bottle_names
|
available_bottles = manifest.all_bottle_names
|
||||||
lineage_map = _bottle_lineage(manifest)
|
|
||||||
display_labels = [lineage_map.get(n, n) for n in available_bottles]
|
|
||||||
label_to_name = {lineage_map.get(n, n): n for n in available_bottles}
|
|
||||||
initial_bottle = _peek_agent_bottle(manifest, agent_name)
|
initial_bottle = _peek_agent_bottle(manifest, agent_name)
|
||||||
initial_labels = [lineage_map.get(initial_bottle, initial_bottle)] if initial_bottle else []
|
initial_bottles = [initial_bottle] if initial_bottle else []
|
||||||
selected_labels = tui.filter_multiselect(
|
selected_bottles = tui.filter_multiselect(
|
||||||
display_labels,
|
available_bottles,
|
||||||
title="Select bottles",
|
title="Select bottles",
|
||||||
initial=initial_labels,
|
initial=initial_bottles,
|
||||||
)
|
)
|
||||||
if selected_labels is None:
|
if selected_bottles is None:
|
||||||
return 0
|
return 0
|
||||||
bottle_names = tuple(label_to_name.get(lbl, lbl) for lbl in selected_labels)
|
bottle_names = tuple(selected_bottles)
|
||||||
|
|
||||||
label, color = tui.name_color_modal(default_label=agent_name)
|
label, color = tui.name_color_modal(default_label=agent_name)
|
||||||
label, color = _resolve_unique_label(label, color)
|
label, color = _resolve_unique_label(label, color)
|
||||||
@@ -105,6 +104,7 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
return _launch_bottle(
|
return _launch_bottle(
|
||||||
spec,
|
spec,
|
||||||
dry_run=dry_run,
|
dry_run=dry_run,
|
||||||
|
remote_control=args.remote_control,
|
||||||
backend_name=backend_name,
|
backend_name=backend_name,
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -149,7 +149,7 @@ def prepare_with_preflight(
|
|||||||
|
|
||||||
|
|
||||||
def attach_agent(
|
def attach_agent(
|
||||||
bottle: Bottle, *, resume: bool = False,
|
bottle: Bottle, *, remote_control: bool = False, resume: bool = False,
|
||||||
agent_provider_template: str = "claude",
|
agent_provider_template: str = "claude",
|
||||||
startup_args: tuple[str, ...] = (),
|
startup_args: tuple[str, ...] = (),
|
||||||
) -> int:
|
) -> int:
|
||||||
@@ -168,6 +168,8 @@ def attach_agent(
|
|||||||
"(Ctrl-D or 'exit' to leave; container will be removed)"
|
"(Ctrl-D or 'exit' to leave; container will be removed)"
|
||||||
)
|
)
|
||||||
agent_args = list(runtime.bypass_args)
|
agent_args = list(runtime.bypass_args)
|
||||||
|
if remote_control:
|
||||||
|
agent_args.extend(runtime.remote_control_args)
|
||||||
agent_args.extend(startup_args)
|
agent_args.extend(startup_args)
|
||||||
if resume:
|
if resume:
|
||||||
agent_args.extend(runtime.resume_args)
|
agent_args.extend(runtime.resume_args)
|
||||||
@@ -263,118 +265,17 @@ def _text_prompt_yes() -> bool:
|
|||||||
return reply in ("y", "Y", "yes", "YES")
|
return reply in ("y", "Y", "yes", "YES")
|
||||||
|
|
||||||
|
|
||||||
def _text_render_preflight():
|
def _text_render_preflight(*, remote_control: bool):
|
||||||
def _render(plan: DockerBottlePlan) -> None:
|
def _render(plan: DockerBottlePlan) -> None:
|
||||||
print(file=sys.stderr)
|
plan.print(remote_control=remote_control)
|
||||||
print(_manifest_to_yaml(plan.manifest), file=sys.stderr)
|
|
||||||
return _render
|
return _render
|
||||||
|
|
||||||
|
|
||||||
def _bottle_lineage(manifest: ManifestIndex) -> dict[str, str]:
|
|
||||||
"""Return {bottle_name: lineage_label} for bottles that have an extends chain.
|
|
||||||
|
|
||||||
Bottles without a parent are omitted (the caller falls back to the bare name).
|
|
||||||
Labels show the chain root-first: e.g. 'dev -> bot-bottle-dev -> claude-dev'."""
|
|
||||||
if manifest.home_md is None:
|
|
||||||
return {}
|
|
||||||
bottles_dir = manifest.home_md / "bottles"
|
|
||||||
if not bottles_dir.is_dir():
|
|
||||||
return {}
|
|
||||||
|
|
||||||
from ..yaml_subset import YamlSubsetError, parse_frontmatter
|
|
||||||
|
|
||||||
extends_of: dict[str, str] = {}
|
|
||||||
for path in bottles_dir.glob("*.md"):
|
|
||||||
try:
|
|
||||||
fm, _ = parse_frontmatter(path.read_text())
|
|
||||||
parent = fm.get("extends", "")
|
|
||||||
if isinstance(parent, str) and parent:
|
|
||||||
extends_of[path.stem] = parent
|
|
||||||
except (OSError, YamlSubsetError):
|
|
||||||
pass
|
|
||||||
|
|
||||||
labels: dict[str, str] = {}
|
|
||||||
for name in extends_of:
|
|
||||||
chain = [name]
|
|
||||||
seen = {name}
|
|
||||||
cur = name
|
|
||||||
while cur in extends_of:
|
|
||||||
par = extends_of[cur]
|
|
||||||
if par in seen:
|
|
||||||
break
|
|
||||||
chain.append(par)
|
|
||||||
seen.add(par)
|
|
||||||
cur = par
|
|
||||||
labels[name] = " -> ".join(reversed(chain))
|
|
||||||
|
|
||||||
return labels
|
|
||||||
|
|
||||||
|
|
||||||
def _manifest_to_yaml(manifest: Manifest) -> str:
|
|
||||||
"""Serialize the resolved Manifest to a YAML string for preflight display."""
|
|
||||||
lines: list[str] = []
|
|
||||||
|
|
||||||
agent = manifest.agent
|
|
||||||
lines.append("agent:")
|
|
||||||
if agent.skills:
|
|
||||||
lines.append(" skills:")
|
|
||||||
for s in agent.skills:
|
|
||||||
lines.append(f" - {s}")
|
|
||||||
if not agent.git_user.is_empty():
|
|
||||||
lines.append(" git-gate:")
|
|
||||||
lines.append(" user:")
|
|
||||||
if agent.git_user.name:
|
|
||||||
lines.append(f" name: {agent.git_user.name}")
|
|
||||||
if agent.git_user.email:
|
|
||||||
lines.append(f" email: {agent.git_user.email}")
|
|
||||||
|
|
||||||
bottle = manifest.bottle
|
|
||||||
lines.append("bottle:")
|
|
||||||
|
|
||||||
if bottle.agent_provider.template != "claude" or bottle.agent_provider.dockerfile:
|
|
||||||
lines.append(" agent_provider:")
|
|
||||||
lines.append(f" template: {bottle.agent_provider.template}")
|
|
||||||
if bottle.agent_provider.dockerfile:
|
|
||||||
lines.append(f" dockerfile: {bottle.agent_provider.dockerfile}")
|
|
||||||
|
|
||||||
if bottle.env:
|
|
||||||
lines.append(" env:")
|
|
||||||
for k, v in sorted(bottle.env.items()):
|
|
||||||
lines.append(f" {k}: {v}")
|
|
||||||
|
|
||||||
has_git_gate = not bottle.git_user.is_empty() or bottle.git
|
|
||||||
if has_git_gate:
|
|
||||||
lines.append(" git-gate:")
|
|
||||||
if not bottle.git_user.is_empty():
|
|
||||||
lines.append(" user:")
|
|
||||||
if bottle.git_user.name:
|
|
||||||
lines.append(f" name: {bottle.git_user.name}")
|
|
||||||
if bottle.git_user.email:
|
|
||||||
lines.append(f" email: {bottle.git_user.email}")
|
|
||||||
if bottle.git:
|
|
||||||
lines.append(" repos:")
|
|
||||||
for entry in bottle.git:
|
|
||||||
lines.append(f" {entry.Name}:")
|
|
||||||
lines.append(f" url: {entry.Upstream}")
|
|
||||||
|
|
||||||
if bottle.egress.routes:
|
|
||||||
lines.append(" egress:")
|
|
||||||
lines.append(" routes:")
|
|
||||||
for r in bottle.egress.routes:
|
|
||||||
lines.append(f" - host: {r.Host}")
|
|
||||||
if r.AuthScheme:
|
|
||||||
lines.append(f" auth:")
|
|
||||||
lines.append(f" scheme: {r.AuthScheme}")
|
|
||||||
|
|
||||||
lines.append(f" supervise: {'true' if bottle.supervise else 'false'}")
|
|
||||||
|
|
||||||
return "\n".join(lines)
|
|
||||||
|
|
||||||
|
|
||||||
def _launch_bottle(
|
def _launch_bottle(
|
||||||
spec: BottleSpec,
|
spec: BottleSpec,
|
||||||
*,
|
*,
|
||||||
dry_run: bool,
|
dry_run: bool,
|
||||||
|
remote_control: bool,
|
||||||
backend_name: str | None = None,
|
backend_name: str | None = None,
|
||||||
) -> int:
|
) -> int:
|
||||||
"""Shared launch core for `start` and `resume`. Builds the plan,
|
"""Shared launch core for `start` and `resume`. Builds the plan,
|
||||||
@@ -386,7 +287,7 @@ def _launch_bottle(
|
|||||||
plan, identity = prepare_with_preflight(
|
plan, identity = prepare_with_preflight(
|
||||||
spec,
|
spec,
|
||||||
stage_dir=stage_dir,
|
stage_dir=stage_dir,
|
||||||
render_preflight=_text_render_preflight(),
|
render_preflight=_text_render_preflight(remote_control=remote_control),
|
||||||
prompt_yes=_text_prompt_yes,
|
prompt_yes=_text_prompt_yes,
|
||||||
dry_run=dry_run,
|
dry_run=dry_run,
|
||||||
backend_name=backend_name,
|
backend_name=backend_name,
|
||||||
@@ -399,6 +300,7 @@ def _launch_bottle(
|
|||||||
agent_provider_template = getattr(plan, "agent_provider_template", "claude")
|
agent_provider_template = getattr(plan, "agent_provider_template", "claude")
|
||||||
exit_code = attach_agent(
|
exit_code = attach_agent(
|
||||||
bottle,
|
bottle,
|
||||||
|
remote_control=remote_control,
|
||||||
agent_provider_template=agent_provider_template,
|
agent_provider_template=agent_provider_template,
|
||||||
startup_args=plan.agent_provision.startup_args,
|
startup_args=plan.agent_provision.startup_args,
|
||||||
)
|
)
|
||||||
@@ -408,8 +310,12 @@ def _launch_bottle(
|
|||||||
)
|
)
|
||||||
# While the container is still alive: always snapshot the
|
# While the container is still alive: always snapshot the
|
||||||
# transcript and — if the agent exited non-zero — mark
|
# transcript and — if the agent exited non-zero — mark
|
||||||
# the state for preservation. This picks up crashes /
|
# the state for preservation. Capability-block already
|
||||||
# Ctrl-Cs / OOM kills before cleanup removes the state dir.
|
# did both before triggering teardown from the dashboard;
|
||||||
|
# this picks up crashes / Ctrl-Cs / OOM kills the same
|
||||||
|
# way. snapshot_transcript is best-effort so the
|
||||||
|
# capability-block path's prior snapshot isn't clobbered
|
||||||
|
# when the container is already gone.
|
||||||
if agent_provider_template == "claude":
|
if agent_provider_template == "claude":
|
||||||
capture_claude_session_state(identity, exit_code)
|
capture_claude_session_state(identity, exit_code)
|
||||||
return 0
|
return 0
|
||||||
|
|||||||
@@ -2,8 +2,9 @@
|
|||||||
act on them (approve / modify / reject).
|
act on them (approve / modify / reject).
|
||||||
|
|
||||||
Curses-based TUI; modify-then-approve shells out to $EDITOR. The
|
Curses-based TUI; modify-then-approve shells out to $EDITOR. The
|
||||||
Egress proposals are queued for operator review as full routes.yaml
|
approval handler wires to PRD 0016 (capability-block), which rebuilds
|
||||||
updates.
|
the bottle Dockerfile. Egress proposals are queued for operator review
|
||||||
|
as full routes.yaml updates.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
@@ -21,6 +22,10 @@ from pathlib import Path
|
|||||||
|
|
||||||
from .. import supervise as _supervise
|
from .. import supervise as _supervise
|
||||||
from ..bottle_state import read_metadata
|
from ..bottle_state import read_metadata
|
||||||
|
# from ..backend.docker.capability_apply import (
|
||||||
|
# CapabilityApplyError,
|
||||||
|
# apply_capability_change,
|
||||||
|
# )
|
||||||
from ..backend.docker.egress_apply import (
|
from ..backend.docker.egress_apply import (
|
||||||
EgressApplyError,
|
EgressApplyError,
|
||||||
applicator as _docker_applicator,
|
applicator as _docker_applicator,
|
||||||
@@ -33,6 +38,10 @@ from ..backend.smolmachines.egress_apply import (
|
|||||||
)
|
)
|
||||||
from ..log import Die, error, info
|
from ..log import Die, error, info
|
||||||
|
|
||||||
|
|
||||||
|
class CapabilityApplyError(RuntimeError):
|
||||||
|
"""Placeholder while capability_apply is disabled."""
|
||||||
|
|
||||||
from ..supervise import (
|
from ..supervise import (
|
||||||
COMPONENT_FOR_TOOL,
|
COMPONENT_FOR_TOOL,
|
||||||
AuditEntry,
|
AuditEntry,
|
||||||
@@ -41,10 +50,12 @@ from ..supervise import (
|
|||||||
STATUS_APPROVED,
|
STATUS_APPROVED,
|
||||||
STATUS_MODIFIED,
|
STATUS_MODIFIED,
|
||||||
STATUS_REJECTED,
|
STATUS_REJECTED,
|
||||||
|
TOOL_CAPABILITY_BLOCK,
|
||||||
TOOL_EGRESS_ALLOW,
|
TOOL_EGRESS_ALLOW,
|
||||||
TOOL_EGRESS_BLOCK,
|
TOOL_EGRESS_BLOCK,
|
||||||
TOOL_GITLEAKS_ALLOW,
|
TOOL_GITLEAKS_ALLOW,
|
||||||
TOOL_EGRESS_TOKEN_ALLOW,
|
TOOL_EGRESS_TOKEN_ALLOW,
|
||||||
|
archive_proposal,
|
||||||
list_pending_proposals,
|
list_pending_proposals,
|
||||||
render_diff,
|
render_diff,
|
||||||
write_audit_entry,
|
write_audit_entry,
|
||||||
@@ -72,7 +83,7 @@ class QueuedProposal:
|
|||||||
# Errors any remediation engine may raise. Caught by the TUI key
|
# Errors any remediation engine may raise. Caught by the TUI key
|
||||||
# handlers and surfaced in the status line so a failed apply keeps
|
# handlers and surfaced in the status line so a failed apply keeps
|
||||||
# the proposal pending rather than crashing curses.
|
# the proposal pending rather than crashing curses.
|
||||||
ApplyError = (EgressApplyError,)
|
ApplyError = (CapabilityApplyError, EgressApplyError)
|
||||||
|
|
||||||
|
|
||||||
def apply_routes_change(slug: str, content: str) -> tuple[str, str]:
|
def apply_routes_change(slug: str, content: str) -> tuple[str, str]:
|
||||||
@@ -132,6 +143,8 @@ def _detail_lines(
|
|||||||
|
|
||||||
|
|
||||||
def _suffix_for_tool(tool: str) -> str:
|
def _suffix_for_tool(tool: str) -> str:
|
||||||
|
if tool == TOOL_CAPABILITY_BLOCK:
|
||||||
|
return ".dockerfile"
|
||||||
if tool in (TOOL_EGRESS_ALLOW, TOOL_EGRESS_BLOCK):
|
if tool in (TOOL_EGRESS_ALLOW, TOOL_EGRESS_BLOCK):
|
||||||
return ".yaml"
|
return ".yaml"
|
||||||
if tool in (TOOL_GITLEAKS_ALLOW, TOOL_EGRESS_TOKEN_ALLOW):
|
if tool in (TOOL_GITLEAKS_ALLOW, TOOL_EGRESS_TOKEN_ALLOW):
|
||||||
@@ -153,6 +166,17 @@ def approve(
|
|||||||
file_to_apply = final_file if final_file is not None else qp.proposal.proposed_file
|
file_to_apply = final_file if final_file is not None else qp.proposal.proposed_file
|
||||||
|
|
||||||
diff_before, diff_after = "", ""
|
diff_before, diff_after = "", ""
|
||||||
|
# if qp.proposal.tool == TOOL_CAPABILITY_BLOCK:
|
||||||
|
# _meta = read_metadata(qp.proposal.bottle_slug)
|
||||||
|
# if _meta is not None and not _meta.compose_project:
|
||||||
|
# raise CapabilityApplyError(
|
||||||
|
# "capability-block remediation is not supported for smolmachines "
|
||||||
|
# "bottles. Reject this proposal or handle the capability change "
|
||||||
|
# "manually, then restart the bottle."
|
||||||
|
# )
|
||||||
|
# diff_before, diff_after = apply_capability_change(
|
||||||
|
# qp.proposal.bottle_slug, file_to_apply,
|
||||||
|
# )
|
||||||
if qp.proposal.tool in (TOOL_EGRESS_ALLOW, TOOL_EGRESS_BLOCK):
|
if qp.proposal.tool in (TOOL_EGRESS_ALLOW, TOOL_EGRESS_BLOCK):
|
||||||
diff_before, diff_after = apply_routes_change(
|
diff_before, diff_after = apply_routes_change(
|
||||||
qp.proposal.bottle_slug,
|
qp.proposal.bottle_slug,
|
||||||
@@ -170,6 +194,9 @@ def approve(
|
|||||||
qp, action=status, notes=notes,
|
qp, action=status, notes=notes,
|
||||||
diff_before=diff_before, diff_after=diff_after,
|
diff_before=diff_before, diff_after=diff_after,
|
||||||
)
|
)
|
||||||
|
if qp.proposal.tool == TOOL_CAPABILITY_BLOCK:
|
||||||
|
archive_proposal(qp.queue_dir, qp.proposal.id)
|
||||||
|
|
||||||
|
|
||||||
def reject(qp: QueuedProposal, *, reason: str) -> None:
|
def reject(qp: QueuedProposal, *, reason: str) -> None:
|
||||||
"""Write a rejection response and an audit entry."""
|
"""Write a rejection response and an audit entry."""
|
||||||
@@ -319,7 +346,7 @@ def _list_once() -> int:
|
|||||||
return 0
|
return 0
|
||||||
|
|
||||||
|
|
||||||
def _try_init_green() -> int: # pragma: no cover
|
def _try_init_green() -> int:
|
||||||
"""Initialise a green color pair and return its attr, or 0."""
|
"""Initialise a green color pair and return its attr, or 0."""
|
||||||
try:
|
try:
|
||||||
curses.start_color()
|
curses.start_color()
|
||||||
@@ -330,7 +357,7 @@ def _try_init_green() -> int: # pragma: no cover
|
|||||||
return 0
|
return 0
|
||||||
|
|
||||||
|
|
||||||
def _main_loop(stdscr: "curses._CursesWindow") -> None: # type: ignore # pragma: no cover
|
def _main_loop(stdscr: "curses._CursesWindow") -> None: # type: ignore
|
||||||
curses.curs_set(0)
|
curses.curs_set(0)
|
||||||
stdscr.timeout(_REFRESH_INTERVAL_MS)
|
stdscr.timeout(_REFRESH_INTERVAL_MS)
|
||||||
green_attr = _try_init_green()
|
green_attr = _try_init_green()
|
||||||
@@ -420,7 +447,7 @@ def _render(
|
|||||||
status_line: str,
|
status_line: str,
|
||||||
*,
|
*,
|
||||||
green_attr: int = 0, # noqa: F841 — unused, but required by interface
|
green_attr: int = 0, # noqa: F841 — unused, but required by interface
|
||||||
) -> None: # pragma: no cover
|
) -> None:
|
||||||
stdscr.erase()
|
stdscr.erase()
|
||||||
h, w = stdscr.getmaxyx()
|
h, w = stdscr.getmaxyx()
|
||||||
header = f"bot-bottle supervise ({len(pending)} pending)"
|
header = f"bot-bottle supervise ({len(pending)} pending)"
|
||||||
@@ -471,7 +498,7 @@ def _detail_view(
|
|||||||
qp: QueuedProposal,
|
qp: QueuedProposal,
|
||||||
*,
|
*,
|
||||||
green_attr: int = 0,
|
green_attr: int = 0,
|
||||||
) -> None: # pragma: no cover
|
) -> None:
|
||||||
"""Render the full proposal. Scrollable. Press q to return."""
|
"""Render the full proposal. Scrollable. Press q to return."""
|
||||||
lines = _detail_lines(qp, green_attr=green_attr)
|
lines = _detail_lines(qp, green_attr=green_attr)
|
||||||
offset = 0
|
offset = 0
|
||||||
@@ -523,7 +550,7 @@ def _detail_view(
|
|||||||
return
|
return
|
||||||
|
|
||||||
|
|
||||||
def _modify(stdscr: "curses._CursesWindow", qp: QueuedProposal) -> str | None: # type: ignore # pragma: no cover
|
def _modify(stdscr: "curses._CursesWindow", qp: QueuedProposal) -> str | None: # type: ignore
|
||||||
"""Suspend curses, open $EDITOR on the proposed file, return edited content."""
|
"""Suspend curses, open $EDITOR on the proposed file, return edited content."""
|
||||||
suffix = _suffix_for_tool(qp.proposal.tool)
|
suffix = _suffix_for_tool(qp.proposal.tool)
|
||||||
curses.endwin()
|
curses.endwin()
|
||||||
@@ -534,7 +561,7 @@ def _modify(stdscr: "curses._CursesWindow", qp: QueuedProposal) -> str | None:
|
|||||||
return edited
|
return edited
|
||||||
|
|
||||||
|
|
||||||
def _prompt(stdscr: "curses._CursesWindow", label: str) -> str: # type: ignore # pragma: no cover
|
def _prompt(stdscr: "curses._CursesWindow", label: str) -> str: # type: ignore
|
||||||
"""One-line input at the bottom of the screen."""
|
"""One-line input at the bottom of the screen."""
|
||||||
curses.curs_set(1)
|
curses.curs_set(1)
|
||||||
h, _ = stdscr.getmaxyx()
|
h, _ = stdscr.getmaxyx()
|
||||||
|
|||||||
@@ -29,8 +29,7 @@ def filter_multiselect(
|
|||||||
Returns the ordered list of selected items, or ``None`` if the user
|
Returns the ordered list of selected items, or ``None`` if the user
|
||||||
cancelled (Esc / ``q`` / Ctrl-C / Ctrl-D with no items).
|
cancelled (Esc / ``q`` / Ctrl-C / Ctrl-D with no items).
|
||||||
|
|
||||||
Press Space to toggle the item under the cursor.
|
Press Space or Enter to toggle the item under the cursor.
|
||||||
Press Enter to confirm the current selection.
|
|
||||||
Press Ctrl-D to confirm the current selection (returns even if empty).
|
Press Ctrl-D to confirm the current selection (returns even if empty).
|
||||||
Press Esc/q to cancel (returns None).
|
Press Esc/q to cancel (returns None).
|
||||||
|
|
||||||
@@ -357,10 +356,7 @@ def _multiselect_loop(
|
|||||||
continue
|
continue
|
||||||
|
|
||||||
if focus == "filter":
|
if focus == "filter":
|
||||||
if key in (curses.KEY_ENTER, _KEY_ENTER_ALT, ord("\r")):
|
if key in (curses.KEY_ENTER, _KEY_ENTER_ALT, ord("\r"), _KEY_SPACE):
|
||||||
return list(selected)
|
|
||||||
|
|
||||||
elif key == _KEY_SPACE:
|
|
||||||
if filtered:
|
if filtered:
|
||||||
item = filtered[cursor]
|
item = filtered[cursor]
|
||||||
if item in selected:
|
if item in selected:
|
||||||
@@ -504,7 +500,7 @@ def _render_multiselect(
|
|||||||
row += 1
|
row += 1
|
||||||
|
|
||||||
if focus == "filter":
|
if focus == "filter":
|
||||||
help_line = "[↑↓/jk] move [Space] toggle [Enter] confirm [Tab] reorder [Esc/q] cancel"
|
help_line = "[↑↓/jk] move [Space/Enter] toggle [Tab] reorder [Ctrl-D] done [Esc/q] cancel"
|
||||||
else:
|
else:
|
||||||
help_line = "[↑↓/jk] cursor [K/J] reorder [Space/Enter] remove [Tab] back [Ctrl-D] done"
|
help_line = "[↑↓/jk] cursor [K/J] reorder [Space/Enter] remove [Tab] back [Ctrl-D] done"
|
||||||
if row < rows:
|
if row < rows:
|
||||||
|
|||||||
@@ -21,7 +21,7 @@ FROM node:22-slim
|
|||||||
# to it) works against egress's bumped TLS without the agent needing
|
# to it) works against egress's bumped TLS without the agent needing
|
||||||
# local DNS.
|
# local DNS.
|
||||||
RUN apt-get update \
|
RUN apt-get update \
|
||||||
&& apt-get install -y --no-install-recommends git ca-certificates curl ripgrep \
|
&& apt-get install -y --no-install-recommends git ca-certificates curl \
|
||||||
&& rm -rf /var/lib/apt/lists/*
|
&& rm -rf /var/lib/apt/lists/*
|
||||||
|
|
||||||
# App-specific deps. Python isn't required by claude-code itself
|
# App-specific deps. Python isn't required by claude-code itself
|
||||||
|
|||||||
@@ -91,6 +91,7 @@ _RUNTIME = AgentProviderRuntime(
|
|||||||
prompt_mode="append_file",
|
prompt_mode="append_file",
|
||||||
bypass_args=("--dangerously-skip-permissions",),
|
bypass_args=("--dangerously-skip-permissions",),
|
||||||
resume_args=("--continue",),
|
resume_args=("--continue",),
|
||||||
|
remote_control_args=("--remote-control",),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -1,12 +1,12 @@
|
|||||||
# bot-bottle Codex provider image.
|
# bot-bottle Codex provider image.
|
||||||
#
|
#
|
||||||
# Mirrors the default Claude image shape: Node LTS, git/network tooling,
|
# Mirrors the default Claude image shape: Node LTS, git/network tooling,
|
||||||
# non-root node user, and the provider CLI installed for that user.
|
# non-root node user, and the provider CLI installed globally.
|
||||||
|
|
||||||
FROM node:22-slim
|
FROM node:22-slim
|
||||||
|
|
||||||
RUN apt-get update \
|
RUN apt-get update \
|
||||||
&& apt-get install -y --no-install-recommends git ca-certificates curl procps ripgrep \
|
&& apt-get install -y --no-install-recommends git ca-certificates curl \
|
||||||
&& rm -rf /var/lib/apt/lists/*
|
&& rm -rf /var/lib/apt/lists/*
|
||||||
|
|
||||||
# App-specific deps. Python isn't required by codex itself
|
# App-specific deps. Python isn't required by codex itself
|
||||||
@@ -17,15 +17,12 @@ RUN apt-get update \
|
|||||||
&& apt-get install -y --no-install-recommends python3 python3-pip python3-venv \
|
&& apt-get install -y --no-install-recommends python3 python3-pip python3-venv \
|
||||||
&& rm -rf /var/lib/apt/lists/*
|
&& rm -rf /var/lib/apt/lists/*
|
||||||
|
|
||||||
|
RUN npm install -g --no-fund --no-audit @openai/codex@0.136.0 \
|
||||||
|
&& npm cache clean --force
|
||||||
|
|
||||||
USER node
|
USER node
|
||||||
WORKDIR /home/node
|
WORKDIR /home/node
|
||||||
|
|
||||||
ENV PATH="/home/node/.local/bin:${PATH}"
|
RUN mkdir -p /home/node/.codex
|
||||||
|
|
||||||
# Remote-control support requires the standalone Codex install layout
|
|
||||||
# under ~/.codex/packages/standalone/current. The npm package can run
|
|
||||||
# the TUI, but remote-control commands expect this installer-owned path.
|
|
||||||
RUN mkdir -p /home/node/.codex \
|
|
||||||
&& curl -fsSL https://chatgpt.com/codex/install.sh | sh
|
|
||||||
|
|
||||||
CMD ["codex"]
|
CMD ["codex"]
|
||||||
|
|||||||
@@ -55,6 +55,7 @@ _RUNTIME = AgentProviderRuntime(
|
|||||||
prompt_mode="read_prompt_file",
|
prompt_mode="read_prompt_file",
|
||||||
bypass_args=("--dangerously-bypass-approvals-and-sandbox",),
|
bypass_args=("--dangerously-bypass-approvals-and-sandbox",),
|
||||||
resume_args=("resume", "--last"),
|
resume_args=("resume", "--last"),
|
||||||
|
remote_control_args=(),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -21,11 +21,6 @@ from pathlib import Path
|
|||||||
|
|
||||||
from ...deploy_key_provisioner import DeployKeyCollisionError, DeployKeyProvisioner
|
from ...deploy_key_provisioner import DeployKeyCollisionError, DeployKeyProvisioner
|
||||||
|
|
||||||
# Timeout for ssh-keygen and Gitea API HTTP calls. A hung Gitea instance at
|
|
||||||
# prepare time would stall bottle launch indefinitely without this bound.
|
|
||||||
_API_TIMEOUT_SECS = 30
|
|
||||||
_KEYGEN_TIMEOUT_SECS = 10
|
|
||||||
|
|
||||||
|
|
||||||
class GiteaDeployKeyProvisioner(DeployKeyProvisioner):
|
class GiteaDeployKeyProvisioner(DeployKeyProvisioner):
|
||||||
"""Manages deploy keys on a Gitea instance."""
|
"""Manages deploy keys on a Gitea instance."""
|
||||||
@@ -51,7 +46,6 @@ class GiteaDeployKeyProvisioner(DeployKeyProvisioner):
|
|||||||
check=True,
|
check=True,
|
||||||
stdout=subprocess.DEVNULL,
|
stdout=subprocess.DEVNULL,
|
||||||
stderr=subprocess.DEVNULL,
|
stderr=subprocess.DEVNULL,
|
||||||
timeout=_KEYGEN_TIMEOUT_SECS,
|
|
||||||
)
|
)
|
||||||
private_key = key_path.read_bytes()
|
private_key = key_path.read_bytes()
|
||||||
public_key = key_path.with_suffix(".pub").read_text().strip()
|
public_key = key_path.with_suffix(".pub").read_text().strip()
|
||||||
@@ -73,7 +67,7 @@ class GiteaDeployKeyProvisioner(DeployKeyProvisioner):
|
|||||||
method="POST",
|
method="POST",
|
||||||
)
|
)
|
||||||
try:
|
try:
|
||||||
with urllib.request.urlopen(req, timeout=_API_TIMEOUT_SECS) as resp:
|
with urllib.request.urlopen(req) as resp:
|
||||||
body = json.loads(resp.read())
|
body = json.loads(resp.read())
|
||||||
except urllib.error.HTTPError as exc:
|
except urllib.error.HTTPError as exc:
|
||||||
_body = _read_error_body(exc)
|
_body = _read_error_body(exc)
|
||||||
@@ -104,7 +98,7 @@ class GiteaDeployKeyProvisioner(DeployKeyProvisioner):
|
|||||||
method="DELETE",
|
method="DELETE",
|
||||||
)
|
)
|
||||||
try:
|
try:
|
||||||
with urllib.request.urlopen(req, timeout=_API_TIMEOUT_SECS):
|
with urllib.request.urlopen(req):
|
||||||
pass
|
pass
|
||||||
except urllib.error.HTTPError as exc:
|
except urllib.error.HTTPError as exc:
|
||||||
if exc.code == 404:
|
if exc.code == 404:
|
||||||
|
|||||||
@@ -166,6 +166,7 @@ _RUNTIME = AgentProviderRuntime(
|
|||||||
prompt_mode="append_system_prompt",
|
prompt_mode="append_system_prompt",
|
||||||
bypass_args=(),
|
bypass_args=(),
|
||||||
resume_args=(),
|
resume_args=(),
|
||||||
|
remote_control_args=(),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
+10
-21
@@ -210,17 +210,6 @@ def egress_token_env_map(
|
|||||||
return out
|
return out
|
||||||
|
|
||||||
|
|
||||||
def _yaml_str_escape(s: str) -> str:
|
|
||||||
"""Escape a string for use inside a YAML double-quoted scalar."""
|
|
||||||
return (
|
|
||||||
s.replace("\\", "\\\\")
|
|
||||||
.replace('"', '\\"')
|
|
||||||
.replace("\n", "\\n")
|
|
||||||
.replace("\r", "\\r")
|
|
||||||
.replace("\t", "\\t")
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def _route_to_yaml_fields(r: Route) -> dict[str, object]:
|
def _route_to_yaml_fields(r: Route) -> dict[str, object]:
|
||||||
fields: dict[str, object] = {"host": r.host}
|
fields: dict[str, object] = {"host": r.host}
|
||||||
if r.auth_scheme and r.token_env:
|
if r.auth_scheme and r.token_env:
|
||||||
@@ -283,12 +272,12 @@ def _render_match_entry(entry: dict[str, object]) -> list[str]:
|
|||||||
for pd in entry["paths"]: # type: ignore[union-attr]
|
for pd in entry["paths"]: # type: ignore[union-attr]
|
||||||
pd_dict: dict[str, str] = pd # type: ignore[assignment]
|
pd_dict: dict[str, str] = pd # type: ignore[assignment]
|
||||||
if "type" in pd_dict:
|
if "type" in pd_dict:
|
||||||
lines.append(f' - type: "{_yaml_str_escape(pd_dict["type"])}"')
|
lines.append(f' - type: "{pd_dict["type"]}"')
|
||||||
lines.append(f' value: "{_yaml_str_escape(pd_dict["value"])}"')
|
lines.append(f' value: "{pd_dict["value"]}"')
|
||||||
else:
|
else:
|
||||||
lines.append(f' - value: "{_yaml_str_escape(pd_dict["value"])}"')
|
lines.append(f' - value: "{pd_dict["value"]}"')
|
||||||
if "methods" in entry:
|
if "methods" in entry:
|
||||||
methods_str = ", ".join(f'"{_yaml_str_escape(m)}"' for m in entry["methods"]) # type: ignore[union-attr]
|
methods_str = ", ".join(f'"{m}"' for m in entry["methods"]) # type: ignore[union-attr]
|
||||||
prefix = " - " if first_key else " "
|
prefix = " - " if first_key else " "
|
||||||
lines.append(f'{prefix}methods: [{methods_str}]')
|
lines.append(f'{prefix}methods: [{methods_str}]')
|
||||||
first_key = False
|
first_key = False
|
||||||
@@ -298,8 +287,8 @@ def _render_match_entry(entry: dict[str, object]) -> list[str]:
|
|||||||
first_key = False
|
first_key = False
|
||||||
for hd in entry["headers"]: # type: ignore[union-attr]
|
for hd in entry["headers"]: # type: ignore[union-attr]
|
||||||
hd_dict: dict[str, str] = hd # type: ignore[assignment]
|
hd_dict: dict[str, str] = hd # type: ignore[assignment]
|
||||||
lines.append(f' - name: "{_yaml_str_escape(hd_dict["name"])}"')
|
lines.append(f' - name: "{hd_dict["name"]}"')
|
||||||
lines.append(f' value: "{_yaml_str_escape(hd_dict["value"])}"')
|
lines.append(f' value: "{hd_dict["value"]}"')
|
||||||
if first_key:
|
if first_key:
|
||||||
lines.append(" - {}")
|
lines.append(" - {}")
|
||||||
return lines
|
return lines
|
||||||
@@ -319,10 +308,10 @@ def egress_render_routes(
|
|||||||
return "\n".join(lines) + "\n"
|
return "\n".join(lines) + "\n"
|
||||||
for r in routes:
|
for r in routes:
|
||||||
f = _route_to_yaml_fields(r)
|
f = _route_to_yaml_fields(r)
|
||||||
lines.append(f' - host: "{_yaml_str_escape(str(f["host"]))}"')
|
lines.append(f' - host: "{f["host"]}"')
|
||||||
if "auth_scheme" in f:
|
if "auth_scheme" in f:
|
||||||
lines.append(f' auth_scheme: "{_yaml_str_escape(str(f["auth_scheme"]))}"')
|
lines.append(f' auth_scheme: "{f["auth_scheme"]}"')
|
||||||
lines.append(f' token_env: "{_yaml_str_escape(str(f["token_env"]))}"')
|
lines.append(f' token_env: "{f["token_env"]}"')
|
||||||
if "matches" in f:
|
if "matches" in f:
|
||||||
lines.append(" matches:")
|
lines.append(" matches:")
|
||||||
for entry in f["matches"]: # type: ignore[union-attr]
|
for entry in f["matches"]: # type: ignore[union-attr]
|
||||||
@@ -342,7 +331,7 @@ def egress_render_routes(
|
|||||||
items_str = ", ".join(f'"{x}"' for x in dv)
|
items_str = ", ".join(f'"{x}"' for x in dv)
|
||||||
lines.append(f" {dk}: [{items_str}]")
|
lines.append(f" {dk}: [{items_str}]")
|
||||||
elif isinstance(dv, str):
|
elif isinstance(dv, str):
|
||||||
lines.append(f' {dk}: "{_yaml_str_escape(dv)}"')
|
lines.append(f' {dk}: "{dv}"')
|
||||||
return "\n".join(lines) + "\n"
|
return "\n".join(lines) + "\n"
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -439,6 +439,15 @@ def route_to_yaml_dict(r: Route) -> dict[str, object]:
|
|||||||
return d
|
return d
|
||||||
|
|
||||||
|
|
||||||
|
def load_routes(text: str) -> tuple[Route, ...]:
|
||||||
|
"""Parse YAML text → routes."""
|
||||||
|
try:
|
||||||
|
payload = parse_yaml_subset(text)
|
||||||
|
except YamlSubsetError as e:
|
||||||
|
raise ValueError(f"routes payload: invalid YAML: {e}") from e
|
||||||
|
return parse_routes(payload)
|
||||||
|
|
||||||
|
|
||||||
def parse_config(payload: object) -> "Config":
|
def parse_config(payload: object) -> "Config":
|
||||||
"""Parse a full egress config payload (top-level log level + routes)."""
|
"""Parse a full egress config payload (top-level log level + routes)."""
|
||||||
if not isinstance(payload, dict):
|
if not isinstance(payload, dict):
|
||||||
@@ -853,6 +862,7 @@ __all__ = [
|
|||||||
"is_git_push_request",
|
"is_git_push_request",
|
||||||
"is_git_fetch_request",
|
"is_git_fetch_request",
|
||||||
"load_config",
|
"load_config",
|
||||||
|
"load_routes",
|
||||||
"match_route",
|
"match_route",
|
||||||
"outbound_scan_headers",
|
"outbound_scan_headers",
|
||||||
"parse_config",
|
"parse_config",
|
||||||
|
|||||||
+6
-17
@@ -43,10 +43,10 @@ from .manifest import ManifestBottle, ManifestGitEntry
|
|||||||
# Short network alias for git-gate inside the sidecar bundle. The
|
# Short network alias for git-gate inside the sidecar bundle. The
|
||||||
# agent's `.gitconfig` insteadOf rewrites resolve through this name.
|
# agent's `.gitconfig` insteadOf rewrites resolve through this name.
|
||||||
GIT_GATE_HOSTNAME = "git-gate"
|
GIT_GATE_HOSTNAME = "git-gate"
|
||||||
# Shared timeout (seconds) for all git-gate subprocess and CGI calls:
|
# Bound half-open git client sessions. If an agent/tool runner is
|
||||||
# git daemon (--timeout/--init-timeout), the access-hook subprocess in
|
# interrupted during push, git daemon should reap the receive-pack
|
||||||
# git_http_backend, and the git http-backend CGI subprocess.
|
# child instead of keeping the gate wedged indefinitely.
|
||||||
GIT_GATE_TIMEOUT_SECS = 15
|
GIT_GATE_DAEMON_TIMEOUT_SECS = 15
|
||||||
|
|
||||||
|
|
||||||
@dataclass(frozen=True)
|
@dataclass(frozen=True)
|
||||||
@@ -112,15 +112,6 @@ def git_gate_upstreams_for_bottle(bottle: ManifestBottle) -> tuple[GitGateUpstre
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
def _gitconfig_validate_value(field: str, value: str) -> None:
|
|
||||||
"""Raise ValueError if value contains characters that break gitconfig line syntax."""
|
|
||||||
if "\n" in value or "\r" in value:
|
|
||||||
raise ValueError(
|
|
||||||
f"git-gate: {field} contains a newline, which would inject "
|
|
||||||
f"arbitrary gitconfig keys; rejecting manifest entry"
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def git_gate_render_gitconfig(
|
def git_gate_render_gitconfig(
|
||||||
entries: tuple[ManifestGitEntry, ...], gate_host: str, *, scheme: str = "git",
|
entries: tuple[ManifestGitEntry, ...], gate_host: str, *, scheme: str = "git",
|
||||||
) -> str:
|
) -> str:
|
||||||
@@ -145,7 +136,6 @@ def git_gate_render_gitconfig(
|
|||||||
"# fetch-from-upstream-before-every-upload-pack via access-hook).\n",
|
"# fetch-from-upstream-before-every-upload-pack via access-hook).\n",
|
||||||
]
|
]
|
||||||
for entry in entries:
|
for entry in entries:
|
||||||
_gitconfig_validate_value(f"repos[{entry.Name!r}].url", entry.Upstream)
|
|
||||||
out.append(f'[url "{scheme}://{gate_host}/{entry.Name}.git"]\n')
|
out.append(f'[url "{scheme}://{gate_host}/{entry.Name}.git"]\n')
|
||||||
out.append(f"\tinsteadOf = {entry.Upstream}\n")
|
out.append(f"\tinsteadOf = {entry.Upstream}\n")
|
||||||
if entry.RemoteKey and entry.RemoteKey != entry.UpstreamHost:
|
if entry.RemoteKey and entry.RemoteKey != entry.UpstreamHost:
|
||||||
@@ -158,7 +148,6 @@ def git_gate_render_gitconfig(
|
|||||||
f"ssh://{entry.UpstreamUser}@{entry.RemoteKey}{port}/"
|
f"ssh://{entry.UpstreamUser}@{entry.RemoteKey}{port}/"
|
||||||
f"{entry.UpstreamPath}"
|
f"{entry.UpstreamPath}"
|
||||||
)
|
)
|
||||||
_gitconfig_validate_value(f"repos[{entry.Name!r}].url (resolved alias)", alias)
|
|
||||||
out.append(f"\tinsteadOf = {alias}\n")
|
out.append(f"\tinsteadOf = {alias}\n")
|
||||||
return "".join(out)
|
return "".join(out)
|
||||||
|
|
||||||
@@ -228,8 +217,8 @@ def git_gate_render_entrypoint(upstreams: tuple[GitGateUpstream, ...]) -> str:
|
|||||||
"",
|
"",
|
||||||
"exec git daemon \\",
|
"exec git daemon \\",
|
||||||
" --reuseaddr \\",
|
" --reuseaddr \\",
|
||||||
f" --timeout={GIT_GATE_TIMEOUT_SECS} \\",
|
f" --timeout={GIT_GATE_DAEMON_TIMEOUT_SECS} \\",
|
||||||
f" --init-timeout={GIT_GATE_TIMEOUT_SECS} \\",
|
f" --init-timeout={GIT_GATE_DAEMON_TIMEOUT_SECS} \\",
|
||||||
" --base-path=/git \\",
|
" --base-path=/git \\",
|
||||||
" --export-all \\",
|
" --export-all \\",
|
||||||
" --enable=receive-pack \\",
|
" --enable=receive-pack \\",
|
||||||
|
|||||||
@@ -16,8 +16,6 @@ from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
|
|||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
from urllib.parse import urlsplit
|
from urllib.parse import urlsplit
|
||||||
|
|
||||||
from .git_gate import GIT_GATE_TIMEOUT_SECS
|
|
||||||
|
|
||||||
|
|
||||||
DEFAULT_PORT = 9420
|
DEFAULT_PORT = 9420
|
||||||
|
|
||||||
@@ -49,7 +47,6 @@ class GitHttpHandler(BaseHTTPRequestHandler):
|
|||||||
[hook_path, "upload-pack", str(repo_dir), peer, peer],
|
[hook_path, "upload-pack", str(repo_dir), peer, peer],
|
||||||
capture_output=True,
|
capture_output=True,
|
||||||
check=False,
|
check=False,
|
||||||
timeout=GIT_GATE_TIMEOUT_SECS,
|
|
||||||
)
|
)
|
||||||
if hook.returncode != 0:
|
if hook.returncode != 0:
|
||||||
detail = (hook.stderr or hook.stdout).decode(
|
detail = (hook.stderr or hook.stdout).decode(
|
||||||
@@ -113,7 +110,6 @@ class GitHttpHandler(BaseHTTPRequestHandler):
|
|||||||
env=env,
|
env=env,
|
||||||
capture_output=True,
|
capture_output=True,
|
||||||
check=False,
|
check=False,
|
||||||
timeout=GIT_GATE_TIMEOUT_SECS,
|
|
||||||
)
|
)
|
||||||
self._write_cgi_response(proc.stdout)
|
self._write_cgi_response(proc.stdout)
|
||||||
|
|
||||||
@@ -152,13 +148,7 @@ class GitHttpHandler(BaseHTTPRequestHandler):
|
|||||||
key, _, value = line.decode("latin1").partition(":")
|
key, _, value = line.decode("latin1").partition(":")
|
||||||
value = value.strip()
|
value = value.strip()
|
||||||
if key.lower() == "status":
|
if key.lower() == "status":
|
||||||
try:
|
status = int(value.split()[0])
|
||||||
status = int(value.split()[0])
|
|
||||||
except (ValueError, IndexError):
|
|
||||||
self.log_message(
|
|
||||||
"malformed CGI Status header %r; using 500", value,
|
|
||||||
)
|
|
||||||
status = 500
|
|
||||||
else:
|
else:
|
||||||
headers.append((key, value))
|
headers.append((key, value))
|
||||||
self.send_response(status)
|
self.send_response(status)
|
||||||
|
|||||||
@@ -113,8 +113,10 @@ class ManifestBottle:
|
|||||||
egress: ManifestEgressConfig = field(default_factory=ManifestEgressConfig)
|
egress: ManifestEgressConfig = field(default_factory=ManifestEgressConfig)
|
||||||
# Per-bottle stuck-recovery sidecar (PRD 0013). When true (the
|
# Per-bottle stuck-recovery sidecar (PRD 0013). When true (the
|
||||||
# default, issue #249), the launch step brings up a supervise
|
# default, issue #249), the launch step brings up a supervise
|
||||||
# sidecar that exposes egress MCP tools to the agent. Set
|
# sidecar that exposes MCP tools to the agent (egress-block,
|
||||||
# `supervise: false` to skip the sidecar.
|
# capability-block) plus mounts the current-config dir read-only
|
||||||
|
# into the agent at /etc/bot-bottle/current-config. Set
|
||||||
|
# `supervise: false` to skip the sidecar and mount.
|
||||||
supervise: bool = True
|
supervise: bool = True
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
|
|||||||
+18
-110
@@ -101,125 +101,33 @@ def _resolve_one_bottle(
|
|||||||
repos_cache[name] = _resolve_repos_raw({}, child_raw)
|
repos_cache[name] = _resolve_repos_raw({}, child_raw)
|
||||||
return bottle
|
return bottle
|
||||||
|
|
||||||
# Normalize to list, accepting both str and list[str].
|
if not isinstance(parent_name_raw, str):
|
||||||
raw_list: list[object]
|
|
||||||
if isinstance(parent_name_raw, str):
|
|
||||||
raw_list = [parent_name_raw]
|
|
||||||
elif isinstance(parent_name_raw, list):
|
|
||||||
raw_list = parent_name_raw
|
|
||||||
else:
|
|
||||||
raise ManifestError(
|
raise ManifestError(
|
||||||
f"bottle '{name}' extends must be a string or list of strings "
|
f"bottle '{name}' extends must be a string "
|
||||||
f"(was {type(parent_name_raw).__name__})"
|
f"(was {type(parent_name_raw).__name__})"
|
||||||
)
|
)
|
||||||
|
parent_name: str = parent_name_raw
|
||||||
# Validate each entry before resolving any of them.
|
if parent_name == name:
|
||||||
parent_names: list[str] = []
|
raise ManifestError(
|
||||||
for i, pname in enumerate(raw_list):
|
f"bottle '{name}' extends itself; remove the "
|
||||||
if not isinstance(pname, str):
|
f"self-reference"
|
||||||
raise ManifestError(
|
)
|
||||||
f"bottle '{name}' extends[{i}] must be a string "
|
if parent_name not in raws:
|
||||||
f"(was {type(pname).__name__})"
|
avail = ", ".join(sorted(raws.keys())) or "(none)"
|
||||||
)
|
raise ManifestError(
|
||||||
parent_names.append(pname)
|
f"bottle '{name}' extends '{parent_name}' which is not "
|
||||||
if pname == name:
|
f"defined. Available bottles: {avail}"
|
||||||
raise ManifestError(
|
)
|
||||||
f"bottle '{name}' extends itself; remove the self-reference"
|
parent = _resolve_one_bottle(
|
||||||
)
|
parent_name, raws, cache, repos_cache, seen + (name,)
|
||||||
if pname not in raws:
|
|
||||||
avail = ", ".join(sorted(raws.keys())) or "(none)"
|
|
||||||
raise ManifestError(
|
|
||||||
f"bottle '{name}' extends '{pname}' which is not "
|
|
||||||
f"defined. Available bottles: {avail}"
|
|
||||||
)
|
|
||||||
|
|
||||||
combined_parent, combined_repos_raw = _fold_parents(
|
|
||||||
parent_names, raws, cache, repos_cache, seen + (name,)
|
|
||||||
)
|
)
|
||||||
merged_repos_raw = _resolve_repos_raw(combined_repos_raw, child_raw)
|
merged_repos_raw = _resolve_repos_raw(repos_cache[parent_name], child_raw)
|
||||||
bottle = _merge_bottles(combined_parent, child_raw, merged_repos_raw, name)
|
bottle = _merge_bottles(parent, child_raw, merged_repos_raw, name)
|
||||||
cache[name] = bottle
|
cache[name] = bottle
|
||||||
repos_cache[name] = merged_repos_raw
|
repos_cache[name] = merged_repos_raw
|
||||||
return bottle
|
return bottle
|
||||||
|
|
||||||
|
|
||||||
def _fold_parents(
|
|
||||||
parent_names: list[str],
|
|
||||||
raws: dict[str, dict[str, object]],
|
|
||||||
cache: dict[str, ManifestBottle],
|
|
||||||
repos_cache: dict[str, dict[str, object]],
|
|
||||||
seen: tuple[str, ...],
|
|
||||||
) -> tuple[ManifestBottle, dict[str, object]]:
|
|
||||||
"""Resolve each parent and fold them left-to-right.
|
|
||||||
|
|
||||||
Later parents win over earlier ones on conflict. The `seen` tuple
|
|
||||||
carries the current bottle's name so cycle detection works across
|
|
||||||
every parent edge in the multi-parent graph."""
|
|
||||||
first = parent_names[0]
|
|
||||||
effective = _resolve_one_bottle(first, raws, cache, repos_cache, seen)
|
|
||||||
effective_repos_raw = repos_cache[first]
|
|
||||||
for pname in parent_names[1:]:
|
|
||||||
later = _resolve_one_bottle(pname, raws, cache, repos_cache, seen)
|
|
||||||
later_repos_raw = repos_cache[pname]
|
|
||||||
effective, effective_repos_raw = _fold_two_bottles(
|
|
||||||
effective, effective_repos_raw, later, later_repos_raw
|
|
||||||
)
|
|
||||||
return effective, effective_repos_raw
|
|
||||||
|
|
||||||
|
|
||||||
def _fold_two_bottles(
|
|
||||||
earlier: ManifestBottle,
|
|
||||||
earlier_repos_raw: dict[str, object],
|
|
||||||
later: ManifestBottle,
|
|
||||||
later_repos_raw: dict[str, object],
|
|
||||||
) -> tuple[ManifestBottle, dict[str, object]]:
|
|
||||||
"""Combine two resolved parent bottles; later wins over earlier."""
|
|
||||||
from .manifest import ManifestBottle, ManifestGitUser
|
|
||||||
from .manifest_egress import ManifestEgressConfig
|
|
||||||
from .manifest_git import parse_git_gate_config
|
|
||||||
from .manifest_util import as_json_object
|
|
||||||
|
|
||||||
merged_env = {**earlier.env, **later.env}
|
|
||||||
|
|
||||||
merged_git_user = ManifestGitUser(
|
|
||||||
name=later.git_user.name or earlier.git_user.name,
|
|
||||||
email=later.git_user.email or earlier.git_user.email,
|
|
||||||
)
|
|
||||||
|
|
||||||
# Repos: union by name; for same-name entries, later wins per-field.
|
|
||||||
# Unlike _resolve_repos_raw, an empty later_repos_raw means "no repos
|
|
||||||
# declared" — it does NOT clear the earlier parent's repos.
|
|
||||||
names = list(earlier_repos_raw) + [
|
|
||||||
n for n in later_repos_raw if n not in earlier_repos_raw
|
|
||||||
]
|
|
||||||
merged_repos_raw: dict[str, object] = {
|
|
||||||
n: {
|
|
||||||
**as_json_object(earlier_repos_raw.get(n, {}), "earlier parent repo"),
|
|
||||||
**as_json_object(later_repos_raw.get(n, {}), "later parent repo"),
|
|
||||||
}
|
|
||||||
for n in names
|
|
||||||
}
|
|
||||||
if merged_repos_raw:
|
|
||||||
merged_git, _ = parse_git_gate_config("_fold", {"repos": merged_repos_raw})
|
|
||||||
else:
|
|
||||||
merged_git = ()
|
|
||||||
|
|
||||||
# Egress: routes concatenate; scalar fields use last-wins.
|
|
||||||
merged_egress = ManifestEgressConfig(
|
|
||||||
routes=earlier.egress.routes + later.egress.routes,
|
|
||||||
Log=later.egress.Log,
|
|
||||||
)
|
|
||||||
|
|
||||||
return ManifestBottle(
|
|
||||||
env=merged_env,
|
|
||||||
agent_provider=later.agent_provider,
|
|
||||||
git=merged_git,
|
|
||||||
git_user=merged_git_user,
|
|
||||||
egress=merged_egress,
|
|
||||||
supervise=later.supervise,
|
|
||||||
), merged_repos_raw
|
|
||||||
|
|
||||||
|
|
||||||
def _merge_bottles(
|
def _merge_bottles(
|
||||||
parent: ManifestBottle,
|
parent: ManifestBottle,
|
||||||
child_raw: dict[str, object],
|
child_raw: dict[str, object],
|
||||||
|
|||||||
@@ -106,7 +106,5 @@ def load_bottle_chain_from_dir(
|
|||||||
parent = fm.get("extends")
|
parent = fm.get("extends")
|
||||||
if isinstance(parent, str):
|
if isinstance(parent, str):
|
||||||
to_load.append(parent)
|
to_load.append(parent)
|
||||||
elif isinstance(parent, list):
|
|
||||||
to_load.extend(p for p in parent if isinstance(p, str))
|
|
||||||
|
|
||||||
return resolve_bottles(raws)[bottle_name]
|
return resolve_bottles(raws)[bottle_name]
|
||||||
|
|||||||
+42
-10
@@ -2,10 +2,11 @@
|
|||||||
|
|
||||||
The supervise plane is the per-bottle MCP sidecar plus its host-side
|
The supervise plane is the per-bottle MCP sidecar plus its host-side
|
||||||
queue/audit support. The sidecar (bot_bottle.supervise_server)
|
queue/audit support. The sidecar (bot_bottle.supervise_server)
|
||||||
sits on the bottle's internal network and exposes MCP tools the agent
|
sits on the bottle's internal network and exposes three MCP tools the
|
||||||
calls when it needs an operator-reviewed egress change:
|
agent calls when it hits a stuck-recovery category:
|
||||||
|
|
||||||
* egress-block / allow — agent proposes a new routes.yaml
|
* egress-block / allow — agent proposes a new routes.yaml
|
||||||
|
* capability-block — agent proposes a new agent Dockerfile
|
||||||
|
|
||||||
Each tool call: the agent passes the full proposed file plus a
|
Each tool call: the agent passes the full proposed file plus a
|
||||||
justification text. The sidecar validates the proposal syntactically,
|
justification text. The sidecar validates the proposal syntactically,
|
||||||
@@ -47,6 +48,7 @@ from pathlib import Path
|
|||||||
SUPERVISE_HOSTNAME = "supervise"
|
SUPERVISE_HOSTNAME = "supervise"
|
||||||
SUPERVISE_PORT = 9100
|
SUPERVISE_PORT = 9100
|
||||||
|
|
||||||
|
TOOL_CAPABILITY_BLOCK = "capability-block"
|
||||||
TOOL_EGRESS_BLOCK = "egress-block"
|
TOOL_EGRESS_BLOCK = "egress-block"
|
||||||
TOOL_EGRESS_ALLOW = "egress-allow"
|
TOOL_EGRESS_ALLOW = "egress-allow"
|
||||||
TOOL_GITLEAKS_ALLOW = "gitleaks-allow"
|
TOOL_GITLEAKS_ALLOW = "gitleaks-allow"
|
||||||
@@ -56,6 +58,7 @@ TOOL_EGRESS_TOKEN_ALLOW = "egress-token-allow"
|
|||||||
TOOL_LIST_EGRESS_ROUTES = "list-egress-routes"
|
TOOL_LIST_EGRESS_ROUTES = "list-egress-routes"
|
||||||
TOOLS: tuple[str, ...] = (
|
TOOLS: tuple[str, ...] = (
|
||||||
TOOL_EGRESS_ALLOW,
|
TOOL_EGRESS_ALLOW,
|
||||||
|
TOOL_CAPABILITY_BLOCK,
|
||||||
TOOL_EGRESS_BLOCK,
|
TOOL_EGRESS_BLOCK,
|
||||||
TOOL_GITLEAKS_ALLOW,
|
TOOL_GITLEAKS_ALLOW,
|
||||||
TOOL_EGRESS_TOKEN_ALLOW,
|
TOOL_EGRESS_TOKEN_ALLOW,
|
||||||
@@ -72,6 +75,10 @@ TOOLS: tuple[str, ...] = (
|
|||||||
EGRESS_FORWARD_PROXY = "http://127.0.0.1:9099"
|
EGRESS_FORWARD_PROXY = "http://127.0.0.1:9099"
|
||||||
EGRESS_INTROSPECT_URL = "http://_egress.local/allowlist"
|
EGRESS_INTROSPECT_URL = "http://_egress.local/allowlist"
|
||||||
|
|
||||||
|
# capability-block has no on-disk config the operator edits in place
|
||||||
|
# (the Dockerfile is rebuilt, not patched), so it has no audit log
|
||||||
|
# here — those changes are captured by git history + the rebuild record
|
||||||
|
# laid down in PRD 0016.
|
||||||
COMPONENT_FOR_TOOL: dict[str, str] = {
|
COMPONENT_FOR_TOOL: dict[str, str] = {
|
||||||
TOOL_EGRESS_ALLOW: "egress",
|
TOOL_EGRESS_ALLOW: "egress",
|
||||||
TOOL_EGRESS_BLOCK: "egress",
|
TOOL_EGRESS_BLOCK: "egress",
|
||||||
@@ -87,6 +94,8 @@ STATUSES: tuple[str, ...] = (STATUS_APPROVED, STATUS_MODIFIED, STATUS_REJECTED)
|
|||||||
ACTION_OPERATOR_EDIT = "operator-edit"
|
ACTION_OPERATOR_EDIT = "operator-edit"
|
||||||
|
|
||||||
QUEUE_DIR_IN_CONTAINER = "/run/supervise/queue"
|
QUEUE_DIR_IN_CONTAINER = "/run/supervise/queue"
|
||||||
|
CURRENT_CONFIG_DIR_IN_AGENT = "/etc/bot-bottle/current-config"
|
||||||
|
|
||||||
DEFAULT_POLL_INTERVAL_SEC = 0.5
|
DEFAULT_POLL_INTERVAL_SEC = 0.5
|
||||||
|
|
||||||
|
|
||||||
@@ -429,39 +438,59 @@ def sha256_hex(content: str) -> str:
|
|||||||
# --- Sidecar plan + abstract lifecycle -------------------------------------
|
# --- Sidecar plan + abstract lifecycle -------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
# Filename of the staged Dockerfile inside the agent's read-only
|
||||||
|
# current-config mount. The capability-block tool's description
|
||||||
|
# points the agent at this exact path so it can read the current
|
||||||
|
# Dockerfile and propose modifications.
|
||||||
|
#
|
||||||
|
# routes.yaml + allowlist used to live here too; PRD 0017 chunk 3
|
||||||
|
# moved them behind the `list-egress-routes` MCP tool (live state
|
||||||
|
# from egress's introspection endpoint) so the agent always sees
|
||||||
|
# current data rather than a launch-time snapshot.
|
||||||
|
CURRENT_CONFIG_DOCKERFILE = "Dockerfile"
|
||||||
|
|
||||||
|
|
||||||
@dataclass(frozen=True)
|
@dataclass(frozen=True)
|
||||||
class SupervisePlan:
|
class SupervisePlan:
|
||||||
"""Output of Supervise.prepare; consumed by .start.
|
"""Output of Supervise.prepare; consumed by .start.
|
||||||
|
|
||||||
`queue_dir` is the host directory bind-mounted into the sidecar
|
`queue_dir` is the host directory bind-mounted into the sidecar
|
||||||
at /run/supervise/queue. `internal_network` is empty at prepare
|
at /run/supervise/queue. `current_config_dir` is the host
|
||||||
time; the backend's launch step fills it via dataclasses.replace
|
directory bind-mounted (read-only) into the *agent* container
|
||||||
before calling .start."""
|
at /etc/bot-bottle/current-config — currently holds only the
|
||||||
|
Dockerfile snapshot (routes.yaml + allowlist moved to the
|
||||||
|
`list-egress-routes` MCP tool). `internal_network` is
|
||||||
|
empty at prepare time; the backend's launch step fills it via
|
||||||
|
dataclasses.replace before calling .start."""
|
||||||
|
|
||||||
slug: str
|
slug: str
|
||||||
queue_dir: Path
|
queue_dir: Path
|
||||||
|
current_config_dir: Path
|
||||||
internal_network: str = ""
|
internal_network: str = ""
|
||||||
|
|
||||||
|
|
||||||
class Supervise(ABC):
|
class Supervise(ABC):
|
||||||
"""Per-bottle supervise sidecar. Encapsulates the host-side
|
"""Per-bottle supervise sidecar. Encapsulates the host-side
|
||||||
prepare (queue dir staging); the sidecar's start/stop lifecycle
|
prepare (queue dir + current-config staging); the sidecar's
|
||||||
is backend-specific."""
|
start/stop lifecycle is backend-specific."""
|
||||||
|
|
||||||
def prepare(
|
def prepare(
|
||||||
self,
|
self,
|
||||||
slug: str,
|
slug: str,
|
||||||
stage_dir: Path,
|
stage_dir: Path,
|
||||||
) -> SupervisePlan:
|
) -> SupervisePlan:
|
||||||
"""Stage the per-bottle queue dir on the host. Returns the
|
"""Stage the per-bottle queue dir on the host and the
|
||||||
plan; `internal_network` must be set by the launch step before
|
current-config dir under `stage_dir`. Returns the plan;
|
||||||
|
`internal_network` must be set by the launch step before
|
||||||
.start runs."""
|
.start runs."""
|
||||||
del stage_dir
|
|
||||||
queue_dir = queue_dir_for_slug(slug)
|
queue_dir = queue_dir_for_slug(slug)
|
||||||
queue_dir.mkdir(parents=True, exist_ok=True)
|
queue_dir.mkdir(parents=True, exist_ok=True)
|
||||||
|
current_config_dir = stage_dir / "current-config"
|
||||||
|
current_config_dir.mkdir(parents=True, exist_ok=True)
|
||||||
return SupervisePlan(
|
return SupervisePlan(
|
||||||
slug=slug,
|
slug=slug,
|
||||||
queue_dir=queue_dir,
|
queue_dir=queue_dir,
|
||||||
|
current_config_dir=current_config_dir,
|
||||||
)
|
)
|
||||||
|
|
||||||
# --- Helpers ---------------------------------------------------------------
|
# --- Helpers ---------------------------------------------------------------
|
||||||
@@ -512,6 +541,8 @@ __all__ = [
|
|||||||
"ACTION_OPERATOR_EDIT",
|
"ACTION_OPERATOR_EDIT",
|
||||||
"AuditEntry",
|
"AuditEntry",
|
||||||
"COMPONENT_FOR_TOOL",
|
"COMPONENT_FOR_TOOL",
|
||||||
|
"CURRENT_CONFIG_DIR_IN_AGENT",
|
||||||
|
"CURRENT_CONFIG_DOCKERFILE",
|
||||||
"DEFAULT_POLL_INTERVAL_SEC",
|
"DEFAULT_POLL_INTERVAL_SEC",
|
||||||
"Proposal",
|
"Proposal",
|
||||||
"QUEUE_DIR_IN_CONTAINER",
|
"QUEUE_DIR_IN_CONTAINER",
|
||||||
@@ -527,6 +558,7 @@ __all__ = [
|
|||||||
"TOOLS",
|
"TOOLS",
|
||||||
"EGRESS_FORWARD_PROXY",
|
"EGRESS_FORWARD_PROXY",
|
||||||
"EGRESS_INTROSPECT_URL",
|
"EGRESS_INTROSPECT_URL",
|
||||||
|
"TOOL_CAPABILITY_BLOCK",
|
||||||
"TOOL_EGRESS_ALLOW",
|
"TOOL_EGRESS_ALLOW",
|
||||||
"TOOL_EGRESS_BLOCK",
|
"TOOL_EGRESS_BLOCK",
|
||||||
"TOOL_GITLEAKS_ALLOW",
|
"TOOL_GITLEAKS_ALLOW",
|
||||||
|
|||||||
@@ -1,8 +1,8 @@
|
|||||||
"""Supervise sidecar HTTP server (PRD 0013).
|
"""Supervise sidecar HTTP server (PRD 0013).
|
||||||
|
|
||||||
Per-bottle MCP server exposing tools the agent calls to propose egress
|
Per-bottle MCP server exposing tools the agent calls to propose config
|
||||||
config changes when stuck. The tools are `egress-allow`,
|
changes when stuck. The tools are `allow`, `egress-block`,
|
||||||
`egress-block`, and `list-egress-routes`.
|
`capability-block`, and `list-egress-routes`.
|
||||||
|
|
||||||
Each queued tool call:
|
Each queued tool call:
|
||||||
|
|
||||||
@@ -47,11 +47,11 @@ from pathlib import Path
|
|||||||
try:
|
try:
|
||||||
# Same-directory imports inside the bundle container; these files are
|
# Same-directory imports inside the bundle container; these files are
|
||||||
# COPYed flat under /app by Dockerfile.sidecars.
|
# COPYed flat under /app by Dockerfile.sidecars.
|
||||||
from egress_addon_core import LOG_OFF, load_config
|
from egress_addon_core import load_routes
|
||||||
import supervise as _sv
|
import supervise as _sv
|
||||||
except ModuleNotFoundError:
|
except ModuleNotFoundError:
|
||||||
# Package imports for host-side tests and tooling.
|
# Package imports for host-side tests and tooling.
|
||||||
from .egress_addon_core import LOG_OFF, load_config
|
from .egress_addon_core import load_routes
|
||||||
from . import supervise as _sv
|
from . import supervise as _sv
|
||||||
|
|
||||||
|
|
||||||
@@ -90,19 +90,19 @@ def parse_jsonrpc(body: bytes) -> JsonRpcRequest:
|
|||||||
try:
|
try:
|
||||||
raw = json.loads(body)
|
raw = json.loads(body)
|
||||||
except json.JSONDecodeError as e:
|
except json.JSONDecodeError as e:
|
||||||
raise _RpcClientError(ERR_PARSE, f"parse error: {e}") from e
|
raise _RpcError(ERR_PARSE, f"parse error: {e}") from e
|
||||||
if not isinstance(raw, dict):
|
if not isinstance(raw, dict):
|
||||||
raise _RpcClientError(ERR_INVALID_REQUEST, "request must be a JSON object")
|
raise _RpcError(ERR_INVALID_REQUEST, "request must be a JSON object")
|
||||||
if raw.get("jsonrpc") != JSONRPC_VERSION:
|
if raw.get("jsonrpc") != JSONRPC_VERSION:
|
||||||
raise _RpcClientError(ERR_INVALID_REQUEST, "jsonrpc field must be '2.0'")
|
raise _RpcError(ERR_INVALID_REQUEST, "jsonrpc field must be '2.0'")
|
||||||
method = raw.get("method")
|
method = raw.get("method")
|
||||||
if not isinstance(method, str):
|
if not isinstance(method, str):
|
||||||
raise _RpcClientError(ERR_INVALID_REQUEST, "method must be a string")
|
raise _RpcError(ERR_INVALID_REQUEST, "method must be a string")
|
||||||
params = raw.get("params", {})
|
params = raw.get("params", {})
|
||||||
if params is None:
|
if params is None:
|
||||||
params = {}
|
params = {}
|
||||||
if not isinstance(params, dict):
|
if not isinstance(params, dict):
|
||||||
raise _RpcClientError(ERR_INVALID_PARAMS, "params must be an object")
|
raise _RpcError(ERR_INVALID_PARAMS, "params must be an object")
|
||||||
rpc_id = raw.get("id", _NO_ID)
|
rpc_id = raw.get("id", _NO_ID)
|
||||||
is_notification = rpc_id is _NO_ID
|
is_notification = rpc_id is _NO_ID
|
||||||
return JsonRpcRequest(
|
return JsonRpcRequest(
|
||||||
@@ -117,23 +117,12 @@ _NO_ID = object()
|
|||||||
|
|
||||||
|
|
||||||
class _RpcError(Exception):
|
class _RpcError(Exception):
|
||||||
"""Base class for all typed RPC errors that surface as JSON-RPC error responses."""
|
|
||||||
def __init__(self, code: int, message: str):
|
def __init__(self, code: int, message: str):
|
||||||
super().__init__(message)
|
super().__init__(message)
|
||||||
self.code = code
|
self.code = code
|
||||||
self.message = message
|
self.message = message
|
||||||
|
|
||||||
|
|
||||||
class _RpcClientError(_RpcError):
|
|
||||||
"""Caller sent a bad request; returned verbatim, no server-side logging."""
|
|
||||||
|
|
||||||
|
|
||||||
class _RpcInternalError(_RpcError):
|
|
||||||
"""Server-side fault; logged at ERROR with cause, always returns ERR_INTERNAL."""
|
|
||||||
def __init__(self, message: str) -> None:
|
|
||||||
super().__init__(ERR_INTERNAL, message)
|
|
||||||
|
|
||||||
|
|
||||||
def jsonrpc_result(request_id: object, result: object) -> bytes:
|
def jsonrpc_result(request_id: object, result: object) -> bytes:
|
||||||
payload = {"jsonrpc": JSONRPC_VERSION, "id": request_id, "result": result}
|
payload = {"jsonrpc": JSONRPC_VERSION, "id": request_id, "result": result}
|
||||||
return (json.dumps(payload) + "\n").encode("utf-8")
|
return (json.dumps(payload) + "\n").encode("utf-8")
|
||||||
@@ -253,6 +242,34 @@ TOOL_DEFINITIONS: list[dict[str, object]] = [
|
|||||||
"required": ["routes_yaml", "justification"],
|
"required": ["routes_yaml", "justification"],
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
|
"description": (
|
||||||
|
"Call when the bottle is missing a tool, skill, permission, "
|
||||||
|
"or env var you need — something that lives in the agent "
|
||||||
|
"Dockerfile rather than in the egress routes. "
|
||||||
|
"Read the current Dockerfile from "
|
||||||
|
"/etc/bot-bottle/current-config/Dockerfile, compose a "
|
||||||
|
"modified version, and pass the full new file plus a "
|
||||||
|
"justification. On approval the supervisor rebuilds the "
|
||||||
|
"bottle from the new Dockerfile and starts a replacement on "
|
||||||
|
"the same branch (wired in PRD 0016; v1 acknowledges only)."
|
||||||
|
),
|
||||||
|
"inputSchema": {
|
||||||
|
"type": "object",
|
||||||
|
"properties": {
|
||||||
|
"dockerfile": {
|
||||||
|
"type": "string",
|
||||||
|
"description": "Full proposed Dockerfile content.",
|
||||||
|
},
|
||||||
|
"justification": {
|
||||||
|
"type": "string",
|
||||||
|
"description": "Why this capability is needed.",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
"required": ["dockerfile", "justification"],
|
||||||
|
},
|
||||||
|
},
|
||||||
]
|
]
|
||||||
|
|
||||||
|
|
||||||
@@ -260,6 +277,7 @@ TOOL_DEFINITIONS: list[dict[str, object]] = [
|
|||||||
# payload (stored in Proposal.proposed_file).
|
# payload (stored in Proposal.proposed_file).
|
||||||
PROPOSED_FILE_FIELD: dict[str, str] = {
|
PROPOSED_FILE_FIELD: dict[str, str] = {
|
||||||
_sv.TOOL_EGRESS_ALLOW: "routes_yaml",
|
_sv.TOOL_EGRESS_ALLOW: "routes_yaml",
|
||||||
|
_sv.TOOL_CAPABILITY_BLOCK: "dockerfile",
|
||||||
_sv.TOOL_EGRESS_BLOCK: "routes_yaml",
|
_sv.TOOL_EGRESS_BLOCK: "routes_yaml",
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -272,22 +290,21 @@ def validate_proposed_file(tool: str, content: str) -> None:
|
|||||||
catches obvious paste-errors / wrong-tool selections before they
|
catches obvious paste-errors / wrong-tool selections before they
|
||||||
enter the queue."""
|
enter the queue."""
|
||||||
if not content.strip():
|
if not content.strip():
|
||||||
raise _RpcClientError(ERR_INVALID_PARAMS, f"{tool}: proposed file is empty")
|
raise _RpcError(ERR_INVALID_PARAMS, f"{tool}: proposed file is empty")
|
||||||
if tool in (_sv.TOOL_EGRESS_ALLOW, _sv.TOOL_EGRESS_BLOCK):
|
if tool == _sv.TOOL_CAPABILITY_BLOCK:
|
||||||
|
# Dockerfiles are too varied to validate syntactically beyond
|
||||||
|
# non-empty. The operator reads the diff in the TUI.
|
||||||
|
pass
|
||||||
|
elif tool in (_sv.TOOL_EGRESS_ALLOW, _sv.TOOL_EGRESS_BLOCK):
|
||||||
try:
|
try:
|
||||||
config = load_config(content)
|
load_routes(content)
|
||||||
except ValueError as e:
|
except ValueError as e:
|
||||||
raise _RpcClientError(
|
raise _RpcError(
|
||||||
ERR_INVALID_PARAMS,
|
ERR_INVALID_PARAMS,
|
||||||
f"{tool}: proposed routes.yaml is not valid: {e}",
|
f"{tool}: proposed routes.yaml is not valid: {e}",
|
||||||
) from e
|
) from e
|
||||||
if config.log != LOG_OFF:
|
|
||||||
raise _RpcClientError(
|
|
||||||
ERR_INVALID_PARAMS,
|
|
||||||
f"{tool}: proposed routes.yaml must not change egress logging",
|
|
||||||
)
|
|
||||||
else:
|
else:
|
||||||
raise _RpcClientError(ERR_INVALID_PARAMS, f"unknown tool {tool!r}")
|
raise _RpcError(ERR_INVALID_PARAMS, f"unknown tool {tool!r}")
|
||||||
|
|
||||||
|
|
||||||
# --- MCP handlers ----------------------------------------------------------
|
# --- MCP handlers ----------------------------------------------------------
|
||||||
@@ -360,17 +377,17 @@ def handle_tools_call(
|
|||||||
doesn't need operator approval."""
|
doesn't need operator approval."""
|
||||||
name = params.get("name")
|
name = params.get("name")
|
||||||
if not isinstance(name, str):
|
if not isinstance(name, str):
|
||||||
raise _RpcClientError(ERR_INVALID_PARAMS, "tools/call missing 'name'")
|
raise _RpcError(ERR_INVALID_PARAMS, "tools/call missing 'name'")
|
||||||
if name == _sv.TOOL_LIST_EGRESS_ROUTES:
|
if name == _sv.TOOL_LIST_EGRESS_ROUTES:
|
||||||
return handle_list_egress_routes(typing.cast(dict[str, object], params.get("arguments", {})), config)
|
return handle_list_egress_routes(typing.cast(dict[str, object], params.get("arguments", {})), config)
|
||||||
|
|
||||||
args_raw = params.get("arguments", {})
|
args_raw = params.get("arguments", {})
|
||||||
if not isinstance(args_raw, dict):
|
if not isinstance(args_raw, dict):
|
||||||
raise _RpcClientError(ERR_INVALID_PARAMS, "tools/call 'arguments' must be an object")
|
raise _RpcError(ERR_INVALID_PARAMS, "tools/call 'arguments' must be an object")
|
||||||
|
|
||||||
justification = args_raw.get("justification")
|
justification = args_raw.get("justification")
|
||||||
if not isinstance(justification, str) or not justification.strip():
|
if not isinstance(justification, str) or not justification.strip():
|
||||||
raise _RpcClientError(
|
raise _RpcError(
|
||||||
ERR_INVALID_PARAMS,
|
ERR_INVALID_PARAMS,
|
||||||
f"{name}: 'justification' is required and must be a non-empty string",
|
f"{name}: 'justification' is required and must be a non-empty string",
|
||||||
)
|
)
|
||||||
@@ -379,13 +396,13 @@ def handle_tools_call(
|
|||||||
file_field = PROPOSED_FILE_FIELD[name]
|
file_field = PROPOSED_FILE_FIELD[name]
|
||||||
proposed_file = args_raw.get(file_field)
|
proposed_file = args_raw.get(file_field)
|
||||||
if not isinstance(proposed_file, str):
|
if not isinstance(proposed_file, str):
|
||||||
raise _RpcClientError(
|
raise _RpcError(
|
||||||
ERR_INVALID_PARAMS,
|
ERR_INVALID_PARAMS,
|
||||||
f"{name}: '{file_field}' is required and must be a string",
|
f"{name}: '{file_field}' is required and must be a string",
|
||||||
)
|
)
|
||||||
validate_proposed_file(name, proposed_file)
|
validate_proposed_file(name, proposed_file)
|
||||||
else:
|
else:
|
||||||
raise _RpcClientError(ERR_INVALID_PARAMS, f"unknown tool {name!r}")
|
raise _RpcError(ERR_INVALID_PARAMS, f"unknown tool {name!r}")
|
||||||
|
|
||||||
proposal = _sv.Proposal.new(
|
proposal = _sv.Proposal.new(
|
||||||
bottle_slug=config.bottle_slug,
|
bottle_slug=config.bottle_slug,
|
||||||
@@ -394,10 +411,7 @@ def handle_tools_call(
|
|||||||
justification=justification,
|
justification=justification,
|
||||||
current_file_hash=_sv.sha256_hex(proposed_file),
|
current_file_hash=_sv.sha256_hex(proposed_file),
|
||||||
)
|
)
|
||||||
try:
|
_sv.write_proposal(config.queue_dir, proposal)
|
||||||
_sv.write_proposal(config.queue_dir, proposal)
|
|
||||||
except OSError as e:
|
|
||||||
raise _RpcInternalError(f"failed to write proposal to queue: {e}") from e
|
|
||||||
sys.stderr.write(
|
sys.stderr.write(
|
||||||
f"supervise: queued proposal {proposal.id} ({name}) "
|
f"supervise: queued proposal {proposal.id} ({name}) "
|
||||||
f"for bottle {config.bottle_slug}; waiting for operator...\n"
|
f"for bottle {config.bottle_slug}; waiting for operator...\n"
|
||||||
@@ -417,10 +431,7 @@ def handle_tools_call(
|
|||||||
"content": [{"type": "text", "text": text}],
|
"content": [{"type": "text", "text": text}],
|
||||||
"isError": False,
|
"isError": False,
|
||||||
}
|
}
|
||||||
try:
|
_sv.archive_proposal(config.queue_dir, proposal.id)
|
||||||
_sv.archive_proposal(config.queue_dir, proposal.id)
|
|
||||||
except OSError as e:
|
|
||||||
raise _RpcInternalError(f"failed to archive proposal: {e}") from e
|
|
||||||
|
|
||||||
text = format_response_text(response)
|
text = format_response_text(response)
|
||||||
return {
|
return {
|
||||||
@@ -454,8 +465,9 @@ def format_pending_response_text(timeout_seconds: float) -> str:
|
|||||||
# --- HTTP transport --------------------------------------------------------
|
# --- HTTP transport --------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
# Max request body the server accepts. 1 MB is well above any realistic
|
# Max request body the server accepts. Generous because Dockerfile
|
||||||
# routes.yaml proposal.
|
# proposals can be a few KB; routes.json is small. 1 MB is well above
|
||||||
|
# any realistic config file.
|
||||||
MAX_BODY_BYTES = 1 * 1024 * 1024
|
MAX_BODY_BYTES = 1 * 1024 * 1024
|
||||||
|
|
||||||
|
|
||||||
@@ -495,7 +507,7 @@ class MCPHandler(http.server.BaseHTTPRequestHandler):
|
|||||||
|
|
||||||
try:
|
try:
|
||||||
req = parse_jsonrpc(body)
|
req = parse_jsonrpc(body)
|
||||||
except _RpcClientError as e:
|
except _RpcError as e:
|
||||||
self._write_jsonrpc(jsonrpc_error(None, e.code, e.message))
|
self._write_jsonrpc(jsonrpc_error(None, e.code, e.message))
|
||||||
return
|
return
|
||||||
|
|
||||||
@@ -503,19 +515,11 @@ class MCPHandler(http.server.BaseHTTPRequestHandler):
|
|||||||
|
|
||||||
try:
|
try:
|
||||||
result = self._dispatch(req, config)
|
result = self._dispatch(req, config)
|
||||||
except _RpcClientError as e:
|
except _RpcError as e:
|
||||||
self._write_jsonrpc(jsonrpc_error(req.id, e.code, e.message))
|
self._write_jsonrpc(jsonrpc_error(req.id, e.code, e.message))
|
||||||
return
|
return
|
||||||
except _RpcInternalError as e:
|
except Exception as e: # noqa: W0718 — catch-all for RPC dispatch errors
|
||||||
cause = e.__cause__
|
sys.stderr.write(f"supervise: internal error: {e}\n")
|
||||||
detail = f": {cause}" if cause else ""
|
|
||||||
sys.stderr.write(f"supervise: internal error: {e.message}{detail}\n")
|
|
||||||
sys.stderr.flush()
|
|
||||||
self._write_jsonrpc(jsonrpc_error(req.id, ERR_INTERNAL, "internal error"))
|
|
||||||
return
|
|
||||||
except Exception as e: # noqa: W0718 — unexpected errors
|
|
||||||
sys.stderr.write(f"supervise: unexpected error: {type(e).__name__}: {e}\n")
|
|
||||||
sys.stderr.flush()
|
|
||||||
self._write_jsonrpc(jsonrpc_error(req.id, ERR_INTERNAL, "internal error"))
|
self._write_jsonrpc(jsonrpc_error(req.id, ERR_INTERNAL, "internal error"))
|
||||||
return
|
return
|
||||||
|
|
||||||
@@ -534,7 +538,7 @@ class MCPHandler(http.server.BaseHTTPRequestHandler):
|
|||||||
return handle_tools_list(req.params)
|
return handle_tools_list(req.params)
|
||||||
if method == "tools/call":
|
if method == "tools/call":
|
||||||
return handle_tools_call(req.params, config)
|
return handle_tools_call(req.params, config)
|
||||||
raise _RpcClientError(ERR_METHOD_NOT_FOUND, f"method not found: {method}")
|
raise _RpcError(ERR_METHOD_NOT_FOUND, f"method not found: {method}")
|
||||||
|
|
||||||
def _write_jsonrpc(self, body: bytes) -> None:
|
def _write_jsonrpc(self, body: bytes) -> None:
|
||||||
self.send_response(200)
|
self.send_response(200)
|
||||||
|
|||||||
@@ -1,166 +0,0 @@
|
|||||||
# PRD 0065: Multi-parent `extends:` for bottles
|
|
||||||
|
|
||||||
- **Status:** Active
|
|
||||||
- **Author:** didericis
|
|
||||||
- **Created:** 2026-06-25
|
|
||||||
- **Issue:** #268
|
|
||||||
- **Extends:** PRD 0025 (`0025-bottle-extends.md`)
|
|
||||||
|
|
||||||
## Summary
|
|
||||||
|
|
||||||
Allow a bottle's `extends:` field to accept either a single bottle name (existing
|
|
||||||
behavior) or a list of bottle names (new). Multiple parents are resolved
|
|
||||||
independently and folded left-to-right into a single effective parent before the
|
|
||||||
child is merged on top. This lets orthogonal concerns (base env, networking/egress,
|
|
||||||
agent provider) live in separate bottles and be composed without forcing them into a
|
|
||||||
linear chain.
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
PRD 0025 shipped single-parent `extends:` and listed "No multi-parent inheritance"
|
|
||||||
as a non-goal. In practice, users want to compose multiple orthogonal bottles — a
|
|
||||||
base environment, a networking profile, and an agent-provider override — without
|
|
||||||
creating a three-level linear chain that couples unrelated parents to each other.
|
|
||||||
The linear chain workaround has two problems:
|
|
||||||
|
|
||||||
1. **Ordering constraint.** `networking extends base` works, but then
|
|
||||||
`agent extends networking` can't also pick up `base` without going through
|
|
||||||
`networking`, coupling two unrelated concerns.
|
|
||||||
|
|
||||||
2. **Quadratic duplication.** N orthogonal bottles require O(N²) chain variants
|
|
||||||
(one chain per permutation of applied concerns).
|
|
||||||
|
|
||||||
Multi-parent `extends:` removes both constraints: each orthogonal concern stays in
|
|
||||||
its own bottle, and the child bottle is the only place that names the combination.
|
|
||||||
|
|
||||||
## Goals / Success Criteria
|
|
||||||
|
|
||||||
- `extends:` accepts a list of strings in addition to a plain string.
|
|
||||||
- Backward compat: existing single-string `extends:` is unchanged.
|
|
||||||
- Parents are resolved left-to-right; later entries win on conflict.
|
|
||||||
- Child wins over all parents (unchanged from PRD 0025).
|
|
||||||
- Cycle detection covers multi-parent graphs, not just linear chains.
|
|
||||||
- Diamond inheritance: a shared ancestor is resolved once (via the existing cache).
|
|
||||||
- Invalid list entries (non-string, undefined bottle, self-reference) die at parse
|
|
||||||
with clear messages.
|
|
||||||
- `manifest_loader.py`'s `load_bottle_chain_from_dir` enqueues all parents from a
|
|
||||||
list `extends:` so the resolver sees every bottle in the graph.
|
|
||||||
|
|
||||||
## Non-goals
|
|
||||||
|
|
||||||
- No change to the agent-vs-bottle trust boundary (PRD 0025 "Alternatives
|
|
||||||
considered" option 2 stays rejected).
|
|
||||||
- No MRO / C3 linearization. Left-to-right fold is sufficient for the expected use
|
|
||||||
cases.
|
|
||||||
- No preflight display of per-field provenance across multiple parents (same open
|
|
||||||
question as PRD 0025; remains a follow-up).
|
|
||||||
|
|
||||||
## Design
|
|
||||||
|
|
||||||
### Schema
|
|
||||||
|
|
||||||
`extends:` now accepts either form:
|
|
||||||
|
|
||||||
```yaml
|
|
||||||
# single parent (unchanged)
|
|
||||||
extends: base
|
|
||||||
|
|
||||||
# multiple parents (new)
|
|
||||||
extends: [base, networking]
|
|
||||||
```
|
|
||||||
|
|
||||||
Both forms are normalized to a list internally. A list with one element behaves
|
|
||||||
identically to the string form.
|
|
||||||
|
|
||||||
### Merge rules for multi-parent fold
|
|
||||||
|
|
||||||
Parents are folded pairwise left-to-right before the child merge. For each step in
|
|
||||||
the fold, the "earlier" bottle is the running accumulator and the "later" bottle is
|
|
||||||
the next parent. Rules per field:
|
|
||||||
|
|
||||||
| Field | Fold rule |
|
|
||||||
|--------------------|--------------------------------------------------------------|
|
|
||||||
| `env` | dict merge; later wins on key collision |
|
|
||||||
| `git-gate.user` | per-field overlay; later's non-empty fields win |
|
|
||||||
| `git-gate.repos` | union by name; for same-name entries, later wins per-field |
|
|
||||||
| `egress.routes` | concatenate (earlier first, later appended) |
|
|
||||||
| `egress.log` | later wins (last-wins) |
|
|
||||||
| `agent_provider` | later wins (last-wins) |
|
|
||||||
| `supervise` | later wins (last-wins) |
|
|
||||||
|
|
||||||
After the fold, the combined parent is merged against the child using the existing
|
|
||||||
PRD 0025 rules (child always wins). The child's `egress.routes` appends to the
|
|
||||||
combined parent's concatenated routes; `validate_egress_routes` runs once on the
|
|
||||||
final merged set and catches duplicate hosts.
|
|
||||||
|
|
||||||
### Algorithm
|
|
||||||
|
|
||||||
```
|
|
||||||
extends: [p1, p2, p3]
|
|
||||||
|
|
||||||
fold:
|
|
||||||
combined = resolve(p1)
|
|
||||||
combined = fold_two(combined, resolve(p2))
|
|
||||||
combined = fold_two(combined, resolve(p3))
|
|
||||||
|
|
||||||
merge:
|
|
||||||
result = _merge_bottles(combined, child_raw, name)
|
|
||||||
```
|
|
||||||
|
|
||||||
`fold_two(earlier, later)` applies the rules in the table above. Cycle detection
|
|
||||||
(the `seen` tuple) is passed to each parent resolution call unchanged — if any
|
|
||||||
parent's chain circles back to the current bottle, it is caught. The `cache` dict
|
|
||||||
ensures a shared ancestor is only resolved once across all parents.
|
|
||||||
|
|
||||||
### Error cases
|
|
||||||
|
|
||||||
| Condition | Error message shape |
|
|
||||||
|----------------------------------------|------------------------------------------------------------------|
|
|
||||||
| `extends` is not a string or list | `extends must be a string or list of strings (was <type>)` |
|
|
||||||
| A list entry is not a string | `extends[<i>] must be a string (was <type>)` |
|
|
||||||
| A list entry names an undefined bottle | `extends '<name>' which is not defined. Available bottles: ...` |
|
|
||||||
| A list entry is the bottle itself | `extends itself; remove the self-reference` |
|
|
||||||
| Cycle through any parent edge | `is in an extends cycle: <chain>` |
|
|
||||||
|
|
||||||
## Implementation
|
|
||||||
|
|
||||||
### `bot_bottle/manifest_extends.py`
|
|
||||||
|
|
||||||
- `_resolve_one_bottle`: accept `str | list[str]` for `extends`; normalize to list;
|
|
||||||
validate each entry; for a single-entry list fall through to the existing
|
|
||||||
single-parent path; for multiple entries call `_fold_parents` then
|
|
||||||
`_merge_bottles`.
|
|
||||||
- `_fold_parents(parent_names, raws, cache, repos_cache, seen)`: resolve each
|
|
||||||
parent and fold pairwise left-to-right; return `(effective_bottle,
|
|
||||||
effective_repos_raw)`.
|
|
||||||
- `_fold_two_bottles(earlier, earlier_repos_raw, later, later_repos_raw)`: apply
|
|
||||||
the fold rules above; return `(folded_bottle, folded_repos_raw)`.
|
|
||||||
|
|
||||||
### `bot_bottle/manifest_loader.py`
|
|
||||||
|
|
||||||
- `load_bottle_chain_from_dir`: when `extends` is a list, enqueue all parent names
|
|
||||||
for loading (previously only `isinstance(parent, str)` was handled).
|
|
||||||
|
|
||||||
### `tests/unit/test_manifest_extends.py`
|
|
||||||
|
|
||||||
- `TestExtendsErrors.test_non_string_extends_dies`: update to use an integer
|
|
||||||
`extends` value (a list is now valid).
|
|
||||||
- New class `TestExtendsMultiParent` covering all cases listed in the issue.
|
|
||||||
|
|
||||||
## Testing strategy
|
|
||||||
|
|
||||||
Unit tests via `ManifestIndex.from_json_obj` (same resolver surface used by all
|
|
||||||
paths). No integration test changes needed — downstream code consumes the already-
|
|
||||||
merged bottle and is unchanged.
|
|
||||||
|
|
||||||
Test cases:
|
|
||||||
- Two-parent list: env union, egress routes concat, git repos union
|
|
||||||
- Last-parent-wins on scalar (supervise, agent_provider)
|
|
||||||
- Child wins over all parents on conflict
|
|
||||||
- Diamond: two parents share an ancestor; ancestor resolved once
|
|
||||||
- Single-element list: identical to string form
|
|
||||||
- Non-string extends value → ManifestError
|
|
||||||
- Non-string list entry → ManifestError
|
|
||||||
- Undefined bottle in list → ManifestError
|
|
||||||
- Self-reference in list → ManifestError
|
|
||||||
- Cycle through multi-parent edge → ManifestError
|
|
||||||
+1
-1
@@ -1,4 +1,4 @@
|
|||||||
# PRD 0066: Separate agent and bottle selection
|
# PRD prd-new: Separate agent and bottle selection
|
||||||
|
|
||||||
- **Status:** Active
|
- **Status:** Active
|
||||||
- **Author:** claude
|
- **Author:** claude
|
||||||
@@ -4,4 +4,3 @@
|
|||||||
|
|
||||||
pylint>=3.0.0
|
pylint>=3.0.0
|
||||||
pyright>=1.1.300
|
pyright>=1.1.300
|
||||||
coverage>=7.0.0
|
|
||||||
|
|||||||
@@ -92,9 +92,9 @@ class TestSandboxEscape(unittest.TestCase):
|
|||||||
"on PATH: curl -sSL https://smolmachines.com/install.sh | sh"
|
"on PATH: curl -sSL https://smolmachines.com/install.sh | sh"
|
||||||
)
|
)
|
||||||
|
|
||||||
# Throwaway static key for the git-gate fixture. It need not
|
# Throwaway "identity file" for the git-gate's `identity` field.
|
||||||
# be a real SSH key: test 5 reaches gitleaks before any SSH
|
# It need not be a real SSH key: test 5 reaches gitleaks before
|
||||||
# attempt anyway.
|
# any SSH attempt anyway.
|
||||||
fd, kp = tempfile.mkstemp(prefix="sandbox-test-key.")
|
fd, kp = tempfile.mkstemp(prefix="sandbox-test-key.")
|
||||||
os.close(fd)
|
os.close(fd)
|
||||||
cls._key_path = Path(kp)
|
cls._key_path = Path(kp)
|
||||||
@@ -123,10 +123,7 @@ class TestSandboxEscape(unittest.TestCase):
|
|||||||
"git-gate": {"repos": {
|
"git-gate": {"repos": {
|
||||||
"throwaway": {
|
"throwaway": {
|
||||||
"url": "ssh://git@unreachable.invalid:22/throwaway.git",
|
"url": "ssh://git@unreachable.invalid:22/throwaway.git",
|
||||||
"key": {
|
"identity": str(cls._key_path),
|
||||||
"provider": "static",
|
|
||||||
"path": str(cls._key_path),
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
}},
|
}},
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -198,7 +198,6 @@ class TestSmolmachinesLaunch(unittest.TestCase):
|
|||||||
# connect fails, which is the property chunk 3 will
|
# connect fails, which is the property chunk 3 will
|
||||||
# preserve once egress is actually running.
|
# preserve once egress is actually running.
|
||||||
r = self.bottle.exec(
|
r = self.bottle.exec(
|
||||||
"env -u HTTPS_PROXY -u HTTP_PROXY -u https_proxy -u http_proxy "
|
|
||||||
f"curl -s --show-error --max-time 3 http://{self.plan.bundle_ip}:9099 "
|
f"curl -s --show-error --max-time 3 http://{self.plan.bundle_ip}:9099 "
|
||||||
"2>&1 || true"
|
"2>&1 || true"
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -115,8 +115,8 @@ class TestBottleIdentity(unittest.TestCase):
|
|||||||
|
|
||||||
|
|
||||||
class TestPreserveMarker(_FakeHomeMixin, unittest.TestCase):
|
class TestPreserveMarker(_FakeHomeMixin, unittest.TestCase):
|
||||||
"""The .preserve marker tells cli.py's session-end cleanup to keep
|
"""The .preserve marker is how capability_apply tells cli.py's
|
||||||
the state dir instead of removing it."""
|
session-end cleanup to keep the state dir instead of removing it."""
|
||||||
|
|
||||||
def setUp(self):
|
def setUp(self):
|
||||||
self._setup_fake_home()
|
self._setup_fake_home()
|
||||||
|
|||||||
@@ -11,7 +11,6 @@ from __future__ import annotations
|
|||||||
|
|
||||||
import os
|
import os
|
||||||
import unittest
|
import unittest
|
||||||
from collections.abc import Mapping, Sequence
|
|
||||||
from unittest.mock import MagicMock, patch
|
from unittest.mock import MagicMock, patch
|
||||||
|
|
||||||
import bot_bottle.cli.start as start_mod
|
import bot_bottle.cli.start as start_mod
|
||||||
@@ -254,107 +253,5 @@ class TestCmdStartLabelCollision(unittest.TestCase):
|
|||||||
self.assertIn("already in use", second_call_kwargs.get("disclaimer", ""))
|
self.assertIn("already in use", second_call_kwargs.get("disclaimer", ""))
|
||||||
|
|
||||||
|
|
||||||
class TestBottleLineage(unittest.TestCase):
|
|
||||||
"""Unit tests for _bottle_lineage."""
|
|
||||||
|
|
||||||
def test_returns_empty_in_eager_mode(self):
|
|
||||||
manifest = _make_manifest(["agent"], ["base", "dev"])
|
|
||||||
# home_md is None in eager mode → no file reads, returns {}
|
|
||||||
result = start_mod._bottle_lineage(manifest)
|
|
||||||
self.assertEqual({}, result)
|
|
||||||
|
|
||||||
def test_reads_extends_chain_from_files(self):
|
|
||||||
import tempfile
|
|
||||||
from pathlib import Path
|
|
||||||
|
|
||||||
with tempfile.TemporaryDirectory() as tmp:
|
|
||||||
bottles_dir = Path(tmp) / "bottles"
|
|
||||||
bottles_dir.mkdir()
|
|
||||||
(bottles_dir / "base.md").write_text("---\n{}\n---\n")
|
|
||||||
(bottles_dir / "mid.md").write_text("---\nextends: base\n---\n")
|
|
||||||
(bottles_dir / "leaf.md").write_text("---\nextends: mid\n---\n")
|
|
||||||
|
|
||||||
manifest = MagicMock()
|
|
||||||
manifest.home_md = Path(tmp)
|
|
||||||
|
|
||||||
result = start_mod._bottle_lineage(manifest)
|
|
||||||
|
|
||||||
self.assertNotIn("base", result) # no parent → not in map
|
|
||||||
self.assertEqual("base -> mid", result["mid"])
|
|
||||||
self.assertEqual("base -> mid -> leaf", result["leaf"])
|
|
||||||
|
|
||||||
def test_cycle_protection(self):
|
|
||||||
import tempfile
|
|
||||||
from pathlib import Path
|
|
||||||
|
|
||||||
with tempfile.TemporaryDirectory() as tmp:
|
|
||||||
bottles_dir = Path(tmp) / "bottles"
|
|
||||||
bottles_dir.mkdir()
|
|
||||||
(bottles_dir / "a.md").write_text("---\nextends: b\n---\n")
|
|
||||||
(bottles_dir / "b.md").write_text("---\nextends: a\n---\n")
|
|
||||||
|
|
||||||
manifest = MagicMock()
|
|
||||||
manifest.home_md = Path(tmp)
|
|
||||||
|
|
||||||
result = start_mod._bottle_lineage(manifest)
|
|
||||||
|
|
||||||
# Cycle must not hang; each should get a two-element chain.
|
|
||||||
for name in ("a", "b"):
|
|
||||||
self.assertIn(name, result)
|
|
||||||
self.assertIn("->", result[name])
|
|
||||||
|
|
||||||
|
|
||||||
class TestManifestToYaml(unittest.TestCase):
|
|
||||||
"""Unit tests for _manifest_to_yaml."""
|
|
||||||
|
|
||||||
def _make_manifest_obj(
|
|
||||||
self,
|
|
||||||
*,
|
|
||||||
skills: Sequence[str] = (),
|
|
||||||
env: Mapping[str, str] | None = None,
|
|
||||||
supervise: bool = True,
|
|
||||||
agent_provider_template: str = "claude",
|
|
||||||
):
|
|
||||||
from bot_bottle.manifest import Manifest, ManifestBottle
|
|
||||||
from bot_bottle.manifest_agent import ManifestAgent, ManifestAgentProvider
|
|
||||||
|
|
||||||
agent = ManifestAgent(skills=tuple(skills))
|
|
||||||
bottle = ManifestBottle(
|
|
||||||
env=env or {},
|
|
||||||
supervise=supervise,
|
|
||||||
agent_provider=ManifestAgentProvider(template=agent_provider_template),
|
|
||||||
)
|
|
||||||
return Manifest(agent=agent, bottle=bottle)
|
|
||||||
|
|
||||||
def test_includes_agent_section(self):
|
|
||||||
m = self._make_manifest_obj(skills=["researcher"])
|
|
||||||
yaml = start_mod._manifest_to_yaml(m)
|
|
||||||
self.assertIn("agent:", yaml)
|
|
||||||
self.assertIn("- researcher", yaml)
|
|
||||||
|
|
||||||
def test_includes_bottle_section(self):
|
|
||||||
m = self._make_manifest_obj(env={"FOO": "bar"})
|
|
||||||
yaml = start_mod._manifest_to_yaml(m)
|
|
||||||
self.assertIn("bottle:", yaml)
|
|
||||||
self.assertIn("FOO: bar", yaml)
|
|
||||||
|
|
||||||
def test_supervise_rendered(self):
|
|
||||||
m_true = self._make_manifest_obj(supervise=True)
|
|
||||||
m_false = self._make_manifest_obj(supervise=False)
|
|
||||||
self.assertIn("supervise: true", start_mod._manifest_to_yaml(m_true))
|
|
||||||
self.assertIn("supervise: false", start_mod._manifest_to_yaml(m_false))
|
|
||||||
|
|
||||||
def test_non_claude_provider_shown(self):
|
|
||||||
m = self._make_manifest_obj(agent_provider_template="codex")
|
|
||||||
yaml = start_mod._manifest_to_yaml(m)
|
|
||||||
self.assertIn("agent_provider:", yaml)
|
|
||||||
self.assertIn("template: codex", yaml)
|
|
||||||
|
|
||||||
def test_default_claude_provider_omitted(self):
|
|
||||||
m = self._make_manifest_obj(agent_provider_template="claude")
|
|
||||||
yaml = start_mod._manifest_to_yaml(m)
|
|
||||||
self.assertNotIn("agent_provider:", yaml)
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
|
|||||||
@@ -29,8 +29,8 @@ class _FakeHomeMixin:
|
|||||||
|
|
||||||
|
|
||||||
class TestCaptureSessionState(_FakeHomeMixin, unittest.TestCase):
|
class TestCaptureSessionState(_FakeHomeMixin, unittest.TestCase):
|
||||||
# capture_claude_session_state handles the preserve marker for
|
# snapshot_transcript is commented out (capability_apply is disabled);
|
||||||
# non-zero agent exits.
|
# capture_claude_session_state now only handles the preserve marker.
|
||||||
def setUp(self):
|
def setUp(self):
|
||||||
self._setup_fake_home()
|
self._setup_fake_home()
|
||||||
|
|
||||||
@@ -102,27 +102,6 @@ class TestAttachAgent(unittest.TestCase):
|
|||||||
bottle.argv,
|
bottle.argv,
|
||||||
)
|
)
|
||||||
|
|
||||||
def test_remote_control_is_provider_startup_arg(self):
|
|
||||||
class Bottle:
|
|
||||||
argv: list[str] = []
|
|
||||||
|
|
||||||
def exec_agent(self, argv: list[str], *, tty: bool = True) -> int:
|
|
||||||
self.argv = list(argv)
|
|
||||||
return 0
|
|
||||||
|
|
||||||
bottle = Bottle()
|
|
||||||
exit_code = start_mod.attach_agent(
|
|
||||||
bottle, # type: ignore[arg-type]
|
|
||||||
agent_provider_template="codex",
|
|
||||||
startup_args=("remote-control",),
|
|
||||||
)
|
|
||||||
|
|
||||||
self.assertEqual(0, exit_code)
|
|
||||||
self.assertEqual(
|
|
||||||
["--dangerously-bypass-approvals-and-sandbox", "remote-control"],
|
|
||||||
bottle.argv,
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
|
|||||||
@@ -12,9 +12,6 @@ from typing import Any, Optional
|
|||||||
|
|
||||||
from bot_bottle.cli.tui import _filter_items, _multiselect_loop, filter_multiselect, filter_select
|
from bot_bottle.cli.tui import _filter_items, _multiselect_loop, filter_multiselect, filter_select
|
||||||
|
|
||||||
_KEY_SPACE = 32
|
|
||||||
_KEY_ENTER = 10
|
|
||||||
|
|
||||||
_KEY_ESC = 27
|
_KEY_ESC = 27
|
||||||
_KEY_CTRL_D = 4
|
_KEY_CTRL_D = 4
|
||||||
|
|
||||||
@@ -147,29 +144,7 @@ class TestMultiselectLoopReordering(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
self.assertEqual(["a", "b"], result)
|
self.assertEqual(["a", "b"], result)
|
||||||
|
|
||||||
def test_space_toggles_item_on(self):
|
|
||||||
# Space on an unselected item selects it; Ctrl-D confirms.
|
|
||||||
result = self._run([_KEY_SPACE, _KEY_CTRL_D], ["a", "b"], [])
|
|
||||||
self.assertEqual(["a"], result)
|
|
||||||
|
|
||||||
def test_space_toggles_item_off(self):
|
|
||||||
# Space on a selected item deselects it; Ctrl-D confirms empty.
|
|
||||||
result = self._run([_KEY_SPACE, _KEY_CTRL_D], ["a", "b"], ["a"])
|
|
||||||
self.assertEqual([], result)
|
|
||||||
|
|
||||||
def test_enter_confirms_without_toggle(self):
|
|
||||||
# Enter immediately confirms the current selection without toggling.
|
|
||||||
result = self._run([_KEY_ENTER], ["a", "b"], ["a"])
|
|
||||||
self.assertEqual(["a"], result)
|
|
||||||
|
|
||||||
def test_enter_confirms_empty_selection(self):
|
|
||||||
result = self._run([_KEY_ENTER], ["a", "b"], [])
|
|
||||||
self.assertEqual([], result)
|
|
||||||
|
|
||||||
def test_space_then_enter_confirms(self):
|
|
||||||
# Space selects "a", Enter confirms.
|
|
||||||
result = self._run([_KEY_SPACE, _KEY_ENTER], ["a", "b"], [])
|
|
||||||
self.assertEqual(["a"], result)
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
|
|||||||
@@ -108,6 +108,7 @@ def _supervise_plan() -> SupervisePlan:
|
|||||||
return SupervisePlan(
|
return SupervisePlan(
|
||||||
slug=SLUG,
|
slug=SLUG,
|
||||||
queue_dir=STATE / "supervise" / "queue",
|
queue_dir=STATE / "supervise" / "queue",
|
||||||
|
current_config_dir=STATE / "supervise" / "current-config",
|
||||||
internal_network=f"bot-bottle-net-{SLUG}",
|
internal_network=f"bot-bottle-net-{SLUG}",
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -270,11 +271,18 @@ class TestAgentAlwaysPresent(unittest.TestCase):
|
|||||||
s = bottle_plan_to_compose(_plan(**kwargs))["services"]["agent"]
|
s = bottle_plan_to_compose(_plan(**kwargs))["services"]["agent"]
|
||||||
self.assertEqual(["sidecars"], s["depends_on"])
|
self.assertEqual(["sidecars"], s["depends_on"])
|
||||||
|
|
||||||
def test_agent_has_no_current_config_mount_with_supervise(self):
|
def test_agent_current_config_mount_only_with_supervise(self):
|
||||||
with_sv = bottle_plan_to_compose(_plan(supervise=True))["services"]["agent"]
|
with_sv = bottle_plan_to_compose(_plan(supervise=True))["services"]["agent"]
|
||||||
self.assertNotIn("volumes", with_sv)
|
self.assertTrue(any(
|
||||||
|
v["target"] == "/etc/bot-bottle/current-config"
|
||||||
|
for v in with_sv.get("volumes", [])
|
||||||
|
))
|
||||||
without_sv = bottle_plan_to_compose(_plan(supervise=False))["services"]["agent"]
|
without_sv = bottle_plan_to_compose(_plan(supervise=False))["services"]["agent"]
|
||||||
self.assertNotIn("volumes", without_sv)
|
# Either no volumes key at all, or no current-config target.
|
||||||
|
self.assertFalse(any(
|
||||||
|
v["target"] == "/etc/bot-bottle/current-config"
|
||||||
|
for v in without_sv.get("volumes", [])
|
||||||
|
))
|
||||||
|
|
||||||
|
|
||||||
class TestSidecarBundleShape(unittest.TestCase):
|
class TestSidecarBundleShape(unittest.TestCase):
|
||||||
|
|||||||
@@ -75,6 +75,7 @@ def _plan(
|
|||||||
supervise_plan = SupervisePlan(
|
supervise_plan = SupervisePlan(
|
||||||
slug="demo-abc12",
|
slug="demo-abc12",
|
||||||
queue_dir=Path("/tmp/queue"),
|
queue_dir=Path("/tmp/queue"),
|
||||||
|
current_config_dir=Path("/tmp/current-config"),
|
||||||
)
|
)
|
||||||
return DockerBottlePlan(
|
return DockerBottlePlan(
|
||||||
spec=spec,
|
spec=spec,
|
||||||
|
|||||||
@@ -29,9 +29,6 @@ from bot_bottle.supervise import SupervisePlan
|
|||||||
|
|
||||||
|
|
||||||
_URL = "http://supervise:9100/"
|
_URL = "http://supervise:9100/"
|
||||||
_CODEX_DOCKERFILE = (
|
|
||||||
Path(__file__).resolve().parents[2] / "bot_bottle/contrib/codex/Dockerfile"
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def _make_bottle(exec_result: ExecResult | None = None) -> MagicMock:
|
def _make_bottle(exec_result: ExecResult | None = None) -> MagicMock:
|
||||||
@@ -78,6 +75,7 @@ def _plan(
|
|||||||
supervise_plan = SupervisePlan(
|
supervise_plan = SupervisePlan(
|
||||||
slug="demo-abc12",
|
slug="demo-abc12",
|
||||||
queue_dir=Path("/tmp/queue"),
|
queue_dir=Path("/tmp/queue"),
|
||||||
|
current_config_dir=Path("/tmp/current-config"),
|
||||||
)
|
)
|
||||||
return DockerBottlePlan(
|
return DockerBottlePlan(
|
||||||
spec=spec,
|
spec=spec,
|
||||||
@@ -278,12 +276,6 @@ class TestCodexProvision(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
class TestCodexDockerfile(unittest.TestCase):
|
|
||||||
def test_installs_procps_for_remote_control_pid_management(self):
|
|
||||||
dockerfile = _CODEX_DOCKERFILE.read_text()
|
|
||||||
self.assertIn("procps", dockerfile)
|
|
||||||
|
|
||||||
|
|
||||||
class TestCodexSuperviseMcp(unittest.TestCase):
|
class TestCodexSuperviseMcp(unittest.TestCase):
|
||||||
def test_noop_when_supervise_disabled(self):
|
def test_noop_when_supervise_disabled(self):
|
||||||
bottle = _make_bottle()
|
bottle = _make_bottle()
|
||||||
|
|||||||
@@ -10,8 +10,6 @@ from unittest.mock import MagicMock, patch
|
|||||||
|
|
||||||
from bot_bottle.contrib.gitea.deploy_key_provisioner import (
|
from bot_bottle.contrib.gitea.deploy_key_provisioner import (
|
||||||
GiteaDeployKeyProvisioner,
|
GiteaDeployKeyProvisioner,
|
||||||
_API_TIMEOUT_SECS,
|
|
||||||
_KEYGEN_TIMEOUT_SECS,
|
|
||||||
_split_owner_repo,
|
_split_owner_repo,
|
||||||
)
|
)
|
||||||
from bot_bottle.deploy_key_provisioner import DeployKeyCollisionError
|
from bot_bottle.deploy_key_provisioner import DeployKeyCollisionError
|
||||||
@@ -85,25 +83,6 @@ class TestCreate(unittest.TestCase):
|
|||||||
self.assertEqual(str(fake_key_id), key_id)
|
self.assertEqual(str(fake_key_id), key_id)
|
||||||
self.assertEqual(fake_private, private_bytes)
|
self.assertEqual(fake_private, private_bytes)
|
||||||
|
|
||||||
def test_create_passes_timeout_to_ssh_keygen_and_urlopen(self):
|
|
||||||
provisioner = _provisioner()
|
|
||||||
with patch(
|
|
||||||
"bot_bottle.contrib.gitea.deploy_key_provisioner.subprocess.run"
|
|
||||||
) as mock_run, patch(
|
|
||||||
"bot_bottle.contrib.gitea.deploy_key_provisioner.urllib.request.urlopen"
|
|
||||||
) as mock_urlopen, patch(
|
|
||||||
"bot_bottle.contrib.gitea.deploy_key_provisioner.Path.read_bytes",
|
|
||||||
return_value=b"PRIVATE",
|
|
||||||
), patch(
|
|
||||||
"bot_bottle.contrib.gitea.deploy_key_provisioner.Path.read_text",
|
|
||||||
return_value="ssh-ed25519 AAAA\n",
|
|
||||||
):
|
|
||||||
mock_urlopen.return_value = _urlopen_response({"id": 1})
|
|
||||||
provisioner.create("owner/repo", "title")
|
|
||||||
|
|
||||||
self.assertEqual(_KEYGEN_TIMEOUT_SECS, mock_run.call_args.kwargs.get("timeout"))
|
|
||||||
self.assertEqual(_API_TIMEOUT_SECS, mock_urlopen.call_args.kwargs.get("timeout"))
|
|
||||||
|
|
||||||
def test_create_raises_on_http_error(self):
|
def test_create_raises_on_http_error(self):
|
||||||
provisioner = _provisioner()
|
provisioner = _provisioner()
|
||||||
with patch(
|
with patch(
|
||||||
@@ -160,16 +139,6 @@ class TestDelete(unittest.TestCase):
|
|||||||
self.assertIn("/api/v1/repos/didericis/bot-bottle/keys/99", req.full_url)
|
self.assertIn("/api/v1/repos/didericis/bot-bottle/keys/99", req.full_url)
|
||||||
self.assertEqual("DELETE", req.get_method())
|
self.assertEqual("DELETE", req.get_method())
|
||||||
|
|
||||||
def test_delete_passes_timeout_to_urlopen(self):
|
|
||||||
provisioner = _provisioner()
|
|
||||||
with patch(
|
|
||||||
"bot_bottle.contrib.gitea.deploy_key_provisioner.urllib.request.urlopen"
|
|
||||||
) as mock_urlopen:
|
|
||||||
mock_urlopen.return_value = _urlopen_response({})
|
|
||||||
provisioner.delete("owner/repo", "7")
|
|
||||||
|
|
||||||
self.assertEqual(_API_TIMEOUT_SECS, mock_urlopen.call_args.kwargs.get("timeout"))
|
|
||||||
|
|
||||||
def test_delete_tolerates_404(self):
|
def test_delete_tolerates_404(self):
|
||||||
provisioner = _provisioner()
|
provisioner = _provisioner()
|
||||||
with patch(
|
with patch(
|
||||||
|
|||||||
@@ -24,36 +24,61 @@ from bot_bottle.dlp_detectors import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
# (case id, sample body carrying the token, substring expected in the reason).
|
|
||||||
# One row per known token shape; all are block-severity credential matches.
|
|
||||||
# `# gitleaks:allow` marks the synthetic tokens so a source scan won't flag them.
|
|
||||||
_TOKEN_PATTERN_CASES: list[tuple[str, str, str]] = [
|
|
||||||
("aws_access_key", "key=AKIAIOSFODNN7EXAMPLE", "AWS access key"),
|
|
||||||
("github_classic", "token: ghp_" + "A" * 36, "GitHub token"), # gitleaks:allow
|
|
||||||
("github_fine_grained", "pat=github_pat_" + "A" * 82, "fine-grained"), # gitleaks:allow
|
|
||||||
("anthropic", "auth: sk-ant-" + "A" * 93, "Anthropic"), # gitleaks:allow
|
|
||||||
("openai", "key=sk-" + "A" * 48, "OpenAI"), # gitleaks:allow
|
|
||||||
("stripe_live", "stripe: sk_live_" + "A" * 24, "Stripe"), # gitleaks:allow
|
|
||||||
("bearer_jwt", "Authorization: Bearer " + "A" * 60, "Bearer JWT"), # gitleaks:allow
|
|
||||||
("openai_project", "key=sk-proj-" + "A" * 48, "OpenAI project"), # gitleaks:allow
|
|
||||||
("huggingface", "token=hf_" + "A" * 34, "HuggingFace"), # gitleaks:allow
|
|
||||||
("databricks", "dapi" + "a" * 32, "Databricks"), # gitleaks:allow
|
|
||||||
("slack_bot", "xoxb-00000000000-00000000000-" + "A" * 24, "Slack"), # gitleaks:allow
|
|
||||||
("npm", "npm_" + "A" * 36, "npm"), # gitleaks:allow
|
|
||||||
("sendgrid", "SG." + "A" * 22 + "." + "B" * 43, "SendGrid"), # gitleaks:allow
|
|
||||||
("pypi", "pypi-" + "A" * 80, "PyPI"), # gitleaks:allow
|
|
||||||
("vault", "hvs." + "A" * 24, "Vault"), # gitleaks:allow
|
|
||||||
]
|
|
||||||
|
|
||||||
|
|
||||||
class TestScanTokenPatterns(unittest.TestCase):
|
class TestScanTokenPatterns(unittest.TestCase):
|
||||||
def test_detects_each_token_pattern(self):
|
def test_aws_access_key(self):
|
||||||
for case_id, sample, expected in _TOKEN_PATTERN_CASES:
|
result = scan_token_patterns("key=AKIAIOSFODNN7EXAMPLE")
|
||||||
with self.subTest(case_id):
|
assert result is not None
|
||||||
result = scan_token_patterns(sample)
|
self.assertEqual("block", result.severity)
|
||||||
assert result is not None
|
self.assertIn("AWS access key", result.reason)
|
||||||
self.assertEqual("block", result.severity)
|
|
||||||
self.assertIn(expected, result.reason)
|
def test_github_classic_token(self):
|
||||||
|
result = scan_token_patterns(
|
||||||
|
"token: ghp_" + "A" * 36,
|
||||||
|
)
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("GitHub token", result.reason)
|
||||||
|
|
||||||
|
def test_github_fine_grained_token(self):
|
||||||
|
result = scan_token_patterns(
|
||||||
|
"pat=github_pat_" + "A" * 82,
|
||||||
|
)
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("fine-grained", result.reason)
|
||||||
|
|
||||||
|
def test_anthropic_api_key(self):
|
||||||
|
result = scan_token_patterns(
|
||||||
|
"auth: sk-ant-" + "A" * 93,
|
||||||
|
)
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("Anthropic", result.reason)
|
||||||
|
|
||||||
|
def test_openai_api_key(self):
|
||||||
|
result = scan_token_patterns(
|
||||||
|
"key=sk-" + "A" * 48,
|
||||||
|
)
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("OpenAI", result.reason)
|
||||||
|
|
||||||
|
def test_stripe_live_key(self):
|
||||||
|
result = scan_token_patterns(
|
||||||
|
"stripe: sk_live_" + "A" * 24,
|
||||||
|
)
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("Stripe", result.reason)
|
||||||
|
|
||||||
|
def test_bearer_jwt(self):
|
||||||
|
result = scan_token_patterns(
|
||||||
|
"Authorization: Bearer " + "A" * 60,
|
||||||
|
)
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("Bearer JWT", result.reason)
|
||||||
|
|
||||||
|
def test_openai_project_key(self):
|
||||||
|
result = scan_token_patterns(
|
||||||
|
"key=sk-proj-" + "A" * 48,
|
||||||
|
)
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("OpenAI project", result.reason)
|
||||||
|
|
||||||
def test_clean_text_returns_none(self):
|
def test_clean_text_returns_none(self):
|
||||||
self.assertIsNone(scan_token_patterns("hello world"))
|
self.assertIsNone(scan_token_patterns("hello world"))
|
||||||
@@ -282,6 +307,44 @@ class TestEncodedVariants(unittest.TestCase):
|
|||||||
self.assertEqual(len(v), len(set(v)))
|
self.assertEqual(len(v), len(set(v)))
|
||||||
|
|
||||||
|
|
||||||
|
class TestScanTokenPatternsExtended(unittest.TestCase):
|
||||||
|
def test_huggingface_token(self):
|
||||||
|
result = scan_token_patterns("token=hf_" + "A" * 34) # gitleaks:allow
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("HuggingFace", result.reason)
|
||||||
|
|
||||||
|
def test_databricks_token(self):
|
||||||
|
result = scan_token_patterns("dapi" + "a" * 32) # gitleaks:allow
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("Databricks", result.reason)
|
||||||
|
|
||||||
|
def test_slack_bot_token(self):
|
||||||
|
# Use all-zero numeric segments to keep entropy low
|
||||||
|
result = scan_token_patterns("xoxb-00000000000-00000000000-" + "A" * 24) # gitleaks:allow
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("Slack", result.reason)
|
||||||
|
|
||||||
|
def test_npm_token(self):
|
||||||
|
result = scan_token_patterns("npm_" + "A" * 36) # gitleaks:allow
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("npm", result.reason)
|
||||||
|
|
||||||
|
def test_sendgrid_key(self):
|
||||||
|
result = scan_token_patterns("SG." + "A" * 22 + "." + "B" * 43) # gitleaks:allow
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("SendGrid", result.reason)
|
||||||
|
|
||||||
|
def test_pypi_token(self):
|
||||||
|
result = scan_token_patterns("pypi-" + "A" * 80) # gitleaks:allow
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("PyPI", result.reason)
|
||||||
|
|
||||||
|
def test_vault_token(self):
|
||||||
|
result = scan_token_patterns("hvs." + "A" * 24) # gitleaks:allow
|
||||||
|
assert result is not None
|
||||||
|
self.assertIn("Vault", result.reason)
|
||||||
|
|
||||||
|
|
||||||
class TestUnicodeNormalization(unittest.TestCase):
|
class TestUnicodeNormalization(unittest.TestCase):
|
||||||
def test_fullwidth_chars_normalized(self):
|
def test_fullwidth_chars_normalized(self):
|
||||||
# Fullwidth ASCII chars (U+FF21..U+FF3A) should map to ASCII
|
# Fullwidth ASCII chars (U+FF21..U+FF3A) should map to ASCII
|
||||||
|
|||||||
@@ -136,16 +136,6 @@ class TestClaudeArgv(unittest.TestCase):
|
|||||||
argv,
|
argv,
|
||||||
)
|
)
|
||||||
|
|
||||||
def test_codex_remote_control_startup_arg_does_not_receive_initial_prompt(self):
|
|
||||||
argv = _codex_bottle("/home/node/.bot-bottle-prompt.txt").agent_argv(
|
|
||||||
["--dangerously-bypass-approvals-and-sandbox", "remote-control"],
|
|
||||||
)
|
|
||||||
self.assertEqual(
|
|
||||||
["docker", "exec", "-it", "bot-bottle-dev-abc", "codex",
|
|
||||||
"--dangerously-bypass-approvals-and-sandbox", "remote-control"],
|
|
||||||
argv,
|
|
||||||
)
|
|
||||||
|
|
||||||
def test_codex_resume_does_not_append_initial_prompt(self):
|
def test_codex_resume_does_not_append_initial_prompt(self):
|
||||||
argv = _codex_bottle("/home/node/.bot-bottle-prompt.txt").agent_argv(
|
argv = _codex_bottle("/home/node/.bot-bottle-prompt.txt").agent_argv(
|
||||||
["--dangerously-bypass-approvals-and-sandbox", "resume", "--last"],
|
["--dangerously-bypass-approvals-and-sandbox", "resume", "--last"],
|
||||||
|
|||||||
@@ -65,8 +65,8 @@ class TestOrphanStateDirs(_FakeHomeMixin, unittest.TestCase):
|
|||||||
)
|
)
|
||||||
|
|
||||||
def test_preserve_marker_skips_dir(self):
|
def test_preserve_marker_skips_dir(self):
|
||||||
# Preserve marker means the user explicitly wanted this dir
|
# Preserve marker = capability-block or crash auto-preserve;
|
||||||
# kept for `resume`.
|
# the user explicitly wanted this dir kept for `resume`.
|
||||||
bottle_state.write_per_bottle_dockerfile("kept-ccc", "FROM x\n")
|
bottle_state.write_per_bottle_dockerfile("kept-ccc", "FROM x\n")
|
||||||
bottle_state.mark_preserved("kept-ccc")
|
bottle_state.mark_preserved("kept-ccc")
|
||||||
self.assertEqual(
|
self.assertEqual(
|
||||||
|
|||||||
@@ -31,6 +31,7 @@ class _Provider(AgentProvider):
|
|||||||
return AgentProviderRuntime(
|
return AgentProviderRuntime(
|
||||||
template="test", command="test", image="",
|
template="test", command="test", image="",
|
||||||
prompt_mode="append_file", bypass_args=(), resume_args=(),
|
prompt_mode="append_file", bypass_args=(), resume_args=(),
|
||||||
|
remote_control_args=(),
|
||||||
)
|
)
|
||||||
def provision_plan(self, **kwargs): # type: ignore[override]
|
def provision_plan(self, **kwargs): # type: ignore[override]
|
||||||
raise NotImplementedError
|
raise NotImplementedError
|
||||||
|
|||||||
@@ -10,7 +10,6 @@ from bot_bottle.egress import (
|
|||||||
Egress,
|
Egress,
|
||||||
EgressPlan,
|
EgressPlan,
|
||||||
EgressRoute,
|
EgressRoute,
|
||||||
_yaml_str_escape,
|
|
||||||
egress_agent_env_entries,
|
egress_agent_env_entries,
|
||||||
egress_manifest_routes,
|
egress_manifest_routes,
|
||||||
egress_render_routes,
|
egress_render_routes,
|
||||||
@@ -323,7 +322,7 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
self.assertEqual([], parse_yaml_subset(rendered)["routes"])
|
self.assertEqual([], parse_yaml_subset(rendered)["routes"])
|
||||||
|
|
||||||
def test_round_trip_through_addon_core(self):
|
def test_round_trip_through_addon_core(self):
|
||||||
from bot_bottle.egress_addon_core import load_config
|
from bot_bottle.egress_addon_core import load_routes
|
||||||
b = _bottle([
|
b = _bottle([
|
||||||
{"host": "api.github.com",
|
{"host": "api.github.com",
|
||||||
"auth": {"scheme": "Bearer", "token_ref": "GH_PAT"},
|
"auth": {"scheme": "Bearer", "token_ref": "GH_PAT"},
|
||||||
@@ -334,7 +333,7 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
{"host": "api.anthropic.com"},
|
{"host": "api.anthropic.com"},
|
||||||
])
|
])
|
||||||
routes = egress_routes_for_bottle(b)
|
routes = egress_routes_for_bottle(b)
|
||||||
addon_routes = load_config(egress_render_routes(routes)).routes
|
addon_routes = load_routes(egress_render_routes(routes))
|
||||||
self.assertEqual(3, len(addon_routes))
|
self.assertEqual(3, len(addon_routes))
|
||||||
self.assertEqual("Bearer", addon_routes[0].auth_scheme)
|
self.assertEqual("Bearer", addon_routes[0].auth_scheme)
|
||||||
self.assertEqual("EGRESS_TOKEN_0", addon_routes[0].token_env)
|
self.assertEqual("EGRESS_TOKEN_0", addon_routes[0].token_env)
|
||||||
@@ -342,26 +341,26 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
self.assertEqual("", addon_routes[2].auth_scheme)
|
self.assertEqual("", addon_routes[2].auth_scheme)
|
||||||
|
|
||||||
def test_dlp_round_trips(self):
|
def test_dlp_round_trips(self):
|
||||||
from bot_bottle.egress_addon_core import load_config
|
from bot_bottle.egress_addon_core import load_routes
|
||||||
b = _bottle([{"host": "x.example", "dlp": {
|
b = _bottle([{"host": "x.example", "dlp": {
|
||||||
"outbound_detectors": ["token_patterns"],
|
"outbound_detectors": ["token_patterns"],
|
||||||
"inbound_detectors": False,
|
"inbound_detectors": False,
|
||||||
}}])
|
}}])
|
||||||
routes = egress_routes_for_bottle(b)
|
routes = egress_routes_for_bottle(b)
|
||||||
rendered = egress_render_routes(routes)
|
rendered = egress_render_routes(routes)
|
||||||
addon_routes = load_config(rendered).routes
|
addon_routes = load_routes(rendered)
|
||||||
self.assertEqual(("token_patterns",), addon_routes[0].outbound_detectors)
|
self.assertEqual(("token_patterns",), addon_routes[0].outbound_detectors)
|
||||||
self.assertEqual((), addon_routes[0].inbound_detectors)
|
self.assertEqual((), addon_routes[0].inbound_detectors)
|
||||||
|
|
||||||
def test_outbound_on_match_round_trips(self):
|
def test_outbound_on_match_round_trips(self):
|
||||||
from bot_bottle.egress_addon_core import load_config
|
from bot_bottle.egress_addon_core import load_routes
|
||||||
b = _bottle([{"host": "logs.example", "dlp": {
|
b = _bottle([{"host": "logs.example", "dlp": {
|
||||||
"outbound_on_match": "redact",
|
"outbound_on_match": "redact",
|
||||||
}}])
|
}}])
|
||||||
routes = egress_routes_for_bottle(b)
|
routes = egress_routes_for_bottle(b)
|
||||||
rendered = egress_render_routes(routes)
|
rendered = egress_render_routes(routes)
|
||||||
self.assertIn('outbound_on_match: "redact"', rendered)
|
self.assertIn('outbound_on_match: "redact"', rendered)
|
||||||
addon_routes = load_config(rendered).routes
|
addon_routes = load_routes(rendered)
|
||||||
self.assertEqual("redact", addon_routes[0].outbound_on_match)
|
self.assertEqual("redact", addon_routes[0].outbound_on_match)
|
||||||
|
|
||||||
def test_outbound_on_match_default_omitted_from_render(self):
|
def test_outbound_on_match_default_omitted_from_render(self):
|
||||||
@@ -371,12 +370,12 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
self.assertNotIn("outbound_on_match", rendered)
|
self.assertNotIn("outbound_on_match", rendered)
|
||||||
|
|
||||||
def test_git_fetch_policy_round_trips(self):
|
def test_git_fetch_policy_round_trips(self):
|
||||||
from bot_bottle.egress_addon_core import load_config
|
from bot_bottle.egress_addon_core import load_routes
|
||||||
b = _bottle([{"host": "github.com", "git": {"fetch": True}}])
|
b = _bottle([{"host": "github.com", "git": {"fetch": True}}])
|
||||||
routes = egress_routes_for_bottle(b)
|
routes = egress_routes_for_bottle(b)
|
||||||
rendered = egress_render_routes(routes)
|
rendered = egress_render_routes(routes)
|
||||||
self.assertEqual({"fetch": True}, self._parsed(routes)[0]["git"])
|
self.assertEqual({"fetch": True}, self._parsed(routes)[0]["git"])
|
||||||
addon_routes = load_config(rendered).routes
|
addon_routes = load_routes(rendered)
|
||||||
self.assertTrue(addon_routes[0].git_fetch)
|
self.assertTrue(addon_routes[0].git_fetch)
|
||||||
|
|
||||||
def test_log_zero_omitted_from_render(self):
|
def test_log_zero_omitted_from_render(self):
|
||||||
@@ -420,76 +419,6 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
self.assertEqual(LOG_BLOCKS, cfg.log)
|
self.assertEqual(LOG_BLOCKS, cfg.log)
|
||||||
|
|
||||||
|
|
||||||
class TestYamlStrEscape(unittest.TestCase):
|
|
||||||
"""_yaml_str_escape produces safe YAML double-quoted scalar content."""
|
|
||||||
|
|
||||||
def test_plain_string_unchanged(self):
|
|
||||||
self.assertEqual("api.example.com", _yaml_str_escape("api.example.com"))
|
|
||||||
|
|
||||||
def test_double_quote_escaped(self):
|
|
||||||
self.assertEqual('\\"', _yaml_str_escape('"'))
|
|
||||||
|
|
||||||
def test_backslash_escaped(self):
|
|
||||||
self.assertEqual("\\\\", _yaml_str_escape("\\"))
|
|
||||||
|
|
||||||
def test_newline_escaped(self):
|
|
||||||
self.assertEqual("\\n", _yaml_str_escape("\n"))
|
|
||||||
|
|
||||||
def test_carriage_return_escaped(self):
|
|
||||||
self.assertEqual("\\r", _yaml_str_escape("\r"))
|
|
||||||
|
|
||||||
def test_tab_escaped(self):
|
|
||||||
self.assertEqual("\\t", _yaml_str_escape("\t"))
|
|
||||||
|
|
||||||
def test_combined(self):
|
|
||||||
self.assertEqual('\\"\\n\\\\', _yaml_str_escape('"\n\\'))
|
|
||||||
|
|
||||||
|
|
||||||
class TestRenderRoutesEscaping(unittest.TestCase):
|
|
||||||
"""Stray quotes/newlines in manifest strings do not corrupt routes.yaml."""
|
|
||||||
|
|
||||||
@staticmethod
|
|
||||||
def _parsed(routes) -> list[dict]: # type: ignore
|
|
||||||
return parse_yaml_subset(egress_render_routes(routes))["routes"] # type: ignore
|
|
||||||
|
|
||||||
def test_host_with_double_quote_round_trips(self):
|
|
||||||
routes = (EgressRoute(host='bad"host.example'),)
|
|
||||||
parsed = self._parsed(routes)
|
|
||||||
self.assertEqual('bad"host.example', parsed[0]["host"])
|
|
||||||
|
|
||||||
def test_host_with_newline_round_trips(self):
|
|
||||||
routes = (EgressRoute(host="host\nextra.example"),)
|
|
||||||
parsed = self._parsed(routes)
|
|
||||||
self.assertEqual("host\nextra.example", parsed[0]["host"])
|
|
||||||
|
|
||||||
def test_auth_scheme_with_double_quote_round_trips(self):
|
|
||||||
routes = (EgressRoute(
|
|
||||||
host="api.example",
|
|
||||||
auth_scheme='Bear"er',
|
|
||||||
token_env="EGRESS_TOKEN_0",
|
|
||||||
),)
|
|
||||||
parsed = self._parsed(routes)
|
|
||||||
self.assertEqual('Bear"er', parsed[0]["auth_scheme"])
|
|
||||||
|
|
||||||
def test_path_value_with_double_quote_round_trips(self):
|
|
||||||
from bot_bottle.egress_addon_core import PathMatch, MatchEntry
|
|
||||||
routes = (EgressRoute(
|
|
||||||
host="api.example",
|
|
||||||
matches=(MatchEntry(paths=(PathMatch(type="prefix", value='/v1/"quoted"/'),)),),
|
|
||||||
),)
|
|
||||||
parsed = self._parsed(routes)
|
|
||||||
self.assertEqual('/v1/"quoted"/', parsed[0]["matches"][0]["paths"][0]["value"])
|
|
||||||
|
|
||||||
def test_header_value_with_double_quote_round_trips(self):
|
|
||||||
from bot_bottle.egress_addon_core import HeaderMatch, MatchEntry
|
|
||||||
routes = (EgressRoute(
|
|
||||||
host="api.example",
|
|
||||||
matches=(MatchEntry(headers=(HeaderMatch(name="x-h", value='val"ue'),)),),
|
|
||||||
),)
|
|
||||||
parsed = self._parsed(routes)
|
|
||||||
self.assertEqual('val"ue', parsed[0]["matches"][0]["headers"][0]["value"])
|
|
||||||
|
|
||||||
|
|
||||||
class TestResolveTokenValues(unittest.TestCase):
|
class TestResolveTokenValues(unittest.TestCase):
|
||||||
def test_reads_host_env(self):
|
def test_reads_host_env(self):
|
||||||
out = egress_resolve_token_values(
|
out = egress_resolve_token_values(
|
||||||
|
|||||||
@@ -32,6 +32,7 @@ from bot_bottle.egress_addon_core import (
|
|||||||
is_git_fetch_request,
|
is_git_fetch_request,
|
||||||
is_git_push_request,
|
is_git_push_request,
|
||||||
load_config,
|
load_config,
|
||||||
|
load_routes,
|
||||||
match_route,
|
match_route,
|
||||||
outbound_scan_headers,
|
outbound_scan_headers,
|
||||||
parse_config,
|
parse_config,
|
||||||
@@ -288,6 +289,47 @@ class TestParseDlp(unittest.TestCase):
|
|||||||
}]})
|
}]})
|
||||||
|
|
||||||
|
|
||||||
|
# --- load_routes ---------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestLoadRoutes(unittest.TestCase):
|
||||||
|
def test_yaml_text_round_trip(self):
|
||||||
|
routes = load_routes(
|
||||||
|
'routes:\n'
|
||||||
|
' - host: "api.example"\n'
|
||||||
|
)
|
||||||
|
self.assertEqual(1, len(routes))
|
||||||
|
self.assertEqual("api.example", routes[0].host)
|
||||||
|
|
||||||
|
def test_full_route_shape_parses(self):
|
||||||
|
routes = load_routes(
|
||||||
|
'routes:\n'
|
||||||
|
' - host: "api.example"\n'
|
||||||
|
' auth_scheme: "Bearer"\n'
|
||||||
|
' token_env: "EGRESS_TOKEN_0"\n'
|
||||||
|
' matches:\n'
|
||||||
|
' - paths:\n'
|
||||||
|
' - value: "/v1/"\n'
|
||||||
|
' - type: "exact"\n'
|
||||||
|
' value: "/messages"\n'
|
||||||
|
)
|
||||||
|
self.assertEqual(1, len(routes))
|
||||||
|
r = routes[0]
|
||||||
|
self.assertEqual("api.example", r.host)
|
||||||
|
self.assertEqual("Bearer", r.auth_scheme)
|
||||||
|
self.assertEqual("EGRESS_TOKEN_0", r.token_env)
|
||||||
|
self.assertEqual(1, len(r.matches))
|
||||||
|
self.assertEqual(2, len(r.matches[0].paths))
|
||||||
|
|
||||||
|
def test_empty_routes_list(self):
|
||||||
|
routes = load_routes("routes: []\n")
|
||||||
|
self.assertEqual((), routes)
|
||||||
|
|
||||||
|
def test_invalid_yaml_raises_value_error(self):
|
||||||
|
with self.assertRaises(ValueError):
|
||||||
|
load_routes("routes:\n\t- host: x\n")
|
||||||
|
|
||||||
|
|
||||||
# --- load_config / parse_config ------------------------------------------
|
# --- load_config / parse_config ------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
@@ -336,33 +378,6 @@ class TestLoadConfig(unittest.TestCase):
|
|||||||
with self.assertRaises(ValueError):
|
with self.assertRaises(ValueError):
|
||||||
parse_config("not a dict")
|
parse_config("not a dict")
|
||||||
|
|
||||||
def test_empty_routes_list(self):
|
|
||||||
cfg = load_config("routes: []\n")
|
|
||||||
self.assertEqual((), cfg.routes)
|
|
||||||
|
|
||||||
def test_full_route_shape_parses(self):
|
|
||||||
cfg = load_config(
|
|
||||||
'routes:\n'
|
|
||||||
' - host: "api.example"\n'
|
|
||||||
' auth_scheme: "Bearer"\n'
|
|
||||||
' token_env: "EGRESS_TOKEN_0"\n'
|
|
||||||
' matches:\n'
|
|
||||||
' - paths:\n'
|
|
||||||
' - value: "/v1/"\n'
|
|
||||||
' - type: "exact"\n'
|
|
||||||
' value: "/messages"\n'
|
|
||||||
)
|
|
||||||
r = cfg.routes[0]
|
|
||||||
self.assertEqual("api.example", r.host)
|
|
||||||
self.assertEqual("Bearer", r.auth_scheme)
|
|
||||||
self.assertEqual("EGRESS_TOKEN_0", r.token_env)
|
|
||||||
self.assertEqual(1, len(r.matches))
|
|
||||||
self.assertEqual(2, len(r.matches[0].paths))
|
|
||||||
|
|
||||||
def test_invalid_yaml_raises_value_error(self):
|
|
||||||
with self.assertRaises(ValueError):
|
|
||||||
load_config("routes:\n\t- host: x\n")
|
|
||||||
|
|
||||||
|
|
||||||
# --- evaluate_matches ---------------------------------------------------
|
# --- evaluate_matches ---------------------------------------------------
|
||||||
|
|
||||||
|
|||||||
@@ -54,15 +54,6 @@ class TestValidateRoutesContent(unittest.TestCase):
|
|||||||
' auth_scheme: "Bearer"\n'
|
' auth_scheme: "Bearer"\n'
|
||||||
)
|
)
|
||||||
|
|
||||||
def test_rejects_log_full(self):
|
|
||||||
with self.assertRaises(EgressApplyError) as cm:
|
|
||||||
applicator.validate_routes_content(
|
|
||||||
'log: 2\n'
|
|
||||||
'routes:\n'
|
|
||||||
' - host: "x.example"\n'
|
|
||||||
)
|
|
||||||
self.assertIn("must not change egress logging", str(cm.exception))
|
|
||||||
|
|
||||||
|
|
||||||
class TestApplyRoutesChange(unittest.TestCase):
|
class TestApplyRoutesChange(unittest.TestCase):
|
||||||
def setUp(self):
|
def setUp(self):
|
||||||
|
|||||||
@@ -4,7 +4,6 @@ import os
|
|||||||
import tempfile
|
import tempfile
|
||||||
import unittest
|
import unittest
|
||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
from unittest.mock import patch
|
|
||||||
|
|
||||||
from bot_bottle.git_gate import (
|
from bot_bottle.git_gate import (
|
||||||
GitGate,
|
GitGate,
|
||||||
@@ -14,8 +13,6 @@ from bot_bottle.git_gate import (
|
|||||||
git_gate_render_access_hook,
|
git_gate_render_access_hook,
|
||||||
git_gate_render_entrypoint,
|
git_gate_render_entrypoint,
|
||||||
git_gate_render_hook,
|
git_gate_render_hook,
|
||||||
revoke_git_gate_provisioned_keys,
|
|
||||||
_resolve_identity_file,
|
|
||||||
git_gate_upstreams_for_bottle,
|
git_gate_upstreams_for_bottle,
|
||||||
)
|
)
|
||||||
from bot_bottle.manifest import ManifestIndex
|
from bot_bottle.manifest import ManifestIndex
|
||||||
@@ -331,68 +328,6 @@ class TestPrepare(unittest.TestCase):
|
|||||||
self.assertIn("exec git daemon", content)
|
self.assertIn("exec git daemon", content)
|
||||||
|
|
||||||
|
|
||||||
class TestDynamicKeyProvisioning(unittest.TestCase):
|
|
||||||
def setUp(self):
|
|
||||||
self.stage = Path(tempfile.mkdtemp())
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
import shutil
|
|
||||||
|
|
||||||
shutil.rmtree(self.stage, ignore_errors=True)
|
|
||||||
|
|
||||||
def _gitea_manifest(self):
|
|
||||||
return ManifestIndex.from_json_obj({
|
|
||||||
"bottles": {
|
|
||||||
"dev": {
|
|
||||||
"git-gate": {
|
|
||||||
"repos": {
|
|
||||||
"repo": {
|
|
||||||
"url": "ssh://git@gitea.example.com/org/repo.git",
|
|
||||||
"key": {
|
|
||||||
"provider": "gitea",
|
|
||||||
"forge_token_env": "GITEA_TOKEN",
|
|
||||||
},
|
|
||||||
"host_key": "ssh-ed25519 AAAA...",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
}
|
|
||||||
}
|
|
||||||
},
|
|
||||||
"agents": {"demo": {"skills": [], "prompt": "", "bottle": "dev"}},
|
|
||||||
})
|
|
||||||
|
|
||||||
def test_resolve_identity_file_static_uses_entry_path(self):
|
|
||||||
entry = fixture_with_git().bottles["dev"].git[0]
|
|
||||||
self.assertEqual(entry.IdentityFile, _resolve_identity_file(entry, "demo", self.stage))
|
|
||||||
|
|
||||||
def test_resolve_identity_file_gitea_provisions_key(self):
|
|
||||||
entry = self._gitea_manifest().bottles["dev"].git[0]
|
|
||||||
with patch("bot_bottle.git_gate._provision_dynamic_key", return_value="/tmp/provisioned-key") as mock_provision:
|
|
||||||
self.assertEqual("/tmp/provisioned-key", _resolve_identity_file(entry, "demo", self.stage))
|
|
||||||
mock_provision.assert_called_once()
|
|
||||||
|
|
||||||
def test_revoke_skips_non_gitea_and_missing_id_file(self):
|
|
||||||
revoke_git_gate_provisioned_keys(fixture_with_git().bottles["dev"], self.stage)
|
|
||||||
|
|
||||||
def test_revoke_calls_delete_for_gitea_entry(self):
|
|
||||||
bottle = self._gitea_manifest().bottles["dev"]
|
|
||||||
(self.stage / "repo-deploy-key-id").write_text("123\n")
|
|
||||||
with patch.dict("os.environ", {"GITEA_TOKEN": "token"}), patch(
|
|
||||||
"bot_bottle.deploy_key_provisioner.get_provisioner"
|
|
||||||
) as mock_get_provisioner:
|
|
||||||
provisioner = mock_get_provisioner.return_value
|
|
||||||
revoke_git_gate_provisioned_keys(bottle, self.stage)
|
|
||||||
mock_get_provisioner.assert_called_once()
|
|
||||||
provisioner.delete.assert_called_once_with("org/repo", "123")
|
|
||||||
|
|
||||||
def test_revoke_missing_token_raises(self):
|
|
||||||
bottle = self._gitea_manifest().bottles["dev"]
|
|
||||||
(self.stage / "repo-deploy-key-id").write_text("123\n")
|
|
||||||
with patch.dict("os.environ", {}, clear=True), self.assertRaises(RuntimeError) as cm:
|
|
||||||
revoke_git_gate_provisioned_keys(bottle, self.stage)
|
|
||||||
self.assertIn("env var is not set", str(cm.exception))
|
|
||||||
|
|
||||||
|
|
||||||
class TestShellEscaping(unittest.TestCase):
|
class TestShellEscaping(unittest.TestCase):
|
||||||
"""Regression tests: all three render functions must produce syntactically
|
"""Regression tests: all three render functions must produce syntactically
|
||||||
valid sh code even when names and upstream URLs contain shell-special
|
valid sh code even when names and upstream URLs contain shell-special
|
||||||
|
|||||||
@@ -9,7 +9,6 @@ import urllib.request
|
|||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
from unittest import mock
|
from unittest import mock
|
||||||
|
|
||||||
from bot_bottle.git_gate import GIT_GATE_TIMEOUT_SECS
|
|
||||||
from bot_bottle.git_http_backend import GitHttpHandler, MAX_BODY_BYTES
|
from bot_bottle.git_http_backend import GitHttpHandler, MAX_BODY_BYTES
|
||||||
|
|
||||||
|
|
||||||
@@ -151,61 +150,6 @@ class TestGitHttpBackend(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
self.assertEqual("git/test", env["HTTP_USER_AGENT"])
|
self.assertEqual("git/test", env["HTTP_USER_AGENT"])
|
||||||
|
|
||||||
def test_subprocess_calls_include_timeout(self):
|
|
||||||
"""Both subprocess.run calls (access-hook and git http-backend) must
|
|
||||||
pass timeout= so a hung upstream cannot wedge the sidecar."""
|
|
||||||
from http.server import ThreadingHTTPServer
|
|
||||||
|
|
||||||
with tempfile.TemporaryDirectory() as tmp:
|
|
||||||
root = Path(tmp)
|
|
||||||
(root / "repo.git").mkdir()
|
|
||||||
|
|
||||||
old_root = os.environ.get("GIT_PROJECT_ROOT")
|
|
||||||
os.environ["GIT_PROJECT_ROOT"] = str(root)
|
|
||||||
self.addCleanup(self._restore_env, old_root)
|
|
||||||
old_hook = os.environ.get("GIT_GATE_ACCESS_HOOK")
|
|
||||||
hook = root / "access-hook"
|
|
||||||
hook.write_text("#!/bin/sh\nexit 0\n")
|
|
||||||
hook.chmod(0o700)
|
|
||||||
os.environ["GIT_GATE_ACCESS_HOOK"] = str(hook)
|
|
||||||
self.addCleanup(self._restore_hook, old_hook)
|
|
||||||
|
|
||||||
server = ThreadingHTTPServer(("127.0.0.1", 0), GitHttpHandler)
|
|
||||||
thread = threading.Thread(target=server.serve_forever, daemon=True)
|
|
||||||
thread.start()
|
|
||||||
self.addCleanup(server.shutdown)
|
|
||||||
self.addCleanup(server.server_close)
|
|
||||||
|
|
||||||
backend_response = (
|
|
||||||
b"Status: 200 OK\r\n"
|
|
||||||
b"Content-Type: application/x-git-upload-pack-result\r\n"
|
|
||||||
b"\r\n"
|
|
||||||
b"0000"
|
|
||||||
)
|
|
||||||
calls = [
|
|
||||||
subprocess.CompletedProcess(["hook"], 0, b"", b""),
|
|
||||||
subprocess.CompletedProcess(["git"], 0, backend_response, b""),
|
|
||||||
]
|
|
||||||
with mock.patch(
|
|
||||||
"bot_bottle.git_http_backend.subprocess.run",
|
|
||||||
side_effect=calls,
|
|
||||||
) as run:
|
|
||||||
req = urllib.request.Request(
|
|
||||||
f"http://127.0.0.1:{server.server_port}"
|
|
||||||
"/repo.git/git-upload-pack",
|
|
||||||
data=b"",
|
|
||||||
method="POST",
|
|
||||||
)
|
|
||||||
with urllib.request.urlopen(req, timeout=5):
|
|
||||||
pass
|
|
||||||
|
|
||||||
for call in run.call_args_list:
|
|
||||||
self.assertEqual(
|
|
||||||
GIT_GATE_TIMEOUT_SECS,
|
|
||||||
call.kwargs.get("timeout"),
|
|
||||||
f"subprocess.run call missing timeout: {call}",
|
|
||||||
)
|
|
||||||
|
|
||||||
def test_access_hook_denial_is_logged_to_stdout(self):
|
def test_access_hook_denial_is_logged_to_stdout(self):
|
||||||
"""When the access-hook exits non-zero we still return 403 to the
|
"""When the access-hook exits non-zero we still return 403 to the
|
||||||
client, but the hook's stderr must also appear on the handler's
|
client, but the hook's stderr must also appear on the handler's
|
||||||
@@ -312,57 +256,6 @@ class TestGitHttpBackend(unittest.TestCase):
|
|||||||
os.environ["GIT_GATE_ACCESS_HOOK"] = value
|
os.environ["GIT_GATE_ACCESS_HOOK"] = value
|
||||||
|
|
||||||
|
|
||||||
class TestMalformedStatusHeader(unittest.TestCase):
|
|
||||||
"""Malformed CGI Status: headers must not propagate as unhandled exceptions;
|
|
||||||
the handler should fall back to HTTP 500."""
|
|
||||||
|
|
||||||
def setUp(self):
|
|
||||||
from http.server import ThreadingHTTPServer
|
|
||||||
import tempfile
|
|
||||||
self._tmp = tempfile.mkdtemp()
|
|
||||||
os.environ["GIT_PROJECT_ROOT"] = self._tmp
|
|
||||||
self._server = ThreadingHTTPServer(("127.0.0.1", 0), GitHttpHandler)
|
|
||||||
self._thread = threading.Thread(
|
|
||||||
target=self._server.serve_forever, daemon=True,
|
|
||||||
)
|
|
||||||
self._thread.start()
|
|
||||||
self._port = self._server.server_port
|
|
||||||
|
|
||||||
def tearDown(self):
|
|
||||||
self._server.shutdown()
|
|
||||||
self._server.server_close()
|
|
||||||
os.environ.pop("GIT_PROJECT_ROOT", None)
|
|
||||||
import shutil
|
|
||||||
shutil.rmtree(self._tmp, ignore_errors=True)
|
|
||||||
|
|
||||||
def _get_with_backend_response(self, cgi_response: bytes) -> int:
|
|
||||||
with mock.patch(
|
|
||||||
"bot_bottle.git_http_backend.subprocess.run",
|
|
||||||
return_value=mock.Mock(returncode=0, stdout=cgi_response),
|
|
||||||
):
|
|
||||||
req = urllib.request.Request(
|
|
||||||
f"http://127.0.0.1:{self._port}/repo.git/info/refs",
|
|
||||||
method="GET",
|
|
||||||
)
|
|
||||||
try:
|
|
||||||
with urllib.request.urlopen(req, timeout=3) as resp:
|
|
||||||
return resp.status
|
|
||||||
except urllib.error.HTTPError as e: # type: ignore
|
|
||||||
return e.code
|
|
||||||
|
|
||||||
def test_empty_status_value_returns_500(self):
|
|
||||||
status = self._get_with_backend_response(
|
|
||||||
b"Status: \r\nContent-Type: text/plain\r\n\r\n"
|
|
||||||
)
|
|
||||||
self.assertEqual(500, status)
|
|
||||||
|
|
||||||
def test_non_numeric_status_returns_500(self):
|
|
||||||
status = self._get_with_backend_response(
|
|
||||||
b"Status: bad\r\nContent-Type: text/plain\r\n\r\n"
|
|
||||||
)
|
|
||||||
self.assertEqual(500, status)
|
|
||||||
|
|
||||||
|
|
||||||
class TestContentLengthBounds(unittest.TestCase):
|
class TestContentLengthBounds(unittest.TestCase):
|
||||||
"""PRD 0041: malformed or oversized Content-Length is rejected before
|
"""PRD 0041: malformed or oversized Content-Length is rejected before
|
||||||
git http-backend is invoked."""
|
git http-backend is invoked."""
|
||||||
|
|||||||
@@ -73,33 +73,6 @@ resolver #2
|
|||||||
)
|
)
|
||||||
self.assertTrue(run.call_args_list[-1].kwargs["check"])
|
self.assertTrue(run.call_args_list[-1].kwargs["check"])
|
||||||
|
|
||||||
def test_build_image_anchors_relative_dockerfile_to_context(self):
|
|
||||||
status = util.subprocess.CompletedProcess(
|
|
||||||
args=[],
|
|
||||||
returncode=0,
|
|
||||||
stdout=(
|
|
||||||
'[{"status":{"state":"running"},'
|
|
||||||
'"configuration":{"dns":{"nameservers":["9.9.9.9"]}}}]'
|
|
||||||
),
|
|
||||||
stderr="",
|
|
||||||
)
|
|
||||||
with patch.object(util.subprocess, "run", return_value=status) as run, \
|
|
||||||
patch.object(util.os, "environ", {
|
|
||||||
"BOT_BOTTLE_MACOS_CONTAINER_DNS": "9.9.9.9",
|
|
||||||
}):
|
|
||||||
util.build_image(
|
|
||||||
"bot-bottle-sidecars:latest",
|
|
||||||
"/repo",
|
|
||||||
dockerfile="Dockerfile.sidecars",
|
|
||||||
)
|
|
||||||
self.assertEqual(
|
|
||||||
[
|
|
||||||
"container", "build", "-t", "bot-bottle-sidecars:latest",
|
|
||||||
"--dns", "9.9.9.9", "-f", "/repo/Dockerfile.sidecars", "/repo",
|
|
||||||
],
|
|
||||||
run.call_args_list[-1].args[0],
|
|
||||||
)
|
|
||||||
|
|
||||||
def test_commit_container_execs_tar_and_builds_image(self):
|
def test_commit_container_execs_tar_and_builds_image(self):
|
||||||
# stderr is bytes because subprocess.run uses stderr=PIPE without text=True
|
# stderr is bytes because subprocess.run uses stderr=PIPE without text=True
|
||||||
completed = util.subprocess.CompletedProcess(
|
completed = util.subprocess.CompletedProcess(
|
||||||
|
|||||||
@@ -423,182 +423,9 @@ class TestExtendsErrors(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
self.assertIn("extends cycle", msg)
|
self.assertIn("extends cycle", msg)
|
||||||
|
|
||||||
def test_non_string_non_list_extends_dies(self):
|
def test_non_string_extends_dies(self):
|
||||||
msg = _error_message(_build, child={"extends": 123})
|
msg = _error_message(_build, child={"extends": ["base"]})
|
||||||
self.assertIn("extends must be a string or list of strings", msg)
|
self.assertIn("extends must be a string", msg)
|
||||||
|
|
||||||
def test_list_entry_non_string_dies(self):
|
|
||||||
msg = _error_message(_build, child={"extends": [123]})
|
|
||||||
self.assertIn("extends[0] must be a string", msg)
|
|
||||||
|
|
||||||
|
|
||||||
class TestExtendsMultiParent(unittest.TestCase):
|
|
||||||
"""extends: [p1, p2, ...] — multi-parent composition (issue #268)."""
|
|
||||||
|
|
||||||
_GIT_A = {"url": "ssh://git@host-a/a.git", "key": {"provider": "static", "path": "/k"}}
|
|
||||||
_GIT_B = {"url": "ssh://git@host-b/b.git", "key": {"provider": "static", "path": "/k"}}
|
|
||||||
|
|
||||||
def test_single_element_list_same_as_string(self):
|
|
||||||
m = _build(
|
|
||||||
base={"env": {"X": "1"}},
|
|
||||||
child={"extends": ["base"]},
|
|
||||||
)
|
|
||||||
self.assertEqual({"X": "1"}, dict(m.bottles["child"].env))
|
|
||||||
|
|
||||||
def test_two_parents_env_union(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"env": {"A": "1"}},
|
|
||||||
p2={"env": {"B": "2"}},
|
|
||||||
child={"extends": ["p1", "p2"]},
|
|
||||||
)
|
|
||||||
self.assertEqual({"A": "1", "B": "2"}, dict(m.bottles["child"].env))
|
|
||||||
|
|
||||||
def test_two_parents_env_last_wins_on_collision(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"env": {"X": "from-p1"}},
|
|
||||||
p2={"env": {"X": "from-p2"}},
|
|
||||||
child={"extends": ["p1", "p2"]},
|
|
||||||
)
|
|
||||||
self.assertEqual("from-p2", m.bottles["child"].env["X"])
|
|
||||||
|
|
||||||
def test_child_wins_over_all_parents(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"env": {"X": "from-p1"}},
|
|
||||||
p2={"env": {"X": "from-p2"}},
|
|
||||||
child={"extends": ["p1", "p2"], "env": {"X": "from-child"}},
|
|
||||||
)
|
|
||||||
self.assertEqual("from-child", m.bottles["child"].env["X"])
|
|
||||||
|
|
||||||
def test_two_parents_supervise_last_wins(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"supervise": False},
|
|
||||||
p2={"supervise": True},
|
|
||||||
child={"extends": ["p1", "p2"]},
|
|
||||||
)
|
|
||||||
self.assertTrue(m.bottles["child"].supervise)
|
|
||||||
|
|
||||||
def test_child_supervise_overrides_all_parents(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"supervise": True},
|
|
||||||
p2={"supervise": True},
|
|
||||||
child={"extends": ["p1", "p2"], "supervise": False},
|
|
||||||
)
|
|
||||||
self.assertFalse(m.bottles["child"].supervise)
|
|
||||||
|
|
||||||
def test_two_parents_egress_routes_concatenated(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"egress": {"routes": [{"host": "a.example.com"}]}},
|
|
||||||
p2={"egress": {"routes": [{"host": "b.example.com"}]}},
|
|
||||||
child={"extends": ["p1", "p2"]},
|
|
||||||
)
|
|
||||||
hosts = [r.Host for r in m.bottles["child"].egress.routes]
|
|
||||||
self.assertEqual(["a.example.com", "b.example.com"], hosts)
|
|
||||||
|
|
||||||
def test_child_egress_appends_after_combined_parents(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"egress": {"routes": [{"host": "a.example.com"}]}},
|
|
||||||
p2={"egress": {"routes": [{"host": "b.example.com"}]}},
|
|
||||||
child={
|
|
||||||
"extends": ["p1", "p2"],
|
|
||||||
"egress": {"routes": [{"host": "c.example.com"}]},
|
|
||||||
},
|
|
||||||
)
|
|
||||||
hosts = [r.Host for r in m.bottles["child"].egress.routes]
|
|
||||||
self.assertEqual(["a.example.com", "b.example.com", "c.example.com"], hosts)
|
|
||||||
|
|
||||||
def test_two_parents_git_repos_union(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"git-gate": {"repos": {"a": self._GIT_A}}},
|
|
||||||
p2={"git-gate": {"repos": {"b": self._GIT_B}}},
|
|
||||||
child={"extends": ["p1", "p2"]},
|
|
||||||
)
|
|
||||||
names = {e.Name for e in m.bottles["child"].git}
|
|
||||||
self.assertEqual({"a", "b"}, names)
|
|
||||||
|
|
||||||
def test_two_parents_git_same_name_later_wins_per_field(self):
|
|
||||||
# Both parents declare the same repo name. p2's `key` wins; p1's
|
|
||||||
# `host_key` is preserved because p2 doesn't override it.
|
|
||||||
p1_entry = {
|
|
||||||
"url": "ssh://git@host-a/repo.git",
|
|
||||||
"host_key": "ecdsa AAAA",
|
|
||||||
"key": {"provider": "static", "path": "/k1"},
|
|
||||||
}
|
|
||||||
p2_entry = {
|
|
||||||
"url": "ssh://git@host-a/repo.git", # required, same url
|
|
||||||
"key": {"provider": "gitea", "forge_token_env": "TOK"},
|
|
||||||
}
|
|
||||||
m = _build(
|
|
||||||
p1={"git-gate": {"repos": {"repo": p1_entry}}},
|
|
||||||
p2={"git-gate": {"repos": {"repo": p2_entry}}},
|
|
||||||
child={"extends": ["p1", "p2"]},
|
|
||||||
)
|
|
||||||
entries = m.bottles["child"].git
|
|
||||||
self.assertEqual(1, len(entries))
|
|
||||||
e = entries[0]
|
|
||||||
self.assertEqual("ssh://git@host-a/repo.git", e.Upstream)
|
|
||||||
self.assertEqual("ecdsa AAAA", e.KnownHostKey)
|
|
||||||
self.assertEqual("gitea", e.Key.provider)
|
|
||||||
|
|
||||||
def test_p1_repos_preserved_when_p2_has_none(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"git-gate": {"repos": {"a": self._GIT_A}}},
|
|
||||||
p2={"env": {"X": "1"}},
|
|
||||||
child={"extends": ["p1", "p2"]},
|
|
||||||
)
|
|
||||||
names = [e.Name for e in m.bottles["child"].git]
|
|
||||||
self.assertEqual(["a"], names)
|
|
||||||
|
|
||||||
def test_diamond_shared_ancestor_resolved_once(self):
|
|
||||||
# a <- b, a <- c; child extends [b, c]
|
|
||||||
# `a` must be resolved once and cached.
|
|
||||||
m = _build(
|
|
||||||
a={"env": {"FROM_A": "1"}, "supervise": False},
|
|
||||||
b={"extends": "a", "env": {"FROM_B": "1"}},
|
|
||||||
c={"extends": "a", "env": {"FROM_C": "1"}},
|
|
||||||
child={"extends": ["b", "c"]},
|
|
||||||
)
|
|
||||||
child = m.bottles["child"]
|
|
||||||
self.assertEqual("1", child.env["FROM_A"])
|
|
||||||
self.assertEqual("1", child.env["FROM_B"])
|
|
||||||
self.assertEqual("1", child.env["FROM_C"])
|
|
||||||
# supervise=False from `a` threads through both b and c; c is the
|
|
||||||
# later parent so its effective supervise (False) wins.
|
|
||||||
self.assertFalse(child.supervise)
|
|
||||||
|
|
||||||
def test_three_parents_env_fold_order(self):
|
|
||||||
m = _build(
|
|
||||||
p1={"env": {"X": "1", "A": "a"}},
|
|
||||||
p2={"env": {"X": "2", "B": "b"}},
|
|
||||||
p3={"env": {"X": "3", "C": "c"}},
|
|
||||||
child={"extends": ["p1", "p2", "p3"]},
|
|
||||||
)
|
|
||||||
env = dict(m.bottles["child"].env)
|
|
||||||
self.assertEqual("3", env["X"])
|
|
||||||
self.assertEqual("a", env["A"])
|
|
||||||
self.assertEqual("b", env["B"])
|
|
||||||
self.assertEqual("c", env["C"])
|
|
||||||
|
|
||||||
def test_undefined_bottle_in_list_dies(self):
|
|
||||||
msg = _error_message(
|
|
||||||
_build,
|
|
||||||
base={"env": {}},
|
|
||||||
child={"extends": ["base", "ghost"]},
|
|
||||||
)
|
|
||||||
self.assertIn("extends 'ghost'", msg)
|
|
||||||
self.assertIn("not defined", msg)
|
|
||||||
|
|
||||||
def test_self_reference_in_list_dies(self):
|
|
||||||
msg = _error_message(_build, child={"extends": ["child"]})
|
|
||||||
self.assertIn("extends itself", msg)
|
|
||||||
|
|
||||||
def test_cycle_through_multi_parent_edge_dies(self):
|
|
||||||
msg = _error_message(
|
|
||||||
_build,
|
|
||||||
a={"extends": ["b", "c"]},
|
|
||||||
b={},
|
|
||||||
c={"extends": "a"},
|
|
||||||
)
|
|
||||||
self.assertIn("extends cycle", msg)
|
|
||||||
|
|
||||||
|
|
||||||
class TestExtendsAvailableInBottleKeys(unittest.TestCase):
|
class TestExtendsAvailableInBottleKeys(unittest.TestCase):
|
||||||
|
|||||||
@@ -130,7 +130,7 @@ def _capture_print(plan: DockerBottlePlan | SmolmachinesBottlePlan) -> list[str]
|
|||||||
orig = sys.stderr
|
orig = sys.stderr
|
||||||
sys.stderr = buf
|
sys.stderr = buf
|
||||||
try:
|
try:
|
||||||
plan.print()
|
plan.print(remote_control=False)
|
||||||
finally:
|
finally:
|
||||||
sys.stderr = orig
|
sys.stderr = orig
|
||||||
return buf.getvalue().splitlines()
|
return buf.getvalue().splitlines()
|
||||||
|
|||||||
@@ -8,7 +8,6 @@ import unittest
|
|||||||
|
|
||||||
from bot_bottle.git_gate import (
|
from bot_bottle.git_gate import (
|
||||||
GIT_GATE_HOSTNAME,
|
GIT_GATE_HOSTNAME,
|
||||||
_gitconfig_validate_value,
|
|
||||||
git_gate_render_gitconfig,
|
git_gate_render_gitconfig,
|
||||||
)
|
)
|
||||||
from bot_bottle.manifest import ManifestIndex
|
from bot_bottle.manifest import ManifestIndex
|
||||||
@@ -91,42 +90,5 @@ class TestGitGateGitconfigRender(unittest.TestCase):
|
|||||||
self.assertNotIn("gitea.dideric.is", out)
|
self.assertNotIn("gitea.dideric.is", out)
|
||||||
|
|
||||||
|
|
||||||
class TestGitconfigValidateValue(unittest.TestCase):
|
|
||||||
"""_gitconfig_validate_value rejects values that would inject gitconfig keys."""
|
|
||||||
|
|
||||||
def test_normal_url_passes(self):
|
|
||||||
_gitconfig_validate_value("url", "ssh://git@github.com/owner/repo.git")
|
|
||||||
|
|
||||||
def test_newline_in_url_raises(self):
|
|
||||||
with self.assertRaises(ValueError):
|
|
||||||
_gitconfig_validate_value("url", "ssh://git@github.com/owner/\nrepo.git")
|
|
||||||
|
|
||||||
def test_carriage_return_in_url_raises(self):
|
|
||||||
with self.assertRaises(ValueError):
|
|
||||||
_gitconfig_validate_value("url", "ssh://git@github.com/\rrepo.git")
|
|
||||||
|
|
||||||
def test_error_message_names_field(self):
|
|
||||||
with self.assertRaises(ValueError, msg="error should name the field") as ctx:
|
|
||||||
_gitconfig_validate_value("repos['bad'].url", "ssh://host/\npath")
|
|
||||||
self.assertIn("repos['bad'].url", str(ctx.exception))
|
|
||||||
|
|
||||||
|
|
||||||
class TestGitconfigRenderRejectsNewlineInUpstream(unittest.TestCase):
|
|
||||||
"""git_gate_render_gitconfig raises on Upstream values with newlines."""
|
|
||||||
|
|
||||||
def test_newline_in_upstream_raises(self):
|
|
||||||
m = ManifestIndex.from_json_obj({
|
|
||||||
"bottles": {"dev": {"git-gate": {"repos": {
|
|
||||||
"evil": {
|
|
||||||
"url": "ssh://git@github.com/owner/\nfake-key = injected\nrepo.git",
|
|
||||||
"key": {"provider": "static", "path": "/dev/null"},
|
|
||||||
},
|
|
||||||
}}}},
|
|
||||||
"agents": {"demo": {"skills": [], "prompt": "", "bottle": "dev"}},
|
|
||||||
})
|
|
||||||
with self.assertRaises(ValueError):
|
|
||||||
git_gate_render_gitconfig(m.bottles["dev"].git, GIT_GATE_HOSTNAME)
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
|
|||||||
@@ -42,6 +42,7 @@ class _Provider(AgentProvider):
|
|||||||
return AgentProviderRuntime(
|
return AgentProviderRuntime(
|
||||||
template="test", command="test", image="",
|
template="test", command="test", image="",
|
||||||
prompt_mode="append_file", bypass_args=(), resume_args=(),
|
prompt_mode="append_file", bypass_args=(), resume_args=(),
|
||||||
|
remote_control_args=(),
|
||||||
)
|
)
|
||||||
def provision_plan(self, **kwargs): # type: ignore[override]
|
def provision_plan(self, **kwargs): # type: ignore[override]
|
||||||
raise NotImplementedError
|
raise NotImplementedError
|
||||||
@@ -130,6 +131,7 @@ def _plan(
|
|||||||
supervise_plan = SupervisePlan(
|
supervise_plan = SupervisePlan(
|
||||||
slug="demo-abc12",
|
slug="demo-abc12",
|
||||||
queue_dir=Path("/tmp/queue"),
|
queue_dir=Path("/tmp/queue"),
|
||||||
|
current_config_dir=Path("/tmp/current-config"),
|
||||||
)
|
)
|
||||||
return SmolmachinesBottlePlan(
|
return SmolmachinesBottlePlan(
|
||||||
spec=spec,
|
spec=spec,
|
||||||
|
|||||||
@@ -16,7 +16,7 @@ from bot_bottle.supervise import (
|
|||||||
STATUS_APPROVED,
|
STATUS_APPROVED,
|
||||||
STATUS_MODIFIED,
|
STATUS_MODIFIED,
|
||||||
STATUS_REJECTED,
|
STATUS_REJECTED,
|
||||||
TOOL_EGRESS_ALLOW,
|
TOOL_CAPABILITY_BLOCK,
|
||||||
TOOL_GITLEAKS_ALLOW,
|
TOOL_GITLEAKS_ALLOW,
|
||||||
archive_proposal,
|
archive_proposal,
|
||||||
audit_log_path,
|
audit_log_path,
|
||||||
@@ -37,9 +37,9 @@ FIXED_TS = datetime(2026, 5, 25, 12, 0, 0, tzinfo=timezone.utc)
|
|||||||
|
|
||||||
|
|
||||||
def _proposal(
|
def _proposal(
|
||||||
tool: str = TOOL_EGRESS_ALLOW,
|
tool: str = TOOL_CAPABILITY_BLOCK,
|
||||||
proposed: str = "routes:\n - host: example.com\n",
|
proposed: str = "FROM python:3.13\n",
|
||||||
justification: str = "need egress",
|
justification: str = "need a capability",
|
||||||
) -> Proposal:
|
) -> Proposal:
|
||||||
return Proposal.new(
|
return Proposal.new(
|
||||||
bottle_slug="dev",
|
bottle_slug="dev",
|
||||||
@@ -57,7 +57,7 @@ class TestProposalRoundtrip(unittest.TestCase):
|
|||||||
self.assertTrue(p.id)
|
self.assertTrue(p.id)
|
||||||
self.assertEqual("2026-05-25T12:00:00+00:00", p.arrival_timestamp)
|
self.assertEqual("2026-05-25T12:00:00+00:00", p.arrival_timestamp)
|
||||||
self.assertEqual("dev", p.bottle_slug)
|
self.assertEqual("dev", p.bottle_slug)
|
||||||
self.assertEqual(TOOL_EGRESS_ALLOW, p.tool)
|
self.assertEqual(TOOL_CAPABILITY_BLOCK, p.tool)
|
||||||
|
|
||||||
def test_to_from_dict_roundtrip(self):
|
def test_to_from_dict_roundtrip(self):
|
||||||
p = _proposal()
|
p = _proposal()
|
||||||
@@ -142,14 +142,14 @@ class TestQueueIO(unittest.TestCase):
|
|||||||
def test_list_pending_sorted_by_arrival(self):
|
def test_list_pending_sorted_by_arrival(self):
|
||||||
# Fabricate two with explicit timestamps.
|
# Fabricate two with explicit timestamps.
|
||||||
a = Proposal.new(
|
a = Proposal.new(
|
||||||
bottle_slug="dev", tool=TOOL_EGRESS_ALLOW,
|
bottle_slug="dev", tool=TOOL_CAPABILITY_BLOCK,
|
||||||
proposed_file="routes:\n - host: early.example.com\n", justification="early",
|
proposed_file="FROM python:3.13\n", justification="early",
|
||||||
current_file_hash="x",
|
current_file_hash="x",
|
||||||
now=datetime(2026, 5, 25, 10, 0, 0, tzinfo=timezone.utc),
|
now=datetime(2026, 5, 25, 10, 0, 0, tzinfo=timezone.utc),
|
||||||
)
|
)
|
||||||
b = Proposal.new(
|
b = Proposal.new(
|
||||||
bottle_slug="dev", tool=TOOL_EGRESS_ALLOW,
|
bottle_slug="dev", tool=TOOL_CAPABILITY_BLOCK,
|
||||||
proposed_file="routes:\n - host: late.example.com\n", justification="late",
|
proposed_file="FROM python:3.13\n", justification="late",
|
||||||
current_file_hash="x",
|
current_file_hash="x",
|
||||||
now=datetime(2026, 5, 25, 14, 0, 0, tzinfo=timezone.utc),
|
now=datetime(2026, 5, 25, 14, 0, 0, tzinfo=timezone.utc),
|
||||||
)
|
)
|
||||||
@@ -319,6 +319,7 @@ class TestToolConstants(unittest.TestCase):
|
|||||||
self.assertEqual(
|
self.assertEqual(
|
||||||
(
|
(
|
||||||
supervise.TOOL_EGRESS_ALLOW,
|
supervise.TOOL_EGRESS_ALLOW,
|
||||||
|
TOOL_CAPABILITY_BLOCK,
|
||||||
supervise.TOOL_EGRESS_BLOCK,
|
supervise.TOOL_EGRESS_BLOCK,
|
||||||
TOOL_GITLEAKS_ALLOW,
|
TOOL_GITLEAKS_ALLOW,
|
||||||
supervise.TOOL_EGRESS_TOKEN_ALLOW,
|
supervise.TOOL_EGRESS_TOKEN_ALLOW,
|
||||||
@@ -377,16 +378,20 @@ class TestSupervisePrepare(unittest.TestCase):
|
|||||||
supervise.bot_bottle_root = fake_root # type: ignore[assignment]
|
supervise.bot_bottle_root = fake_root # type: ignore[assignment]
|
||||||
return lambda: setattr(supervise, "bot_bottle_root", original)
|
return lambda: setattr(supervise, "bot_bottle_root", original)
|
||||||
|
|
||||||
def test_prepare_creates_queue(self):
|
def test_prepare_creates_queue_and_current_config(self):
|
||||||
plan = _StubSupervise().prepare("dev", self.stage_dir)
|
plan = _StubSupervise().prepare("dev", self.stage_dir)
|
||||||
self.assertTrue(plan.queue_dir.is_dir())
|
self.assertTrue(plan.queue_dir.is_dir())
|
||||||
|
self.assertTrue(plan.current_config_dir.is_dir())
|
||||||
self.assertEqual("dev", plan.slug)
|
self.assertEqual("dev", plan.slug)
|
||||||
self.assertEqual("", plan.internal_network)
|
self.assertEqual("", plan.internal_network)
|
||||||
|
|
||||||
def test_prepare_does_not_create_current_config_dir(self):
|
def test_prepare_writes_no_files_to_current_config(self):
|
||||||
|
# dockerfile_content is no longer accepted by prepare.
|
||||||
|
# routes.yaml + allowlist live behind the
|
||||||
|
# `list-egress-routes` MCP tool (PRD 0017 chunk 3).
|
||||||
plan = _StubSupervise().prepare("dev", self.stage_dir)
|
plan = _StubSupervise().prepare("dev", self.stage_dir)
|
||||||
self.assertFalse((self.stage_dir / "current-config").exists())
|
files = sorted(p.name for p in plan.current_config_dir.iterdir())
|
||||||
self.assertFalse(hasattr(plan, "current_config_dir"))
|
self.assertEqual([], files)
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
|
|||||||
@@ -18,7 +18,7 @@ from bot_bottle.supervise import (
|
|||||||
STATUS_APPROVED,
|
STATUS_APPROVED,
|
||||||
STATUS_MODIFIED,
|
STATUS_MODIFIED,
|
||||||
STATUS_REJECTED,
|
STATUS_REJECTED,
|
||||||
TOOL_EGRESS_ALLOW,
|
TOOL_CAPABILITY_BLOCK,
|
||||||
TOOL_GITLEAKS_ALLOW,
|
TOOL_GITLEAKS_ALLOW,
|
||||||
TOOL_EGRESS_TOKEN_ALLOW,
|
TOOL_EGRESS_TOKEN_ALLOW,
|
||||||
read_audit_entries,
|
read_audit_entries,
|
||||||
@@ -30,8 +30,9 @@ from bot_bottle.supervise import (
|
|||||||
FIXED = datetime(2026, 5, 25, 12, 0, 0, tzinfo=timezone.utc)
|
FIXED = datetime(2026, 5, 25, 12, 0, 0, tzinfo=timezone.utc)
|
||||||
|
|
||||||
|
|
||||||
def _proposal(slug: str = "dev", tool: str = TOOL_EGRESS_ALLOW) -> Proposal:
|
def _proposal(slug: str = "dev", tool: str = TOOL_CAPABILITY_BLOCK) -> Proposal:
|
||||||
payloads = {
|
payloads = {
|
||||||
|
TOOL_CAPABILITY_BLOCK: "FROM python:3.13\n",
|
||||||
supervise.TOOL_EGRESS_ALLOW: "routes:\n - host: example.com\n",
|
supervise.TOOL_EGRESS_ALLOW: "routes:\n - host: example.com\n",
|
||||||
supervise.TOOL_EGRESS_BLOCK: "routes:\n - host: example.com\n",
|
supervise.TOOL_EGRESS_BLOCK: "routes:\n - host: example.com\n",
|
||||||
TOOL_GITLEAKS_ALLOW: "file: tests/test_fixture.py\nline: 3\n",
|
TOOL_GITLEAKS_ALLOW: "file: tests/test_fixture.py\nline: 3\n",
|
||||||
@@ -85,14 +86,14 @@ class TestDiscoverPending(_FakeHomeMixin, unittest.TestCase):
|
|||||||
|
|
||||||
def test_sorted_by_arrival_across_bottles(self):
|
def test_sorted_by_arrival_across_bottles(self):
|
||||||
early = Proposal.new(
|
early = Proposal.new(
|
||||||
bottle_slug="api", tool=TOOL_EGRESS_ALLOW,
|
bottle_slug="api", tool=TOOL_CAPABILITY_BLOCK,
|
||||||
proposed_file="routes:\n - host: early.example.com\n", justification="early",
|
proposed_file="FROM python:3.13\n", justification="early",
|
||||||
current_file_hash="h",
|
current_file_hash="h",
|
||||||
now=datetime(2026, 5, 25, 10, 0, 0, tzinfo=timezone.utc),
|
now=datetime(2026, 5, 25, 10, 0, 0, tzinfo=timezone.utc),
|
||||||
)
|
)
|
||||||
late = Proposal.new(
|
late = Proposal.new(
|
||||||
bottle_slug="dev", tool=TOOL_EGRESS_ALLOW,
|
bottle_slug="dev", tool=TOOL_CAPABILITY_BLOCK,
|
||||||
proposed_file="routes:\n - host: late.example.com\n", justification="late",
|
proposed_file="FROM python:3.13\n", justification="late",
|
||||||
current_file_hash="h",
|
current_file_hash="h",
|
||||||
now=datetime(2026, 5, 25, 14, 0, 0, tzinfo=timezone.utc),
|
now=datetime(2026, 5, 25, 14, 0, 0, tzinfo=timezone.utc),
|
||||||
)
|
)
|
||||||
@@ -121,7 +122,7 @@ class TestApproveReject(_FakeHomeMixin, unittest.TestCase):
|
|||||||
def tearDown(self):
|
def tearDown(self):
|
||||||
self._teardown_fake_home()
|
self._teardown_fake_home()
|
||||||
|
|
||||||
def _enqueue(self, tool: str = TOOL_EGRESS_ALLOW):
|
def _enqueue(self, tool: str = TOOL_CAPABILITY_BLOCK):
|
||||||
p = _proposal(tool=tool)
|
p = _proposal(tool=tool)
|
||||||
qdir = supervise.queue_dir_for_slug("dev")
|
qdir = supervise.queue_dir_for_slug("dev")
|
||||||
qdir.mkdir(parents=True, exist_ok=True)
|
qdir.mkdir(parents=True, exist_ok=True)
|
||||||
@@ -130,29 +131,19 @@ class TestApproveReject(_FakeHomeMixin, unittest.TestCase):
|
|||||||
|
|
||||||
def test_approve_writes_response(self):
|
def test_approve_writes_response(self):
|
||||||
qp = self._enqueue()
|
qp = self._enqueue()
|
||||||
with patch(
|
supervise_cli.approve(qp)
|
||||||
"bot_bottle.cli.supervise.apply_routes_change",
|
# capability-block is archived on approve, so the response file
|
||||||
return_value=("routes: []\n", "routes:\n - host: example.com\n"),
|
# moves to processed/ before the caller can read it.
|
||||||
):
|
resp = read_response(qp.queue_dir / "processed", qp.proposal.id)
|
||||||
supervise_cli.approve(qp)
|
|
||||||
resp = read_response(qp.queue_dir, qp.proposal.id)
|
|
||||||
self.assertEqual(STATUS_APPROVED, resp.status)
|
self.assertEqual(STATUS_APPROVED, resp.status)
|
||||||
self.assertIsNone(resp.final_file)
|
self.assertIsNone(resp.final_file)
|
||||||
|
|
||||||
def test_approve_with_final_file_marks_modified(self):
|
def test_approve_with_final_file_marks_modified(self):
|
||||||
qp = self._enqueue()
|
qp = self._enqueue()
|
||||||
with patch(
|
supervise_cli.approve(qp, final_file="FROM bookworm\n", notes="tweaked")
|
||||||
"bot_bottle.cli.supervise.apply_routes_change",
|
resp = read_response(qp.queue_dir / "processed", qp.proposal.id)
|
||||||
return_value=("routes: []\n", "routes:\n - host: edited.example.com\n"),
|
|
||||||
):
|
|
||||||
supervise_cli.approve(
|
|
||||||
qp,
|
|
||||||
final_file="routes:\n - host: edited.example.com\n",
|
|
||||||
notes="tweaked",
|
|
||||||
)
|
|
||||||
resp = read_response(qp.queue_dir, qp.proposal.id)
|
|
||||||
self.assertEqual(STATUS_MODIFIED, resp.status)
|
self.assertEqual(STATUS_MODIFIED, resp.status)
|
||||||
self.assertEqual("routes:\n - host: edited.example.com\n", resp.final_file)
|
self.assertEqual("FROM bookworm\n", resp.final_file)
|
||||||
self.assertEqual("tweaked", resp.notes)
|
self.assertEqual("tweaked", resp.notes)
|
||||||
|
|
||||||
def test_reject_writes_rejection(self):
|
def test_reject_writes_rejection(self):
|
||||||
@@ -162,6 +153,11 @@ class TestApproveReject(_FakeHomeMixin, unittest.TestCase):
|
|||||||
self.assertEqual(STATUS_REJECTED, resp.status)
|
self.assertEqual(STATUS_REJECTED, resp.status)
|
||||||
self.assertEqual("nope", resp.notes)
|
self.assertEqual("nope", resp.notes)
|
||||||
|
|
||||||
|
def test_no_audit_log_for_capability_block(self):
|
||||||
|
qp = self._enqueue(tool=TOOL_CAPABILITY_BLOCK)
|
||||||
|
supervise_cli.approve(qp)
|
||||||
|
self.assertEqual([], read_audit_entries("egress", "dev"))
|
||||||
|
|
||||||
def test_approve_egress_block_writes_audit_log(self):
|
def test_approve_egress_block_writes_audit_log(self):
|
||||||
qp = self._enqueue(tool=supervise.TOOL_EGRESS_BLOCK)
|
qp = self._enqueue(tool=supervise.TOOL_EGRESS_BLOCK)
|
||||||
with patch(
|
with patch(
|
||||||
@@ -236,6 +232,11 @@ class TestApproveReject(_FakeHomeMixin, unittest.TestCase):
|
|||||||
self.assertEqual(".txt", supervise_cli._suffix_for_tool(TOOL_EGRESS_TOKEN_ALLOW))
|
self.assertEqual(".txt", supervise_cli._suffix_for_tool(TOOL_EGRESS_TOKEN_ALLOW))
|
||||||
|
|
||||||
|
|
||||||
|
# class TestCapabilityApplyWiring(_FakeHomeMixin, unittest.TestCase):
|
||||||
|
# # DISABLED — capability_apply functionality is currently commented out.
|
||||||
|
# pass
|
||||||
|
|
||||||
|
|
||||||
class TestEditInEditor(unittest.TestCase):
|
class TestEditInEditor(unittest.TestCase):
|
||||||
def test_runs_editor_returns_edited_content(self):
|
def test_runs_editor_returns_edited_content(self):
|
||||||
original_editor = os.environ.get("EDITOR")
|
original_editor = os.environ.get("EDITOR")
|
||||||
@@ -280,5 +281,10 @@ class TestEditInEditor(unittest.TestCase):
|
|||||||
os.environ["EDITOR"] = original_editor
|
os.environ["EDITOR"] = original_editor
|
||||||
|
|
||||||
|
|
||||||
|
# class TestCapabilityBlockSmolmachinesGuard(_FakeHomeMixin, unittest.TestCase):
|
||||||
|
# # DISABLED — capability_apply functionality is currently commented out.
|
||||||
|
# pass
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
|
|||||||
@@ -20,7 +20,6 @@ import supervise as _sv # noqa: E402 # type: ignore
|
|||||||
|
|
||||||
from bot_bottle import supervise_server # noqa: E402
|
from bot_bottle import supervise_server # noqa: E402
|
||||||
from bot_bottle.supervise_server import (
|
from bot_bottle.supervise_server import (
|
||||||
ERR_INTERNAL,
|
|
||||||
ERR_INVALID_PARAMS,
|
ERR_INVALID_PARAMS,
|
||||||
ERR_INVALID_REQUEST,
|
ERR_INVALID_REQUEST,
|
||||||
ERR_METHOD_NOT_FOUND,
|
ERR_METHOD_NOT_FOUND,
|
||||||
@@ -30,9 +29,7 @@ from bot_bottle.supervise_server import (
|
|||||||
PROPOSED_FILE_FIELD,
|
PROPOSED_FILE_FIELD,
|
||||||
ServerConfig,
|
ServerConfig,
|
||||||
TOOL_DEFINITIONS,
|
TOOL_DEFINITIONS,
|
||||||
_RpcClientError,
|
|
||||||
_RpcError,
|
_RpcError,
|
||||||
_RpcInternalError,
|
|
||||||
_response_timeout_from_env,
|
_response_timeout_from_env,
|
||||||
format_response_text,
|
format_response_text,
|
||||||
handle_initialize,
|
handle_initialize,
|
||||||
@@ -50,15 +47,15 @@ from bot_bottle.supervise_server import (
|
|||||||
|
|
||||||
|
|
||||||
class TestValidation(unittest.TestCase):
|
class TestValidation(unittest.TestCase):
|
||||||
|
def test_capability_block_accepts_anything_nonempty(self):
|
||||||
|
validate_proposed_file(
|
||||||
|
_sv.TOOL_CAPABILITY_BLOCK,
|
||||||
|
"FROM python:3.13\nRUN apk add git\n",
|
||||||
|
)
|
||||||
|
|
||||||
def test_empty_proposed_file_rejected_for_tools_with_file_field(self):
|
def test_empty_proposed_file_rejected_for_tools_with_file_field(self):
|
||||||
with self.assertRaises(_RpcError):
|
with self.assertRaises(_RpcError):
|
||||||
validate_proposed_file(_sv.TOOL_EGRESS_ALLOW, " \n\t")
|
validate_proposed_file(_sv.TOOL_CAPABILITY_BLOCK, " \n\t")
|
||||||
|
|
||||||
def test_capability_block_rejected_as_unknown_tool(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
validate_proposed_file("capability-block", "FROM python:3.13\n")
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
self.assertIn("unknown tool", cm.exception.message)
|
|
||||||
|
|
||||||
def test_egress_routes_yaml_is_validated(self):
|
def test_egress_routes_yaml_is_validated(self):
|
||||||
validate_proposed_file(
|
validate_proposed_file(
|
||||||
@@ -70,74 +67,6 @@ class TestValidation(unittest.TestCase):
|
|||||||
with self.assertRaises(_RpcError):
|
with self.assertRaises(_RpcError):
|
||||||
validate_proposed_file(_sv.TOOL_EGRESS_BLOCK, "routes: nope\n")
|
validate_proposed_file(_sv.TOOL_EGRESS_BLOCK, "routes: nope\n")
|
||||||
|
|
||||||
def test_egress_routes_yaml_rejects_log_full(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
validate_proposed_file(
|
|
||||||
_sv.TOOL_EGRESS_ALLOW,
|
|
||||||
"log: 2\nroutes:\n - host: example.com\n",
|
|
||||||
)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
self.assertIn("must not change egress logging", cm.exception.message)
|
|
||||||
|
|
||||||
|
|
||||||
# --- Error taxonomy --------------------------------------------------------
|
|
||||||
|
|
||||||
|
|
||||||
class TestRpcErrorTaxonomy(unittest.TestCase):
|
|
||||||
def test_rpc_client_error_is_rpc_error(self):
|
|
||||||
e = _RpcClientError(ERR_INVALID_PARAMS, "bad param")
|
|
||||||
self.assertIsInstance(e, _RpcError)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, e.code)
|
|
||||||
self.assertEqual("bad param", e.message)
|
|
||||||
|
|
||||||
def test_rpc_internal_error_is_rpc_error(self):
|
|
||||||
e = _RpcInternalError("disk full")
|
|
||||||
self.assertIsInstance(e, _RpcError)
|
|
||||||
self.assertEqual(ERR_INTERNAL, e.code)
|
|
||||||
self.assertEqual("disk full", e.message)
|
|
||||||
|
|
||||||
def test_rpc_internal_error_preserves_cause(self):
|
|
||||||
cause = OSError("no space left on device")
|
|
||||||
try:
|
|
||||||
raise _RpcInternalError("failed to write") from cause
|
|
||||||
except _RpcInternalError as e:
|
|
||||||
self.assertIs(cause, e.__cause__)
|
|
||||||
|
|
||||||
def test_parse_error_is_client_error(self):
|
|
||||||
with self.assertRaises(_RpcClientError):
|
|
||||||
parse_jsonrpc(b"{bad json")
|
|
||||||
|
|
||||||
def test_validation_error_is_client_error(self):
|
|
||||||
with self.assertRaises(_RpcClientError):
|
|
||||||
validate_proposed_file(_sv.TOOL_EGRESS_ALLOW, "routes: nope\n")
|
|
||||||
|
|
||||||
def test_unknown_tool_in_tools_call_is_client_error(self):
|
|
||||||
config = ServerConfig(bottle_slug="dev", queue_dir=Path("/unused"))
|
|
||||||
with self.assertRaises(_RpcClientError) as cm:
|
|
||||||
handle_tools_call({"name": "no-such-tool", "arguments": {}}, config)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
|
|
||||||
|
|
||||||
class TestRpcInternalErrorOnIoFailure(unittest.TestCase):
|
|
||||||
def test_write_proposal_os_error_raises_internal(self):
|
|
||||||
config = ServerConfig(
|
|
||||||
bottle_slug="dev",
|
|
||||||
queue_dir=Path("/dev/null/cannot-exist"),
|
|
||||||
)
|
|
||||||
with self.assertRaises(_RpcInternalError) as cm:
|
|
||||||
handle_tools_call(
|
|
||||||
{
|
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
|
||||||
"arguments": {
|
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
|
||||||
"justification": "x",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
config,
|
|
||||||
)
|
|
||||||
self.assertEqual(ERR_INTERNAL, cm.exception.code)
|
|
||||||
self.assertIsNotNone(cm.exception.__cause__)
|
|
||||||
|
|
||||||
|
|
||||||
# --- JSON-RPC parsing ------------------------------------------------------
|
# --- JSON-RPC parsing ------------------------------------------------------
|
||||||
|
|
||||||
@@ -219,6 +148,7 @@ class TestHandleToolsList(unittest.TestCase):
|
|||||||
self.assertEqual(
|
self.assertEqual(
|
||||||
sorted([
|
sorted([
|
||||||
_sv.TOOL_EGRESS_ALLOW,
|
_sv.TOOL_EGRESS_ALLOW,
|
||||||
|
_sv.TOOL_CAPABILITY_BLOCK,
|
||||||
_sv.TOOL_EGRESS_BLOCK,
|
_sv.TOOL_EGRESS_BLOCK,
|
||||||
_sv.TOOL_LIST_EGRESS_ROUTES,
|
_sv.TOOL_LIST_EGRESS_ROUTES,
|
||||||
]),
|
]),
|
||||||
@@ -294,10 +224,10 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
try:
|
try:
|
||||||
result = handle_tools_call(
|
result = handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_BLOCK,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {
|
"arguments": {
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
"dockerfile": "FROM python:3.13\n",
|
||||||
"justification": "need example.com",
|
"justification": "need git",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
self.config,
|
self.config,
|
||||||
@@ -334,9 +264,9 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
try:
|
try:
|
||||||
result = handle_tools_call(
|
result = handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {
|
"arguments": {
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
"dockerfile": "FROM python:3.13\n",
|
||||||
"justification": "needed for tests",
|
"justification": "needed for tests",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -358,52 +288,20 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
with self.assertRaises(_RpcError):
|
with self.assertRaises(_RpcError):
|
||||||
handle_tools_call(
|
handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {"routes_yaml": "routes:\n - host: example.com\n"},
|
"arguments": {"dockerfile": "FROM python:3.13\n"},
|
||||||
},
|
},
|
||||||
self.config,
|
self.config,
|
||||||
)
|
)
|
||||||
|
|
||||||
def test_missing_name_raises(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
handle_tools_call({"arguments": {}}, self.config)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
|
|
||||||
def test_arguments_must_be_object(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
handle_tools_call(
|
|
||||||
{
|
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
|
||||||
"arguments": [],
|
|
||||||
},
|
|
||||||
self.config,
|
|
||||||
)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
self.assertIn("must be an object", cm.exception.message)
|
|
||||||
|
|
||||||
def test_capability_block_call_raises_unknown_tool(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
handle_tools_call(
|
|
||||||
{
|
|
||||||
"name": "capability-block",
|
|
||||||
"arguments": {
|
|
||||||
"dockerfile": "FROM python:3.13\n",
|
|
||||||
"justification": "need git",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
self.config,
|
|
||||||
)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
self.assertIn("unknown tool", cm.exception.message)
|
|
||||||
|
|
||||||
def test_archives_proposal_after_response(self):
|
def test_archives_proposal_after_response(self):
|
||||||
responder = self._respond_when_proposal_appears(_sv.STATUS_APPROVED)
|
responder = self._respond_when_proposal_appears(_sv.STATUS_APPROVED)
|
||||||
try:
|
try:
|
||||||
handle_tools_call(
|
handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {
|
"arguments": {
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
"dockerfile": "FROM python:3.13\n",
|
||||||
"justification": "x",
|
"justification": "x",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -425,10 +323,10 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
result = handle_tools_call(
|
result = handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {
|
"arguments": {
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
"dockerfile": "FROM python:3.13\n",
|
||||||
"justification": "need egress",
|
"justification": "need a capability",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
config,
|
config,
|
||||||
@@ -443,31 +341,6 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
|
|
||||||
|
|
||||||
class TestHandleListEgressRoutes(unittest.TestCase):
|
class TestHandleListEgressRoutes(unittest.TestCase):
|
||||||
def test_success_returns_body_text(self):
|
|
||||||
class _Resp:
|
|
||||||
def __enter__(self):
|
|
||||||
return self
|
|
||||||
|
|
||||||
def __exit__(self, exc_type: type[BaseException] | None, exc: BaseException | None, tb: object) -> bool:
|
|
||||||
return False
|
|
||||||
|
|
||||||
def read(self):
|
|
||||||
return b"[{\"host\": \"example.com\"}]"
|
|
||||||
|
|
||||||
class _Opener:
|
|
||||||
def open(self, *args, **kwargs): # noqa: ANN001, ANN002, ANN003 # type: ignore
|
|
||||||
return _Resp()
|
|
||||||
|
|
||||||
with patch.object(supervise_server.urllib.request, "build_opener", return_value=_Opener()):
|
|
||||||
result = handle_list_egress_routes(
|
|
||||||
{},
|
|
||||||
ServerConfig(bottle_slug="dev", queue_dir=Path("/unused")),
|
|
||||||
)
|
|
||||||
|
|
||||||
self.assertFalse(result["isError"]) # type: ignore[index]
|
|
||||||
text = result["content"][0]["text"] # type: ignore[index]
|
|
||||||
self.assertIn("example.com", text)
|
|
||||||
|
|
||||||
def test_url_error_returns_tool_error(self):
|
def test_url_error_returns_tool_error(self):
|
||||||
class _Opener:
|
class _Opener:
|
||||||
def open(self, *args, **kwargs): # noqa: ANN001, ANN002, ANN003 # type: ignore
|
def open(self, *args, **kwargs): # noqa: ANN001, ANN002, ANN003 # type: ignore
|
||||||
@@ -527,13 +400,6 @@ class TestFormatResponseText(unittest.TestCase):
|
|||||||
self.assertIn("the operator modified", text.lower())
|
self.assertIn("the operator modified", text.lower())
|
||||||
|
|
||||||
|
|
||||||
class TestFormatPendingResponseText(unittest.TestCase):
|
|
||||||
def test_formats_timeout_message(self):
|
|
||||||
text = supervise_server.format_pending_response_text(12.5)
|
|
||||||
self.assertIn("status: pending", text)
|
|
||||||
self.assertIn("12.5s", text)
|
|
||||||
|
|
||||||
|
|
||||||
# --- End-to-end HTTP sanity ------------------------------------------------
|
# --- End-to-end HTTP sanity ------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
@@ -584,7 +450,7 @@ class TestHttpEndToEnd(unittest.TestCase):
|
|||||||
self.assertEqual("2.0", result["jsonrpc"])
|
self.assertEqual("2.0", result["jsonrpc"])
|
||||||
self.assertEqual(1, result["id"])
|
self.assertEqual(1, result["id"])
|
||||||
names = [t["name"] for t in result["result"]["tools"]] # type: ignore[index]
|
names = [t["name"] for t in result["result"]["tools"]] # type: ignore[index]
|
||||||
self.assertNotIn("capability-block", names)
|
self.assertIn(_sv.TOOL_CAPABILITY_BLOCK, names)
|
||||||
self.assertIn(_sv.TOOL_EGRESS_ALLOW, names)
|
self.assertIn(_sv.TOOL_EGRESS_ALLOW, names)
|
||||||
self.assertIn(_sv.TOOL_EGRESS_BLOCK, names)
|
self.assertIn(_sv.TOOL_EGRESS_BLOCK, names)
|
||||||
|
|
||||||
@@ -594,26 +460,6 @@ class TestHttpEndToEnd(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
self.assertEqual(ERR_METHOD_NOT_FOUND, result["error"]["code"]) # type: ignore[index]
|
self.assertEqual(ERR_METHOD_NOT_FOUND, result["error"]["code"]) # type: ignore[index]
|
||||||
|
|
||||||
def test_internal_error_returns_err_internal_over_http(self):
|
|
||||||
with patch.object(
|
|
||||||
supervise_server._sv, "write_proposal",
|
|
||||||
side_effect=OSError("disk full"),
|
|
||||||
):
|
|
||||||
result = self._post_jsonrpc({
|
|
||||||
"jsonrpc": "2.0",
|
|
||||||
"id": 99,
|
|
||||||
"method": "tools/call",
|
|
||||||
"params": {
|
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
|
||||||
"arguments": {
|
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
|
||||||
"justification": "x",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
})
|
|
||||||
self.assertIn("error", result)
|
|
||||||
self.assertEqual(ERR_INTERNAL, result["error"]["code"]) # type: ignore[index]
|
|
||||||
|
|
||||||
def test_health_endpoint(self):
|
def test_health_endpoint(self):
|
||||||
conn = http.client.HTTPConnection("127.0.0.1", self.port, timeout=5)
|
conn = http.client.HTTPConnection("127.0.0.1", self.port, timeout=5)
|
||||||
try:
|
try:
|
||||||
|
|||||||
Reference in New Issue
Block a user