Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| ea1f022f1a | |||
| f8f1bd6f32 | |||
| b8e2ce0b4d |
@@ -1,9 +0,0 @@
|
|||||||
[run]
|
|
||||||
branch = True
|
|
||||||
source = .
|
|
||||||
|
|
||||||
[report]
|
|
||||||
omit =
|
|
||||||
bot_bottle/egress_addon.py
|
|
||||||
bot_bottle/cli/tui.py
|
|
||||||
tests/*
|
|
||||||
@@ -39,14 +39,8 @@ jobs:
|
|||||||
with:
|
with:
|
||||||
python-version: "3.12"
|
python-version: "3.12"
|
||||||
|
|
||||||
- name: Install dev requirements
|
|
||||||
run: python3 -m pip install -r requirements-dev.txt
|
|
||||||
|
|
||||||
- name: Run unit tests
|
- name: Run unit tests
|
||||||
run: python3 -m coverage run -m unittest discover -t . -s tests/unit -v
|
run: python3 -m unittest discover -t . -s tests/unit -v
|
||||||
|
|
||||||
- name: Report unit coverage
|
|
||||||
run: python3 -m coverage report -m
|
|
||||||
|
|
||||||
integration:
|
integration:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
|||||||
@@ -22,4 +22,3 @@ venv/
|
|||||||
.pytest_cache/
|
.pytest_cache/
|
||||||
.mypy_cache/
|
.mypy_cache/
|
||||||
.ruff_cache/
|
.ruff_cache/
|
||||||
.coverage
|
|
||||||
|
|||||||
@@ -61,6 +61,7 @@ class AgentProviderRuntime:
|
|||||||
prompt_mode: PromptMode
|
prompt_mode: PromptMode
|
||||||
bypass_args: tuple[str, ...]
|
bypass_args: tuple[str, ...]
|
||||||
resume_args: tuple[str, ...]
|
resume_args: tuple[str, ...]
|
||||||
|
remote_control_args: tuple[str, ...]
|
||||||
|
|
||||||
|
|
||||||
@dataclass(frozen=True)
|
@dataclass(frozen=True)
|
||||||
@@ -390,7 +391,7 @@ def prompt_args(
|
|||||||
if prompt_mode == "append_file":
|
if prompt_mode == "append_file":
|
||||||
return ["--append-system-prompt-file", prompt_path]
|
return ["--append-system-prompt-file", prompt_path]
|
||||||
if prompt_mode == "read_prompt_file":
|
if prompt_mode == "read_prompt_file":
|
||||||
if argv and ("resume" in argv or "remote-control" in argv):
|
if argv and "resume" in argv:
|
||||||
return []
|
return []
|
||||||
return [f"Read and follow the instructions in {prompt_path}."]
|
return [f"Read and follow the instructions in {prompt_path}."]
|
||||||
if prompt_mode == "print_read_prompt_file":
|
if prompt_mode == "print_read_prompt_file":
|
||||||
|
|||||||
@@ -109,8 +109,9 @@ class BottlePlan(ABC):
|
|||||||
def workspace_plan(self) -> WorkspacePlan:
|
def workspace_plan(self) -> WorkspacePlan:
|
||||||
return workspace_plan(self.spec, guest_home=self.guest_home)
|
return workspace_plan(self.spec, guest_home=self.guest_home)
|
||||||
|
|
||||||
def print(self) -> None:
|
def print(self, *, remote_control: bool) -> None:
|
||||||
"""Render the y/N preflight summary to stderr."""
|
"""Render the y/N preflight summary to stderr."""
|
||||||
|
del remote_control
|
||||||
spec = self.spec
|
spec = self.spec
|
||||||
manifest = self.manifest
|
manifest = self.manifest
|
||||||
agent = manifest.agent
|
agent = manifest.agent
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ from pathlib import Path
|
|||||||
|
|
||||||
from ..bottle_state import egress_state_dir
|
from ..bottle_state import egress_state_dir
|
||||||
from ..egress import EGRESS_ROUTES_FILENAME
|
from ..egress import EGRESS_ROUTES_FILENAME
|
||||||
from ..egress_addon_core import LOG_OFF, load_config
|
from ..egress_addon_core import load_routes
|
||||||
|
|
||||||
|
|
||||||
class EgressApplyError(RuntimeError):
|
class EgressApplyError(RuntimeError):
|
||||||
@@ -33,15 +33,11 @@ class EgressApplicator(ABC):
|
|||||||
@staticmethod
|
@staticmethod
|
||||||
def validate_routes_content(content: str) -> None:
|
def validate_routes_content(content: str) -> None:
|
||||||
try:
|
try:
|
||||||
config = load_config(content)
|
load_routes(content)
|
||||||
except ValueError as e:
|
except ValueError as e:
|
||||||
raise EgressApplyError(
|
raise EgressApplyError(
|
||||||
f"proposed routes.yaml is not valid: {e}"
|
f"proposed routes.yaml is not valid: {e}"
|
||||||
) from e
|
) from e
|
||||||
if config.log != LOG_OFF:
|
|
||||||
raise EgressApplyError(
|
|
||||||
"proposed routes.yaml must not change egress logging"
|
|
||||||
)
|
|
||||||
|
|
||||||
@staticmethod
|
@staticmethod
|
||||||
def _routes_path(slug: str) -> Path:
|
def _routes_path(slug: str) -> Path:
|
||||||
|
|||||||
@@ -68,11 +68,6 @@ def build_image(ref: str, context: str, *, dockerfile: str = "") -> None:
|
|||||||
_ensure_builder_dns()
|
_ensure_builder_dns()
|
||||||
args = [_CONTAINER, "build", "-t", ref, "--dns", dns_server()]
|
args = [_CONTAINER, "build", "-t", ref, "--dns", dns_server()]
|
||||||
if dockerfile:
|
if dockerfile:
|
||||||
# `container build` resolves -f relative to the current working
|
|
||||||
# directory, not the build context. Anchor a relative Dockerfile to
|
|
||||||
# the context so builds work from any cwd.
|
|
||||||
if not os.path.isabs(dockerfile):
|
|
||||||
dockerfile = os.path.join(context, dockerfile)
|
|
||||||
args.extend(["-f", dockerfile])
|
args.extend(["-f", dockerfile])
|
||||||
args.append(context)
|
args.append(context)
|
||||||
subprocess.run(args, check=True)
|
subprocess.run(args, check=True)
|
||||||
|
|||||||
@@ -28,6 +28,7 @@ from .start import _launch_bottle
|
|||||||
def cmd_resume(argv: list[str]) -> int:
|
def cmd_resume(argv: list[str]) -> int:
|
||||||
parser = argparse.ArgumentParser(prog=f"{PROG} resume", add_help=True)
|
parser = argparse.ArgumentParser(prog=f"{PROG} resume", add_help=True)
|
||||||
parser.add_argument("--dry-run", action="store_true")
|
parser.add_argument("--dry-run", action="store_true")
|
||||||
|
parser.add_argument("--remote-control", action="store_true")
|
||||||
parser.add_argument(
|
parser.add_argument(
|
||||||
"identity",
|
"identity",
|
||||||
help="bottle identity from a prior `start` (see its session-end output)",
|
help="bottle identity from a prior `start` (see its session-end output)",
|
||||||
@@ -55,5 +56,6 @@ def cmd_resume(argv: list[str]) -> int:
|
|||||||
return _launch_bottle(
|
return _launch_bottle(
|
||||||
spec,
|
spec,
|
||||||
dry_run=args.dry_run,
|
dry_run=args.dry_run,
|
||||||
|
remote_control=args.remote_control,
|
||||||
backend_name=backend_name,
|
backend_name=backend_name,
|
||||||
)
|
)
|
||||||
|
|||||||
+10
-4
@@ -42,6 +42,7 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
parser = argparse.ArgumentParser(prog=f"{PROG} start", add_help=True)
|
parser = argparse.ArgumentParser(prog=f"{PROG} start", add_help=True)
|
||||||
parser.add_argument("--dry-run", action="store_true")
|
parser.add_argument("--dry-run", action="store_true")
|
||||||
parser.add_argument("--cwd", action="store_true", help="copy host cwd into the running bottle")
|
parser.add_argument("--cwd", action="store_true", help="copy host cwd into the running bottle")
|
||||||
|
parser.add_argument("--remote-control", action="store_true")
|
||||||
parser.add_argument(
|
parser.add_argument(
|
||||||
"--backend",
|
"--backend",
|
||||||
choices=known_backend_names(),
|
choices=known_backend_names(),
|
||||||
@@ -88,6 +89,7 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
return _launch_bottle(
|
return _launch_bottle(
|
||||||
spec,
|
spec,
|
||||||
dry_run=dry_run,
|
dry_run=dry_run,
|
||||||
|
remote_control=args.remote_control,
|
||||||
backend_name=backend_name,
|
backend_name=backend_name,
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -132,7 +134,7 @@ def prepare_with_preflight(
|
|||||||
|
|
||||||
|
|
||||||
def attach_agent(
|
def attach_agent(
|
||||||
bottle: Bottle, *, resume: bool = False,
|
bottle: Bottle, *, remote_control: bool = False, resume: bool = False,
|
||||||
agent_provider_template: str = "claude",
|
agent_provider_template: str = "claude",
|
||||||
startup_args: tuple[str, ...] = (),
|
startup_args: tuple[str, ...] = (),
|
||||||
) -> int:
|
) -> int:
|
||||||
@@ -151,6 +153,8 @@ def attach_agent(
|
|||||||
"(Ctrl-D or 'exit' to leave; container will be removed)"
|
"(Ctrl-D or 'exit' to leave; container will be removed)"
|
||||||
)
|
)
|
||||||
agent_args = list(runtime.bypass_args)
|
agent_args = list(runtime.bypass_args)
|
||||||
|
if remote_control:
|
||||||
|
agent_args.extend(runtime.remote_control_args)
|
||||||
agent_args.extend(startup_args)
|
agent_args.extend(startup_args)
|
||||||
if resume:
|
if resume:
|
||||||
agent_args.extend(runtime.resume_args)
|
agent_args.extend(runtime.resume_args)
|
||||||
@@ -214,9 +218,9 @@ def _text_prompt_yes() -> bool:
|
|||||||
return reply in ("y", "Y", "yes", "YES")
|
return reply in ("y", "Y", "yes", "YES")
|
||||||
|
|
||||||
|
|
||||||
def _text_render_preflight():
|
def _text_render_preflight(*, remote_control: bool):
|
||||||
def _render(plan: DockerBottlePlan) -> None:
|
def _render(plan: DockerBottlePlan) -> None:
|
||||||
plan.print()
|
plan.print(remote_control=remote_control)
|
||||||
return _render
|
return _render
|
||||||
|
|
||||||
|
|
||||||
@@ -224,6 +228,7 @@ def _launch_bottle(
|
|||||||
spec: BottleSpec,
|
spec: BottleSpec,
|
||||||
*,
|
*,
|
||||||
dry_run: bool,
|
dry_run: bool,
|
||||||
|
remote_control: bool,
|
||||||
backend_name: str | None = None,
|
backend_name: str | None = None,
|
||||||
) -> int:
|
) -> int:
|
||||||
"""Shared launch core for `start` and `resume`. Builds the plan,
|
"""Shared launch core for `start` and `resume`. Builds the plan,
|
||||||
@@ -235,7 +240,7 @@ def _launch_bottle(
|
|||||||
plan, identity = prepare_with_preflight(
|
plan, identity = prepare_with_preflight(
|
||||||
spec,
|
spec,
|
||||||
stage_dir=stage_dir,
|
stage_dir=stage_dir,
|
||||||
render_preflight=_text_render_preflight(),
|
render_preflight=_text_render_preflight(remote_control=remote_control),
|
||||||
prompt_yes=_text_prompt_yes,
|
prompt_yes=_text_prompt_yes,
|
||||||
dry_run=dry_run,
|
dry_run=dry_run,
|
||||||
backend_name=backend_name,
|
backend_name=backend_name,
|
||||||
@@ -248,6 +253,7 @@ def _launch_bottle(
|
|||||||
agent_provider_template = getattr(plan, "agent_provider_template", "claude")
|
agent_provider_template = getattr(plan, "agent_provider_template", "claude")
|
||||||
exit_code = attach_agent(
|
exit_code = attach_agent(
|
||||||
bottle,
|
bottle,
|
||||||
|
remote_control=remote_control,
|
||||||
agent_provider_template=agent_provider_template,
|
agent_provider_template=agent_provider_template,
|
||||||
startup_args=plan.agent_provision.startup_args,
|
startup_args=plan.agent_provision.startup_args,
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -2,8 +2,9 @@
|
|||||||
act on them (approve / modify / reject).
|
act on them (approve / modify / reject).
|
||||||
|
|
||||||
Curses-based TUI; modify-then-approve shells out to $EDITOR. The
|
Curses-based TUI; modify-then-approve shells out to $EDITOR. The
|
||||||
Egress proposals are queued for operator review as full routes.yaml
|
approval handler wires to PRD 0016 (capability-block), which rebuilds
|
||||||
updates.
|
the bottle Dockerfile. Egress proposals are queued for operator review
|
||||||
|
as full routes.yaml updates.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
@@ -21,6 +22,10 @@ from pathlib import Path
|
|||||||
|
|
||||||
from .. import supervise as _supervise
|
from .. import supervise as _supervise
|
||||||
from ..bottle_state import read_metadata
|
from ..bottle_state import read_metadata
|
||||||
|
# from ..backend.docker.capability_apply import (
|
||||||
|
# CapabilityApplyError,
|
||||||
|
# apply_capability_change,
|
||||||
|
# )
|
||||||
from ..backend.docker.egress_apply import (
|
from ..backend.docker.egress_apply import (
|
||||||
EgressApplyError,
|
EgressApplyError,
|
||||||
applicator as _docker_applicator,
|
applicator as _docker_applicator,
|
||||||
@@ -33,6 +38,10 @@ from ..backend.smolmachines.egress_apply import (
|
|||||||
)
|
)
|
||||||
from ..log import Die, error, info
|
from ..log import Die, error, info
|
||||||
|
|
||||||
|
|
||||||
|
class CapabilityApplyError(RuntimeError):
|
||||||
|
"""Placeholder while capability_apply is disabled."""
|
||||||
|
|
||||||
from ..supervise import (
|
from ..supervise import (
|
||||||
COMPONENT_FOR_TOOL,
|
COMPONENT_FOR_TOOL,
|
||||||
AuditEntry,
|
AuditEntry,
|
||||||
@@ -41,10 +50,12 @@ from ..supervise import (
|
|||||||
STATUS_APPROVED,
|
STATUS_APPROVED,
|
||||||
STATUS_MODIFIED,
|
STATUS_MODIFIED,
|
||||||
STATUS_REJECTED,
|
STATUS_REJECTED,
|
||||||
|
TOOL_CAPABILITY_BLOCK,
|
||||||
TOOL_EGRESS_ALLOW,
|
TOOL_EGRESS_ALLOW,
|
||||||
TOOL_EGRESS_BLOCK,
|
TOOL_EGRESS_BLOCK,
|
||||||
TOOL_GITLEAKS_ALLOW,
|
TOOL_GITLEAKS_ALLOW,
|
||||||
TOOL_EGRESS_TOKEN_ALLOW,
|
TOOL_EGRESS_TOKEN_ALLOW,
|
||||||
|
archive_proposal,
|
||||||
list_pending_proposals,
|
list_pending_proposals,
|
||||||
render_diff,
|
render_diff,
|
||||||
write_audit_entry,
|
write_audit_entry,
|
||||||
@@ -72,7 +83,7 @@ class QueuedProposal:
|
|||||||
# Errors any remediation engine may raise. Caught by the TUI key
|
# Errors any remediation engine may raise. Caught by the TUI key
|
||||||
# handlers and surfaced in the status line so a failed apply keeps
|
# handlers and surfaced in the status line so a failed apply keeps
|
||||||
# the proposal pending rather than crashing curses.
|
# the proposal pending rather than crashing curses.
|
||||||
ApplyError = (EgressApplyError,)
|
ApplyError = (CapabilityApplyError, EgressApplyError)
|
||||||
|
|
||||||
|
|
||||||
def apply_routes_change(slug: str, content: str) -> tuple[str, str]:
|
def apply_routes_change(slug: str, content: str) -> tuple[str, str]:
|
||||||
@@ -132,6 +143,8 @@ def _detail_lines(
|
|||||||
|
|
||||||
|
|
||||||
def _suffix_for_tool(tool: str) -> str:
|
def _suffix_for_tool(tool: str) -> str:
|
||||||
|
if tool == TOOL_CAPABILITY_BLOCK:
|
||||||
|
return ".dockerfile"
|
||||||
if tool in (TOOL_EGRESS_ALLOW, TOOL_EGRESS_BLOCK):
|
if tool in (TOOL_EGRESS_ALLOW, TOOL_EGRESS_BLOCK):
|
||||||
return ".yaml"
|
return ".yaml"
|
||||||
if tool in (TOOL_GITLEAKS_ALLOW, TOOL_EGRESS_TOKEN_ALLOW):
|
if tool in (TOOL_GITLEAKS_ALLOW, TOOL_EGRESS_TOKEN_ALLOW):
|
||||||
@@ -153,6 +166,17 @@ def approve(
|
|||||||
file_to_apply = final_file if final_file is not None else qp.proposal.proposed_file
|
file_to_apply = final_file if final_file is not None else qp.proposal.proposed_file
|
||||||
|
|
||||||
diff_before, diff_after = "", ""
|
diff_before, diff_after = "", ""
|
||||||
|
# if qp.proposal.tool == TOOL_CAPABILITY_BLOCK:
|
||||||
|
# _meta = read_metadata(qp.proposal.bottle_slug)
|
||||||
|
# if _meta is not None and not _meta.compose_project:
|
||||||
|
# raise CapabilityApplyError(
|
||||||
|
# "capability-block remediation is not supported for smolmachines "
|
||||||
|
# "bottles. Reject this proposal or handle the capability change "
|
||||||
|
# "manually, then restart the bottle."
|
||||||
|
# )
|
||||||
|
# diff_before, diff_after = apply_capability_change(
|
||||||
|
# qp.proposal.bottle_slug, file_to_apply,
|
||||||
|
# )
|
||||||
if qp.proposal.tool in (TOOL_EGRESS_ALLOW, TOOL_EGRESS_BLOCK):
|
if qp.proposal.tool in (TOOL_EGRESS_ALLOW, TOOL_EGRESS_BLOCK):
|
||||||
diff_before, diff_after = apply_routes_change(
|
diff_before, diff_after = apply_routes_change(
|
||||||
qp.proposal.bottle_slug,
|
qp.proposal.bottle_slug,
|
||||||
@@ -170,6 +194,9 @@ def approve(
|
|||||||
qp, action=status, notes=notes,
|
qp, action=status, notes=notes,
|
||||||
diff_before=diff_before, diff_after=diff_after,
|
diff_before=diff_before, diff_after=diff_after,
|
||||||
)
|
)
|
||||||
|
if qp.proposal.tool == TOOL_CAPABILITY_BLOCK:
|
||||||
|
archive_proposal(qp.queue_dir, qp.proposal.id)
|
||||||
|
|
||||||
|
|
||||||
def reject(qp: QueuedProposal, *, reason: str) -> None:
|
def reject(qp: QueuedProposal, *, reason: str) -> None:
|
||||||
"""Write a rejection response and an audit entry."""
|
"""Write a rejection response and an audit entry."""
|
||||||
@@ -319,7 +346,7 @@ def _list_once() -> int:
|
|||||||
return 0
|
return 0
|
||||||
|
|
||||||
|
|
||||||
def _try_init_green() -> int: # pragma: no cover
|
def _try_init_green() -> int:
|
||||||
"""Initialise a green color pair and return its attr, or 0."""
|
"""Initialise a green color pair and return its attr, or 0."""
|
||||||
try:
|
try:
|
||||||
curses.start_color()
|
curses.start_color()
|
||||||
@@ -330,7 +357,7 @@ def _try_init_green() -> int: # pragma: no cover
|
|||||||
return 0
|
return 0
|
||||||
|
|
||||||
|
|
||||||
def _main_loop(stdscr: "curses._CursesWindow") -> None: # type: ignore # pragma: no cover
|
def _main_loop(stdscr: "curses._CursesWindow") -> None: # type: ignore
|
||||||
curses.curs_set(0)
|
curses.curs_set(0)
|
||||||
stdscr.timeout(_REFRESH_INTERVAL_MS)
|
stdscr.timeout(_REFRESH_INTERVAL_MS)
|
||||||
green_attr = _try_init_green()
|
green_attr = _try_init_green()
|
||||||
@@ -420,7 +447,7 @@ def _render(
|
|||||||
status_line: str,
|
status_line: str,
|
||||||
*,
|
*,
|
||||||
green_attr: int = 0, # noqa: F841 — unused, but required by interface
|
green_attr: int = 0, # noqa: F841 — unused, but required by interface
|
||||||
) -> None: # pragma: no cover
|
) -> None:
|
||||||
stdscr.erase()
|
stdscr.erase()
|
||||||
h, w = stdscr.getmaxyx()
|
h, w = stdscr.getmaxyx()
|
||||||
header = f"bot-bottle supervise ({len(pending)} pending)"
|
header = f"bot-bottle supervise ({len(pending)} pending)"
|
||||||
@@ -471,7 +498,7 @@ def _detail_view(
|
|||||||
qp: QueuedProposal,
|
qp: QueuedProposal,
|
||||||
*,
|
*,
|
||||||
green_attr: int = 0,
|
green_attr: int = 0,
|
||||||
) -> None: # pragma: no cover
|
) -> None:
|
||||||
"""Render the full proposal. Scrollable. Press q to return."""
|
"""Render the full proposal. Scrollable. Press q to return."""
|
||||||
lines = _detail_lines(qp, green_attr=green_attr)
|
lines = _detail_lines(qp, green_attr=green_attr)
|
||||||
offset = 0
|
offset = 0
|
||||||
@@ -523,7 +550,7 @@ def _detail_view(
|
|||||||
return
|
return
|
||||||
|
|
||||||
|
|
||||||
def _modify(stdscr: "curses._CursesWindow", qp: QueuedProposal) -> str | None: # type: ignore # pragma: no cover
|
def _modify(stdscr: "curses._CursesWindow", qp: QueuedProposal) -> str | None: # type: ignore
|
||||||
"""Suspend curses, open $EDITOR on the proposed file, return edited content."""
|
"""Suspend curses, open $EDITOR on the proposed file, return edited content."""
|
||||||
suffix = _suffix_for_tool(qp.proposal.tool)
|
suffix = _suffix_for_tool(qp.proposal.tool)
|
||||||
curses.endwin()
|
curses.endwin()
|
||||||
@@ -534,7 +561,7 @@ def _modify(stdscr: "curses._CursesWindow", qp: QueuedProposal) -> str | None:
|
|||||||
return edited
|
return edited
|
||||||
|
|
||||||
|
|
||||||
def _prompt(stdscr: "curses._CursesWindow", label: str) -> str: # type: ignore # pragma: no cover
|
def _prompt(stdscr: "curses._CursesWindow", label: str) -> str: # type: ignore
|
||||||
"""One-line input at the bottom of the screen."""
|
"""One-line input at the bottom of the screen."""
|
||||||
curses.curs_set(1)
|
curses.curs_set(1)
|
||||||
h, _ = stdscr.getmaxyx()
|
h, _ = stdscr.getmaxyx()
|
||||||
|
|||||||
@@ -91,6 +91,7 @@ _RUNTIME = AgentProviderRuntime(
|
|||||||
prompt_mode="append_file",
|
prompt_mode="append_file",
|
||||||
bypass_args=("--dangerously-skip-permissions",),
|
bypass_args=("--dangerously-skip-permissions",),
|
||||||
resume_args=("--continue",),
|
resume_args=("--continue",),
|
||||||
|
remote_control_args=("--remote-control",),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -1,12 +1,12 @@
|
|||||||
# bot-bottle Codex provider image.
|
# bot-bottle Codex provider image.
|
||||||
#
|
#
|
||||||
# Mirrors the default Claude image shape: Node LTS, git/network tooling,
|
# Mirrors the default Claude image shape: Node LTS, git/network tooling,
|
||||||
# non-root node user, and the provider CLI installed for that user.
|
# non-root node user, and the provider CLI installed globally.
|
||||||
|
|
||||||
FROM node:22-slim
|
FROM node:22-slim
|
||||||
|
|
||||||
RUN apt-get update \
|
RUN apt-get update \
|
||||||
&& apt-get install -y --no-install-recommends git ca-certificates curl procps \
|
&& apt-get install -y --no-install-recommends git ca-certificates curl \
|
||||||
&& rm -rf /var/lib/apt/lists/*
|
&& rm -rf /var/lib/apt/lists/*
|
||||||
|
|
||||||
# App-specific deps. Python isn't required by codex itself
|
# App-specific deps. Python isn't required by codex itself
|
||||||
@@ -17,15 +17,12 @@ RUN apt-get update \
|
|||||||
&& apt-get install -y --no-install-recommends python3 python3-pip python3-venv \
|
&& apt-get install -y --no-install-recommends python3 python3-pip python3-venv \
|
||||||
&& rm -rf /var/lib/apt/lists/*
|
&& rm -rf /var/lib/apt/lists/*
|
||||||
|
|
||||||
|
RUN npm install -g --no-fund --no-audit @openai/codex@0.136.0 \
|
||||||
|
&& npm cache clean --force
|
||||||
|
|
||||||
USER node
|
USER node
|
||||||
WORKDIR /home/node
|
WORKDIR /home/node
|
||||||
|
|
||||||
ENV PATH="/home/node/.local/bin:${PATH}"
|
RUN mkdir -p /home/node/.codex
|
||||||
|
|
||||||
# Remote-control support requires the standalone Codex install layout
|
|
||||||
# under ~/.codex/packages/standalone/current. The npm package can run
|
|
||||||
# the TUI, but remote-control commands expect this installer-owned path.
|
|
||||||
RUN mkdir -p /home/node/.codex \
|
|
||||||
&& curl -fsSL https://chatgpt.com/codex/install.sh | sh
|
|
||||||
|
|
||||||
CMD ["codex"]
|
CMD ["codex"]
|
||||||
|
|||||||
@@ -55,6 +55,7 @@ _RUNTIME = AgentProviderRuntime(
|
|||||||
prompt_mode="read_prompt_file",
|
prompt_mode="read_prompt_file",
|
||||||
bypass_args=("--dangerously-bypass-approvals-and-sandbox",),
|
bypass_args=("--dangerously-bypass-approvals-and-sandbox",),
|
||||||
resume_args=("resume", "--last"),
|
resume_args=("resume", "--last"),
|
||||||
|
remote_control_args=(),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -166,6 +166,7 @@ _RUNTIME = AgentProviderRuntime(
|
|||||||
prompt_mode="append_system_prompt",
|
prompt_mode="append_system_prompt",
|
||||||
bypass_args=(),
|
bypass_args=(),
|
||||||
resume_args=(),
|
resume_args=(),
|
||||||
|
remote_control_args=(),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -439,6 +439,15 @@ def route_to_yaml_dict(r: Route) -> dict[str, object]:
|
|||||||
return d
|
return d
|
||||||
|
|
||||||
|
|
||||||
|
def load_routes(text: str) -> tuple[Route, ...]:
|
||||||
|
"""Parse YAML text → routes."""
|
||||||
|
try:
|
||||||
|
payload = parse_yaml_subset(text)
|
||||||
|
except YamlSubsetError as e:
|
||||||
|
raise ValueError(f"routes payload: invalid YAML: {e}") from e
|
||||||
|
return parse_routes(payload)
|
||||||
|
|
||||||
|
|
||||||
def parse_config(payload: object) -> "Config":
|
def parse_config(payload: object) -> "Config":
|
||||||
"""Parse a full egress config payload (top-level log level + routes)."""
|
"""Parse a full egress config payload (top-level log level + routes)."""
|
||||||
if not isinstance(payload, dict):
|
if not isinstance(payload, dict):
|
||||||
@@ -853,6 +862,7 @@ __all__ = [
|
|||||||
"is_git_push_request",
|
"is_git_push_request",
|
||||||
"is_git_fetch_request",
|
"is_git_fetch_request",
|
||||||
"load_config",
|
"load_config",
|
||||||
|
"load_routes",
|
||||||
"match_route",
|
"match_route",
|
||||||
"outbound_scan_headers",
|
"outbound_scan_headers",
|
||||||
"parse_config",
|
"parse_config",
|
||||||
|
|||||||
+110
-18
@@ -49,33 +49,125 @@ def _resolve_one_bottle(
|
|||||||
repos_cache[name] = _resolve_repos_raw({}, child_raw)
|
repos_cache[name] = _resolve_repos_raw({}, child_raw)
|
||||||
return bottle
|
return bottle
|
||||||
|
|
||||||
if not isinstance(parent_name_raw, str):
|
# Normalize to list, accepting both str and list[str].
|
||||||
|
raw_list: list[object]
|
||||||
|
if isinstance(parent_name_raw, str):
|
||||||
|
raw_list = [parent_name_raw]
|
||||||
|
elif isinstance(parent_name_raw, list):
|
||||||
|
raw_list = parent_name_raw
|
||||||
|
else:
|
||||||
raise ManifestError(
|
raise ManifestError(
|
||||||
f"bottle '{name}' extends must be a string "
|
f"bottle '{name}' extends must be a string or list of strings "
|
||||||
f"(was {type(parent_name_raw).__name__})"
|
f"(was {type(parent_name_raw).__name__})"
|
||||||
)
|
)
|
||||||
parent_name: str = parent_name_raw
|
|
||||||
if parent_name == name:
|
# Validate each entry before resolving any of them.
|
||||||
raise ManifestError(
|
parent_names: list[str] = []
|
||||||
f"bottle '{name}' extends itself; remove the "
|
for i, pname in enumerate(raw_list):
|
||||||
f"self-reference"
|
if not isinstance(pname, str):
|
||||||
)
|
raise ManifestError(
|
||||||
if parent_name not in raws:
|
f"bottle '{name}' extends[{i}] must be a string "
|
||||||
avail = ", ".join(sorted(raws.keys())) or "(none)"
|
f"(was {type(pname).__name__})"
|
||||||
raise ManifestError(
|
)
|
||||||
f"bottle '{name}' extends '{parent_name}' which is not "
|
parent_names.append(pname)
|
||||||
f"defined. Available bottles: {avail}"
|
if pname == name:
|
||||||
)
|
raise ManifestError(
|
||||||
parent = _resolve_one_bottle(
|
f"bottle '{name}' extends itself; remove the self-reference"
|
||||||
parent_name, raws, cache, repos_cache, seen + (name,)
|
)
|
||||||
|
if pname not in raws:
|
||||||
|
avail = ", ".join(sorted(raws.keys())) or "(none)"
|
||||||
|
raise ManifestError(
|
||||||
|
f"bottle '{name}' extends '{pname}' which is not "
|
||||||
|
f"defined. Available bottles: {avail}"
|
||||||
|
)
|
||||||
|
|
||||||
|
combined_parent, combined_repos_raw = _fold_parents(
|
||||||
|
parent_names, raws, cache, repos_cache, seen + (name,)
|
||||||
)
|
)
|
||||||
merged_repos_raw = _resolve_repos_raw(repos_cache[parent_name], child_raw)
|
merged_repos_raw = _resolve_repos_raw(combined_repos_raw, child_raw)
|
||||||
bottle = _merge_bottles(parent, child_raw, merged_repos_raw, name)
|
bottle = _merge_bottles(combined_parent, child_raw, merged_repos_raw, name)
|
||||||
cache[name] = bottle
|
cache[name] = bottle
|
||||||
repos_cache[name] = merged_repos_raw
|
repos_cache[name] = merged_repos_raw
|
||||||
return bottle
|
return bottle
|
||||||
|
|
||||||
|
|
||||||
|
def _fold_parents(
|
||||||
|
parent_names: list[str],
|
||||||
|
raws: dict[str, dict[str, object]],
|
||||||
|
cache: dict[str, ManifestBottle],
|
||||||
|
repos_cache: dict[str, dict[str, object]],
|
||||||
|
seen: tuple[str, ...],
|
||||||
|
) -> tuple[ManifestBottle, dict[str, object]]:
|
||||||
|
"""Resolve each parent and fold them left-to-right.
|
||||||
|
|
||||||
|
Later parents win over earlier ones on conflict. The `seen` tuple
|
||||||
|
carries the current bottle's name so cycle detection works across
|
||||||
|
every parent edge in the multi-parent graph."""
|
||||||
|
first = parent_names[0]
|
||||||
|
effective = _resolve_one_bottle(first, raws, cache, repos_cache, seen)
|
||||||
|
effective_repos_raw = repos_cache[first]
|
||||||
|
for pname in parent_names[1:]:
|
||||||
|
later = _resolve_one_bottle(pname, raws, cache, repos_cache, seen)
|
||||||
|
later_repos_raw = repos_cache[pname]
|
||||||
|
effective, effective_repos_raw = _fold_two_bottles(
|
||||||
|
effective, effective_repos_raw, later, later_repos_raw
|
||||||
|
)
|
||||||
|
return effective, effective_repos_raw
|
||||||
|
|
||||||
|
|
||||||
|
def _fold_two_bottles(
|
||||||
|
earlier: ManifestBottle,
|
||||||
|
earlier_repos_raw: dict[str, object],
|
||||||
|
later: ManifestBottle,
|
||||||
|
later_repos_raw: dict[str, object],
|
||||||
|
) -> tuple[ManifestBottle, dict[str, object]]:
|
||||||
|
"""Combine two resolved parent bottles; later wins over earlier."""
|
||||||
|
from .manifest import ManifestBottle, ManifestGitUser
|
||||||
|
from .manifest_egress import ManifestEgressConfig
|
||||||
|
from .manifest_git import parse_git_gate_config
|
||||||
|
from .manifest_util import as_json_object
|
||||||
|
|
||||||
|
merged_env = {**earlier.env, **later.env}
|
||||||
|
|
||||||
|
merged_git_user = ManifestGitUser(
|
||||||
|
name=later.git_user.name or earlier.git_user.name,
|
||||||
|
email=later.git_user.email or earlier.git_user.email,
|
||||||
|
)
|
||||||
|
|
||||||
|
# Repos: union by name; for same-name entries, later wins per-field.
|
||||||
|
# Unlike _resolve_repos_raw, an empty later_repos_raw means "no repos
|
||||||
|
# declared" — it does NOT clear the earlier parent's repos.
|
||||||
|
names = list(earlier_repos_raw) + [
|
||||||
|
n for n in later_repos_raw if n not in earlier_repos_raw
|
||||||
|
]
|
||||||
|
merged_repos_raw: dict[str, object] = {
|
||||||
|
n: {
|
||||||
|
**as_json_object(earlier_repos_raw.get(n, {}), "earlier parent repo"),
|
||||||
|
**as_json_object(later_repos_raw.get(n, {}), "later parent repo"),
|
||||||
|
}
|
||||||
|
for n in names
|
||||||
|
}
|
||||||
|
if merged_repos_raw:
|
||||||
|
merged_git, _ = parse_git_gate_config("_fold", {"repos": merged_repos_raw})
|
||||||
|
else:
|
||||||
|
merged_git = ()
|
||||||
|
|
||||||
|
# Egress: routes concatenate; scalar fields use last-wins.
|
||||||
|
merged_egress = ManifestEgressConfig(
|
||||||
|
routes=earlier.egress.routes + later.egress.routes,
|
||||||
|
Log=later.egress.Log,
|
||||||
|
)
|
||||||
|
|
||||||
|
return ManifestBottle(
|
||||||
|
env=merged_env,
|
||||||
|
agent_provider=later.agent_provider,
|
||||||
|
git=merged_git,
|
||||||
|
git_user=merged_git_user,
|
||||||
|
egress=merged_egress,
|
||||||
|
supervise=later.supervise,
|
||||||
|
), merged_repos_raw
|
||||||
|
|
||||||
|
|
||||||
def _merge_bottles(
|
def _merge_bottles(
|
||||||
parent: ManifestBottle,
|
parent: ManifestBottle,
|
||||||
child_raw: dict[str, object],
|
child_raw: dict[str, object],
|
||||||
|
|||||||
@@ -87,5 +87,7 @@ def load_bottle_chain_from_dir(
|
|||||||
parent = fm.get("extends")
|
parent = fm.get("extends")
|
||||||
if isinstance(parent, str):
|
if isinstance(parent, str):
|
||||||
to_load.append(parent)
|
to_load.append(parent)
|
||||||
|
elif isinstance(parent, list):
|
||||||
|
to_load.extend(p for p in parent if isinstance(p, str))
|
||||||
|
|
||||||
return resolve_bottles(raws)[bottle_name]
|
return resolve_bottles(raws)[bottle_name]
|
||||||
|
|||||||
@@ -47,11 +47,11 @@ from pathlib import Path
|
|||||||
try:
|
try:
|
||||||
# Same-directory imports inside the bundle container; these files are
|
# Same-directory imports inside the bundle container; these files are
|
||||||
# COPYed flat under /app by Dockerfile.sidecars.
|
# COPYed flat under /app by Dockerfile.sidecars.
|
||||||
from egress_addon_core import LOG_OFF, load_config
|
from egress_addon_core import load_routes
|
||||||
import supervise as _sv
|
import supervise as _sv
|
||||||
except ModuleNotFoundError:
|
except ModuleNotFoundError:
|
||||||
# Package imports for host-side tests and tooling.
|
# Package imports for host-side tests and tooling.
|
||||||
from .egress_addon_core import LOG_OFF, load_config
|
from .egress_addon_core import load_routes
|
||||||
from . import supervise as _sv
|
from . import supervise as _sv
|
||||||
|
|
||||||
|
|
||||||
@@ -297,17 +297,12 @@ def validate_proposed_file(tool: str, content: str) -> None:
|
|||||||
pass
|
pass
|
||||||
elif tool in (_sv.TOOL_EGRESS_ALLOW, _sv.TOOL_EGRESS_BLOCK):
|
elif tool in (_sv.TOOL_EGRESS_ALLOW, _sv.TOOL_EGRESS_BLOCK):
|
||||||
try:
|
try:
|
||||||
config = load_config(content)
|
load_routes(content)
|
||||||
except ValueError as e:
|
except ValueError as e:
|
||||||
raise _RpcError(
|
raise _RpcError(
|
||||||
ERR_INVALID_PARAMS,
|
ERR_INVALID_PARAMS,
|
||||||
f"{tool}: proposed routes.yaml is not valid: {e}",
|
f"{tool}: proposed routes.yaml is not valid: {e}",
|
||||||
) from e
|
) from e
|
||||||
if config.log != LOG_OFF:
|
|
||||||
raise _RpcError(
|
|
||||||
ERR_INVALID_PARAMS,
|
|
||||||
f"{tool}: proposed routes.yaml must not change egress logging",
|
|
||||||
)
|
|
||||||
else:
|
else:
|
||||||
raise _RpcError(ERR_INVALID_PARAMS, f"unknown tool {tool!r}")
|
raise _RpcError(ERR_INVALID_PARAMS, f"unknown tool {tool!r}")
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,166 @@
|
|||||||
|
# PRD prd-new: Multi-parent `extends:` for bottles
|
||||||
|
|
||||||
|
- **Status:** Draft
|
||||||
|
- **Author:** didericis
|
||||||
|
- **Created:** 2026-06-25
|
||||||
|
- **Issue:** #268
|
||||||
|
- **Extends:** PRD 0025 (`0025-bottle-extends.md`)
|
||||||
|
|
||||||
|
## Summary
|
||||||
|
|
||||||
|
Allow a bottle's `extends:` field to accept either a single bottle name (existing
|
||||||
|
behavior) or a list of bottle names (new). Multiple parents are resolved
|
||||||
|
independently and folded left-to-right into a single effective parent before the
|
||||||
|
child is merged on top. This lets orthogonal concerns (base env, networking/egress,
|
||||||
|
agent provider) live in separate bottles and be composed without forcing them into a
|
||||||
|
linear chain.
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
PRD 0025 shipped single-parent `extends:` and listed "No multi-parent inheritance"
|
||||||
|
as a non-goal. In practice, users want to compose multiple orthogonal bottles — a
|
||||||
|
base environment, a networking profile, and an agent-provider override — without
|
||||||
|
creating a three-level linear chain that couples unrelated parents to each other.
|
||||||
|
The linear chain workaround has two problems:
|
||||||
|
|
||||||
|
1. **Ordering constraint.** `networking extends base` works, but then
|
||||||
|
`agent extends networking` can't also pick up `base` without going through
|
||||||
|
`networking`, coupling two unrelated concerns.
|
||||||
|
|
||||||
|
2. **Quadratic duplication.** N orthogonal bottles require O(N²) chain variants
|
||||||
|
(one chain per permutation of applied concerns).
|
||||||
|
|
||||||
|
Multi-parent `extends:` removes both constraints: each orthogonal concern stays in
|
||||||
|
its own bottle, and the child bottle is the only place that names the combination.
|
||||||
|
|
||||||
|
## Goals / Success Criteria
|
||||||
|
|
||||||
|
- `extends:` accepts a list of strings in addition to a plain string.
|
||||||
|
- Backward compat: existing single-string `extends:` is unchanged.
|
||||||
|
- Parents are resolved left-to-right; later entries win on conflict.
|
||||||
|
- Child wins over all parents (unchanged from PRD 0025).
|
||||||
|
- Cycle detection covers multi-parent graphs, not just linear chains.
|
||||||
|
- Diamond inheritance: a shared ancestor is resolved once (via the existing cache).
|
||||||
|
- Invalid list entries (non-string, undefined bottle, self-reference) die at parse
|
||||||
|
with clear messages.
|
||||||
|
- `manifest_loader.py`'s `load_bottle_chain_from_dir` enqueues all parents from a
|
||||||
|
list `extends:` so the resolver sees every bottle in the graph.
|
||||||
|
|
||||||
|
## Non-goals
|
||||||
|
|
||||||
|
- No change to the agent-vs-bottle trust boundary (PRD 0025 "Alternatives
|
||||||
|
considered" option 2 stays rejected).
|
||||||
|
- No MRO / C3 linearization. Left-to-right fold is sufficient for the expected use
|
||||||
|
cases.
|
||||||
|
- No preflight display of per-field provenance across multiple parents (same open
|
||||||
|
question as PRD 0025; remains a follow-up).
|
||||||
|
|
||||||
|
## Design
|
||||||
|
|
||||||
|
### Schema
|
||||||
|
|
||||||
|
`extends:` now accepts either form:
|
||||||
|
|
||||||
|
```yaml
|
||||||
|
# single parent (unchanged)
|
||||||
|
extends: base
|
||||||
|
|
||||||
|
# multiple parents (new)
|
||||||
|
extends: [base, networking]
|
||||||
|
```
|
||||||
|
|
||||||
|
Both forms are normalized to a list internally. A list with one element behaves
|
||||||
|
identically to the string form.
|
||||||
|
|
||||||
|
### Merge rules for multi-parent fold
|
||||||
|
|
||||||
|
Parents are folded pairwise left-to-right before the child merge. For each step in
|
||||||
|
the fold, the "earlier" bottle is the running accumulator and the "later" bottle is
|
||||||
|
the next parent. Rules per field:
|
||||||
|
|
||||||
|
| Field | Fold rule |
|
||||||
|
|--------------------|--------------------------------------------------------------|
|
||||||
|
| `env` | dict merge; later wins on key collision |
|
||||||
|
| `git-gate.user` | per-field overlay; later's non-empty fields win |
|
||||||
|
| `git-gate.repos` | union by name; for same-name entries, later wins per-field |
|
||||||
|
| `egress.routes` | concatenate (earlier first, later appended) |
|
||||||
|
| `egress.log` | later wins (last-wins) |
|
||||||
|
| `agent_provider` | later wins (last-wins) |
|
||||||
|
| `supervise` | later wins (last-wins) |
|
||||||
|
|
||||||
|
After the fold, the combined parent is merged against the child using the existing
|
||||||
|
PRD 0025 rules (child always wins). The child's `egress.routes` appends to the
|
||||||
|
combined parent's concatenated routes; `validate_egress_routes` runs once on the
|
||||||
|
final merged set and catches duplicate hosts.
|
||||||
|
|
||||||
|
### Algorithm
|
||||||
|
|
||||||
|
```
|
||||||
|
extends: [p1, p2, p3]
|
||||||
|
|
||||||
|
fold:
|
||||||
|
combined = resolve(p1)
|
||||||
|
combined = fold_two(combined, resolve(p2))
|
||||||
|
combined = fold_two(combined, resolve(p3))
|
||||||
|
|
||||||
|
merge:
|
||||||
|
result = _merge_bottles(combined, child_raw, name)
|
||||||
|
```
|
||||||
|
|
||||||
|
`fold_two(earlier, later)` applies the rules in the table above. Cycle detection
|
||||||
|
(the `seen` tuple) is passed to each parent resolution call unchanged — if any
|
||||||
|
parent's chain circles back to the current bottle, it is caught. The `cache` dict
|
||||||
|
ensures a shared ancestor is only resolved once across all parents.
|
||||||
|
|
||||||
|
### Error cases
|
||||||
|
|
||||||
|
| Condition | Error message shape |
|
||||||
|
|----------------------------------------|------------------------------------------------------------------|
|
||||||
|
| `extends` is not a string or list | `extends must be a string or list of strings (was <type>)` |
|
||||||
|
| A list entry is not a string | `extends[<i>] must be a string (was <type>)` |
|
||||||
|
| A list entry names an undefined bottle | `extends '<name>' which is not defined. Available bottles: ...` |
|
||||||
|
| A list entry is the bottle itself | `extends itself; remove the self-reference` |
|
||||||
|
| Cycle through any parent edge | `is in an extends cycle: <chain>` |
|
||||||
|
|
||||||
|
## Implementation
|
||||||
|
|
||||||
|
### `bot_bottle/manifest_extends.py`
|
||||||
|
|
||||||
|
- `_resolve_one_bottle`: accept `str | list[str]` for `extends`; normalize to list;
|
||||||
|
validate each entry; for a single-entry list fall through to the existing
|
||||||
|
single-parent path; for multiple entries call `_fold_parents` then
|
||||||
|
`_merge_bottles`.
|
||||||
|
- `_fold_parents(parent_names, raws, cache, repos_cache, seen)`: resolve each
|
||||||
|
parent and fold pairwise left-to-right; return `(effective_bottle,
|
||||||
|
effective_repos_raw)`.
|
||||||
|
- `_fold_two_bottles(earlier, earlier_repos_raw, later, later_repos_raw)`: apply
|
||||||
|
the fold rules above; return `(folded_bottle, folded_repos_raw)`.
|
||||||
|
|
||||||
|
### `bot_bottle/manifest_loader.py`
|
||||||
|
|
||||||
|
- `load_bottle_chain_from_dir`: when `extends` is a list, enqueue all parent names
|
||||||
|
for loading (previously only `isinstance(parent, str)` was handled).
|
||||||
|
|
||||||
|
### `tests/unit/test_manifest_extends.py`
|
||||||
|
|
||||||
|
- `TestExtendsErrors.test_non_string_extends_dies`: update to use an integer
|
||||||
|
`extends` value (a list is now valid).
|
||||||
|
- New class `TestExtendsMultiParent` covering all cases listed in the issue.
|
||||||
|
|
||||||
|
## Testing strategy
|
||||||
|
|
||||||
|
Unit tests via `ManifestIndex.from_json_obj` (same resolver surface used by all
|
||||||
|
paths). No integration test changes needed — downstream code consumes the already-
|
||||||
|
merged bottle and is unchanged.
|
||||||
|
|
||||||
|
Test cases:
|
||||||
|
- Two-parent list: env union, egress routes concat, git repos union
|
||||||
|
- Last-parent-wins on scalar (supervise, agent_provider)
|
||||||
|
- Child wins over all parents on conflict
|
||||||
|
- Diamond: two parents share an ancestor; ancestor resolved once
|
||||||
|
- Single-element list: identical to string form
|
||||||
|
- Non-string extends value → ManifestError
|
||||||
|
- Non-string list entry → ManifestError
|
||||||
|
- Undefined bottle in list → ManifestError
|
||||||
|
- Self-reference in list → ManifestError
|
||||||
|
- Cycle through multi-parent edge → ManifestError
|
||||||
@@ -4,4 +4,3 @@
|
|||||||
|
|
||||||
pylint>=3.0.0
|
pylint>=3.0.0
|
||||||
pyright>=1.1.300
|
pyright>=1.1.300
|
||||||
coverage>=7.0.0
|
|
||||||
|
|||||||
@@ -92,9 +92,9 @@ class TestSandboxEscape(unittest.TestCase):
|
|||||||
"on PATH: curl -sSL https://smolmachines.com/install.sh | sh"
|
"on PATH: curl -sSL https://smolmachines.com/install.sh | sh"
|
||||||
)
|
)
|
||||||
|
|
||||||
# Throwaway static key for the git-gate fixture. It need not
|
# Throwaway "identity file" for the git-gate's `identity` field.
|
||||||
# be a real SSH key: test 5 reaches gitleaks before any SSH
|
# It need not be a real SSH key: test 5 reaches gitleaks before
|
||||||
# attempt anyway.
|
# any SSH attempt anyway.
|
||||||
fd, kp = tempfile.mkstemp(prefix="sandbox-test-key.")
|
fd, kp = tempfile.mkstemp(prefix="sandbox-test-key.")
|
||||||
os.close(fd)
|
os.close(fd)
|
||||||
cls._key_path = Path(kp)
|
cls._key_path = Path(kp)
|
||||||
@@ -123,10 +123,7 @@ class TestSandboxEscape(unittest.TestCase):
|
|||||||
"git-gate": {"repos": {
|
"git-gate": {"repos": {
|
||||||
"throwaway": {
|
"throwaway": {
|
||||||
"url": "ssh://git@unreachable.invalid:22/throwaway.git",
|
"url": "ssh://git@unreachable.invalid:22/throwaway.git",
|
||||||
"key": {
|
"identity": str(cls._key_path),
|
||||||
"provider": "static",
|
|
||||||
"path": str(cls._key_path),
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
}},
|
}},
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -198,7 +198,6 @@ class TestSmolmachinesLaunch(unittest.TestCase):
|
|||||||
# connect fails, which is the property chunk 3 will
|
# connect fails, which is the property chunk 3 will
|
||||||
# preserve once egress is actually running.
|
# preserve once egress is actually running.
|
||||||
r = self.bottle.exec(
|
r = self.bottle.exec(
|
||||||
"env -u HTTPS_PROXY -u HTTP_PROXY -u https_proxy -u http_proxy "
|
|
||||||
f"curl -s --show-error --max-time 3 http://{self.plan.bundle_ip}:9099 "
|
f"curl -s --show-error --max-time 3 http://{self.plan.bundle_ip}:9099 "
|
||||||
"2>&1 || true"
|
"2>&1 || true"
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -102,27 +102,6 @@ class TestAttachAgent(unittest.TestCase):
|
|||||||
bottle.argv,
|
bottle.argv,
|
||||||
)
|
)
|
||||||
|
|
||||||
def test_remote_control_is_provider_startup_arg(self):
|
|
||||||
class Bottle:
|
|
||||||
argv: list[str] = []
|
|
||||||
|
|
||||||
def exec_agent(self, argv: list[str], *, tty: bool = True) -> int:
|
|
||||||
self.argv = list(argv)
|
|
||||||
return 0
|
|
||||||
|
|
||||||
bottle = Bottle()
|
|
||||||
exit_code = start_mod.attach_agent(
|
|
||||||
bottle, # type: ignore[arg-type]
|
|
||||||
agent_provider_template="codex",
|
|
||||||
startup_args=("remote-control",),
|
|
||||||
)
|
|
||||||
|
|
||||||
self.assertEqual(0, exit_code)
|
|
||||||
self.assertEqual(
|
|
||||||
["--dangerously-bypass-approvals-and-sandbox", "remote-control"],
|
|
||||||
bottle.argv,
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
|
|||||||
@@ -29,9 +29,6 @@ from bot_bottle.supervise import SupervisePlan
|
|||||||
|
|
||||||
|
|
||||||
_URL = "http://supervise:9100/"
|
_URL = "http://supervise:9100/"
|
||||||
_CODEX_DOCKERFILE = (
|
|
||||||
Path(__file__).resolve().parents[2] / "bot_bottle/contrib/codex/Dockerfile"
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def _make_bottle(exec_result: ExecResult | None = None) -> MagicMock:
|
def _make_bottle(exec_result: ExecResult | None = None) -> MagicMock:
|
||||||
@@ -279,12 +276,6 @@ class TestCodexProvision(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
class TestCodexDockerfile(unittest.TestCase):
|
|
||||||
def test_installs_procps_for_remote_control_pid_management(self):
|
|
||||||
dockerfile = _CODEX_DOCKERFILE.read_text()
|
|
||||||
self.assertIn("procps", dockerfile)
|
|
||||||
|
|
||||||
|
|
||||||
class TestCodexSuperviseMcp(unittest.TestCase):
|
class TestCodexSuperviseMcp(unittest.TestCase):
|
||||||
def test_noop_when_supervise_disabled(self):
|
def test_noop_when_supervise_disabled(self):
|
||||||
bottle = _make_bottle()
|
bottle = _make_bottle()
|
||||||
|
|||||||
@@ -136,16 +136,6 @@ class TestClaudeArgv(unittest.TestCase):
|
|||||||
argv,
|
argv,
|
||||||
)
|
)
|
||||||
|
|
||||||
def test_codex_remote_control_startup_arg_does_not_receive_initial_prompt(self):
|
|
||||||
argv = _codex_bottle("/home/node/.bot-bottle-prompt.txt").agent_argv(
|
|
||||||
["--dangerously-bypass-approvals-and-sandbox", "remote-control"],
|
|
||||||
)
|
|
||||||
self.assertEqual(
|
|
||||||
["docker", "exec", "-it", "bot-bottle-dev-abc", "codex",
|
|
||||||
"--dangerously-bypass-approvals-and-sandbox", "remote-control"],
|
|
||||||
argv,
|
|
||||||
)
|
|
||||||
|
|
||||||
def test_codex_resume_does_not_append_initial_prompt(self):
|
def test_codex_resume_does_not_append_initial_prompt(self):
|
||||||
argv = _codex_bottle("/home/node/.bot-bottle-prompt.txt").agent_argv(
|
argv = _codex_bottle("/home/node/.bot-bottle-prompt.txt").agent_argv(
|
||||||
["--dangerously-bypass-approvals-and-sandbox", "resume", "--last"],
|
["--dangerously-bypass-approvals-and-sandbox", "resume", "--last"],
|
||||||
|
|||||||
@@ -31,6 +31,7 @@ class _Provider(AgentProvider):
|
|||||||
return AgentProviderRuntime(
|
return AgentProviderRuntime(
|
||||||
template="test", command="test", image="",
|
template="test", command="test", image="",
|
||||||
prompt_mode="append_file", bypass_args=(), resume_args=(),
|
prompt_mode="append_file", bypass_args=(), resume_args=(),
|
||||||
|
remote_control_args=(),
|
||||||
)
|
)
|
||||||
def provision_plan(self, **kwargs): # type: ignore[override]
|
def provision_plan(self, **kwargs): # type: ignore[override]
|
||||||
raise NotImplementedError
|
raise NotImplementedError
|
||||||
|
|||||||
@@ -322,7 +322,7 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
self.assertEqual([], parse_yaml_subset(rendered)["routes"])
|
self.assertEqual([], parse_yaml_subset(rendered)["routes"])
|
||||||
|
|
||||||
def test_round_trip_through_addon_core(self):
|
def test_round_trip_through_addon_core(self):
|
||||||
from bot_bottle.egress_addon_core import load_config
|
from bot_bottle.egress_addon_core import load_routes
|
||||||
b = _bottle([
|
b = _bottle([
|
||||||
{"host": "api.github.com",
|
{"host": "api.github.com",
|
||||||
"auth": {"scheme": "Bearer", "token_ref": "GH_PAT"},
|
"auth": {"scheme": "Bearer", "token_ref": "GH_PAT"},
|
||||||
@@ -333,7 +333,7 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
{"host": "api.anthropic.com"},
|
{"host": "api.anthropic.com"},
|
||||||
])
|
])
|
||||||
routes = egress_routes_for_bottle(b)
|
routes = egress_routes_for_bottle(b)
|
||||||
addon_routes = load_config(egress_render_routes(routes)).routes
|
addon_routes = load_routes(egress_render_routes(routes))
|
||||||
self.assertEqual(3, len(addon_routes))
|
self.assertEqual(3, len(addon_routes))
|
||||||
self.assertEqual("Bearer", addon_routes[0].auth_scheme)
|
self.assertEqual("Bearer", addon_routes[0].auth_scheme)
|
||||||
self.assertEqual("EGRESS_TOKEN_0", addon_routes[0].token_env)
|
self.assertEqual("EGRESS_TOKEN_0", addon_routes[0].token_env)
|
||||||
@@ -341,26 +341,26 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
self.assertEqual("", addon_routes[2].auth_scheme)
|
self.assertEqual("", addon_routes[2].auth_scheme)
|
||||||
|
|
||||||
def test_dlp_round_trips(self):
|
def test_dlp_round_trips(self):
|
||||||
from bot_bottle.egress_addon_core import load_config
|
from bot_bottle.egress_addon_core import load_routes
|
||||||
b = _bottle([{"host": "x.example", "dlp": {
|
b = _bottle([{"host": "x.example", "dlp": {
|
||||||
"outbound_detectors": ["token_patterns"],
|
"outbound_detectors": ["token_patterns"],
|
||||||
"inbound_detectors": False,
|
"inbound_detectors": False,
|
||||||
}}])
|
}}])
|
||||||
routes = egress_routes_for_bottle(b)
|
routes = egress_routes_for_bottle(b)
|
||||||
rendered = egress_render_routes(routes)
|
rendered = egress_render_routes(routes)
|
||||||
addon_routes = load_config(rendered).routes
|
addon_routes = load_routes(rendered)
|
||||||
self.assertEqual(("token_patterns",), addon_routes[0].outbound_detectors)
|
self.assertEqual(("token_patterns",), addon_routes[0].outbound_detectors)
|
||||||
self.assertEqual((), addon_routes[0].inbound_detectors)
|
self.assertEqual((), addon_routes[0].inbound_detectors)
|
||||||
|
|
||||||
def test_outbound_on_match_round_trips(self):
|
def test_outbound_on_match_round_trips(self):
|
||||||
from bot_bottle.egress_addon_core import load_config
|
from bot_bottle.egress_addon_core import load_routes
|
||||||
b = _bottle([{"host": "logs.example", "dlp": {
|
b = _bottle([{"host": "logs.example", "dlp": {
|
||||||
"outbound_on_match": "redact",
|
"outbound_on_match": "redact",
|
||||||
}}])
|
}}])
|
||||||
routes = egress_routes_for_bottle(b)
|
routes = egress_routes_for_bottle(b)
|
||||||
rendered = egress_render_routes(routes)
|
rendered = egress_render_routes(routes)
|
||||||
self.assertIn('outbound_on_match: "redact"', rendered)
|
self.assertIn('outbound_on_match: "redact"', rendered)
|
||||||
addon_routes = load_config(rendered).routes
|
addon_routes = load_routes(rendered)
|
||||||
self.assertEqual("redact", addon_routes[0].outbound_on_match)
|
self.assertEqual("redact", addon_routes[0].outbound_on_match)
|
||||||
|
|
||||||
def test_outbound_on_match_default_omitted_from_render(self):
|
def test_outbound_on_match_default_omitted_from_render(self):
|
||||||
@@ -370,12 +370,12 @@ class TestRenderRoutes(unittest.TestCase):
|
|||||||
self.assertNotIn("outbound_on_match", rendered)
|
self.assertNotIn("outbound_on_match", rendered)
|
||||||
|
|
||||||
def test_git_fetch_policy_round_trips(self):
|
def test_git_fetch_policy_round_trips(self):
|
||||||
from bot_bottle.egress_addon_core import load_config
|
from bot_bottle.egress_addon_core import load_routes
|
||||||
b = _bottle([{"host": "github.com", "git": {"fetch": True}}])
|
b = _bottle([{"host": "github.com", "git": {"fetch": True}}])
|
||||||
routes = egress_routes_for_bottle(b)
|
routes = egress_routes_for_bottle(b)
|
||||||
rendered = egress_render_routes(routes)
|
rendered = egress_render_routes(routes)
|
||||||
self.assertEqual({"fetch": True}, self._parsed(routes)[0]["git"])
|
self.assertEqual({"fetch": True}, self._parsed(routes)[0]["git"])
|
||||||
addon_routes = load_config(rendered).routes
|
addon_routes = load_routes(rendered)
|
||||||
self.assertTrue(addon_routes[0].git_fetch)
|
self.assertTrue(addon_routes[0].git_fetch)
|
||||||
|
|
||||||
def test_log_zero_omitted_from_render(self):
|
def test_log_zero_omitted_from_render(self):
|
||||||
|
|||||||
@@ -32,6 +32,7 @@ from bot_bottle.egress_addon_core import (
|
|||||||
is_git_fetch_request,
|
is_git_fetch_request,
|
||||||
is_git_push_request,
|
is_git_push_request,
|
||||||
load_config,
|
load_config,
|
||||||
|
load_routes,
|
||||||
match_route,
|
match_route,
|
||||||
outbound_scan_headers,
|
outbound_scan_headers,
|
||||||
parse_config,
|
parse_config,
|
||||||
@@ -288,6 +289,47 @@ class TestParseDlp(unittest.TestCase):
|
|||||||
}]})
|
}]})
|
||||||
|
|
||||||
|
|
||||||
|
# --- load_routes ---------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class TestLoadRoutes(unittest.TestCase):
|
||||||
|
def test_yaml_text_round_trip(self):
|
||||||
|
routes = load_routes(
|
||||||
|
'routes:\n'
|
||||||
|
' - host: "api.example"\n'
|
||||||
|
)
|
||||||
|
self.assertEqual(1, len(routes))
|
||||||
|
self.assertEqual("api.example", routes[0].host)
|
||||||
|
|
||||||
|
def test_full_route_shape_parses(self):
|
||||||
|
routes = load_routes(
|
||||||
|
'routes:\n'
|
||||||
|
' - host: "api.example"\n'
|
||||||
|
' auth_scheme: "Bearer"\n'
|
||||||
|
' token_env: "EGRESS_TOKEN_0"\n'
|
||||||
|
' matches:\n'
|
||||||
|
' - paths:\n'
|
||||||
|
' - value: "/v1/"\n'
|
||||||
|
' - type: "exact"\n'
|
||||||
|
' value: "/messages"\n'
|
||||||
|
)
|
||||||
|
self.assertEqual(1, len(routes))
|
||||||
|
r = routes[0]
|
||||||
|
self.assertEqual("api.example", r.host)
|
||||||
|
self.assertEqual("Bearer", r.auth_scheme)
|
||||||
|
self.assertEqual("EGRESS_TOKEN_0", r.token_env)
|
||||||
|
self.assertEqual(1, len(r.matches))
|
||||||
|
self.assertEqual(2, len(r.matches[0].paths))
|
||||||
|
|
||||||
|
def test_empty_routes_list(self):
|
||||||
|
routes = load_routes("routes: []\n")
|
||||||
|
self.assertEqual((), routes)
|
||||||
|
|
||||||
|
def test_invalid_yaml_raises_value_error(self):
|
||||||
|
with self.assertRaises(ValueError):
|
||||||
|
load_routes("routes:\n\t- host: x\n")
|
||||||
|
|
||||||
|
|
||||||
# --- load_config / parse_config ------------------------------------------
|
# --- load_config / parse_config ------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
@@ -336,33 +378,6 @@ class TestLoadConfig(unittest.TestCase):
|
|||||||
with self.assertRaises(ValueError):
|
with self.assertRaises(ValueError):
|
||||||
parse_config("not a dict")
|
parse_config("not a dict")
|
||||||
|
|
||||||
def test_empty_routes_list(self):
|
|
||||||
cfg = load_config("routes: []\n")
|
|
||||||
self.assertEqual((), cfg.routes)
|
|
||||||
|
|
||||||
def test_full_route_shape_parses(self):
|
|
||||||
cfg = load_config(
|
|
||||||
'routes:\n'
|
|
||||||
' - host: "api.example"\n'
|
|
||||||
' auth_scheme: "Bearer"\n'
|
|
||||||
' token_env: "EGRESS_TOKEN_0"\n'
|
|
||||||
' matches:\n'
|
|
||||||
' - paths:\n'
|
|
||||||
' - value: "/v1/"\n'
|
|
||||||
' - type: "exact"\n'
|
|
||||||
' value: "/messages"\n'
|
|
||||||
)
|
|
||||||
r = cfg.routes[0]
|
|
||||||
self.assertEqual("api.example", r.host)
|
|
||||||
self.assertEqual("Bearer", r.auth_scheme)
|
|
||||||
self.assertEqual("EGRESS_TOKEN_0", r.token_env)
|
|
||||||
self.assertEqual(1, len(r.matches))
|
|
||||||
self.assertEqual(2, len(r.matches[0].paths))
|
|
||||||
|
|
||||||
def test_invalid_yaml_raises_value_error(self):
|
|
||||||
with self.assertRaises(ValueError):
|
|
||||||
load_config("routes:\n\t- host: x\n")
|
|
||||||
|
|
||||||
|
|
||||||
# --- evaluate_matches ---------------------------------------------------
|
# --- evaluate_matches ---------------------------------------------------
|
||||||
|
|
||||||
|
|||||||
@@ -54,15 +54,6 @@ class TestValidateRoutesContent(unittest.TestCase):
|
|||||||
' auth_scheme: "Bearer"\n'
|
' auth_scheme: "Bearer"\n'
|
||||||
)
|
)
|
||||||
|
|
||||||
def test_rejects_log_full(self):
|
|
||||||
with self.assertRaises(EgressApplyError) as cm:
|
|
||||||
applicator.validate_routes_content(
|
|
||||||
'log: 2\n'
|
|
||||||
'routes:\n'
|
|
||||||
' - host: "x.example"\n'
|
|
||||||
)
|
|
||||||
self.assertIn("must not change egress logging", str(cm.exception))
|
|
||||||
|
|
||||||
|
|
||||||
class TestApplyRoutesChange(unittest.TestCase):
|
class TestApplyRoutesChange(unittest.TestCase):
|
||||||
def setUp(self):
|
def setUp(self):
|
||||||
|
|||||||
@@ -73,33 +73,6 @@ resolver #2
|
|||||||
)
|
)
|
||||||
self.assertTrue(run.call_args_list[-1].kwargs["check"])
|
self.assertTrue(run.call_args_list[-1].kwargs["check"])
|
||||||
|
|
||||||
def test_build_image_anchors_relative_dockerfile_to_context(self):
|
|
||||||
status = util.subprocess.CompletedProcess(
|
|
||||||
args=[],
|
|
||||||
returncode=0,
|
|
||||||
stdout=(
|
|
||||||
'[{"status":{"state":"running"},'
|
|
||||||
'"configuration":{"dns":{"nameservers":["9.9.9.9"]}}}]'
|
|
||||||
),
|
|
||||||
stderr="",
|
|
||||||
)
|
|
||||||
with patch.object(util.subprocess, "run", return_value=status) as run, \
|
|
||||||
patch.object(util.os, "environ", {
|
|
||||||
"BOT_BOTTLE_MACOS_CONTAINER_DNS": "9.9.9.9",
|
|
||||||
}):
|
|
||||||
util.build_image(
|
|
||||||
"bot-bottle-sidecars:latest",
|
|
||||||
"/repo",
|
|
||||||
dockerfile="Dockerfile.sidecars",
|
|
||||||
)
|
|
||||||
self.assertEqual(
|
|
||||||
[
|
|
||||||
"container", "build", "-t", "bot-bottle-sidecars:latest",
|
|
||||||
"--dns", "9.9.9.9", "-f", "/repo/Dockerfile.sidecars", "/repo",
|
|
||||||
],
|
|
||||||
run.call_args_list[-1].args[0],
|
|
||||||
)
|
|
||||||
|
|
||||||
def test_commit_container_execs_tar_and_builds_image(self):
|
def test_commit_container_execs_tar_and_builds_image(self):
|
||||||
# stderr is bytes because subprocess.run uses stderr=PIPE without text=True
|
# stderr is bytes because subprocess.run uses stderr=PIPE without text=True
|
||||||
completed = util.subprocess.CompletedProcess(
|
completed = util.subprocess.CompletedProcess(
|
||||||
|
|||||||
@@ -423,9 +423,182 @@ class TestExtendsErrors(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
self.assertIn("extends cycle", msg)
|
self.assertIn("extends cycle", msg)
|
||||||
|
|
||||||
def test_non_string_extends_dies(self):
|
def test_non_string_non_list_extends_dies(self):
|
||||||
msg = _error_message(_build, child={"extends": ["base"]})
|
msg = _error_message(_build, child={"extends": 123})
|
||||||
self.assertIn("extends must be a string", msg)
|
self.assertIn("extends must be a string or list of strings", msg)
|
||||||
|
|
||||||
|
def test_list_entry_non_string_dies(self):
|
||||||
|
msg = _error_message(_build, child={"extends": [123]})
|
||||||
|
self.assertIn("extends[0] must be a string", msg)
|
||||||
|
|
||||||
|
|
||||||
|
class TestExtendsMultiParent(unittest.TestCase):
|
||||||
|
"""extends: [p1, p2, ...] — multi-parent composition (issue #268)."""
|
||||||
|
|
||||||
|
_GIT_A = {"url": "ssh://git@host-a/a.git", "key": {"provider": "static", "path": "/k"}}
|
||||||
|
_GIT_B = {"url": "ssh://git@host-b/b.git", "key": {"provider": "static", "path": "/k"}}
|
||||||
|
|
||||||
|
def test_single_element_list_same_as_string(self):
|
||||||
|
m = _build(
|
||||||
|
base={"env": {"X": "1"}},
|
||||||
|
child={"extends": ["base"]},
|
||||||
|
)
|
||||||
|
self.assertEqual({"X": "1"}, dict(m.bottles["child"].env))
|
||||||
|
|
||||||
|
def test_two_parents_env_union(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"env": {"A": "1"}},
|
||||||
|
p2={"env": {"B": "2"}},
|
||||||
|
child={"extends": ["p1", "p2"]},
|
||||||
|
)
|
||||||
|
self.assertEqual({"A": "1", "B": "2"}, dict(m.bottles["child"].env))
|
||||||
|
|
||||||
|
def test_two_parents_env_last_wins_on_collision(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"env": {"X": "from-p1"}},
|
||||||
|
p2={"env": {"X": "from-p2"}},
|
||||||
|
child={"extends": ["p1", "p2"]},
|
||||||
|
)
|
||||||
|
self.assertEqual("from-p2", m.bottles["child"].env["X"])
|
||||||
|
|
||||||
|
def test_child_wins_over_all_parents(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"env": {"X": "from-p1"}},
|
||||||
|
p2={"env": {"X": "from-p2"}},
|
||||||
|
child={"extends": ["p1", "p2"], "env": {"X": "from-child"}},
|
||||||
|
)
|
||||||
|
self.assertEqual("from-child", m.bottles["child"].env["X"])
|
||||||
|
|
||||||
|
def test_two_parents_supervise_last_wins(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"supervise": False},
|
||||||
|
p2={"supervise": True},
|
||||||
|
child={"extends": ["p1", "p2"]},
|
||||||
|
)
|
||||||
|
self.assertTrue(m.bottles["child"].supervise)
|
||||||
|
|
||||||
|
def test_child_supervise_overrides_all_parents(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"supervise": True},
|
||||||
|
p2={"supervise": True},
|
||||||
|
child={"extends": ["p1", "p2"], "supervise": False},
|
||||||
|
)
|
||||||
|
self.assertFalse(m.bottles["child"].supervise)
|
||||||
|
|
||||||
|
def test_two_parents_egress_routes_concatenated(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"egress": {"routes": [{"host": "a.example.com"}]}},
|
||||||
|
p2={"egress": {"routes": [{"host": "b.example.com"}]}},
|
||||||
|
child={"extends": ["p1", "p2"]},
|
||||||
|
)
|
||||||
|
hosts = [r.Host for r in m.bottles["child"].egress.routes]
|
||||||
|
self.assertEqual(["a.example.com", "b.example.com"], hosts)
|
||||||
|
|
||||||
|
def test_child_egress_appends_after_combined_parents(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"egress": {"routes": [{"host": "a.example.com"}]}},
|
||||||
|
p2={"egress": {"routes": [{"host": "b.example.com"}]}},
|
||||||
|
child={
|
||||||
|
"extends": ["p1", "p2"],
|
||||||
|
"egress": {"routes": [{"host": "c.example.com"}]},
|
||||||
|
},
|
||||||
|
)
|
||||||
|
hosts = [r.Host for r in m.bottles["child"].egress.routes]
|
||||||
|
self.assertEqual(["a.example.com", "b.example.com", "c.example.com"], hosts)
|
||||||
|
|
||||||
|
def test_two_parents_git_repos_union(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"git-gate": {"repos": {"a": self._GIT_A}}},
|
||||||
|
p2={"git-gate": {"repos": {"b": self._GIT_B}}},
|
||||||
|
child={"extends": ["p1", "p2"]},
|
||||||
|
)
|
||||||
|
names = {e.Name for e in m.bottles["child"].git}
|
||||||
|
self.assertEqual({"a", "b"}, names)
|
||||||
|
|
||||||
|
def test_two_parents_git_same_name_later_wins_per_field(self):
|
||||||
|
# Both parents declare the same repo name. p2's `key` wins; p1's
|
||||||
|
# `host_key` is preserved because p2 doesn't override it.
|
||||||
|
p1_entry = {
|
||||||
|
"url": "ssh://git@host-a/repo.git",
|
||||||
|
"host_key": "ecdsa AAAA",
|
||||||
|
"key": {"provider": "static", "path": "/k1"},
|
||||||
|
}
|
||||||
|
p2_entry = {
|
||||||
|
"url": "ssh://git@host-a/repo.git", # required, same url
|
||||||
|
"key": {"provider": "gitea", "forge_token_env": "TOK"},
|
||||||
|
}
|
||||||
|
m = _build(
|
||||||
|
p1={"git-gate": {"repos": {"repo": p1_entry}}},
|
||||||
|
p2={"git-gate": {"repos": {"repo": p2_entry}}},
|
||||||
|
child={"extends": ["p1", "p2"]},
|
||||||
|
)
|
||||||
|
entries = m.bottles["child"].git
|
||||||
|
self.assertEqual(1, len(entries))
|
||||||
|
e = entries[0]
|
||||||
|
self.assertEqual("ssh://git@host-a/repo.git", e.Upstream)
|
||||||
|
self.assertEqual("ecdsa AAAA", e.KnownHostKey)
|
||||||
|
self.assertEqual("gitea", e.Key.provider)
|
||||||
|
|
||||||
|
def test_p1_repos_preserved_when_p2_has_none(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"git-gate": {"repos": {"a": self._GIT_A}}},
|
||||||
|
p2={"env": {"X": "1"}},
|
||||||
|
child={"extends": ["p1", "p2"]},
|
||||||
|
)
|
||||||
|
names = [e.Name for e in m.bottles["child"].git]
|
||||||
|
self.assertEqual(["a"], names)
|
||||||
|
|
||||||
|
def test_diamond_shared_ancestor_resolved_once(self):
|
||||||
|
# a <- b, a <- c; child extends [b, c]
|
||||||
|
# `a` must be resolved once and cached.
|
||||||
|
m = _build(
|
||||||
|
a={"env": {"FROM_A": "1"}, "supervise": False},
|
||||||
|
b={"extends": "a", "env": {"FROM_B": "1"}},
|
||||||
|
c={"extends": "a", "env": {"FROM_C": "1"}},
|
||||||
|
child={"extends": ["b", "c"]},
|
||||||
|
)
|
||||||
|
child = m.bottles["child"]
|
||||||
|
self.assertEqual("1", child.env["FROM_A"])
|
||||||
|
self.assertEqual("1", child.env["FROM_B"])
|
||||||
|
self.assertEqual("1", child.env["FROM_C"])
|
||||||
|
# supervise=False from `a` threads through both b and c; c is the
|
||||||
|
# later parent so its effective supervise (False) wins.
|
||||||
|
self.assertFalse(child.supervise)
|
||||||
|
|
||||||
|
def test_three_parents_env_fold_order(self):
|
||||||
|
m = _build(
|
||||||
|
p1={"env": {"X": "1", "A": "a"}},
|
||||||
|
p2={"env": {"X": "2", "B": "b"}},
|
||||||
|
p3={"env": {"X": "3", "C": "c"}},
|
||||||
|
child={"extends": ["p1", "p2", "p3"]},
|
||||||
|
)
|
||||||
|
env = dict(m.bottles["child"].env)
|
||||||
|
self.assertEqual("3", env["X"])
|
||||||
|
self.assertEqual("a", env["A"])
|
||||||
|
self.assertEqual("b", env["B"])
|
||||||
|
self.assertEqual("c", env["C"])
|
||||||
|
|
||||||
|
def test_undefined_bottle_in_list_dies(self):
|
||||||
|
msg = _error_message(
|
||||||
|
_build,
|
||||||
|
base={"env": {}},
|
||||||
|
child={"extends": ["base", "ghost"]},
|
||||||
|
)
|
||||||
|
self.assertIn("extends 'ghost'", msg)
|
||||||
|
self.assertIn("not defined", msg)
|
||||||
|
|
||||||
|
def test_self_reference_in_list_dies(self):
|
||||||
|
msg = _error_message(_build, child={"extends": ["child"]})
|
||||||
|
self.assertIn("extends itself", msg)
|
||||||
|
|
||||||
|
def test_cycle_through_multi_parent_edge_dies(self):
|
||||||
|
msg = _error_message(
|
||||||
|
_build,
|
||||||
|
a={"extends": ["b", "c"]},
|
||||||
|
b={},
|
||||||
|
c={"extends": "a"},
|
||||||
|
)
|
||||||
|
self.assertIn("extends cycle", msg)
|
||||||
|
|
||||||
|
|
||||||
class TestExtendsAvailableInBottleKeys(unittest.TestCase):
|
class TestExtendsAvailableInBottleKeys(unittest.TestCase):
|
||||||
|
|||||||
@@ -130,7 +130,7 @@ def _capture_print(plan: DockerBottlePlan | SmolmachinesBottlePlan) -> list[str]
|
|||||||
orig = sys.stderr
|
orig = sys.stderr
|
||||||
sys.stderr = buf
|
sys.stderr = buf
|
||||||
try:
|
try:
|
||||||
plan.print()
|
plan.print(remote_control=False)
|
||||||
finally:
|
finally:
|
||||||
sys.stderr = orig
|
sys.stderr = orig
|
||||||
return buf.getvalue().splitlines()
|
return buf.getvalue().splitlines()
|
||||||
|
|||||||
@@ -42,6 +42,7 @@ class _Provider(AgentProvider):
|
|||||||
return AgentProviderRuntime(
|
return AgentProviderRuntime(
|
||||||
template="test", command="test", image="",
|
template="test", command="test", image="",
|
||||||
prompt_mode="append_file", bypass_args=(), resume_args=(),
|
prompt_mode="append_file", bypass_args=(), resume_args=(),
|
||||||
|
remote_control_args=(),
|
||||||
)
|
)
|
||||||
def provision_plan(self, **kwargs): # type: ignore[override]
|
def provision_plan(self, **kwargs): # type: ignore[override]
|
||||||
raise NotImplementedError
|
raise NotImplementedError
|
||||||
|
|||||||
@@ -20,7 +20,6 @@ import supervise as _sv # noqa: E402 # type: ignore
|
|||||||
|
|
||||||
from bot_bottle import supervise_server # noqa: E402
|
from bot_bottle import supervise_server # noqa: E402
|
||||||
from bot_bottle.supervise_server import (
|
from bot_bottle.supervise_server import (
|
||||||
ERR_INTERNAL,
|
|
||||||
ERR_INVALID_PARAMS,
|
ERR_INVALID_PARAMS,
|
||||||
ERR_INVALID_REQUEST,
|
ERR_INVALID_REQUEST,
|
||||||
ERR_METHOD_NOT_FOUND,
|
ERR_METHOD_NOT_FOUND,
|
||||||
@@ -30,9 +29,7 @@ from bot_bottle.supervise_server import (
|
|||||||
PROPOSED_FILE_FIELD,
|
PROPOSED_FILE_FIELD,
|
||||||
ServerConfig,
|
ServerConfig,
|
||||||
TOOL_DEFINITIONS,
|
TOOL_DEFINITIONS,
|
||||||
_RpcClientError,
|
|
||||||
_RpcError,
|
_RpcError,
|
||||||
_RpcInternalError,
|
|
||||||
_response_timeout_from_env,
|
_response_timeout_from_env,
|
||||||
format_response_text,
|
format_response_text,
|
||||||
handle_initialize,
|
handle_initialize,
|
||||||
@@ -50,15 +47,15 @@ from bot_bottle.supervise_server import (
|
|||||||
|
|
||||||
|
|
||||||
class TestValidation(unittest.TestCase):
|
class TestValidation(unittest.TestCase):
|
||||||
|
def test_capability_block_accepts_anything_nonempty(self):
|
||||||
|
validate_proposed_file(
|
||||||
|
_sv.TOOL_CAPABILITY_BLOCK,
|
||||||
|
"FROM python:3.13\nRUN apk add git\n",
|
||||||
|
)
|
||||||
|
|
||||||
def test_empty_proposed_file_rejected_for_tools_with_file_field(self):
|
def test_empty_proposed_file_rejected_for_tools_with_file_field(self):
|
||||||
with self.assertRaises(_RpcError):
|
with self.assertRaises(_RpcError):
|
||||||
validate_proposed_file(_sv.TOOL_EGRESS_ALLOW, " \n\t")
|
validate_proposed_file(_sv.TOOL_CAPABILITY_BLOCK, " \n\t")
|
||||||
|
|
||||||
def test_capability_block_rejected_as_unknown_tool(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
validate_proposed_file("capability-block", "FROM python:3.13\n")
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
self.assertIn("unknown tool", cm.exception.message)
|
|
||||||
|
|
||||||
def test_egress_routes_yaml_is_validated(self):
|
def test_egress_routes_yaml_is_validated(self):
|
||||||
validate_proposed_file(
|
validate_proposed_file(
|
||||||
@@ -70,74 +67,6 @@ class TestValidation(unittest.TestCase):
|
|||||||
with self.assertRaises(_RpcError):
|
with self.assertRaises(_RpcError):
|
||||||
validate_proposed_file(_sv.TOOL_EGRESS_BLOCK, "routes: nope\n")
|
validate_proposed_file(_sv.TOOL_EGRESS_BLOCK, "routes: nope\n")
|
||||||
|
|
||||||
def test_egress_routes_yaml_rejects_log_full(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
validate_proposed_file(
|
|
||||||
_sv.TOOL_EGRESS_ALLOW,
|
|
||||||
"log: 2\nroutes:\n - host: example.com\n",
|
|
||||||
)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
self.assertIn("must not change egress logging", cm.exception.message)
|
|
||||||
|
|
||||||
|
|
||||||
# --- Error taxonomy --------------------------------------------------------
|
|
||||||
|
|
||||||
|
|
||||||
class TestRpcErrorTaxonomy(unittest.TestCase):
|
|
||||||
def test_rpc_client_error_is_rpc_error(self):
|
|
||||||
e = _RpcClientError(ERR_INVALID_PARAMS, "bad param")
|
|
||||||
self.assertIsInstance(e, _RpcError)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, e.code)
|
|
||||||
self.assertEqual("bad param", e.message)
|
|
||||||
|
|
||||||
def test_rpc_internal_error_is_rpc_error(self):
|
|
||||||
e = _RpcInternalError("disk full")
|
|
||||||
self.assertIsInstance(e, _RpcError)
|
|
||||||
self.assertEqual(ERR_INTERNAL, e.code)
|
|
||||||
self.assertEqual("disk full", e.message)
|
|
||||||
|
|
||||||
def test_rpc_internal_error_preserves_cause(self):
|
|
||||||
cause = OSError("no space left on device")
|
|
||||||
try:
|
|
||||||
raise _RpcInternalError("failed to write") from cause
|
|
||||||
except _RpcInternalError as e:
|
|
||||||
self.assertIs(cause, e.__cause__)
|
|
||||||
|
|
||||||
def test_parse_error_is_client_error(self):
|
|
||||||
with self.assertRaises(_RpcClientError):
|
|
||||||
parse_jsonrpc(b"{bad json")
|
|
||||||
|
|
||||||
def test_validation_error_is_client_error(self):
|
|
||||||
with self.assertRaises(_RpcClientError):
|
|
||||||
validate_proposed_file(_sv.TOOL_EGRESS_ALLOW, "routes: nope\n")
|
|
||||||
|
|
||||||
def test_unknown_tool_in_tools_call_is_client_error(self):
|
|
||||||
config = ServerConfig(bottle_slug="dev", queue_dir=Path("/unused"))
|
|
||||||
with self.assertRaises(_RpcClientError) as cm:
|
|
||||||
handle_tools_call({"name": "no-such-tool", "arguments": {}}, config)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
|
|
||||||
|
|
||||||
class TestRpcInternalErrorOnIoFailure(unittest.TestCase):
|
|
||||||
def test_write_proposal_os_error_raises_internal(self):
|
|
||||||
config = ServerConfig(
|
|
||||||
bottle_slug="dev",
|
|
||||||
queue_dir=Path("/dev/null/cannot-exist"),
|
|
||||||
)
|
|
||||||
with self.assertRaises(_RpcInternalError) as cm:
|
|
||||||
handle_tools_call(
|
|
||||||
{
|
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
|
||||||
"arguments": {
|
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
|
||||||
"justification": "x",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
config,
|
|
||||||
)
|
|
||||||
self.assertEqual(ERR_INTERNAL, cm.exception.code)
|
|
||||||
self.assertIsNotNone(cm.exception.__cause__)
|
|
||||||
|
|
||||||
|
|
||||||
# --- JSON-RPC parsing ------------------------------------------------------
|
# --- JSON-RPC parsing ------------------------------------------------------
|
||||||
|
|
||||||
@@ -219,6 +148,7 @@ class TestHandleToolsList(unittest.TestCase):
|
|||||||
self.assertEqual(
|
self.assertEqual(
|
||||||
sorted([
|
sorted([
|
||||||
_sv.TOOL_EGRESS_ALLOW,
|
_sv.TOOL_EGRESS_ALLOW,
|
||||||
|
_sv.TOOL_CAPABILITY_BLOCK,
|
||||||
_sv.TOOL_EGRESS_BLOCK,
|
_sv.TOOL_EGRESS_BLOCK,
|
||||||
_sv.TOOL_LIST_EGRESS_ROUTES,
|
_sv.TOOL_LIST_EGRESS_ROUTES,
|
||||||
]),
|
]),
|
||||||
@@ -294,10 +224,10 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
try:
|
try:
|
||||||
result = handle_tools_call(
|
result = handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_BLOCK,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {
|
"arguments": {
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
"dockerfile": "FROM python:3.13\n",
|
||||||
"justification": "need example.com",
|
"justification": "need git",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
self.config,
|
self.config,
|
||||||
@@ -334,9 +264,9 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
try:
|
try:
|
||||||
result = handle_tools_call(
|
result = handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {
|
"arguments": {
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
"dockerfile": "FROM python:3.13\n",
|
||||||
"justification": "needed for tests",
|
"justification": "needed for tests",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -358,52 +288,20 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
with self.assertRaises(_RpcError):
|
with self.assertRaises(_RpcError):
|
||||||
handle_tools_call(
|
handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {"routes_yaml": "routes:\n - host: example.com\n"},
|
"arguments": {"dockerfile": "FROM python:3.13\n"},
|
||||||
},
|
},
|
||||||
self.config,
|
self.config,
|
||||||
)
|
)
|
||||||
|
|
||||||
def test_missing_name_raises(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
handle_tools_call({"arguments": {}}, self.config)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
|
|
||||||
def test_arguments_must_be_object(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
handle_tools_call(
|
|
||||||
{
|
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
|
||||||
"arguments": [],
|
|
||||||
},
|
|
||||||
self.config,
|
|
||||||
)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
self.assertIn("must be an object", cm.exception.message)
|
|
||||||
|
|
||||||
def test_capability_block_call_raises_unknown_tool(self):
|
|
||||||
with self.assertRaises(_RpcError) as cm:
|
|
||||||
handle_tools_call(
|
|
||||||
{
|
|
||||||
"name": "capability-block",
|
|
||||||
"arguments": {
|
|
||||||
"dockerfile": "FROM python:3.13\n",
|
|
||||||
"justification": "need git",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
self.config,
|
|
||||||
)
|
|
||||||
self.assertEqual(ERR_INVALID_PARAMS, cm.exception.code)
|
|
||||||
self.assertIn("unknown tool", cm.exception.message)
|
|
||||||
|
|
||||||
def test_archives_proposal_after_response(self):
|
def test_archives_proposal_after_response(self):
|
||||||
responder = self._respond_when_proposal_appears(_sv.STATUS_APPROVED)
|
responder = self._respond_when_proposal_appears(_sv.STATUS_APPROVED)
|
||||||
try:
|
try:
|
||||||
handle_tools_call(
|
handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {
|
"arguments": {
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
"dockerfile": "FROM python:3.13\n",
|
||||||
"justification": "x",
|
"justification": "x",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
@@ -425,10 +323,10 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
result = handle_tools_call(
|
result = handle_tools_call(
|
||||||
{
|
{
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
"name": _sv.TOOL_CAPABILITY_BLOCK,
|
||||||
"arguments": {
|
"arguments": {
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
"dockerfile": "FROM python:3.13\n",
|
||||||
"justification": "need egress",
|
"justification": "need a capability",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
config,
|
config,
|
||||||
@@ -443,31 +341,6 @@ class TestHandleToolsCall(unittest.TestCase):
|
|||||||
|
|
||||||
|
|
||||||
class TestHandleListEgressRoutes(unittest.TestCase):
|
class TestHandleListEgressRoutes(unittest.TestCase):
|
||||||
def test_success_returns_body_text(self):
|
|
||||||
class _Resp:
|
|
||||||
def __enter__(self):
|
|
||||||
return self
|
|
||||||
|
|
||||||
def __exit__(self, exc_type: type[BaseException] | None, exc: BaseException | None, tb: object) -> bool:
|
|
||||||
return False
|
|
||||||
|
|
||||||
def read(self):
|
|
||||||
return b"[{\"host\": \"example.com\"}]"
|
|
||||||
|
|
||||||
class _Opener:
|
|
||||||
def open(self, *args, **kwargs): # noqa: ANN001, ANN002, ANN003 # type: ignore
|
|
||||||
return _Resp()
|
|
||||||
|
|
||||||
with patch.object(supervise_server.urllib.request, "build_opener", return_value=_Opener()):
|
|
||||||
result = handle_list_egress_routes(
|
|
||||||
{},
|
|
||||||
ServerConfig(bottle_slug="dev", queue_dir=Path("/unused")),
|
|
||||||
)
|
|
||||||
|
|
||||||
self.assertFalse(result["isError"]) # type: ignore[index]
|
|
||||||
text = result["content"][0]["text"] # type: ignore[index]
|
|
||||||
self.assertIn("example.com", text)
|
|
||||||
|
|
||||||
def test_url_error_returns_tool_error(self):
|
def test_url_error_returns_tool_error(self):
|
||||||
class _Opener:
|
class _Opener:
|
||||||
def open(self, *args, **kwargs): # noqa: ANN001, ANN002, ANN003 # type: ignore
|
def open(self, *args, **kwargs): # noqa: ANN001, ANN002, ANN003 # type: ignore
|
||||||
@@ -527,13 +400,6 @@ class TestFormatResponseText(unittest.TestCase):
|
|||||||
self.assertIn("the operator modified", text.lower())
|
self.assertIn("the operator modified", text.lower())
|
||||||
|
|
||||||
|
|
||||||
class TestFormatPendingResponseText(unittest.TestCase):
|
|
||||||
def test_formats_timeout_message(self):
|
|
||||||
text = supervise_server.format_pending_response_text(12.5)
|
|
||||||
self.assertIn("status: pending", text)
|
|
||||||
self.assertIn("12.5s", text)
|
|
||||||
|
|
||||||
|
|
||||||
# --- End-to-end HTTP sanity ------------------------------------------------
|
# --- End-to-end HTTP sanity ------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
@@ -584,7 +450,7 @@ class TestHttpEndToEnd(unittest.TestCase):
|
|||||||
self.assertEqual("2.0", result["jsonrpc"])
|
self.assertEqual("2.0", result["jsonrpc"])
|
||||||
self.assertEqual(1, result["id"])
|
self.assertEqual(1, result["id"])
|
||||||
names = [t["name"] for t in result["result"]["tools"]] # type: ignore[index]
|
names = [t["name"] for t in result["result"]["tools"]] # type: ignore[index]
|
||||||
self.assertNotIn("capability-block", names)
|
self.assertIn(_sv.TOOL_CAPABILITY_BLOCK, names)
|
||||||
self.assertIn(_sv.TOOL_EGRESS_ALLOW, names)
|
self.assertIn(_sv.TOOL_EGRESS_ALLOW, names)
|
||||||
self.assertIn(_sv.TOOL_EGRESS_BLOCK, names)
|
self.assertIn(_sv.TOOL_EGRESS_BLOCK, names)
|
||||||
|
|
||||||
@@ -594,26 +460,6 @@ class TestHttpEndToEnd(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
self.assertEqual(ERR_METHOD_NOT_FOUND, result["error"]["code"]) # type: ignore[index]
|
self.assertEqual(ERR_METHOD_NOT_FOUND, result["error"]["code"]) # type: ignore[index]
|
||||||
|
|
||||||
def test_internal_error_returns_err_internal_over_http(self):
|
|
||||||
with patch.object(
|
|
||||||
supervise_server._sv, "write_proposal",
|
|
||||||
side_effect=OSError("disk full"),
|
|
||||||
):
|
|
||||||
result = self._post_jsonrpc({
|
|
||||||
"jsonrpc": "2.0",
|
|
||||||
"id": 99,
|
|
||||||
"method": "tools/call",
|
|
||||||
"params": {
|
|
||||||
"name": _sv.TOOL_EGRESS_ALLOW,
|
|
||||||
"arguments": {
|
|
||||||
"routes_yaml": "routes:\n - host: example.com\n",
|
|
||||||
"justification": "x",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
})
|
|
||||||
self.assertIn("error", result)
|
|
||||||
self.assertEqual(ERR_INTERNAL, result["error"]["code"]) # type: ignore[index]
|
|
||||||
|
|
||||||
def test_health_endpoint(self):
|
def test_health_endpoint(self):
|
||||||
conn = http.client.HTTPConnection("127.0.0.1", self.port, timeout=5)
|
conn = http.client.HTTPConnection("127.0.0.1", self.port, timeout=5)
|
||||||
try:
|
try:
|
||||||
|
|||||||
Reference in New Issue
Block a user