Compare commits
6 Commits
a256e5762a
...
main
| Author | SHA1 | Date | |
|---|---|---|---|
| 5970b785aa | |||
| 2f5cf81cf5 | |||
| 4a1e667306 | |||
| b93fe58523 | |||
| 94eca35b4f | |||
| f787764364 |
@@ -5,8 +5,8 @@
|
|||||||
# bot-bottle
|
# bot-bottle
|
||||||
|
|
||||||
[](https://gitea.dideric.is/didericis/bot-bottle/actions?workflow=test.yml)
|
[](https://gitea.dideric.is/didericis/bot-bottle/actions?workflow=test.yml)
|
||||||
[](https://coverage.readthedocs.io/)
|
[](https://coverage.readthedocs.io/)
|
||||||
[](https://gitea.dideric.is/didericis/bot-bottle/src/branch/main/docs/decisions/0004-coverage-policy.md)
|
[](https://gitea.dideric.is/didericis/bot-bottle/src/branch/main/docs/decisions/0004-coverage-policy.md)
|
||||||
|
|
||||||
**Problem:** Developer wants to run a coding agent without supervision, but they don't want a prompt injected or misbehaving agent wrecking their environment or exfiltrating sensitive data.
|
**Problem:** Developer wants to run a coding agent without supervision, but they don't want a prompt injected or misbehaving agent wrecking their environment or exfiltrating sensitive data.
|
||||||
|
|
||||||
|
|||||||
@@ -209,6 +209,15 @@ class AgentProvider(ABC):
|
|||||||
the supervise sidecar is reachable. No-op when
|
the supervise sidecar is reachable. No-op when
|
||||||
`plan.supervise_plan is None`."""
|
`plan.supervise_plan is None`."""
|
||||||
|
|
||||||
|
@abstractmethod
|
||||||
|
def headless_prompt(self, prompt: str) -> list[str]:
|
||||||
|
"""Return the agent CLI args that deliver `prompt` as the
|
||||||
|
initial task in a non-interactive (headless) session.
|
||||||
|
|
||||||
|
Called only when ``--prompt`` is passed to
|
||||||
|
``./cli.py start --headless``; the returned args are appended
|
||||||
|
after the provider's ``bypass_args`` and ``startup_args``."""
|
||||||
|
|
||||||
def provision_ca(self, bottle: "Bottle", plan: "BottlePlan") -> None:
|
def provision_ca(self, bottle: "Bottle", plan: "BottlePlan") -> None:
|
||||||
"""Install the egress MITM CA into the agent's trust store.
|
"""Install the egress MITM CA into the agent's trust store.
|
||||||
|
|
||||||
|
|||||||
@@ -37,7 +37,10 @@ from pathlib import Path
|
|||||||
from typing import Callable, Generator
|
from typing import Callable, Generator
|
||||||
|
|
||||||
from ...egress import egress_resolve_token_values
|
from ...egress import egress_resolve_token_values
|
||||||
from ...git_gate import revoke_git_gate_provisioned_keys
|
from ...git_gate import (
|
||||||
|
provision_git_gate_dynamic_keys,
|
||||||
|
revoke_git_gate_provisioned_keys,
|
||||||
|
)
|
||||||
from ...log import info, warn
|
from ...log import info, warn
|
||||||
from . import network as network_mod
|
from . import network as network_mod
|
||||||
from . import util as docker_mod
|
from . import util as docker_mod
|
||||||
@@ -118,6 +121,11 @@ def launch(
|
|||||||
|
|
||||||
git_gate_plan = plan.git_gate_plan
|
git_gate_plan = plan.git_gate_plan
|
||||||
if git_gate_plan.upstreams:
|
if git_gate_plan.upstreams:
|
||||||
|
git_gate_plan = provision_git_gate_dynamic_keys(
|
||||||
|
plan.manifest.bottle,
|
||||||
|
git_gate_plan,
|
||||||
|
git_gate_state_dir(plan.slug),
|
||||||
|
)
|
||||||
git_gate_plan = dataclasses.replace(
|
git_gate_plan = dataclasses.replace(
|
||||||
git_gate_plan,
|
git_gate_plan,
|
||||||
internal_network=internal_network,
|
internal_network=internal_network,
|
||||||
|
|||||||
@@ -28,7 +28,10 @@ from ...egress import (
|
|||||||
egress_resolve_token_values,
|
egress_resolve_token_values,
|
||||||
egress_sidecar_env_entries,
|
egress_sidecar_env_entries,
|
||||||
)
|
)
|
||||||
from ...git_gate import revoke_git_gate_provisioned_keys
|
from ...git_gate import (
|
||||||
|
provision_git_gate_dynamic_keys,
|
||||||
|
revoke_git_gate_provisioned_keys,
|
||||||
|
)
|
||||||
from ...log import die, info, warn
|
from ...log import die, info, warn
|
||||||
from ...supervise import QUEUE_DIR_IN_CONTAINER, SUPERVISE_PORT
|
from ...supervise import QUEUE_DIR_IN_CONTAINER, SUPERVISE_PORT
|
||||||
from ...util import expand_tilde
|
from ...util import expand_tilde
|
||||||
@@ -98,6 +101,8 @@ def launch(
|
|||||||
egress_network = egress_network_name(plan.slug)
|
egress_network = egress_network_name(plan.slug)
|
||||||
_create_networks(internal_network, egress_network, stack)
|
_create_networks(internal_network, egress_network, stack)
|
||||||
|
|
||||||
|
plan = _provision_git_gate_keys(plan)
|
||||||
|
|
||||||
sidecar_name = sidecar_container_name(plan.slug)
|
sidecar_name = sidecar_container_name(plan.slug)
|
||||||
container_mod.force_remove_container(sidecar_name)
|
container_mod.force_remove_container(sidecar_name)
|
||||||
_start_sidecar_bundle(plan, sidecar_name, internal_network, egress_network)
|
_start_sidecar_bundle(plan, sidecar_name, internal_network, egress_network)
|
||||||
@@ -241,6 +246,19 @@ def _stamp_agent_urls(
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _provision_git_gate_keys(
|
||||||
|
plan: MacosContainerBottlePlan,
|
||||||
|
) -> MacosContainerBottlePlan:
|
||||||
|
if not plan.git_gate_plan.upstreams:
|
||||||
|
return plan
|
||||||
|
git_gate_plan = provision_git_gate_dynamic_keys(
|
||||||
|
plan.manifest.bottle,
|
||||||
|
plan.git_gate_plan,
|
||||||
|
git_gate_state_dir(plan.slug),
|
||||||
|
)
|
||||||
|
return dataclasses.replace(plan, git_gate_plan=git_gate_plan)
|
||||||
|
|
||||||
|
|
||||||
def _stage_git_gate(plan: MacosContainerBottlePlan, sidecar_name: str) -> None:
|
def _stage_git_gate(plan: MacosContainerBottlePlan, sidecar_name: str) -> None:
|
||||||
gp = plan.git_gate_plan
|
gp = plan.git_gate_plan
|
||||||
if not gp.upstreams:
|
if not gp.upstreams:
|
||||||
|
|||||||
@@ -41,7 +41,10 @@ from ..docker.git_gate import (
|
|||||||
GIT_GATE_ENTRYPOINT_IN_CONTAINER,
|
GIT_GATE_ENTRYPOINT_IN_CONTAINER,
|
||||||
GIT_GATE_HOOK_IN_CONTAINER,
|
GIT_GATE_HOOK_IN_CONTAINER,
|
||||||
)
|
)
|
||||||
from ...git_gate import revoke_git_gate_provisioned_keys
|
from ...git_gate import (
|
||||||
|
provision_git_gate_dynamic_keys,
|
||||||
|
revoke_git_gate_provisioned_keys,
|
||||||
|
)
|
||||||
from ...log import info, warn
|
from ...log import info, warn
|
||||||
from ...bottle_state import (
|
from ...bottle_state import (
|
||||||
egress_state_dir,
|
egress_state_dir,
|
||||||
@@ -174,6 +177,7 @@ def _start_bundle(
|
|||||||
) -> SmolmachinesBottlePlan:
|
) -> SmolmachinesBottlePlan:
|
||||||
"""Build the BundleLaunchSpec, resolve token env, start the
|
"""Build the BundleLaunchSpec, resolve token env, start the
|
||||||
sidecar bundle container, and register teardown."""
|
sidecar bundle container, and register teardown."""
|
||||||
|
plan = _provision_git_gate_keys(plan)
|
||||||
bundle_spec = _bundle_launch_spec(plan, network, loopback_ip)
|
bundle_spec = _bundle_launch_spec(plan, network, loopback_ip)
|
||||||
token_env = _resolve_token_env(plan, dict(os.environ))
|
token_env = _resolve_token_env(plan, dict(os.environ))
|
||||||
_bundle.ensure_bundle_image(bundle_spec.image)
|
_bundle.ensure_bundle_image(bundle_spec.image)
|
||||||
@@ -182,6 +186,19 @@ def _start_bundle(
|
|||||||
return plan
|
return plan
|
||||||
|
|
||||||
|
|
||||||
|
def _provision_git_gate_keys(
|
||||||
|
plan: SmolmachinesBottlePlan,
|
||||||
|
) -> SmolmachinesBottlePlan:
|
||||||
|
if not plan.git_gate_plan.upstreams:
|
||||||
|
return plan
|
||||||
|
git_gate_plan = provision_git_gate_dynamic_keys(
|
||||||
|
plan.manifest.bottle,
|
||||||
|
plan.git_gate_plan,
|
||||||
|
git_gate_state_dir(plan.slug),
|
||||||
|
)
|
||||||
|
return dataclasses.replace(plan, git_gate_plan=git_gate_plan)
|
||||||
|
|
||||||
|
|
||||||
def _discover_urls(
|
def _discover_urls(
|
||||||
plan: SmolmachinesBottlePlan,
|
plan: SmolmachinesBottlePlan,
|
||||||
loopback_ip: str,
|
loopback_ip: str,
|
||||||
|
|||||||
+142
-7
@@ -2,6 +2,11 @@
|
|||||||
interactive claude-code session. The container is torn down when the
|
interactive claude-code session. The container is torn down when the
|
||||||
session ends.
|
session ends.
|
||||||
|
|
||||||
|
`--headless` selects a non-interactive launch (agent/bottles/label from
|
||||||
|
flags, no TUI selectors, no y/N prompt) for orchestrators,
|
||||||
|
CI, and webhook dispatch. The agent still execs on the inherited
|
||||||
|
stdio/PTY, so an orchestrator that allocates the PTY drives the session.
|
||||||
|
|
||||||
The launch core is shared with `cli.py resume <identity>` through
|
The launch core is shared with `cli.py resume <identity>` through
|
||||||
the private orchestrator `_launch_bottle`.
|
the private orchestrator `_launch_bottle`.
|
||||||
"""
|
"""
|
||||||
@@ -16,7 +21,7 @@ import tempfile
|
|||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
from typing import Callable
|
from typing import Callable
|
||||||
|
|
||||||
from ..agent_provider import runtime_for
|
from ..agent_provider import get_provider, runtime_for
|
||||||
from ..backend import (
|
from ..backend import (
|
||||||
Bottle,
|
Bottle,
|
||||||
BottleSpec,
|
BottleSpec,
|
||||||
@@ -31,7 +36,7 @@ from ..bottle_state import (
|
|||||||
is_preserved,
|
is_preserved,
|
||||||
mark_preserved,
|
mark_preserved,
|
||||||
)
|
)
|
||||||
from ..log import info
|
from ..log import info, die
|
||||||
from ..manifest import Manifest, ManifestIndex
|
from ..manifest import Manifest, ManifestIndex
|
||||||
from ._common import PROG, USER_CWD, read_tty_line
|
from ._common import PROG, USER_CWD, read_tty_line
|
||||||
from . import tui
|
from . import tui
|
||||||
@@ -50,6 +55,39 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
"or host auto-selection). Overrides the env var when set."
|
"or host auto-selection). Overrides the env var when set."
|
||||||
),
|
),
|
||||||
)
|
)
|
||||||
|
parser.add_argument(
|
||||||
|
"--headless",
|
||||||
|
action="store_true",
|
||||||
|
help=(
|
||||||
|
"non-interactive launch: take agent/bottles/label from flags, "
|
||||||
|
"skip all prompts. For orchestrators, CI, and webhooks."
|
||||||
|
),
|
||||||
|
)
|
||||||
|
parser.add_argument(
|
||||||
|
"--bottle",
|
||||||
|
action="append",
|
||||||
|
default=None,
|
||||||
|
metavar="NAME",
|
||||||
|
help=(
|
||||||
|
"bottle to compose, repeatable (order = merge order). In "
|
||||||
|
"--headless, defaults to the agent's own bottle when omitted."
|
||||||
|
),
|
||||||
|
)
|
||||||
|
parser.add_argument(
|
||||||
|
"--label",
|
||||||
|
default=None,
|
||||||
|
help="bottle label / terminal title (--headless default: agent name)",
|
||||||
|
)
|
||||||
|
parser.add_argument(
|
||||||
|
"--color",
|
||||||
|
default=None,
|
||||||
|
help="bottle color, one of the 16 ANSI color names (--headless default: none)",
|
||||||
|
)
|
||||||
|
parser.add_argument(
|
||||||
|
"--prompt",
|
||||||
|
default=None,
|
||||||
|
help="initial task prompt delivered to the agent (required with --headless)",
|
||||||
|
)
|
||||||
parser.add_argument(
|
parser.add_argument(
|
||||||
"name",
|
"name",
|
||||||
nargs="?",
|
nargs="?",
|
||||||
@@ -61,6 +99,12 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
dry_run = args.dry_run or os.environ.get("BOT_BOTTLE_DRY_RUN") == "1"
|
dry_run = args.dry_run or os.environ.get("BOT_BOTTLE_DRY_RUN") == "1"
|
||||||
|
|
||||||
manifest = ManifestIndex.resolve(USER_CWD)
|
manifest = ManifestIndex.resolve(USER_CWD)
|
||||||
|
backend_name: str | None = args.backend
|
||||||
|
|
||||||
|
if args.headless:
|
||||||
|
return _start_headless(
|
||||||
|
manifest, args, dry_run=dry_run, backend_name=backend_name
|
||||||
|
)
|
||||||
|
|
||||||
agent_name: str | None = args.name
|
agent_name: str | None = args.name
|
||||||
if agent_name is None:
|
if agent_name is None:
|
||||||
@@ -71,8 +115,6 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
if agent_name is None:
|
if agent_name is None:
|
||||||
return 0
|
return 0
|
||||||
|
|
||||||
backend_name: str | None = args.backend
|
|
||||||
|
|
||||||
# Bottle multiselect: always show after agent selection so operators
|
# Bottle multiselect: always show after agent selection so operators
|
||||||
# can compose bottles at launch time without editing agent manifests.
|
# can compose bottles at launch time without editing agent manifests.
|
||||||
available_bottles = manifest.all_bottle_names
|
available_bottles = manifest.all_bottle_names
|
||||||
@@ -109,6 +151,83 @@ def cmd_start(argv: list[str]) -> int:
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
# --- Headless launch -----------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _start_headless(
|
||||||
|
manifest: ManifestIndex,
|
||||||
|
args: argparse.Namespace,
|
||||||
|
*,
|
||||||
|
dry_run: bool,
|
||||||
|
backend_name: str | None,
|
||||||
|
) -> int:
|
||||||
|
"""Non-interactive launch path for orchestrators / CI / webhooks.
|
||||||
|
|
||||||
|
Resolves agent, bottles, label, and color from flags + manifest
|
||||||
|
defaults instead of the TUI selectors, and auto-confirms the
|
||||||
|
preflight. Otherwise runs the same launch core as the interactive
|
||||||
|
path, so the agent still execs on the inherited stdio/PTY — an
|
||||||
|
orchestrator allocates that PTY and relays it to its
|
||||||
|
desktop/mobile clients."""
|
||||||
|
agent_name = args.name
|
||||||
|
if not agent_name:
|
||||||
|
die("--headless requires an agent name: ./cli.py start <agent> --headless")
|
||||||
|
manifest.require_agent(agent_name) # raises ManifestError if unknown
|
||||||
|
|
||||||
|
prompt = args.prompt
|
||||||
|
if not prompt:
|
||||||
|
die(
|
||||||
|
"--headless requires --prompt: "
|
||||||
|
"./cli.py start <agent> --headless --prompt 'Do the thing'"
|
||||||
|
)
|
||||||
|
|
||||||
|
if args.bottle:
|
||||||
|
bottle_names: tuple[str, ...] = tuple(args.bottle)
|
||||||
|
else:
|
||||||
|
default_bottle = _peek_agent_bottle(manifest, agent_name)
|
||||||
|
if not default_bottle:
|
||||||
|
die(
|
||||||
|
f"--headless: agent '{agent_name}' has no default bottle; "
|
||||||
|
f"pass one or more --bottle NAME"
|
||||||
|
)
|
||||||
|
bottle_names = (default_bottle,)
|
||||||
|
|
||||||
|
label = _uniquify_label_headless(args.label or agent_name)
|
||||||
|
|
||||||
|
spec = BottleSpec(
|
||||||
|
manifest=manifest,
|
||||||
|
agent_name=agent_name,
|
||||||
|
copy_cwd=args.cwd,
|
||||||
|
user_cwd=USER_CWD,
|
||||||
|
label=label,
|
||||||
|
color=args.color or "",
|
||||||
|
bottle_names=bottle_names,
|
||||||
|
)
|
||||||
|
return _launch_bottle(
|
||||||
|
spec,
|
||||||
|
dry_run=dry_run,
|
||||||
|
backend_name=backend_name,
|
||||||
|
assume_yes=True,
|
||||||
|
headless_prompt_text=prompt,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _uniquify_label_headless(label: str) -> str:
|
||||||
|
"""Non-interactive analog of `_resolve_unique_label`: if the label's
|
||||||
|
slug collides with a running bottle, append -2, -3, … until free,
|
||||||
|
logging the chosen label. Orchestrators fire-and-forget many bottles,
|
||||||
|
so silently picking a free name beats erroring on every collision."""
|
||||||
|
active_slugs = {a.slug for a in enumerate_active_agents()}
|
||||||
|
if docker_mod.slugify(label) not in active_slugs:
|
||||||
|
return label
|
||||||
|
n = 2
|
||||||
|
while docker_mod.slugify(f"{label}-{n}") in active_slugs:
|
||||||
|
n += 1
|
||||||
|
chosen = f"{label}-{n}"
|
||||||
|
info(f"label '{label}' already in use; using '{chosen}'")
|
||||||
|
return chosen
|
||||||
|
|
||||||
|
|
||||||
# --- Launch helpers ------------------------------------------------------
|
# --- Launch helpers ------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
@@ -376,10 +495,19 @@ def _launch_bottle(
|
|||||||
*,
|
*,
|
||||||
dry_run: bool,
|
dry_run: bool,
|
||||||
backend_name: str | None = None,
|
backend_name: str | None = None,
|
||||||
|
assume_yes: bool = False,
|
||||||
|
headless_prompt_text: str = "",
|
||||||
) -> int:
|
) -> int:
|
||||||
"""Shared launch core for `start` and `resume`. Builds the plan,
|
"""Shared launch core for `start` and `resume`. Builds the plan,
|
||||||
prints / dry-runs / prompts as appropriate, brings the bottle up,
|
prints / dry-runs / prompts as appropriate, brings the bottle up,
|
||||||
attaches claude, and prints the resume hint on session end."""
|
attaches claude, and prints the resume hint on session end.
|
||||||
|
|
||||||
|
`assume_yes` skips the interactive y/N confirmation (headless /
|
||||||
|
orchestrator launches), where there is no human at the prompt.
|
||||||
|
|
||||||
|
`headless_prompt_text` is passed to the provider's `headless_prompt`
|
||||||
|
method and the resulting args are appended to startup_args so the
|
||||||
|
agent receives the initial task without interactive input."""
|
||||||
stage_dir = Path(tempfile.mkdtemp(prefix="bot-bottle-stage."))
|
stage_dir = Path(tempfile.mkdtemp(prefix="bot-bottle-stage."))
|
||||||
identity = ""
|
identity = ""
|
||||||
try:
|
try:
|
||||||
@@ -387,7 +515,7 @@ def _launch_bottle(
|
|||||||
spec,
|
spec,
|
||||||
stage_dir=stage_dir,
|
stage_dir=stage_dir,
|
||||||
render_preflight=_text_render_preflight(),
|
render_preflight=_text_render_preflight(),
|
||||||
prompt_yes=_text_prompt_yes,
|
prompt_yes=(lambda: True) if assume_yes else _text_prompt_yes,
|
||||||
dry_run=dry_run,
|
dry_run=dry_run,
|
||||||
backend_name=backend_name,
|
backend_name=backend_name,
|
||||||
)
|
)
|
||||||
@@ -397,10 +525,17 @@ def _launch_bottle(
|
|||||||
backend = get_bottle_backend(backend_name)
|
backend = get_bottle_backend(backend_name)
|
||||||
with backend.launch(plan) as bottle:
|
with backend.launch(plan) as bottle:
|
||||||
agent_provider_template = getattr(plan, "agent_provider_template", "claude")
|
agent_provider_template = getattr(plan, "agent_provider_template", "claude")
|
||||||
|
extra_args: tuple[str, ...] = ()
|
||||||
|
if headless_prompt_text:
|
||||||
|
extra_args = tuple(
|
||||||
|
get_provider(agent_provider_template).headless_prompt(
|
||||||
|
headless_prompt_text
|
||||||
|
)
|
||||||
|
)
|
||||||
exit_code = attach_agent(
|
exit_code = attach_agent(
|
||||||
bottle,
|
bottle,
|
||||||
agent_provider_template=agent_provider_template,
|
agent_provider_template=agent_provider_template,
|
||||||
startup_args=plan.agent_provision.startup_args,
|
startup_args=plan.agent_provision.startup_args + extra_args,
|
||||||
)
|
)
|
||||||
info(
|
info(
|
||||||
f"session ended (exit {exit_code}); "
|
f"session ended (exit {exit_code}); "
|
||||||
|
|||||||
@@ -217,7 +217,7 @@ class ClaudeAgentProvider(AgentProvider):
|
|||||||
if not agent.skills:
|
if not agent.skills:
|
||||||
return
|
return
|
||||||
skills_dir = _skills_dir(plan.guest_home)
|
skills_dir = _skills_dir(plan.guest_home)
|
||||||
bottle.exec(f"mkdir -p {skills_dir}", user="root")
|
bottle.exec(f"mkdir -p {shlex.quote(skills_dir)}", user="root")
|
||||||
for name in agent.skills:
|
for name in agent.skills:
|
||||||
src = host_skill_dir(name)
|
src = host_skill_dir(name)
|
||||||
if not os.path.isdir(src):
|
if not os.path.isdir(src):
|
||||||
@@ -227,9 +227,13 @@ class ClaudeAgentProvider(AgentProvider):
|
|||||||
)
|
)
|
||||||
dst = f"{skills_dir}/{name}"
|
dst = f"{skills_dir}/{name}"
|
||||||
info(f"copying skill {name} into {bottle.name}:{dst}")
|
info(f"copying skill {name} into {bottle.name}:{dst}")
|
||||||
bottle.exec(f"rm -rf {dst} && mkdir -p {dst}", user="root")
|
# Defense in depth: skill names are validated kebab-case at
|
||||||
|
# manifest load, but quote the path so a future unvalidated
|
||||||
|
# field can't inject shell metacharacters here either.
|
||||||
|
dst_q = shlex.quote(dst)
|
||||||
|
bottle.exec(f"rm -rf {dst_q} && mkdir -p {dst_q}", user="root")
|
||||||
bottle.cp_in(f"{src}/.", f"{dst}/")
|
bottle.cp_in(f"{src}/.", f"{dst}/")
|
||||||
bottle.exec(f"chown -R node:node {dst}", user="root")
|
bottle.exec(f"chown -R node:node {dst_q}", user="root")
|
||||||
|
|
||||||
def provision_prompt(self, plan: "BottlePlan", bottle: "Bottle") -> str | None:
|
def provision_prompt(self, plan: "BottlePlan", bottle: "Bottle") -> str | None:
|
||||||
"""Copy the prompt file into the guest, fix ownership/mode.
|
"""Copy the prompt file into the guest, fix ownership/mode.
|
||||||
@@ -309,6 +313,9 @@ class ClaudeAgentProvider(AgentProvider):
|
|||||||
f"claude mcp add --scope user --transport http supervise {supervise_url}"
|
f"claude mcp add --scope user --transport http supervise {supervise_url}"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
def headless_prompt(self, prompt: str) -> list[str]:
|
||||||
|
return ["-p", prompt]
|
||||||
|
|
||||||
|
|
||||||
def _exec(bottle: "Bottle", script: str, error: str) -> None:
|
def _exec(bottle: "Bottle", script: str, error: str) -> None:
|
||||||
result = bottle.exec(script, user="root")
|
result = bottle.exec(script, user="root")
|
||||||
|
|||||||
@@ -183,7 +183,7 @@ class CodexAgentProvider(AgentProvider):
|
|||||||
if not agent.skills:
|
if not agent.skills:
|
||||||
return
|
return
|
||||||
skills_dir = _skills_dir(plan.guest_home)
|
skills_dir = _skills_dir(plan.guest_home)
|
||||||
bottle.exec(f"mkdir -p {skills_dir}", user="root")
|
bottle.exec(f"mkdir -p {shlex.quote(skills_dir)}", user="root")
|
||||||
for name in agent.skills:
|
for name in agent.skills:
|
||||||
src = host_skill_dir(name)
|
src = host_skill_dir(name)
|
||||||
if not os.path.isdir(src):
|
if not os.path.isdir(src):
|
||||||
@@ -193,9 +193,13 @@ class CodexAgentProvider(AgentProvider):
|
|||||||
)
|
)
|
||||||
dst = f"{skills_dir}/{name}"
|
dst = f"{skills_dir}/{name}"
|
||||||
info(f"copying skill {name} into {bottle.name}:{dst}")
|
info(f"copying skill {name} into {bottle.name}:{dst}")
|
||||||
bottle.exec(f"rm -rf {dst} && mkdir -p {dst}", user="root")
|
# Defense in depth: skill names are validated kebab-case at
|
||||||
|
# manifest load, but quote the path so a future unvalidated
|
||||||
|
# field can't inject shell metacharacters here either.
|
||||||
|
dst_q = shlex.quote(dst)
|
||||||
|
bottle.exec(f"rm -rf {dst_q} && mkdir -p {dst_q}", user="root")
|
||||||
bottle.cp_in(f"{src}/.", f"{dst}/")
|
bottle.cp_in(f"{src}/.", f"{dst}/")
|
||||||
bottle.exec(f"chown -R node:node {dst}", user="root")
|
bottle.exec(f"chown -R node:node {dst_q}", user="root")
|
||||||
|
|
||||||
def provision_prompt(self, plan: "BottlePlan", bottle: "Bottle") -> str | None:
|
def provision_prompt(self, plan: "BottlePlan", bottle: "Bottle") -> str | None:
|
||||||
"""Copy the prompt file into the guest, fix ownership/mode.
|
"""Copy the prompt file into the guest, fix ownership/mode.
|
||||||
@@ -275,6 +279,9 @@ class CodexAgentProvider(AgentProvider):
|
|||||||
f"codex mcp add supervise --url {shlex.quote(supervise_url)}"
|
f"codex mcp add supervise --url {shlex.quote(supervise_url)}"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
def headless_prompt(self, prompt: str) -> list[str]:
|
||||||
|
return [prompt]
|
||||||
|
|
||||||
|
|
||||||
def _exec(bottle: "Bottle", script: str, error: str) -> None:
|
def _exec(bottle: "Bottle", script: str, error: str) -> None:
|
||||||
result = bottle.exec(script, user="root")
|
result = bottle.exec(script, user="root")
|
||||||
|
|||||||
@@ -238,7 +238,7 @@ class PiAgentProvider(AgentProvider):
|
|||||||
if not agent.skills:
|
if not agent.skills:
|
||||||
return
|
return
|
||||||
skills_dir = _skills_dir(plan.guest_home)
|
skills_dir = _skills_dir(plan.guest_home)
|
||||||
bottle.exec(f"mkdir -p {skills_dir}", user="root")
|
bottle.exec(f"mkdir -p {shlex.quote(skills_dir)}", user="root")
|
||||||
for name in agent.skills:
|
for name in agent.skills:
|
||||||
src = host_skill_dir(name)
|
src = host_skill_dir(name)
|
||||||
if not os.path.isdir(src):
|
if not os.path.isdir(src):
|
||||||
@@ -248,9 +248,13 @@ class PiAgentProvider(AgentProvider):
|
|||||||
)
|
)
|
||||||
dst = f"{skills_dir}/{name}"
|
dst = f"{skills_dir}/{name}"
|
||||||
info(f"copying skill {name} into {bottle.name}:{dst}")
|
info(f"copying skill {name} into {bottle.name}:{dst}")
|
||||||
bottle.exec(f"rm -rf {dst} && mkdir -p {dst}", user="root")
|
# Defense in depth: skill names are validated kebab-case at
|
||||||
|
# manifest load, but quote the path so a future unvalidated
|
||||||
|
# field can't inject shell metacharacters here either.
|
||||||
|
dst_q = shlex.quote(dst)
|
||||||
|
bottle.exec(f"rm -rf {dst_q} && mkdir -p {dst_q}", user="root")
|
||||||
bottle.cp_in(f"{src}/.", f"{dst}/")
|
bottle.cp_in(f"{src}/.", f"{dst}/")
|
||||||
bottle.exec(f"chown -R node:node {dst}", user="root")
|
bottle.exec(f"chown -R node:node {dst_q}", user="root")
|
||||||
|
|
||||||
def provision_prompt(self, plan: "BottlePlan", bottle: "Bottle") -> str | None:
|
def provision_prompt(self, plan: "BottlePlan", bottle: "Bottle") -> str | None:
|
||||||
prompt_path = _prompt_path(plan.guest_home)
|
prompt_path = _prompt_path(plan.guest_home)
|
||||||
@@ -311,6 +315,9 @@ class PiAgentProvider(AgentProvider):
|
|||||||
) -> None:
|
) -> None:
|
||||||
del plan, bottle, supervise_url
|
del plan, bottle, supervise_url
|
||||||
|
|
||||||
|
def headless_prompt(self, prompt: str) -> list[str]:
|
||||||
|
return ["-p", prompt]
|
||||||
|
|
||||||
|
|
||||||
def _exec(bottle: "Bottle", script: str, error: str) -> None:
|
def _exec(bottle: "Bottle", script: str, error: str) -> None:
|
||||||
result = bottle.exec(script, user="root")
|
result = bottle.exec(script, user="root")
|
||||||
|
|||||||
+6
-11
@@ -30,7 +30,6 @@ backend-specific and lives on concrete subclasses (see
|
|||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|
||||||
import dataclasses
|
|
||||||
from abc import ABC
|
from abc import ABC
|
||||||
from dataclasses import dataclass
|
from dataclasses import dataclass
|
||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
@@ -53,6 +52,7 @@ from .git_gate_render import (
|
|||||||
_gitconfig_validate_value,
|
_gitconfig_validate_value,
|
||||||
)
|
)
|
||||||
from .git_gate_provision import (
|
from .git_gate_provision import (
|
||||||
|
provision_git_gate_dynamic_keys,
|
||||||
revoke_git_gate_provisioned_keys,
|
revoke_git_gate_provisioned_keys,
|
||||||
_provision_dynamic_key,
|
_provision_dynamic_key,
|
||||||
_resolve_identity_file,
|
_resolve_identity_file,
|
||||||
@@ -93,20 +93,14 @@ class GitGate(ABC):
|
|||||||
entrypoint, pre-receive hook, and access-hook scripts (mode
|
entrypoint, pre-receive hook, and access-hook scripts (mode
|
||||||
600) under `stage_dir`. Pure host-side, no docker subprocess.
|
600) under `stage_dir`. Pure host-side, no docker subprocess.
|
||||||
|
|
||||||
For `gitea` key entries, also generates and registers
|
For `gitea` key entries, the returned upstream intentionally
|
||||||
a fresh deploy key via the forge API and writes the private key
|
has an empty identity file. Backend launch fills that in after
|
||||||
+ key ID to `stage_dir`.
|
the operator confirms the preflight.
|
||||||
|
|
||||||
Returned plan is incomplete: the launch step must fill
|
Returned plan is incomplete: the launch step must fill
|
||||||
`internal_network` / `egress_network` via `dataclasses.replace`
|
`internal_network` / `egress_network` via `dataclasses.replace`
|
||||||
before passing the plan to `.start`."""
|
before passing the plan to `.start`."""
|
||||||
upstreams_list = list(git_gate_upstreams_for_bottle(bottle))
|
upstreams = git_gate_upstreams_for_bottle(bottle)
|
||||||
for i, entry in enumerate(bottle.git):
|
|
||||||
upstreams_list[i] = dataclasses.replace(
|
|
||||||
upstreams_list[i],
|
|
||||||
identity_file=_resolve_identity_file(entry, slug, stage_dir),
|
|
||||||
)
|
|
||||||
upstreams = tuple(upstreams_list)
|
|
||||||
entrypoint = stage_dir / "git_gate_entrypoint.sh"
|
entrypoint = stage_dir / "git_gate_entrypoint.sh"
|
||||||
entrypoint.write_text(git_gate_render_entrypoint(upstreams))
|
entrypoint.write_text(git_gate_render_entrypoint(upstreams))
|
||||||
entrypoint.chmod(0o600)
|
entrypoint.chmod(0o600)
|
||||||
@@ -162,6 +156,7 @@ __all__ = [
|
|||||||
"git_gate_render_entrypoint",
|
"git_gate_render_entrypoint",
|
||||||
"git_gate_render_hook",
|
"git_gate_render_hook",
|
||||||
"git_gate_render_access_hook",
|
"git_gate_render_access_hook",
|
||||||
|
"provision_git_gate_dynamic_keys",
|
||||||
"revoke_git_gate_provisioned_keys",
|
"revoke_git_gate_provisioned_keys",
|
||||||
"_gitconfig_validate_value",
|
"_gitconfig_validate_value",
|
||||||
"_provision_dynamic_key",
|
"_provision_dynamic_key",
|
||||||
|
|||||||
@@ -9,10 +9,16 @@ imported (`deploy_key_provisioner`) to keep its cost off the host path.
|
|||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|
||||||
import os
|
import os
|
||||||
|
import dataclasses
|
||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
|
from typing import TYPE_CHECKING
|
||||||
|
|
||||||
from .log import info
|
from .log import info
|
||||||
from .manifest import ManifestBottle, ManifestGitEntry
|
from .manifest import ManifestBottle, ManifestGitEntry
|
||||||
|
from .git_gate_render import GitGateUpstream
|
||||||
|
|
||||||
|
if TYPE_CHECKING:
|
||||||
|
from .git_gate import GitGatePlan
|
||||||
|
|
||||||
def _provision_dynamic_key(
|
def _provision_dynamic_key(
|
||||||
entry: ManifestGitEntry,
|
entry: ManifestGitEntry,
|
||||||
@@ -95,8 +101,45 @@ def _resolve_identity_file(entry: ManifestGitEntry, slug: str, stage_dir: Path)
|
|||||||
return entry.IdentityFile
|
return entry.IdentityFile
|
||||||
|
|
||||||
|
|
||||||
|
def provision_git_gate_dynamic_keys(
|
||||||
|
bottle: ManifestBottle,
|
||||||
|
plan: "GitGatePlan",
|
||||||
|
stage_dir: Path,
|
||||||
|
) -> "GitGatePlan":
|
||||||
|
"""Provision dynamic git-gate keys and return an updated plan.
|
||||||
|
|
||||||
|
This runs during backend launch, after the operator confirms the
|
||||||
|
preflight. Plan preparation intentionally stays side-effect-light:
|
||||||
|
dry-runs and aborted launches must not create remote deploy keys.
|
||||||
|
"""
|
||||||
|
if not plan.upstreams:
|
||||||
|
return plan
|
||||||
|
|
||||||
|
upstreams_by_name: dict[str, GitGateUpstream] = {
|
||||||
|
upstream.name: upstream for upstream in plan.upstreams
|
||||||
|
}
|
||||||
|
updated: list[GitGateUpstream] = []
|
||||||
|
for entry in bottle.git:
|
||||||
|
upstream = upstreams_by_name.get(entry.Name)
|
||||||
|
if upstream is None:
|
||||||
|
continue
|
||||||
|
if entry.Key.provider == "gitea":
|
||||||
|
identity_file = _provision_dynamic_key(entry, plan.slug, stage_dir)
|
||||||
|
upstream = dataclasses.replace(upstream, identity_file=identity_file)
|
||||||
|
updated.append(upstream)
|
||||||
|
|
||||||
|
if len(updated) != len(plan.upstreams):
|
||||||
|
updated_names = {u.name for u in updated}
|
||||||
|
for upstream in plan.upstreams:
|
||||||
|
if upstream.name not in updated_names:
|
||||||
|
updated.append(upstream)
|
||||||
|
|
||||||
|
return dataclasses.replace(plan, upstreams=tuple(updated))
|
||||||
|
|
||||||
|
|
||||||
__all__ = [
|
__all__ = [
|
||||||
"revoke_git_gate_provisioned_keys",
|
"revoke_git_gate_provisioned_keys",
|
||||||
|
"provision_git_gate_dynamic_keys",
|
||||||
"_provision_dynamic_key",
|
"_provision_dynamic_key",
|
||||||
"_resolve_identity_file",
|
"_resolve_identity_file",
|
||||||
]
|
]
|
||||||
|
|||||||
@@ -16,11 +16,16 @@ from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
|
|||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
from urllib.parse import urlsplit
|
from urllib.parse import urlsplit
|
||||||
|
|
||||||
from .git_gate import GIT_GATE_TIMEOUT_SECS
|
|
||||||
|
|
||||||
|
|
||||||
DEFAULT_PORT = 9420
|
DEFAULT_PORT = 9420
|
||||||
|
|
||||||
|
# Mirrors git_gate_render.GIT_GATE_TIMEOUT_SECS. Duplicated rather than
|
||||||
|
# imported: this module ships as a flat top-level sibling in the sidecar
|
||||||
|
# bundle image (see Dockerfile.sidecars), not as part of the bot_bottle
|
||||||
|
# package, so `bot_bottle.git_gate` and its dependency chain aren't
|
||||||
|
# available at runtime.
|
||||||
|
GIT_GATE_TIMEOUT_SECS = 15
|
||||||
|
|
||||||
# Bound memory use while still allowing ordinary git push packfiles.
|
# Bound memory use while still allowing ordinary git push packfiles.
|
||||||
MAX_BODY_BYTES = 100 * 1024 * 1024
|
MAX_BODY_BYTES = 100 * 1024 * 1024
|
||||||
|
|
||||||
|
|||||||
+12
-122
@@ -62,15 +62,25 @@ from dataclasses import dataclass, field, replace
|
|||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
from typing import Mapping
|
from typing import Mapping
|
||||||
|
|
||||||
|
from .log import warn
|
||||||
from .manifest_util import ManifestError, as_json_object
|
from .manifest_util import ManifestError, as_json_object
|
||||||
from .manifest_agent import ManifestAgent, ManifestAgentProvider
|
from .manifest_agent import ManifestAgent, ManifestAgentProvider
|
||||||
|
from .manifest_bottle import ManifestBottle
|
||||||
from .manifest_egress import (
|
from .manifest_egress import (
|
||||||
EGRESS_AUTH_SCHEMES,
|
EGRESS_AUTH_SCHEMES,
|
||||||
ManifestEgressConfig,
|
ManifestEgressConfig,
|
||||||
ManifestEgressRoute,
|
ManifestEgressRoute,
|
||||||
)
|
)
|
||||||
from .manifest_git import ManifestGitEntry, ManifestGitUser, ManifestKeyConfig, parse_git_gate_config
|
from .manifest_extends import merge_bottles_runtime, resolve_bottles
|
||||||
from .manifest_schema import BOTTLE_KEYS
|
from .manifest_git import ManifestGitEntry, ManifestGitUser, ManifestKeyConfig
|
||||||
|
from .manifest_loader import (
|
||||||
|
check_stale_json,
|
||||||
|
load_bottle_chain_from_dir,
|
||||||
|
scan_agent_names,
|
||||||
|
scan_bottle_names,
|
||||||
|
)
|
||||||
|
from .manifest_schema import validate_agent_frontmatter_keys
|
||||||
|
from .yaml_subset import YamlSubsetError, parse_frontmatter
|
||||||
|
|
||||||
# Re-export everything that callers currently import from this module.
|
# Re-export everything that callers currently import from this module.
|
||||||
__all__ = [
|
__all__ = [
|
||||||
@@ -89,10 +99,6 @@ __all__ = [
|
|||||||
]
|
]
|
||||||
|
|
||||||
|
|
||||||
def _empty_str_dict() -> dict[str, str]:
|
|
||||||
return {}
|
|
||||||
|
|
||||||
|
|
||||||
def _section_dict(value: object, label: str) -> dict[str, object]:
|
def _section_dict(value: object, label: str) -> dict[str, object]:
|
||||||
"""Like as_json_object but treats absent/null as an empty section."""
|
"""Like as_json_object but treats absent/null as an empty section."""
|
||||||
if value is None:
|
if value is None:
|
||||||
@@ -100,107 +106,6 @@ def _section_dict(value: object, label: str) -> dict[str, object]:
|
|||||||
return as_json_object(value, label)
|
return as_json_object(value, label)
|
||||||
|
|
||||||
|
|
||||||
@dataclass(frozen=True)
|
|
||||||
class ManifestBottle:
|
|
||||||
env: Mapping[str, str] = field(default_factory=_empty_str_dict)
|
|
||||||
agent_provider: ManifestAgentProvider = field(default_factory=ManifestAgentProvider)
|
|
||||||
git: tuple[ManifestGitEntry, ...] = ()
|
|
||||||
# Per-bottle git identity (issue #86). Empty default — bottles
|
|
||||||
# that don't set `git-gate.user:` in the manifest skip the
|
|
||||||
# `git config --global` step entirely. A bottle can declare a user
|
|
||||||
# identity without any git-gate.repos upstreams, and vice versa.
|
|
||||||
git_user: ManifestGitUser = field(default_factory=ManifestGitUser)
|
|
||||||
egress: ManifestEgressConfig = field(default_factory=ManifestEgressConfig)
|
|
||||||
# Per-bottle stuck-recovery sidecar (PRD 0013). When true (the
|
|
||||||
# default, issue #249), the launch step brings up a supervise
|
|
||||||
# sidecar that exposes egress MCP tools to the agent. Set
|
|
||||||
# `supervise: false` to skip the sidecar.
|
|
||||||
supervise: bool = True
|
|
||||||
|
|
||||||
@classmethod
|
|
||||||
def from_dict(cls, name: str, raw: object) -> "ManifestBottle":
|
|
||||||
d = as_json_object(raw, f"bottle '{name}'")
|
|
||||||
|
|
||||||
if "runtime" in d:
|
|
||||||
raise ManifestError(
|
|
||||||
f"bottle '{name}' has a 'runtime' field, which is no longer "
|
|
||||||
f"supported. gVisor (runsc) is now auto-detected by the "
|
|
||||||
f"backend; remove the 'runtime' field from the bottle "
|
|
||||||
f"definition."
|
|
||||||
)
|
|
||||||
|
|
||||||
if "ssh" in d:
|
|
||||||
raise ManifestError(
|
|
||||||
f"bottle '{name}' has an 'ssh' field, which has been removed "
|
|
||||||
f"(PRD 0009). Declare upstreams under 'git-gate.repos' with "
|
|
||||||
f"url + identity + host_key; the git-gate sidecar (PRD 0008) "
|
|
||||||
f"holds the credential and gitleaks-scans pushes."
|
|
||||||
)
|
|
||||||
|
|
||||||
if "git" in d:
|
|
||||||
raise ManifestError(
|
|
||||||
f"bottle '{name}' uses 'git' which has been replaced by "
|
|
||||||
f"'git-gate' (PRD 0047). Move git.user → git-gate.user "
|
|
||||||
f"and git.remotes → git-gate.repos (fields: url, identity, host_key)."
|
|
||||||
)
|
|
||||||
|
|
||||||
if "git_user" in d:
|
|
||||||
raise ManifestError(
|
|
||||||
f"bottle '{name}' has a 'git_user' field, which has been "
|
|
||||||
f"removed. Move it under 'git-gate.user'."
|
|
||||||
)
|
|
||||||
|
|
||||||
unknown = set(d.keys()) - BOTTLE_KEYS
|
|
||||||
if unknown:
|
|
||||||
allowed = ", ".join(sorted(BOTTLE_KEYS))
|
|
||||||
raise ManifestError(
|
|
||||||
f"bottle '{name}' has unknown key(s) {sorted(unknown)}; "
|
|
||||||
f"allowed keys are {allowed}."
|
|
||||||
)
|
|
||||||
|
|
||||||
env: dict[str, str] = {}
|
|
||||||
env_raw = d.get("env")
|
|
||||||
if env_raw is not None:
|
|
||||||
env_dict = as_json_object(env_raw, f"bottle '{name}' env")
|
|
||||||
for var, value in env_dict.items():
|
|
||||||
if not isinstance(value, str):
|
|
||||||
raise ManifestError(
|
|
||||||
f"env entry {var} in bottle '{name}' must be a JSON string "
|
|
||||||
f"(was {type(value).__name__}). Use \"?<message>\" for prompt-at-runtime."
|
|
||||||
)
|
|
||||||
env[var] = value
|
|
||||||
|
|
||||||
git: tuple[ManifestGitEntry, ...] = ()
|
|
||||||
git_user = ManifestGitUser()
|
|
||||||
git_raw = d.get("git-gate")
|
|
||||||
if git_raw is not None:
|
|
||||||
git, git_user = parse_git_gate_config(name, git_raw)
|
|
||||||
|
|
||||||
agent_provider = (
|
|
||||||
ManifestAgentProvider.from_dict(name, d["agent_provider"])
|
|
||||||
if "agent_provider" in d
|
|
||||||
else ManifestAgentProvider()
|
|
||||||
)
|
|
||||||
|
|
||||||
egress = (
|
|
||||||
ManifestEgressConfig.from_dict(name, d["egress"])
|
|
||||||
if "egress" in d
|
|
||||||
else ManifestEgressConfig()
|
|
||||||
)
|
|
||||||
|
|
||||||
supervise_raw = d.get("supervise", True)
|
|
||||||
if not isinstance(supervise_raw, bool):
|
|
||||||
raise ManifestError(
|
|
||||||
f"bottle '{name}' supervise must be a boolean "
|
|
||||||
f"(was {type(supervise_raw).__name__})"
|
|
||||||
)
|
|
||||||
|
|
||||||
return cls(
|
|
||||||
env=env, agent_provider=agent_provider, git=git,
|
|
||||||
git_user=git_user, egress=egress, supervise=supervise_raw,
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def _merge_git_user(
|
def _merge_git_user(
|
||||||
agent_user: ManifestGitUser, base_user: ManifestGitUser
|
agent_user: ManifestGitUser, base_user: ManifestGitUser
|
||||||
) -> ManifestGitUser:
|
) -> ManifestGitUser:
|
||||||
@@ -237,8 +142,6 @@ def _resolve_effective_bottle_eager(
|
|||||||
|
|
||||||
When bottle_names is non-empty they are merged in order. When empty, falls
|
When bottle_names is non-empty they are merged in order. When empty, falls
|
||||||
back to agent.bottle. Raises ManifestError when neither is set."""
|
back to agent.bottle. Raises ManifestError when neither is set."""
|
||||||
from .manifest_extends import merge_bottles_runtime
|
|
||||||
|
|
||||||
if bottle_names:
|
if bottle_names:
|
||||||
resolved: list[ManifestBottle] = []
|
resolved: list[ManifestBottle] = []
|
||||||
for bn in bottle_names:
|
for bn in bottle_names:
|
||||||
@@ -270,9 +173,6 @@ def _resolve_effective_bottle_lazy(
|
|||||||
When bottle_names is non-empty they are resolved from disk and merged in
|
When bottle_names is non-empty they are resolved from disk and merged in
|
||||||
order. When empty, falls back to agent_bottle. Raises ManifestError when
|
order. When empty, falls back to agent_bottle. Raises ManifestError when
|
||||||
neither is set."""
|
neither is set."""
|
||||||
from .manifest_extends import merge_bottles_runtime
|
|
||||||
from .manifest_loader import load_bottle_chain_from_dir
|
|
||||||
|
|
||||||
if bottle_names:
|
if bottle_names:
|
||||||
resolved = [load_bottle_chain_from_dir(bn, bottles_dir) for bn in bottle_names]
|
resolved = [load_bottle_chain_from_dir(bn, bottles_dir) for bn in bottle_names]
|
||||||
return merge_bottles_runtime(resolved)
|
return merge_bottles_runtime(resolved)
|
||||||
@@ -358,8 +258,6 @@ class ManifestIndex:
|
|||||||
home_md = home_dir / ".bot-bottle"
|
home_md = home_dir / ".bot-bottle"
|
||||||
cwd_md = cwd_dir / ".bot-bottle"
|
cwd_md = cwd_dir / ".bot-bottle"
|
||||||
|
|
||||||
from .manifest_loader import check_stale_json
|
|
||||||
|
|
||||||
check_stale_json(home_dir, home_md, "$HOME")
|
check_stale_json(home_dir, home_md, "$HOME")
|
||||||
if cwd_dir.resolve() != home_dir.resolve():
|
if cwd_dir.resolve() != home_dir.resolve():
|
||||||
check_stale_json(cwd_dir, cwd_md, "$CWD")
|
check_stale_json(cwd_dir, cwd_md, "$CWD")
|
||||||
@@ -399,7 +297,6 @@ class ManifestIndex:
|
|||||||
files = sorted(stale_bottles.glob("*.md"))
|
files = sorted(stale_bottles.glob("*.md"))
|
||||||
if files:
|
if files:
|
||||||
names = ", ".join(p.name for p in files)
|
names = ", ".join(p.name for p in files)
|
||||||
from .log import warn
|
|
||||||
warn(
|
warn(
|
||||||
f"ignoring bottle file(s) under "
|
f"ignoring bottle file(s) under "
|
||||||
f"{stale_bottles}: {names}. Bottles can only "
|
f"{stale_bottles}: {names}. Bottles can only "
|
||||||
@@ -421,7 +318,6 @@ class ManifestIndex:
|
|||||||
raw_bottles: dict[str, dict[str, object]] = {}
|
raw_bottles: dict[str, dict[str, object]] = {}
|
||||||
for n, b in raw_bottles_obj.items():
|
for n, b in raw_bottles_obj.items():
|
||||||
raw_bottles[n] = as_json_object(b, f"bottle '{n}'")
|
raw_bottles[n] = as_json_object(b, f"bottle '{n}'")
|
||||||
from .manifest_extends import resolve_bottles
|
|
||||||
|
|
||||||
bottles = resolve_bottles(raw_bottles)
|
bottles = resolve_bottles(raw_bottles)
|
||||||
|
|
||||||
@@ -439,7 +335,6 @@ class ManifestIndex:
|
|||||||
filenames without reading their content. In eager mode (from
|
filenames without reading their content. In eager mode (from
|
||||||
from_json_obj) it returns the pre-parsed bottles' names."""
|
from_json_obj) it returns the pre-parsed bottles' names."""
|
||||||
if self.home_md is not None:
|
if self.home_md is not None:
|
||||||
from .manifest_loader import scan_bottle_names
|
|
||||||
return scan_bottle_names(self.home_md / "bottles")
|
return scan_bottle_names(self.home_md / "bottles")
|
||||||
return sorted(self.bottles.keys())
|
return sorted(self.bottles.keys())
|
||||||
|
|
||||||
@@ -451,7 +346,6 @@ class ManifestIndex:
|
|||||||
filenames without reading their content. In eager mode (from
|
filenames without reading their content. In eager mode (from
|
||||||
from_json_obj) it returns the pre-parsed agents' names."""
|
from_json_obj) it returns the pre-parsed agents' names."""
|
||||||
if self.home_md is not None:
|
if self.home_md is not None:
|
||||||
from .manifest_loader import scan_agent_names
|
|
||||||
home_names = set(scan_agent_names(self.home_md / "agents").keys())
|
home_names = set(scan_agent_names(self.home_md / "agents").keys())
|
||||||
cwd_names: set[str] = set()
|
cwd_names: set[str] = set()
|
||||||
if self.cwd_md is not None:
|
if self.cwd_md is not None:
|
||||||
@@ -509,10 +403,6 @@ class ManifestIndex:
|
|||||||
"""Lazy path (resolve/from_md_dirs): read and parse the agent file and
|
"""Lazy path (resolve/from_md_dirs): read and parse the agent file and
|
||||||
its bottle chain from disk for the first time here."""
|
its bottle chain from disk for the first time here."""
|
||||||
assert self.home_md is not None # guaranteed by load_for_agent dispatch
|
assert self.home_md is not None # guaranteed by load_for_agent dispatch
|
||||||
from .manifest_loader import scan_agent_names
|
|
||||||
from .manifest_schema import validate_agent_frontmatter_keys
|
|
||||||
from .yaml_subset import YamlSubsetError, parse_frontmatter
|
|
||||||
|
|
||||||
# Locate the agent file; cwd wins over home on name collision.
|
# Locate the agent file; cwd wins over home on name collision.
|
||||||
home_agents = scan_agent_names(self.home_md / "agents")
|
home_agents = scan_agent_names(self.home_md / "agents")
|
||||||
cwd_agents: dict[str, Path] = {}
|
cwd_agents: dict[str, Path] = {}
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ from typing import cast
|
|||||||
from .agent_provider import PROVIDER_TEMPLATES
|
from .agent_provider import PROVIDER_TEMPLATES
|
||||||
from .manifest_util import ManifestError, as_json_object
|
from .manifest_util import ManifestError, as_json_object
|
||||||
from .manifest_git import ManifestGitUser
|
from .manifest_git import ManifestGitUser
|
||||||
from .manifest_schema import AGENT_MODEL_KEYS
|
from .manifest_schema import AGENT_MODEL_KEYS, is_valid_entity_name
|
||||||
|
|
||||||
|
|
||||||
@dataclass(frozen=True)
|
@dataclass(frozen=True)
|
||||||
@@ -161,6 +161,16 @@ class ManifestAgent:
|
|||||||
f"agent '{name}' skills[{i}] must be a string "
|
f"agent '{name}' skills[{i}] must be a string "
|
||||||
f"(was {type(skill).__name__})"
|
f"(was {type(skill).__name__})"
|
||||||
)
|
)
|
||||||
|
# Skill names become host/guest path segments and are
|
||||||
|
# interpolated into provisioning shell commands, so they
|
||||||
|
# must fit the same kebab-case convention as bottle/agent
|
||||||
|
# filenames — rejecting anything that could break out of a
|
||||||
|
# path segment or inject shell metacharacters.
|
||||||
|
if not is_valid_entity_name(skill):
|
||||||
|
raise ManifestError(
|
||||||
|
f"agent '{name}' skills[{i}] {skill!r} is not a valid "
|
||||||
|
f"skill name; must match [a-z][a-z0-9-]*"
|
||||||
|
)
|
||||||
collected.append(skill)
|
collected.append(skill)
|
||||||
skills = tuple(collected)
|
skills = tuple(collected)
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,129 @@
|
|||||||
|
"""The `ManifestBottle` value type.
|
||||||
|
|
||||||
|
Split out of `manifest.py` so the `extends:`/loader resolvers can import it
|
||||||
|
without a circular dependency: `manifest.py` imports those resolvers, while
|
||||||
|
they only need this value type. Everything here depends on leaf modules
|
||||||
|
(`manifest_util`, `manifest_agent`, `manifest_egress`, `manifest_git`,
|
||||||
|
`manifest_schema`), so this module sits at the bottom of the manifest layer.
|
||||||
|
|
||||||
|
`manifest.py` re-exports `ManifestBottle`, so existing
|
||||||
|
`from .manifest import ManifestBottle` callers are unaffected.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from dataclasses import dataclass, field
|
||||||
|
from typing import Mapping
|
||||||
|
|
||||||
|
from .manifest_util import ManifestError, as_json_object
|
||||||
|
from .manifest_agent import ManifestAgentProvider
|
||||||
|
from .manifest_egress import ManifestEgressConfig
|
||||||
|
from .manifest_git import ManifestGitEntry, ManifestGitUser, parse_git_gate_config
|
||||||
|
from .manifest_schema import BOTTLE_KEYS
|
||||||
|
|
||||||
|
__all__ = ["ManifestBottle"]
|
||||||
|
|
||||||
|
|
||||||
|
def _empty_str_dict() -> dict[str, str]:
|
||||||
|
return {}
|
||||||
|
|
||||||
|
|
||||||
|
@dataclass(frozen=True)
|
||||||
|
class ManifestBottle:
|
||||||
|
env: Mapping[str, str] = field(default_factory=_empty_str_dict)
|
||||||
|
agent_provider: ManifestAgentProvider = field(default_factory=ManifestAgentProvider)
|
||||||
|
git: tuple[ManifestGitEntry, ...] = ()
|
||||||
|
# Per-bottle git identity (issue #86). Empty default — bottles
|
||||||
|
# that don't set `git-gate.user:` in the manifest skip the
|
||||||
|
# `git config --global` step entirely. A bottle can declare a user
|
||||||
|
# identity without any git-gate.repos upstreams, and vice versa.
|
||||||
|
git_user: ManifestGitUser = field(default_factory=ManifestGitUser)
|
||||||
|
egress: ManifestEgressConfig = field(default_factory=ManifestEgressConfig)
|
||||||
|
# Per-bottle stuck-recovery sidecar (PRD 0013). When true (the
|
||||||
|
# default, issue #249), the launch step brings up a supervise
|
||||||
|
# sidecar that exposes egress MCP tools to the agent. Set
|
||||||
|
# `supervise: false` to skip the sidecar.
|
||||||
|
supervise: bool = True
|
||||||
|
|
||||||
|
@classmethod
|
||||||
|
def from_dict(cls, name: str, raw: object) -> "ManifestBottle":
|
||||||
|
d = as_json_object(raw, f"bottle '{name}'")
|
||||||
|
|
||||||
|
if "runtime" in d:
|
||||||
|
raise ManifestError(
|
||||||
|
f"bottle '{name}' has a 'runtime' field, which is no longer "
|
||||||
|
f"supported. gVisor (runsc) is now auto-detected by the "
|
||||||
|
f"backend; remove the 'runtime' field from the bottle "
|
||||||
|
f"definition."
|
||||||
|
)
|
||||||
|
|
||||||
|
if "ssh" in d:
|
||||||
|
raise ManifestError(
|
||||||
|
f"bottle '{name}' has an 'ssh' field, which has been removed "
|
||||||
|
f"(PRD 0009). Declare upstreams under 'git-gate.repos' with "
|
||||||
|
f"url + identity + host_key; the git-gate sidecar (PRD 0008) "
|
||||||
|
f"holds the credential and gitleaks-scans pushes."
|
||||||
|
)
|
||||||
|
|
||||||
|
if "git" in d:
|
||||||
|
raise ManifestError(
|
||||||
|
f"bottle '{name}' uses 'git' which has been replaced by "
|
||||||
|
f"'git-gate' (PRD 0047). Move git.user → git-gate.user "
|
||||||
|
f"and git.remotes → git-gate.repos (fields: url, identity, host_key)."
|
||||||
|
)
|
||||||
|
|
||||||
|
if "git_user" in d:
|
||||||
|
raise ManifestError(
|
||||||
|
f"bottle '{name}' has a 'git_user' field, which has been "
|
||||||
|
f"removed. Move it under 'git-gate.user'."
|
||||||
|
)
|
||||||
|
|
||||||
|
unknown = set(d.keys()) - BOTTLE_KEYS
|
||||||
|
if unknown:
|
||||||
|
allowed = ", ".join(sorted(BOTTLE_KEYS))
|
||||||
|
raise ManifestError(
|
||||||
|
f"bottle '{name}' has unknown key(s) {sorted(unknown)}; "
|
||||||
|
f"allowed keys are {allowed}."
|
||||||
|
)
|
||||||
|
|
||||||
|
env: dict[str, str] = {}
|
||||||
|
env_raw = d.get("env")
|
||||||
|
if env_raw is not None:
|
||||||
|
env_dict = as_json_object(env_raw, f"bottle '{name}' env")
|
||||||
|
for var, value in env_dict.items():
|
||||||
|
if not isinstance(value, str):
|
||||||
|
raise ManifestError(
|
||||||
|
f"env entry {var} in bottle '{name}' must be a JSON string "
|
||||||
|
f"(was {type(value).__name__}). Use \"?<message>\" for prompt-at-runtime."
|
||||||
|
)
|
||||||
|
env[var] = value
|
||||||
|
|
||||||
|
git: tuple[ManifestGitEntry, ...] = ()
|
||||||
|
git_user = ManifestGitUser()
|
||||||
|
git_raw = d.get("git-gate")
|
||||||
|
if git_raw is not None:
|
||||||
|
git, git_user = parse_git_gate_config(name, git_raw)
|
||||||
|
|
||||||
|
agent_provider = (
|
||||||
|
ManifestAgentProvider.from_dict(name, d["agent_provider"])
|
||||||
|
if "agent_provider" in d
|
||||||
|
else ManifestAgentProvider()
|
||||||
|
)
|
||||||
|
|
||||||
|
egress = (
|
||||||
|
ManifestEgressConfig.from_dict(name, d["egress"])
|
||||||
|
if "egress" in d
|
||||||
|
else ManifestEgressConfig()
|
||||||
|
)
|
||||||
|
|
||||||
|
supervise_raw = d.get("supervise", True)
|
||||||
|
if not isinstance(supervise_raw, bool):
|
||||||
|
raise ManifestError(
|
||||||
|
f"bottle '{name}' supervise must be a boolean "
|
||||||
|
f"(was {type(supervise_raw).__name__})"
|
||||||
|
)
|
||||||
|
|
||||||
|
return cls(
|
||||||
|
env=env, agent_provider=agent_provider, git=git,
|
||||||
|
git_user=git_user, egress=egress, supervise=supervise_raw,
|
||||||
|
)
|
||||||
@@ -2,11 +2,10 @@
|
|||||||
|
|
||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|
||||||
from typing import TYPE_CHECKING
|
from .manifest_bottle import ManifestBottle
|
||||||
|
from .manifest_egress import ManifestEgressConfig, validate_egress_routes
|
||||||
if TYPE_CHECKING:
|
from .manifest_git import ManifestGitUser, parse_git_gate_config
|
||||||
from .manifest import ManifestBottle
|
from .manifest_util import ManifestError, as_json_object
|
||||||
from .manifest_egress import ManifestEgressConfig
|
|
||||||
|
|
||||||
|
|
||||||
def merge_bottles_runtime(bottles: "list[ManifestBottle]") -> "ManifestBottle":
|
def merge_bottles_runtime(bottles: "list[ManifestBottle]") -> "ManifestBottle":
|
||||||
@@ -27,9 +26,6 @@ def merge_bottles_runtime(bottles: "list[ManifestBottle]") -> "ManifestBottle":
|
|||||||
|
|
||||||
|
|
||||||
def _merge_two_bottles_runtime(base: "ManifestBottle", override: "ManifestBottle") -> "ManifestBottle":
|
def _merge_two_bottles_runtime(base: "ManifestBottle", override: "ManifestBottle") -> "ManifestBottle":
|
||||||
from .manifest import ManifestBottle, ManifestGitUser
|
|
||||||
from .manifest_egress import ManifestEgressConfig
|
|
||||||
|
|
||||||
merged_env = {**base.env, **override.env}
|
merged_env = {**base.env, **override.env}
|
||||||
|
|
||||||
merged_git_user = ManifestGitUser(
|
merged_git_user = ManifestGitUser(
|
||||||
@@ -81,8 +77,6 @@ def _resolve_one_bottle(
|
|||||||
repos_cache: dict[str, dict[str, object]],
|
repos_cache: dict[str, dict[str, object]],
|
||||||
seen: tuple[str, ...],
|
seen: tuple[str, ...],
|
||||||
) -> ManifestBottle:
|
) -> ManifestBottle:
|
||||||
from .manifest import ManifestBottle, ManifestError
|
|
||||||
|
|
||||||
if name in cache:
|
if name in cache:
|
||||||
return cache[name]
|
return cache[name]
|
||||||
if name in seen:
|
if name in seen:
|
||||||
@@ -174,11 +168,6 @@ def _fold_two_bottles(
|
|||||||
later_repos_raw: dict[str, object],
|
later_repos_raw: dict[str, object],
|
||||||
) -> tuple[ManifestBottle, dict[str, object]]:
|
) -> tuple[ManifestBottle, dict[str, object]]:
|
||||||
"""Combine two resolved parent bottles; later wins over earlier."""
|
"""Combine two resolved parent bottles; later wins over earlier."""
|
||||||
from .manifest import ManifestBottle, ManifestGitUser
|
|
||||||
from .manifest_egress import ManifestEgressConfig
|
|
||||||
from .manifest_git import parse_git_gate_config
|
|
||||||
from .manifest_util import as_json_object
|
|
||||||
|
|
||||||
merged_env = {**earlier.env, **later.env}
|
merged_env = {**earlier.env, **later.env}
|
||||||
|
|
||||||
merged_git_user = ManifestGitUser(
|
merged_git_user = ManifestGitUser(
|
||||||
@@ -227,10 +216,6 @@ def _merge_bottles(
|
|||||||
name: str,
|
name: str,
|
||||||
) -> ManifestBottle:
|
) -> ManifestBottle:
|
||||||
"""Apply PRD 0025 merge rules."""
|
"""Apply PRD 0025 merge rules."""
|
||||||
from .manifest import ManifestBottle, ManifestGitUser
|
|
||||||
from .manifest_egress import validate_egress_routes
|
|
||||||
from .manifest_util import as_json_object
|
|
||||||
|
|
||||||
# git-gate.repos: when the child declares repos, inject the already
|
# git-gate.repos: when the child declares repos, inject the already
|
||||||
# name-merged repo set (computed by _resolve_repos_raw) so the child
|
# name-merged repo set (computed by _resolve_repos_raw) so the child
|
||||||
# parses with the full inherited+overridden list (issue #237).
|
# parses with the full inherited+overridden list (issue #237).
|
||||||
@@ -303,8 +288,6 @@ def _resolve_repos_raw(
|
|||||||
inherits the parent's set verbatim; an explicit empty dict clears it.
|
inherits the parent's set verbatim; an explicit empty dict clears it.
|
||||||
Otherwise parent and child unite by name, with same-name entries
|
Otherwise parent and child unite by name, with same-name entries
|
||||||
field-merged (parent fields are defaults, child fields win)."""
|
field-merged (parent fields are defaults, child fields win)."""
|
||||||
from .manifest_util import as_json_object
|
|
||||||
|
|
||||||
if not _child_declares_git_gate_repos(child_raw):
|
if not _child_declares_git_gate_repos(child_raw):
|
||||||
return parent_repos
|
return parent_repos
|
||||||
child_repos = _declared_repos_raw(child_raw)
|
child_repos = _declared_repos_raw(child_raw)
|
||||||
@@ -324,8 +307,6 @@ def _resolve_repos_raw(
|
|||||||
def _declared_repos_raw(child_raw: dict[str, object]) -> dict[str, object]:
|
def _declared_repos_raw(child_raw: dict[str, object]) -> dict[str, object]:
|
||||||
"""Return the child's explicitly declared git-gate.repos as raw dicts,
|
"""Return the child's explicitly declared git-gate.repos as raw dicts,
|
||||||
or an empty dict when none are declared."""
|
or an empty dict when none are declared."""
|
||||||
from .manifest_util import as_json_object
|
|
||||||
|
|
||||||
if not _child_declares_git_gate_repos(child_raw):
|
if not _child_declares_git_gate_repos(child_raw):
|
||||||
return {}
|
return {}
|
||||||
git_raw = as_json_object(child_raw.get("git-gate", {}), "child git-gate")
|
git_raw = as_json_object(child_raw.get("git-gate", {}), "child git-gate")
|
||||||
@@ -333,8 +314,6 @@ def _declared_repos_raw(child_raw: dict[str, object]) -> dict[str, object]:
|
|||||||
|
|
||||||
|
|
||||||
def _child_declares_git_gate_repos(child_raw: dict[str, object]) -> bool:
|
def _child_declares_git_gate_repos(child_raw: dict[str, object]) -> bool:
|
||||||
from .manifest_util import as_json_object
|
|
||||||
|
|
||||||
git_raw = child_raw.get("git-gate")
|
git_raw = child_raw.get("git-gate")
|
||||||
if git_raw is None:
|
if git_raw is None:
|
||||||
return False
|
return False
|
||||||
@@ -347,9 +326,6 @@ def _merge_egress(
|
|||||||
child: ManifestEgressConfig,
|
child: ManifestEgressConfig,
|
||||||
child_raw: dict[str, object],
|
child_raw: dict[str, object],
|
||||||
) -> ManifestEgressConfig:
|
) -> ManifestEgressConfig:
|
||||||
from .manifest_egress import ManifestEgressConfig
|
|
||||||
from .manifest_util import as_json_object
|
|
||||||
|
|
||||||
child_egress_raw = as_json_object(child_raw.get("egress"), "child egress")
|
child_egress_raw = as_json_object(child_raw.get("egress"), "child egress")
|
||||||
routes = parent.routes + child.routes
|
routes = parent.routes + child.routes
|
||||||
log = child.Log if "log" in child_egress_raw else parent.Log
|
log = child.Log if "log" in child_egress_raw else parent.Log
|
||||||
|
|||||||
@@ -3,9 +3,10 @@
|
|||||||
from __future__ import annotations
|
from __future__ import annotations
|
||||||
|
|
||||||
from pathlib import Path
|
from pathlib import Path
|
||||||
from typing import TYPE_CHECKING
|
|
||||||
|
|
||||||
from .log import warn
|
from .log import warn
|
||||||
|
from .manifest_bottle import ManifestBottle
|
||||||
|
from .manifest_extends import resolve_bottles
|
||||||
from .manifest_schema import (
|
from .manifest_schema import (
|
||||||
entity_name_from_path,
|
entity_name_from_path,
|
||||||
validate_bottle_frontmatter_keys,
|
validate_bottle_frontmatter_keys,
|
||||||
@@ -13,9 +14,6 @@ from .manifest_schema import (
|
|||||||
from .manifest_util import ManifestError
|
from .manifest_util import ManifestError
|
||||||
from .yaml_subset import YamlSubsetError, parse_frontmatter
|
from .yaml_subset import YamlSubsetError, parse_frontmatter
|
||||||
|
|
||||||
if TYPE_CHECKING:
|
|
||||||
from .manifest import ManifestBottle
|
|
||||||
|
|
||||||
|
|
||||||
def check_stale_json(dir_path: Path, md_dir: Path, label: str) -> None:
|
def check_stale_json(dir_path: Path, md_dir: Path, label: str) -> None:
|
||||||
"""Die if `<dir_path>/bot-bottle.json` exists but `md_dir` does
|
"""Die if `<dir_path>/bot-bottle.json` exists but `md_dir` does
|
||||||
@@ -78,8 +76,6 @@ def load_bottle_chain_from_dir(
|
|||||||
|
|
||||||
Only the files in the extends chain are read — unrelated bottle files
|
Only the files in the extends chain are read — unrelated bottle files
|
||||||
are never touched. Raises ManifestError on parse or validation failure."""
|
are never touched. Raises ManifestError on parse or validation failure."""
|
||||||
from .manifest_extends import resolve_bottles
|
|
||||||
|
|
||||||
raws: dict[str, dict[str, object]] = {}
|
raws: dict[str, dict[str, object]] = {}
|
||||||
to_load = [bottle_name]
|
to_load = [bottle_name]
|
||||||
while to_load:
|
while to_load:
|
||||||
|
|||||||
@@ -33,13 +33,20 @@ AGENT_KEYS = (
|
|||||||
AGENT_MODEL_KEYS = AGENT_KEYS | frozenset({"prompt"})
|
AGENT_MODEL_KEYS = AGENT_KEYS | frozenset({"prompt"})
|
||||||
|
|
||||||
|
|
||||||
|
def is_valid_entity_name(name: str) -> bool:
|
||||||
|
"""True if `name` fits the kebab-case `[a-z][a-z0-9-]*` convention
|
||||||
|
shared by bottle/agent filenames and skill names. Names that satisfy
|
||||||
|
this are also safe to interpolate into a host/guest path segment."""
|
||||||
|
return bool(_FILENAME_RX.match(name))
|
||||||
|
|
||||||
|
|
||||||
def entity_name_from_path(path: Path) -> str | None:
|
def entity_name_from_path(path: Path) -> str | None:
|
||||||
"""Return the entity name implied by the filename, or None if the
|
"""Return the entity name implied by the filename, or None if the
|
||||||
filename does not fit the [a-z][a-z0-9-]* convention."""
|
filename does not fit the [a-z][a-z0-9-]* convention."""
|
||||||
if path.suffix != ".md":
|
if path.suffix != ".md":
|
||||||
return None
|
return None
|
||||||
stem = path.stem
|
stem = path.stem
|
||||||
if not _FILENAME_RX.match(stem):
|
if not is_valid_entity_name(stem):
|
||||||
return None
|
return None
|
||||||
return stem
|
return stem
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,188 @@
|
|||||||
|
"""Unit: `cli.py start --headless` non-interactive launch path.
|
||||||
|
|
||||||
|
Headless is the keystone for orchestrators, CI, and webhook
|
||||||
|
dispatch: agent/bottles/label come from flags + manifest defaults, no
|
||||||
|
TUI selectors fire, and the preflight y/N is auto-confirmed
|
||||||
|
(`assume_yes=True`). All actual launch work is stubbed so no container
|
||||||
|
is created.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import os
|
||||||
|
import unittest
|
||||||
|
from unittest.mock import MagicMock, patch
|
||||||
|
|
||||||
|
import bot_bottle.cli.start as start_mod
|
||||||
|
import bot_bottle.cli.tui as tui_mod
|
||||||
|
from bot_bottle.backend import ActiveAgent
|
||||||
|
from bot_bottle.log import Die
|
||||||
|
from bot_bottle.manifest import ManifestError
|
||||||
|
|
||||||
|
|
||||||
|
def _make_manifest(
|
||||||
|
agent_names: list[str],
|
||||||
|
bottle_names: list[str] | None = None,
|
||||||
|
agent_bottle: str = "",
|
||||||
|
):
|
||||||
|
manifest = MagicMock()
|
||||||
|
manifest.agents = {name: MagicMock(bottle=agent_bottle) for name in agent_names}
|
||||||
|
manifest.all_agent_names = sorted(agent_names)
|
||||||
|
manifest.all_bottle_names = sorted(bottle_names or [])
|
||||||
|
manifest.home_md = None # eager mode so _peek_agent_bottle uses agents dict
|
||||||
|
manifest.require_agent = MagicMock(return_value=None)
|
||||||
|
return manifest
|
||||||
|
|
||||||
|
|
||||||
|
def _active_agent(slug: str) -> ActiveAgent:
|
||||||
|
return ActiveAgent(
|
||||||
|
backend_name="docker",
|
||||||
|
slug=slug,
|
||||||
|
agent_name="demo",
|
||||||
|
started_at="2026-01-01T00:00:00+00:00",
|
||||||
|
services=(),
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestCmdStartHeadless(unittest.TestCase):
|
||||||
|
"""Drive `cmd_start --headless` with launch + TUI stubbed out."""
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
self._manifest = _make_manifest(
|
||||||
|
["researcher", "implementer"], ["claude", "dev"], agent_bottle="claude"
|
||||||
|
)
|
||||||
|
patch(
|
||||||
|
"bot_bottle.cli.start.ManifestIndex.resolve",
|
||||||
|
return_value=self._manifest,
|
||||||
|
).start()
|
||||||
|
self._launch_mock = patch(
|
||||||
|
"bot_bottle.cli.start._launch_bottle", return_value=0
|
||||||
|
).start()
|
||||||
|
# No bottles running by default → no label collision.
|
||||||
|
patch(
|
||||||
|
"bot_bottle.cli.start.enumerate_active_agents", return_value=[]
|
||||||
|
).start()
|
||||||
|
# If any TUI picker fires in headless mode, that's a bug.
|
||||||
|
self._agent_picker = patch.object(tui_mod, "filter_select").start()
|
||||||
|
self._bottle_picker = patch.object(tui_mod, "filter_multiselect").start()
|
||||||
|
self._modal = patch.object(tui_mod, "name_color_modal").start()
|
||||||
|
patch.dict(os.environ, {}, clear=False).start()
|
||||||
|
os.environ.pop("BOT_BOTTLE_BACKEND", None)
|
||||||
|
self.addCleanup(patch.stopall)
|
||||||
|
|
||||||
|
def _spec(self):
|
||||||
|
self._launch_mock.assert_called_once()
|
||||||
|
return self._launch_mock.call_args[0][0]
|
||||||
|
|
||||||
|
# -- no TUI in headless --------------------------------------------
|
||||||
|
|
||||||
|
def test_headless_fires_no_pickers(self):
|
||||||
|
rc = start_mod.cmd_start(
|
||||||
|
["--headless", "researcher", "--bottle", "claude", "--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
self.assertEqual(0, rc)
|
||||||
|
self._agent_picker.assert_not_called()
|
||||||
|
self._bottle_picker.assert_not_called()
|
||||||
|
self._modal.assert_not_called()
|
||||||
|
|
||||||
|
def test_headless_assume_yes_forwarded(self):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "researcher", "--bottle", "claude", "--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
self.assertTrue(self._launch_mock.call_args[1]["assume_yes"])
|
||||||
|
|
||||||
|
# -- prompt --------------------------------------------------------
|
||||||
|
|
||||||
|
def test_headless_without_prompt_dies(self):
|
||||||
|
with self.assertRaises(Die):
|
||||||
|
start_mod.cmd_start(["--headless", "researcher", "--bottle", "claude"])
|
||||||
|
self._launch_mock.assert_not_called()
|
||||||
|
|
||||||
|
def test_headless_prompt_forwarded_to_launch(self):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "researcher", "--bottle", "claude",
|
||||||
|
"--prompt", "Implement issue #42"]
|
||||||
|
)
|
||||||
|
self.assertEqual(
|
||||||
|
"Implement issue #42",
|
||||||
|
self._launch_mock.call_args[1]["headless_prompt_text"],
|
||||||
|
)
|
||||||
|
|
||||||
|
# -- bottle resolution ---------------------------------------------
|
||||||
|
|
||||||
|
def test_explicit_bottles_forwarded_in_order(self):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "researcher", "--bottle", "dev", "--bottle", "claude",
|
||||||
|
"--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
self.assertEqual(("dev", "claude"), self._spec().bottle_names)
|
||||||
|
|
||||||
|
def test_omitted_bottle_falls_back_to_agent_default(self):
|
||||||
|
start_mod.cmd_start(["--headless", "implementer", "--prompt", "Do it"])
|
||||||
|
self.assertEqual(("claude",), self._spec().bottle_names)
|
||||||
|
|
||||||
|
def test_no_bottle_and_no_default_dies(self):
|
||||||
|
manifest = _make_manifest(["researcher"], ["claude"], agent_bottle="")
|
||||||
|
with patch(
|
||||||
|
"bot_bottle.cli.start.ManifestIndex.resolve", return_value=manifest
|
||||||
|
):
|
||||||
|
with self.assertRaises(Die):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "researcher", "--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
self._launch_mock.assert_not_called()
|
||||||
|
|
||||||
|
# -- agent resolution ----------------------------------------------
|
||||||
|
|
||||||
|
def test_missing_agent_name_dies(self):
|
||||||
|
with self.assertRaises(Die):
|
||||||
|
start_mod.cmd_start(["--headless"])
|
||||||
|
self._launch_mock.assert_not_called()
|
||||||
|
|
||||||
|
def test_unknown_agent_raises_manifest_error(self):
|
||||||
|
self._manifest.require_agent.side_effect = ManifestError("agent 'x' not defined")
|
||||||
|
with self.assertRaises(ManifestError):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "x", "--bottle", "claude", "--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
self._launch_mock.assert_not_called()
|
||||||
|
|
||||||
|
# -- label / color -------------------------------------------------
|
||||||
|
|
||||||
|
def test_label_defaults_to_agent_name(self):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "researcher", "--bottle", "claude", "--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
self.assertEqual("researcher", self._spec().label)
|
||||||
|
|
||||||
|
def test_explicit_label_and_color_forwarded(self):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "researcher", "--bottle", "claude",
|
||||||
|
"--label", "nightly", "--color", "green", "--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
spec = self._spec()
|
||||||
|
self.assertEqual("nightly", spec.label)
|
||||||
|
self.assertEqual("green", spec.color)
|
||||||
|
|
||||||
|
def test_label_collision_uniquifies(self):
|
||||||
|
with patch(
|
||||||
|
"bot_bottle.cli.start.enumerate_active_agents",
|
||||||
|
return_value=[_active_agent("researcher")],
|
||||||
|
):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "researcher", "--bottle", "claude", "--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
self.assertEqual("researcher-2", self._spec().label)
|
||||||
|
|
||||||
|
# -- backend wiring ------------------------------------------------
|
||||||
|
|
||||||
|
def test_backend_flag_forwarded(self):
|
||||||
|
start_mod.cmd_start(
|
||||||
|
["--headless", "--backend=docker", "researcher", "--bottle", "claude",
|
||||||
|
"--prompt", "Do it"]
|
||||||
|
)
|
||||||
|
self.assertEqual("docker", self._launch_mock.call_args[1]["backend_name"])
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
unittest.main()
|
||||||
@@ -343,5 +343,14 @@ class TestClaudeSuperviseMcp(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestClaudeHeadlessPrompt(unittest.TestCase):
|
||||||
|
def test_returns_p_flag_and_prompt(self):
|
||||||
|
self.assertEqual(["-p", "Do the task"], ClaudeAgentProvider().headless_prompt("Do the task"))
|
||||||
|
|
||||||
|
def test_preserves_prompt_text_verbatim(self):
|
||||||
|
text = "Fix issue #42: the widget breaks on empty input"
|
||||||
|
self.assertEqual(["-p", text], ClaudeAgentProvider().headless_prompt(text))
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
|
|||||||
@@ -314,5 +314,14 @@ class TestCodexSuperviseMcp(unittest.TestCase):
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
class TestCodexHeadlessPrompt(unittest.TestCase):
|
||||||
|
def test_returns_prompt_as_positional_arg(self):
|
||||||
|
self.assertEqual(["Do the task"], CodexAgentProvider().headless_prompt("Do the task"))
|
||||||
|
|
||||||
|
def test_preserves_prompt_text_verbatim(self):
|
||||||
|
text = "Fix issue #42: the widget breaks on empty input"
|
||||||
|
self.assertEqual([text], CodexAgentProvider().headless_prompt(text))
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
|
|||||||
@@ -223,5 +223,14 @@ class TestPiDockerfile(unittest.TestCase):
|
|||||||
self.assertIn("chmod 1777 /tmp /var/tmp", dockerfile)
|
self.assertIn("chmod 1777 /tmp /var/tmp", dockerfile)
|
||||||
|
|
||||||
|
|
||||||
|
class TestPiHeadlessPrompt(unittest.TestCase):
|
||||||
|
def test_returns_p_flag_and_prompt(self):
|
||||||
|
self.assertEqual(["-p", "Do the task"], PiAgentProvider().headless_prompt("Do the task"))
|
||||||
|
|
||||||
|
def test_preserves_prompt_text_verbatim(self):
|
||||||
|
text = "Fix issue #42: the widget breaks on empty input"
|
||||||
|
self.assertEqual(["-p", text], PiAgentProvider().headless_prompt(text))
|
||||||
|
|
||||||
|
|
||||||
if __name__ == "__main__":
|
if __name__ == "__main__":
|
||||||
unittest.main()
|
unittest.main()
|
||||||
|
|||||||
@@ -38,6 +38,7 @@ class _Provider(AgentProvider):
|
|||||||
def provision_prompt(self, plan, bottle): ... # type: ignore[override]
|
def provision_prompt(self, plan, bottle): ... # type: ignore[override]
|
||||||
def provision(self, plan, bottle): ... # type: ignore[override]
|
def provision(self, plan, bottle): ... # type: ignore[override]
|
||||||
def provision_supervise_mcp(self, plan, bottle, supervise_url): ... # type: ignore[override]
|
def provision_supervise_mcp(self, plan, bottle, supervise_url): ... # type: ignore[override]
|
||||||
|
def headless_prompt(self, prompt): return [] # type: ignore[override]
|
||||||
|
|
||||||
|
|
||||||
_PROVIDER = _Provider()
|
_PROVIDER = _Provider()
|
||||||
|
|||||||
@@ -14,6 +14,7 @@ from bot_bottle.git_gate import (
|
|||||||
git_gate_render_access_hook,
|
git_gate_render_access_hook,
|
||||||
git_gate_render_entrypoint,
|
git_gate_render_entrypoint,
|
||||||
git_gate_render_hook,
|
git_gate_render_hook,
|
||||||
|
provision_git_gate_dynamic_keys,
|
||||||
revoke_git_gate_provisioned_keys,
|
revoke_git_gate_provisioned_keys,
|
||||||
_resolve_identity_file,
|
_resolve_identity_file,
|
||||||
git_gate_upstreams_for_bottle,
|
git_gate_upstreams_for_bottle,
|
||||||
@@ -371,6 +372,27 @@ class TestDynamicKeyProvisioning(unittest.TestCase):
|
|||||||
self.assertEqual("/tmp/provisioned-key", _resolve_identity_file(entry, "demo", self.stage))
|
self.assertEqual("/tmp/provisioned-key", _resolve_identity_file(entry, "demo", self.stage))
|
||||||
mock_provision.assert_called_once()
|
mock_provision.assert_called_once()
|
||||||
|
|
||||||
|
def test_prepare_defers_gitea_key_provisioning(self):
|
||||||
|
bottle = self._gitea_manifest().bottles["dev"]
|
||||||
|
with patch("bot_bottle.git_gate_provision._provision_dynamic_key") as mock_provision:
|
||||||
|
plan = _StubGate().prepare(bottle, "demo", self.stage)
|
||||||
|
|
||||||
|
mock_provision.assert_not_called()
|
||||||
|
self.assertEqual("", plan.upstreams[0].identity_file)
|
||||||
|
|
||||||
|
def test_launch_time_helper_provisions_gitea_keys(self):
|
||||||
|
bottle = self._gitea_manifest().bottles["dev"]
|
||||||
|
plan = _StubGate().prepare(bottle, "demo", self.stage)
|
||||||
|
|
||||||
|
with patch(
|
||||||
|
"bot_bottle.git_gate_provision._provision_dynamic_key",
|
||||||
|
return_value="/tmp/provisioned-key",
|
||||||
|
) as mock_provision:
|
||||||
|
updated = provision_git_gate_dynamic_keys(bottle, plan, self.stage)
|
||||||
|
|
||||||
|
mock_provision.assert_called_once_with(bottle.git[0], "demo", self.stage)
|
||||||
|
self.assertEqual("/tmp/provisioned-key", updated.upstreams[0].identity_file)
|
||||||
|
|
||||||
def test_revoke_skips_non_gitea_and_missing_id_file(self):
|
def test_revoke_skips_non_gitea_and_missing_id_file(self):
|
||||||
revoke_git_gate_provisioned_keys(fixture_with_git().bottles["dev"], self.stage)
|
revoke_git_gate_provisioned_keys(fixture_with_git().bottles["dev"], self.stage)
|
||||||
|
|
||||||
|
|||||||
@@ -165,6 +165,22 @@ class TestAgentValidation(unittest.TestCase):
|
|||||||
with self.assertRaises(ManifestError):
|
with self.assertRaises(ManifestError):
|
||||||
ManifestAgent.from_dict("a", {"skills": [5]}, set())
|
ManifestAgent.from_dict("a", {"skills": [5]}, set())
|
||||||
|
|
||||||
|
def test_skill_name_rejects_shell_metacharacters(self) -> None:
|
||||||
|
# Skill names become host/guest path segments interpolated into
|
||||||
|
# provisioning shell commands; anything outside kebab-case is
|
||||||
|
# rejected at load so it can never reach a `bottle.exec` string.
|
||||||
|
for bad in ("foo; rm -rf /", "../escape", "foo bar", "Foo", "-leading"):
|
||||||
|
with self.assertRaises(ManifestError):
|
||||||
|
ManifestAgent.from_dict("a", {"skills": [bad]}, set())
|
||||||
|
|
||||||
|
def test_skill_name_accepts_kebab_case(self) -> None:
|
||||||
|
agent = ManifestAgent.from_dict(
|
||||||
|
"a", {"skills": ["init-entry", "quality-eval", "skill0"]}, set()
|
||||||
|
)
|
||||||
|
self.assertEqual(
|
||||||
|
agent.skills, ("init-entry", "quality-eval", "skill0")
|
||||||
|
)
|
||||||
|
|
||||||
def test_prompt_not_string(self) -> None:
|
def test_prompt_not_string(self) -> None:
|
||||||
with self.assertRaises(ManifestError):
|
with self.assertRaises(ManifestError):
|
||||||
ManifestAgent.from_dict("a", {"prompt": 5}, set())
|
ManifestAgent.from_dict("a", {"prompt": 5}, set())
|
||||||
|
|||||||
@@ -49,6 +49,7 @@ class _Provider(AgentProvider):
|
|||||||
def provision_prompt(self, plan, bottle): ... # type: ignore[override]
|
def provision_prompt(self, plan, bottle): ... # type: ignore[override]
|
||||||
def provision(self, plan, bottle): ... # type: ignore[override]
|
def provision(self, plan, bottle): ... # type: ignore[override]
|
||||||
def provision_supervise_mcp(self, plan, bottle, supervise_url): ... # type: ignore[override]
|
def provision_supervise_mcp(self, plan, bottle, supervise_url): ... # type: ignore[override]
|
||||||
|
def headless_prompt(self, prompt): return [] # type: ignore[override]
|
||||||
|
|
||||||
|
|
||||||
_PROVIDER = _Provider()
|
_PROVIDER = _Provider()
|
||||||
|
|||||||
Reference in New Issue
Block a user