bot-bottle

Author	SHA1	Message	Date
didericis-claude	8a321770dd	fix(backend): fix pyright errors in lazy-load implementation test / integration (pull_request) Successful in 12s Details test / unit (pull_request) Successful in 32s Details test / coverage (pull_request) Successful in 36s Details lint / lint (push) Successful in 2m17s Details - Rename _BACKENDS → _backends: pyright treats uppercase module-level names as constants and flags the reassignment in _get_backends() as reportConstantRedefinition; lowercase avoids this. - Add TYPE_CHECKING guard importing CommitCancelled/Freezer/get_freezer from .freeze: pyright cannot see module-level __getattr__ bindings, so reportUnsupportedDunderAll fired for those three __all__ entries; the guard makes them visible to the type checker without running at import time. - Update test_backend_selection.py to patch _backends (lowercase).	2026-07-18 05:11:29 -04:00
didericis-claude	4b8b09ab83	fix(backend): silence pylint false positives from lazy-load pattern `undefined-all-variable` fires on CommitCancelled / Freezer / get_freezer in __all__ because pylint can't see module-level __getattr__ bindings; `global-statement` fires on the _BACKENDS singleton setter. Both are intentional patterns — add inline disables rather than suppress globally.	2026-07-18 05:11:29 -04:00
didericis-claude	3fe90b3a88	perf: lazy-load backend modules and consolidate docker subprocess helpers Importing backend.docker.util previously triggered eager loading of all three backend packages (~76 modules) because backend/__init__.py imported DockerBottleBackend, FirecrackerBottleBackend, and MacosContainerBottleBackend at module scope. This made the module prohibitively expensive to import from the orchestrator layer and elsewhere. The three backend imports are now deferred into _get_backends(), which loads all three on first call and caches the result in the module-level _BACKENDS variable (initially None). Module-level __getattr__ exposes backend classes and freeze symbols lazily for existing import/patch sites. backend/docker/util.py raw subprocess.run(["docker", ...]) calls are replaced with the shared run_docker primitive from docker_cmd, eliminating the duplication between the backend and orchestrator implementations. _silent_run() is removed; image_exists() is inlined directly onto run_docker. The commit_container test is updated to patch run_docker instead of subprocess.run.	2026-07-18 05:11:29 -04:00
didericis	4f10b810d4	ci(lint): drop actions/setup-python; install into the container's system Python lint / lint (push) Successful in 2m16s Details Same fix as the test workflow: the old act_runner engine mishandles actions/setup-python's PATH, so `pip install` hit the image's externally-managed system Python and failed with "externally-managed-environment" on the "Install dev dependencies" step. The runner image already ships Python 3.12 and the job container is ephemeral, so drop setup-python and install straight into system Python with --break-system-packages. pylint/pyright console scripts land on /usr/local/bin (on PATH), so the lint steps still resolve. Also drops the now-pointless `pip install --upgrade pip`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UoEZHDjv84ChoZbozQERhJ	2026-07-18 05:08:18 -04:00

1 changed files with 7 additions and 8 deletions

									
										.gitea/workflows/lint.yml
									
		+7
		-8
	
												View File
												
				@@ -13,15 +13,14 @@ jobs:

				    steps:

				      - uses: actions/checkout@v3

				      - name: Set up Python

				        uses: actions/setup-python@v4

				        with:

				          python-version: "3.12"

				      # No actions/setup-python: the runner image already ships Python 3.12,

				      # and older act_runner engines mishandle setup-python's PATH. Install

				      # into the ephemeral job container's system Python — the pylint/pyright

				      # console scripts land on /usr/local/bin (on PATH) so the steps below

				      # still resolve. --break-system-packages is safe: the container is

				      # disposable.

				      - name: Install dev dependencies

				        run: |

				          python -m pip install --upgrade pip

				          pip install -r requirements-dev.txt

				        run: python3 -m pip install --break-system-packages -r requirements-dev.txt

				      - name: Run pylint

				        run: |

Compare commits

4 Commits

78d72264c8 .. 8a321770dd

Compare commits

4 Commits 78d72264c8 .. 8a321770dd

4 Commits

78d72264c8 .. 8a321770dd