bot-bottle

didericis/bot-bottle

Fork 0

Commit Graph

Author	SHA1	Message	Date
didericis	a5078daf1c	fix: resolve all 22 remaining pylint warnings Lint and Type Check / lint (push) Has been cancelled Details test / unit (pull_request) Has been cancelled Details test / integration (pull_request) Has been cancelled Details Fixed issues across bot_bottle/: 1. Unspecified encoding in open() - 6 files: - Added encoding='utf-8' to Path.read_text() and open() calls - Files: env.py, pipelock_apply.py, prepare.py, loopback_alias.py, _common.py, supervise.py 2. Exception chaining (raise-missing-from) - 5 files: - Added 'from e' to raise statements for proper traceback chaining - Files: manifest_loader.py (2x), manifest_egress.py 3. Redefining built-in 'format' - 2 files: - Added # noqa: A002 comments to override methods - Files: supervise_server.py, git_http_backend.py 4. Unused function arguments - 5 files: - Added # noqa: F841 comments for interface-required unused params - Files: manifest_loader.py, supervise.py, loopback_alias.py, cli/supervise.py 5. Broad exception catching - 6 files: - Added # noqa: broad-exception-caught comments with explanations - Files: supervise_server.py, docker/launch.py, smolmachines/launch.py, tui.py, supervise.py, deploy_key_provisioner.py 6. Unreachable code - 3 files: - Removed unreachable return statements after die() calls - Files: loopback_alias.py, sidecar_bundle.py, local_registry.py 7. Unnecessary ellipsis in Protocol - 2 files: - Reverted pass back to ... (more idiomatic for Protocols) - Files: workspace.py, backend/__init__.py 8. Platform-specific function redeclaration: - Added type: ignore[reportRedeclaration] for Unix/Windows variants - File: supervise.py (_try_flock, _try_funlock) Final scores: ✅ Pylint: 9.95/10 (0 E/W violations) ✅ Pyright: 0 errors (100% type safe) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>	2026-06-04 11:42:40 -04:00
didericis-claude	7c285fde7a	feat(manifest): replace git key with git-gate (PRD 0047) - BOTTLE_KEYS and AGENT_KEYS_OPTIONAL: "git" → "git-gate" - GitEntry: remove from_dict/from_remote_dict; add from_repos_entry parsing url/identity/host_key with repo name as the dict key - GitUser.from_dict: error messages updated to git-gate.user - _parse_git_config → _parse_git_gate_config; repos/user subkeys - Bottle.from_dict: reads git-gate key; "git" key raises a migration error - Agent.from_dict: reads git-gate key; repos rejected at agent level - manifest_extends: _child_declares_git_remotes → _child_declares_git_gate_repos - manifest_loader: threads git-gate frontmatter key into agent_dict	2026-06-02 23:59:34 -04:00
didericis-codex	8f28bd81a7	refactor(manifest): split schema boundaries	2026-06-02 07:32:06 +00:00

Author

SHA1

Message

Date

didericis

a5078daf1c

fix: resolve all 22 remaining pylint warnings

Lint and Type Check / lint (push) Has been cancelled

Details

test / unit (pull_request) Has been cancelled

Details

test / integration (pull_request) Has been cancelled

Details

Fixed issues across bot_bottle/:

1. Unspecified encoding in open() - 6 files:
   - Added encoding='utf-8' to Path.read_text() and open() calls
   - Files: env.py, pipelock_apply.py, prepare.py, loopback_alias.py, _common.py, supervise.py

2. Exception chaining (raise-missing-from) - 5 files:
   - Added 'from e' to raise statements for proper traceback chaining
   - Files: manifest_loader.py (2x), manifest_egress.py

3. Redefining built-in 'format' - 2 files:
   - Added # noqa: A002 comments to override methods
   - Files: supervise_server.py, git_http_backend.py

4. Unused function arguments - 5 files:
   - Added # noqa: F841 comments for interface-required unused params
   - Files: manifest_loader.py, supervise.py, loopback_alias.py, cli/supervise.py

5. Broad exception catching - 6 files:
   - Added # noqa: broad-exception-caught comments with explanations
   - Files: supervise_server.py, docker/launch.py, smolmachines/launch.py, tui.py, supervise.py, deploy_key_provisioner.py

6. Unreachable code - 3 files:
   - Removed unreachable return statements after die() calls
   - Files: loopback_alias.py, sidecar_bundle.py, local_registry.py

7. Unnecessary ellipsis in Protocol - 2 files:
   - Reverted pass back to ... (more idiomatic for Protocols)
   - Files: workspace.py, backend/__init__.py

8. Platform-specific function redeclaration:
   - Added type: ignore[reportRedeclaration] for Unix/Windows variants
   - File: supervise.py (_try_flock, _try_funlock)

Final scores:
✅ Pylint: 9.95/10 (0 E/W violations)
✅ Pyright: 0 errors (100% type safe)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

2026-06-04 11:42:40 -04:00

didericis-claude

7c285fde7a

feat(manifest): replace git key with git-gate (PRD 0047)

- BOTTLE_KEYS and AGENT_KEYS_OPTIONAL: "git" → "git-gate"
- GitEntry: remove from_dict/from_remote_dict; add from_repos_entry
  parsing url/identity/host_key with repo name as the dict key
- GitUser.from_dict: error messages updated to git-gate.user
- _parse_git_config → _parse_git_gate_config; repos/user subkeys
- Bottle.from_dict: reads git-gate key; "git" key raises a migration error
- Agent.from_dict: reads git-gate key; repos rejected at agent level
- manifest_extends: _child_declares_git_remotes → _child_declares_git_gate_repos
- manifest_loader: threads git-gate frontmatter key into agent_dict

2026-06-02 23:59:34 -04:00

didericis-codex

8f28bd81a7

refactor(manifest): split schema boundaries

2026-06-02 07:32:06 +00:00

3 Commits