2 Commits

Author	SHA1	Message	Date
didericis	94eca35b4f	fix(skills): validate skill names and quote provisioning paths ... Skill names become host/guest path segments interpolated into the `bottle.exec` shell strings in each contrib provider's provision_skills. They were validated only as strings, so a name with shell metacharacters or path traversal could reach the command. Layer two defenses: - Primary: reject any skill name that isn't kebab-case ([a-z][a-z0-9-]*) at manifest load, reusing the convention already enforced on bottle/agent filenames (new is_valid_entity_name helper in manifest_schema). Fails loud and early, protecting every consumer of the name — not just the exec call sites. - Failsafe: shlex.quote the interpolated skills_dir / dst paths in the claude, codex, and pi providers, so a future unvalidated field can't inject shell metacharacters even if it bypasses the load-time check. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NkwFXLFff9PYPy4wgVBJp9	2026-06-27 02:15:30 -04:00
didericis	74060192e0	test(manifest): ratchet manifest + manifest_agent to >=90% ... Fifth per-module ratchet under ADR 0004. Drive the validation rejection and edge paths: - ManifestBottle.from_dict: unknown key, non-string env value, non-bool supervise, removed `runtime` field. - ManifestAgentProvider.from_dict: unknown key, empty template, non-string dockerfile, auth_token / forward_host_credentials template constraints. - _parse_provider_settings: pass-through for non-built-in templates, startup_args shape, and the pi-specific string/int/bool/models/ max_tokens_field/api-key-conflict checks. - ManifestAgent.from_dict: bottle empty/undefined, skills shape, prompt type, agent-level git-gate.repos rejection, empty git-gate allowed. - Eager ManifestIndex: empty bottles section, unknown-agent load, has_agent / require_agent, git_identity_summary (set and empty). manifest_agent.py: 84% -> 99%; manifest.py: 86% -> 94%. Remaining manifest.py misses are the lazy on-disk loader paths exercised by the integration suite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NkwFXLFff9PYPy4wgVBJp9	2026-06-25 22:15:07 -04:00