fix(git-http): extract peer variable to clarify access hook call convention
Both remote-addr and peer-addr args to the access hook are the same TCP peer in this non-proxied stack. Extract a `peer` variable so the intentional repetition is visible. Closes #148.
This commit is contained in:
@@ -42,9 +42,9 @@ class GitHttpHandler(BaseHTTPRequestHandler):
|
|||||||
hook_path = os.environ.get(
|
hook_path = os.environ.get(
|
||||||
"GIT_GATE_ACCESS_HOOK", "/etc/git-gate/access-hook",
|
"GIT_GATE_ACCESS_HOOK", "/etc/git-gate/access-hook",
|
||||||
)
|
)
|
||||||
|
peer = self.client_address[0]
|
||||||
hook = subprocess.run(
|
hook = subprocess.run(
|
||||||
[hook_path, "upload-pack",
|
[hook_path, "upload-pack", str(repo_dir), peer, peer],
|
||||||
str(repo_dir), self.client_address[0], self.client_address[0]],
|
|
||||||
capture_output=True,
|
capture_output=True,
|
||||||
check=False,
|
check=False,
|
||||||
)
|
)
|
||||||
|
|||||||
Reference in New Issue
Block a user