fix: resolve pylint and pyright linting issues
lint / lint (push) Successful in 1m43s
test / unit (push) Successful in 42s
test / integration (push) Successful in 59s

- Remove .keys() iteration in favor of direct dictionary iteration
- Remove redundant os module reimport in tui.py
- Disable unnecessary-ellipsis rule in pylintrc to avoid conflict with pyright's
  Protocol type requirements

pyright: 0 errors
pylint: 9.93/10

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
2026-06-04 12:40:36 -04:00
parent 544a024e22
commit f114c861b4
4 changed files with 6 additions and 6 deletions
+2 -1
View File
@@ -419,7 +419,8 @@ disable=raw-checker-failed,
too-many-instance-attributes, too-many-instance-attributes,
duplicate-code, duplicate-code,
import-outside-toplevel, import-outside-toplevel,
too-few-public-methods too-few-public-methods,
unnecessary-ellipsis
# Enable the message, report, category or checker with the given id(s). You can # Enable the message, report, category or checker with the given id(s). You can
# either give multiple identifier separated by comma (,) or put this option # either give multiple identifier separated by comma (,) or put this option
+1 -2
View File
@@ -42,8 +42,7 @@ def filter_select(
# Use os.dup() to duplicate the fd so the original file object # Use os.dup() to duplicate the fd so the original file object
# and FileIO in _run_picker each manage independent copies, # and FileIO in _run_picker each manage independent copies,
# preventing double-close errors. # preventing double-close errors.
import os as _os fd_dup = os.dup(tty_fd.fileno())
fd_dup = _os.dup(tty_fd.fileno())
return _run_picker(items, title=title, tty_fd=fd_dup) return _run_picker(items, title=title, tty_fd=fd_dup)
finally: finally:
tty_fd.close() tty_fd.close()
+1 -1
View File
@@ -161,7 +161,7 @@ class Agent:
git_raw = d.get("git-gate") git_raw = d.get("git-gate")
if git_raw is not None: if git_raw is not None:
gd = as_json_object(git_raw, f"agent '{name}' git-gate") gd = as_json_object(git_raw, f"agent '{name}' git-gate")
for k in gd.keys(): for k in gd:
if k != "user": if k != "user":
raise ManifestError( raise ManifestError(
f"agent '{name}' git-gate.{k} is not allowed at the " f"agent '{name}' git-gate.{k} is not allowed at the "
+2 -2
View File
@@ -246,7 +246,7 @@ class GitUser:
@classmethod @classmethod
def from_dict(cls, bottle_name: str, raw: object) -> "GitUser": def from_dict(cls, bottle_name: str, raw: object) -> "GitUser":
d = as_json_object(raw, f"bottle '{bottle_name}' git-gate.user") d = as_json_object(raw, f"bottle '{bottle_name}' git-gate.user")
for k in d.keys(): for k in d:
if k not in {"name", "email"}: if k not in {"name", "email"}:
raise ManifestError( raise ManifestError(
f"bottle '{bottle_name}' git-gate.user has unknown key {k!r}; " f"bottle '{bottle_name}' git-gate.user has unknown key {k!r}; "
@@ -281,7 +281,7 @@ def parse_git_gate_config(
raw: object, raw: object,
) -> tuple[tuple[GitEntry, ...], GitUser]: ) -> tuple[tuple[GitEntry, ...], GitUser]:
d = as_json_object(raw, f"bottle '{bottle_name}' git-gate") d = as_json_object(raw, f"bottle '{bottle_name}' git-gate")
for k in d.keys(): for k in d:
if k not in {"user", "repos"}: if k not in {"user", "repos"}:
raise ManifestError( raise ManifestError(
f"bottle '{bottle_name}' git-gate has unknown key {k!r}; " f"bottle '{bottle_name}' git-gate has unknown key {k!r}; "