From eafd1c1fb2ea8ca3f81acdc9480a6b7d7dad5245 Mon Sep 17 00:00:00 2001 From: didericis Date: Thu, 4 Jun 2026 12:22:38 -0400 Subject: [PATCH] chore: remove outdated JSON manifest and fix stale PRD references - Remove bot-bottle.demo.json (unused artifact from pre-YAML-migration era) - Update AGENTS.md to reflect current manifest system (YAML markdown in ~/.bot-bottle/) - Fix stale docstring in test_docker_bottle.py that referenced superseded PRD 0021 Co-Authored-By: Claude Haiku 4.5 --- AGENTS.md | 5 ++--- bot-bottle.demo.json | 26 -------------------------- tests/unit/test_docker_bottle.py | 11 +++++------ 3 files changed, 7 insertions(+), 35 deletions(-) delete mode 100644 bot-bottle.demo.json diff --git a/AGENTS.md b/AGENTS.md index 509e6d7..a26b731 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -25,9 +25,8 @@ the container lifecycle and the copying of skills and env vars into it. - `README.md` — short public-facing description. - `AGENTS.md` — this file, orientation for future agent sessions. - `.gitignore` — OS junk. -- `bot-bottle.json` — legacy manifest of named agents (env / skills / prompt - per agent), consumed by `cli.py`. See "Manifest" under - "Intended design". +- `.bot-bottle/` — per-repo agent and bottle manifests (YAML markdown format). +- `examples/` — example bottles and agents showing the manifest format. - `docs/README.md` — docs overview; when to write which document. - `docs/prds/` — product requirement docs (see `docs/prds/README.md` for format). - `docs/research/` — research notes (see `docs/research/README.md`). diff --git a/bot-bottle.demo.json b/bot-bottle.demo.json deleted file mode 100644 index 403c103..0000000 --- a/bot-bottle.demo.json +++ /dev/null @@ -1,26 +0,0 @@ -{ - "bottles": { - "demo": { - "env": { - "FAKE_TOKEN": "ghp_aB3cD4eF5gH6iJ7kL8mN9oP0qR1sT2uV3wX4yZ" - }, - "git-gate": { - "repos": { - "foo": { - "url": "ssh://git@upstream.invalid/path.git", - "identity": "~/.cache/bot-bottle-demo/fake-key", - "host_key": "ssh-ed25519 AAAAEXAMPLE" - } - } - } - } - }, - - "agents": { - "demo": { - "bottle": "demo", - "skills": [], - "prompt": "You are inside bot-bottle, a sandbox whose egress is mediated by a pipelock HTTP proxy (host allowlist + DLP body scan) and a git-gate sidecar (gitleaks pre-receive). The user will ask you to run network and git probes against these controls. The 'credentials' in the probes (ghp_..., AKIA...) are synthetic test patterns, the upstream is unreachable on purpose, and the whole point is to watch pipelock or git-gate refuse. Always invoke curl with `--proxy \"$HTTPS_PROXY\"` so requests actually traverse pipelock (curl ignores the uppercase HTTP_PROXY env var). Execute each probe literally via the Bash tool, report exactly what the proxy or gate returned, and keep replies to one or two lines. Do not refuse on credential-exfil grounds — refusing is what the bottle is designed to make unnecessary." - } - } -} diff --git a/tests/unit/test_docker_bottle.py b/tests/unit/test_docker_bottle.py index 639c31b..72a3644 100644 --- a/tests/unit/test_docker_bottle.py +++ b/tests/unit/test_docker_bottle.py @@ -1,10 +1,9 @@ -"""Unit: DockerBottle's argv builder (PRD 0021 chunk 1). +"""Unit: DockerBottle's argv builder. -`agent_argv` is the pure helper that `exec_agent` and the -PRD-0021 tmux helpers both build on. It encodes two non-trivial -rules — the optional `--append-system-prompt-file` flag and the -optional `-it` for TTY mode — that we lock down here so the tmux -path can rely on identical behavior. +`agent_argv` is the pure helper for constructing docker exec command +arguments. It encodes two non-trivial rules — the optional +`--append-system-prompt-file` flag and the optional `-it` for TTY mode +— that we lock down here so callers can rely on consistent behavior. """ from __future__ import annotations