From d0a0ce8d606e5e3f21e2490230c567d515677692 Mon Sep 17 00:00:00 2001 From: didericis Date: Fri, 17 Jul 2026 00:36:43 -0400 Subject: [PATCH] test(firecracker): satisfy pyright strict + line length in committed-rootfs tests Annotate the counting_run subprocess.run wrapper (reportMissingParameterType) and wrap an over-long patch target line. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01UoEZHDjv84ChoZbozQERhJ --- tests/unit/test_backend_freezer.py | 3 ++- tests/unit/test_firecracker_helpers.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/unit/test_backend_freezer.py b/tests/unit/test_backend_freezer.py index b46ee72..304f6d6 100644 --- a/tests/unit/test_backend_freezer.py +++ b/tests/unit/test_backend_freezer.py @@ -213,7 +213,8 @@ class TestFirecrackerFreezer(_FakeHomeMixin, unittest.TestCase): freezer = FirecrackerFreezer() agent = _make_agent(slug, "firecracker") - with patch("bot_bottle.backend.firecracker.freezer._commit_rootfs_via_ssh") as mock_commit, \ + commit_fn = "bot_bottle.backend.firecracker.freezer._commit_rootfs_via_ssh" + with patch(commit_fn) as mock_commit, \ patch("bot_bottle.backend.freeze.info"), \ patch("bot_bottle.backend.firecracker.freezer.info"): freezer.commit(agent) diff --git a/tests/unit/test_firecracker_helpers.py b/tests/unit/test_firecracker_helpers.py index e1173d1..76f97d8 100644 --- a/tests/unit/test_firecracker_helpers.py +++ b/tests/unit/test_firecracker_helpers.py @@ -11,6 +11,7 @@ import subprocess import tempfile import unittest from pathlib import Path +from typing import Any from unittest.mock import patch from bot_bottle.backend.firecracker import firecracker_vm, freezer, netpool, util @@ -189,7 +190,7 @@ class TestBuildCommittedRootfsDir(unittest.TestCase): real_run = subprocess.run calls = {"n": 0} - def counting_run(argv, *a, **k): + def counting_run(argv: list[str], *a: Any, **k: Any) -> Any: if argv and argv[0] == "tar": calls["n"] += 1 return real_run(argv, *a, **k)