From bef45348f57155d9f08726362dfe819d09045655 Mon Sep 17 00:00:00 2001 From: didericis Date: Fri, 24 Jul 2026 19:11:37 -0400 Subject: [PATCH] fix(types): satisfy pyright strict on the refactored facades MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two facade issues from the reorg: * orchestrator/__init__.py used `__all__ = list(_LAZY)`, which pyright strict can't analyze (reportUnsupportedDunderAll) — and because it isn't a static literal, the TYPE_CHECKING re-export imports read as unused. Replaced with the explicit literal list the other lazy facades already use. * manifest/index.py imported six piece types (ManifestAgentProvider, EGRESS_AUTH_SCHEMES, ManifestEgressConfig/Route, ManifestGitEntry, ManifestKeyConfig) it never referenced — the package facade re-exports those straight from their submodules, so index.py needn't import them. Dropped the dead imports. pyright: 0 errors (was 24). Full unit suite green (2243). Co-Authored-By: Claude Opus 4.8 --- bot_bottle/manifest/index.py | 9 ++------- bot_bottle/orchestrator/__init__.py | 20 +++++++++++++++++++- 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/bot_bottle/manifest/index.py b/bot_bottle/manifest/index.py index 35966b4..8996560 100644 --- a/bot_bottle/manifest/index.py +++ b/bot_bottle/manifest/index.py @@ -16,15 +16,10 @@ from typing import Mapping from ..log import warn from .util import ManifestError, as_json_object -from .agent import ManifestAgent, ManifestAgentProvider +from .agent import ManifestAgent from .bottle import ManifestBottle -from .egress import ( - EGRESS_AUTH_SCHEMES, - ManifestEgressConfig, - ManifestEgressRoute, -) from .extends import merge_bottles_runtime, resolve_bottles -from .git import ManifestGitEntry, ManifestGitUser, ManifestKeyConfig +from .git import ManifestGitUser from .loader import ( check_stale_json, load_bottle_chain_from_dir, diff --git a/bot_bottle/orchestrator/__init__.py b/bot_bottle/orchestrator/__init__.py index 0858e0e..7597a69 100644 --- a/bot_bottle/orchestrator/__init__.py +++ b/bot_bottle/orchestrator/__init__.py @@ -82,4 +82,22 @@ def __getattr__(name: str) -> Any: return value -__all__ = list(_LAZY) +__all__ = [ + "BottleRecord", + "RegistryStore", + "new_identity_token", + "BrokerAuthError", + "LaunchBroker", + "LaunchRequest", + "StubBroker", + "sign_request", + "verify_request", + "DockerBroker", + "DockerBrokerError", + "Gateway", + "GatewayError", + "Orchestrator", + "OrchestratorServer", + "dispatch", + "make_server", +]