fix(manifest): OR nested_containers across composed bottles

merge_bottles_runtime sees resolved bottles, where a bottle that never
mentioned the key is indistinguishable from one that set it false. With
"later replaces" semantics, `--bottle with-containers --bottle claude-dev`
silently dropped the capability — the second bottle's default clobbered
it. OR instead: composing bottles adds capabilities, it does not remove
them. The file-based extends path still sees raw keys, so an explicit
`nested_containers: false` in a child continues to turn it back off.

Also surface the flag in the launch summary, where its absence was the
only reason the clobber went unnoticed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
2026-07-21 15:43:31 -04:00
parent 29c46356ef
commit adeb581cdf
4 changed files with 24 additions and 9 deletions
+2
View File
@@ -524,6 +524,8 @@ def _manifest_to_yaml(manifest: Manifest) -> str:
lines.append(f" scheme: {r.AuthScheme}") lines.append(f" scheme: {r.AuthScheme}")
lines.append(f" supervise: {'true' if bottle.supervise else 'false'}") lines.append(f" supervise: {'true' if bottle.supervise else 'false'}")
if bottle.nested_containers:
lines.append(" nested_containers: true")
return "\n".join(lines) return "\n".join(lines)
+1
View File
@@ -20,6 +20,7 @@ Bottle schema (frontmatter):
egress: { routes: [ <egress-route>, ... ] } egress: { routes: [ <egress-route>, ... ] }
# route keys: host, matches, auth, role, dlp # route keys: host, matches, auth, role, dlp
supervise: <bool> # optional (default true) supervise: <bool> # optional (default true)
nested_containers: <bool> # optional (default false)
Agent schema (frontmatter): Agent schema (frontmatter):
bottle: <bottle-name> # required bottle: <bottle-name> # required
+12 -4
View File
@@ -15,8 +15,16 @@ def merge_bottles_runtime(bottles: "list[ManifestBottle]") -> "ManifestBottle":
the same field-merge rules as the file-based extends machinery: the same field-merge rules as the file-based extends machinery:
env: dict merge, later wins; git_user: per-field overlay, later env: dict merge, later wins; git_user: per-field overlay, later
wins on non-empty; git (repos): union by name, later wins; egress wins on non-empty; git (repos): union by name, later wins; egress
routes: concatenate; agent_provider, supervise, routes: concatenate; agent_provider, supervise: later
nested_containers: later replaces. replaces; nested_containers: OR (see below).
nested_containers is OR'd rather than replaced because these objects
are already resolved: a bottle that never mentions the key is
indistinguishable from one that sets it false, so "later replaces"
would let any bottle composed after a container-enabled one silently
drop the capability. The file-based `extends:` path still sees the
raw keys, so there an explicit `nested_containers: false` in a child
turns it back off.
""" """
if not bottles: if not bottles:
raise ValueError("merge_bottles_runtime requires at least one bottle") raise ValueError("merge_bottles_runtime requires at least one bottle")
@@ -55,7 +63,7 @@ def _merge_two_bottles_runtime(base: "ManifestBottle", override: "ManifestBottle
git_user=merged_git_user, git_user=merged_git_user,
egress=merged_egress, egress=merged_egress,
supervise=override.supervise, supervise=override.supervise,
nested_containers=override.nested_containers, nested_containers=base.nested_containers or override.nested_containers,
) )
@@ -208,7 +216,7 @@ def _fold_two_bottles(
git_user=merged_git_user, git_user=merged_git_user,
egress=merged_egress, egress=merged_egress,
supervise=later.supervise, supervise=later.supervise,
nested_containers=later.nested_containers, nested_containers=earlier.nested_containers or later.nested_containers,
), merged_repos_raw ), merged_repos_raw
+9 -5
View File
@@ -56,11 +56,15 @@ class TestMergeBottlesRuntime(unittest.TestCase):
result = merge_bottles_runtime([base, override]) result = merge_bottles_runtime([base, override])
self.assertFalse(result.supervise) self.assertFalse(result.supervise)
def test_nested_containers_later_wins(self): def test_nested_containers_survives_a_later_bottle(self):
base = _bottle(nested_containers=True) """OR, not replace: a resolved bottle that never mentioned the key is
override = _bottle(nested_containers=False) indistinguishable from one that set it false, so `--bottle with-docker
self.assertFalse(merge_bottles_runtime([base, override]).nested_containers) --bottle claude-dev` must not silently drop the capability."""
self.assertTrue(merge_bottles_runtime([override, base]).nested_containers) enabled = _bottle(nested_containers=True)
quiet = _bottle(env={"X": "1"})
self.assertTrue(merge_bottles_runtime([enabled, quiet]).nested_containers)
self.assertTrue(merge_bottles_runtime([quiet, enabled]).nested_containers)
self.assertFalse(merge_bottles_runtime([quiet, quiet]).nested_containers)
def test_three_bottles_merged_left_to_right(self): def test_three_bottles_merged_left_to_right(self):
b1 = _bottle(env={"A": "1", "B": "1", "C": "1"}) b1 = _bottle(env={"A": "1", "B": "1", "C": "1"})