didericis/bot-bottle
1
0
Fork 0
Code Issues 34 Pull Requests 11 Actions Packages Releases Wiki Activity

feat(manifest): trusted agent forge identity and guidance

Browse Source 
Implements PRD prd-new-trusted-agent-forge-identity. Moves author identity
and named forge configurations onto the trusted, host-only agent definition,
and lets a bottle repository optionally associate a git-gate repo with one of
the agent's forge aliases.

- Agent-owned identity: new `author` (name/email) and `forge-accounts`
  (alias -> canonical Gitea /api/v1 origin + host `token_secret` ref) on the
  agent manifest. `author` populates the bottle's git user.name/user.email.
- Remove `git-gate.user` from both agents and bottles; fail with a migration
  pointer to `author`. `git-gate` is no longer accepted on an agent.
- Bottle git-gate repos gain optional `forge: <alias>`, resolved against the
  selected agent's forge-accounts at composition (fail-closed on unknown).
- Fail-closed Gitea API URL validation (https, no userinfo/query/fragment,
  /api/v1 base, host lowercased, trailing slash normalized, host dedup).
- Proxy-held credential: synthesize one inspected, token-authenticated egress
  route per referenced forge alias, scoped to the origin + API prefix. The
  token is resolved from the host env at launch into the egress proxy only —
  never the bottle env, prompt, gitconfig, or workspace.
- Generated, non-secret forge workflow guidance appended to the agent prompt
  for associated repos (API base, branch-backed PR flow, AGit-ref prohibition,
  mutation verification); omitted when no repo declares a forge.
- Agents become home-only: cwd `.bot-bottle/agents` no longer contributes,
  overrides, or is selectable; warned-and-ignored like cwd bottles.
- Docs: README examples, PRD 0011 supersession note, manifest schema docstring.
- Tests: new test_forge_identity suite; legacy git-gate.user/cwd tests updated
  to the agent-owned identity model.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
didericis (claude)
2026-07-27 00:20:14 +00:00
parent 14f19247c0
commit a2edaf8694
26 changed files with 1261 additions and 439 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_manifest_git_user.py
+62 -52
View File
@@ -1,4 +1,11 @@
"""Unit: Bottle git-gate.user manifest parsing + validation (issue #86, PRD 0047)."""
"""Unit: agent `author` identity -> bottle.git_user (PRD
prd-new-trusted-agent-forge-identity).
Identity moved off `git-gate.user` (bottle) onto the trusted agent's
`author` block. At `load_for_agent` the agent's author populates the
effective bottle's `git_user` (a `ManifestGitUser`). This locks the
`author` validation/rejection paths and the bottle `git-gate.user`
migration die."""
import unittest
@@ -14,89 +21,92 @@ def _error_message(callable_, *args, **kwargs) -> str: # type: ignore
raise AssertionError("expected ManifestError was not raised")
def _manifest(git_user): # type: ignore
return {
"bottles": {"dev": {"git-gate": {"user": git_user}}},
"agents": {"demo": {"skills": [], "prompt": "", "bottle": "dev"}},
}
def _manifest(author): # type: ignore
"""Build an index with one agent 'demo' carrying the given `author`
block, then load it, returning the composed Manifest."""
agent: dict = {"skills": [], "prompt": "", "bottle": "dev"} # type: ignore
if author is not None:
agent["author"] = author
return ManifestIndex.from_json_obj({
"bottles": {"dev": {}},
"agents": {"demo": agent},
}).load_for_agent("demo")
class TestGitUserParsing(unittest.TestCase):
class TestAuthorIdentity(unittest.TestCase):
"""The agent's `author` block populates bottle.git_user."""
def test_parses_both_fields(self):
m = ManifestIndex.from_json_obj(_manifest({
m = _manifest({
"name": "Eric Bauerfeld",
"email": "eric+claude@dideric.is",
}))
u = m.bottles["dev"].git_user
})
u = m.bottle.git_user
self.assertEqual("Eric Bauerfeld", u.name)
self.assertEqual("eric+claude@dideric.is", u.email)
self.assertFalse(u.is_empty())
def test_name_only(self):
m = ManifestIndex.from_json_obj(_manifest({"name": "Bot"}))
u = m.bottles["dev"].git_user
self.assertEqual("Bot", u.name)
self.assertEqual("", u.email)
def test_email_only(self):
m = ManifestIndex.from_json_obj(_manifest({"email": "bot@example.com"}))
u = m.bottles["dev"].git_user
self.assertEqual("", u.name)
self.assertEqual("bot@example.com", u.email)
def test_omitted_defaults_to_empty(self):
# No git.user block at all → empty GitUser, is_empty True →
def test_omitted_author_defaults_to_empty(self):
# No author block at all -> empty git_user, is_empty True ->
# provisioner skips the `git config` step entirely.
m = ManifestIndex.from_json_obj({
"bottles": {"dev": {}},
"agents": {"demo": {"skills": [], "prompt": "", "bottle": "dev"}},
})
u = m.bottles["dev"].git_user
self.assertTrue(u.is_empty())
m = _manifest(None)
self.assertTrue(m.bottle.git_user.is_empty())
def test_missing_name_dies(self):
# `author` is present but name is absent -> both fields required.
msg = _error_message(_manifest, {"email": "bot@example.com"})
self.assertIn("author.name must be a non-empty string", msg)
def test_missing_email_dies(self):
msg = _error_message(_manifest, {"name": "Bot"})
self.assertIn("author.email must be a non-empty string", msg)
def test_both_empty_strings_dies(self):
# An explicit `git.user: {name: "", email: ""}` is a typo
# / half-finished edit; fail loudly rather than silently
# no-op (the operator clearly meant to configure something).
msg = _error_message(
ManifestIndex.from_json_obj, _manifest({"name": "", "email": ""}),
)
self.assertIn("neither name nor email", msg)
# An explicit `author: {name: "", email: ""}` is a typo /
# half-finished edit; fail loudly rather than silently no-op.
msg = _error_message(_manifest, {"name": "", "email": ""})
self.assertIn("author.name must be a non-empty string", msg)
def test_unknown_key_dies(self):
msg = _error_message(
ManifestIndex.from_json_obj,
_manifest({"name": "Bot", "username": "bot"}),
_manifest,
{"name": "Bot", "email": "b@x", "username": "bot"},
)
self.assertIn("unknown key", msg)
self.assertIn("username", msg)
def test_non_string_name_dies(self):
msg = _error_message(
ManifestIndex.from_json_obj, _manifest({"name": 42}),
)
self.assertIn("git-gate.user.name must be a string", msg)
msg = _error_message(_manifest, {"name": 42, "email": "b@x"})
self.assertIn("author.name must be a non-empty string", msg)
def test_non_string_email_dies(self):
msg = _error_message(
ManifestIndex.from_json_obj, _manifest({"email": ["x@y.z"]}),
)
self.assertIn("git-gate.user.email must be a string", msg)
msg = _error_message(_manifest, {"name": "Bot", "email": ["x@y.z"]})
self.assertIn("author.email must be a non-empty string", msg)
def test_legacy_top_level_git_user_dies(self):
def test_email_with_whitespace_dies(self):
msg = _error_message(_manifest, {"name": "Bot", "email": "a @b"})
self.assertIn("author.email must not contain whitespace", msg)
class TestBottleGitGateUserMigration(unittest.TestCase):
"""`git-gate.user` on a bottle is no longer supported: it raises a
ManifestError pointing at the agent's `author` block."""
def test_bottle_git_gate_user_dies(self):
msg = _error_message(
ManifestIndex.from_json_obj,
{
"bottles": {"dev": {"git_user": {"name": "Bot"}}},
"bottles": {"dev": {"git-gate": {"user": {"name": "Bot"}}}},
"agents": {"demo": {"skills": [], "prompt": "", "bottle": "dev"}},
},
)
self.assertIn("git_user", msg)
self.assertIn("git-gate.user", msg)
self.assertIn("git-gate.user is no longer supported", msg)
self.assertIn("author", msg)
class TestGitUserDirect(unittest.TestCase):
"""Direct GitUser dataclass exercises (no manifest wrapper)."""
"""Direct GitUser dataclass exercises (no manifest wrapper). The
dataclass is still the runtime carrier on ManifestBottle.git_user."""
def test_is_empty_default(self):
self.assertTrue(ManifestGitUser().is_empty())