style: pass explicit check= to every subprocess.run call
test / unit (push) Successful in 11s
test / integration (push) Failing after 11s

Silences pylint W1510 / ruff PLW1510 across the codebase. The choice
at each site reflects existing intent:

- check=True where the caller implicitly trusts success (docker ps /
  network ls returning stdout, docker build, exec chown/chmod inside
  provisioners).
- check=False where the caller inspects .returncode (race-retry on
  docker run, pipelock sidecar lifecycle, network plumbing, exec_claude
  propagating the session's exit code, best-effort cleanup paths).

No behavior change; check= defaults to False so the False sites are
semantically identical.
This commit is contained in:
2026-05-12 10:13:56 -04:00
parent 64a31a382b
commit 95a14bb8d2
11 changed files with 36 additions and 9 deletions
+1 -1
View File
@@ -36,7 +36,7 @@ class DockerBottle(Bottle):
if tty:
cmd.append("-it")
cmd.extend([self.name, "claude", *full_argv])
return subprocess.run(cmd).returncode
return subprocess.run(cmd, check=False).returncode
def cp_in(self, host_path: str, container_path: str) -> None:
subprocess.run(