fix(egress): run supervise propose/poll RPCs off the mitmproxy event loop
tracker-policy-pr / check-pr (pull_request) Successful in 14s
test / integration-docker (pull_request) Successful in 40s
test / unit (pull_request) Successful in 46s
lint / lint (push) Successful in 57s
test / integration-firecracker (pull_request) Successful in 4m2s
test / coverage (pull_request) Successful in 16s
test / publish-infra (pull_request) Has been skipped
tracker-policy-pr / check-pr (pull_request) Successful in 14s
test / integration-docker (pull_request) Successful in 40s
test / unit (pull_request) Successful in 46s
lint / lint (push) Successful in 57s
test / integration-firecracker (pull_request) Successful in 4m2s
test / coverage (pull_request) Successful in 16s
test / publish-infra (pull_request) Has been skipped
`_supervise_token_block` and `_await_token_response` called the synchronous `PolicyResolver` directly from mitmproxy's async request handling. Those RPCs funnel through `PolicyResolver._post_json`, which blocks on `urllib.request.urlopen`. Because the poll loop runs for the entire operator-approval window, a slow or unreachable orchestrator would repeatedly freeze the proxy event loop — stalling every other bottle's traffic — despite `_await_token_response`'s contract of not blocking the loop (#471 review, review #443). Dispatch both the propose and poll RPCs via `asyncio.to_thread` so the blocking urllib call runs in a worker thread and the event loop keeps serving other flows. Fail-closed semantics are unchanged: `PolicyResolveError` still propagates through the await and is caught exactly as before. Regression test records the thread each RPC executes on and asserts it is not the loop thread; it fails against the pre-fix inline calls and passes with the dispatch. Full egress-addon + policy-resolver + supervise-server suites green (155 tests). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -612,7 +612,11 @@ class EgressAddon:
|
||||
source_ip = conn.peername[0] if conn is not None and conn.peername else ""
|
||||
token = self._conn_tokens.get(getattr(conn, "id", ""), "") if conn is not None else ""
|
||||
try:
|
||||
proposal_id = self._resolver.propose_supervise(
|
||||
# The resolver RPC is synchronous (blocking urllib); run it off the
|
||||
# event loop so a slow/unreachable orchestrator can't freeze the
|
||||
# proxy for every other bottle's traffic (#471 review).
|
||||
proposal_id = await asyncio.to_thread(
|
||||
self._resolver.propose_supervise,
|
||||
source_ip, token,
|
||||
tool=TOOL_EGRESS_TOKEN_ALLOW,
|
||||
proposed_file=payload,
|
||||
@@ -675,7 +679,13 @@ class EgressAddon:
|
||||
deadline = loop.time() + self._token_allow_timeout
|
||||
while True:
|
||||
try:
|
||||
result = self._resolver.poll_supervise(source_ip, token, proposal_id)
|
||||
# Poll off the event loop — the resolver RPC blocks on urllib,
|
||||
# and this loop runs for the whole operator-approval window, so
|
||||
# calling it inline would repeatedly freeze all proxy traffic
|
||||
# until a decision or timeout (#471 review).
|
||||
result = await asyncio.to_thread(
|
||||
self._resolver.poll_supervise, source_ip, token, proposal_id,
|
||||
)
|
||||
except PolicyResolveError:
|
||||
result = None
|
||||
if result is not None and result.get("status") in STATUSES:
|
||||
|
||||
Reference in New Issue
Block a user