didericis/bot-bottle
1
0
Fork 0
Code Issues 33 Pull Requests 10 Actions Packages Releases Wiki Activity

integration-macos: dispatch-only (drop push-to-main trigger)
test / integration-macos (pull_request) Has been skipped
Details
tracker-policy-pr / check-pr (pull_request) Successful in 11s
Details
test / integration-docker (pull_request) Successful in 34s
Details
test / unit (pull_request) Successful in 44s
Details
lint / lint (push) Successful in 1m2s
Details
test / integration-firecracker (pull_request) Successful in 2m6s
Details
test / coverage (pull_request) Successful in 17s
Details
test / publish-infra (pull_request) Has been skipped
Details

Browse Source 
Make the advisory macOS Apple Container job run on workflow_dispatch
only, removing the push-to-`main` trigger so a single non-redundant
laptop never runs unattended on every push. Updates the job comment,
docs/ci.md, README CI note, and the PRD accordingly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
didericis (claude)
2026-07-26 02:02:06 +00:00
committed by didericis
parent 5401f036a9
commit 27dea58ae1
4 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/prds/prd-new-macos-container-ci-runner.md
+8 -6
View File
@@ -57,10 +57,12 @@ plugs into; this PRD supplies the runner and the job.
## Non-goals
- Making `integration-macos` a **required** PR check. It runs on push-to-main
and `workflow_dispatch` only. A single non-redundant laptop that sleeps and
roams must never be able to block a PR merge, and it is deliberately kept out
of the `coverage` job's `needs` so the diff-coverage gate never depends on it.
- Making `integration-macos` a **required** PR check. It runs on
`workflow_dispatch` (manual dispatch) only — never on push or PRs. A single
non-redundant laptop that sleeps and roams must never be able to block a PR
merge or churn unattended on every push to main, and it is deliberately kept
out of the `coverage` job's `needs` so the diff-coverage gate never depends on
it.
- Multi-machine or hosted macOS runners. Apple Container needs the host
virtualization framework, so the runner must be a physical/VM macOS host on
Apple Silicon — it cannot reuse the KVM runner or run in a Linux container.
@@ -91,8 +93,8 @@ plugs into; this PRD supplies the runner and the job.
Modeled on `integration-firecracker`:
- `runs-on: [self-hosted, macos]`.
- `if:` push-to-main OR `workflow_dispatch` only (advisory; never PRs, so no
fork-PR exposure and no merge-blocking).
- `if:` `workflow_dispatch` only (advisory, manual dispatch; never push or PRs,
so no fork-PR exposure, no merge-blocking, and no unattended runs on push).
- `concurrency: { group: integration-macos-infra, cancel-in-progress: false }`
to serialize runs against the singleton.
- **Preflight** — `command -v container`, `container system status`, then